| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
android tests.
This reverts r197964.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
If the ID specified as a query parameter doesn't match any extension in the list, there is a JS error when calculating the offset of the highlight, which leads to the message not being hidden. This fixes the JS error so the execution flow can continue normally.
BUG=224191
Review URL: https://chromiumcodereview.appspot.com/14852008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
with enable_webrtc=0.
Tested building all targets both with enable_webrtc=0 and =1.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/14840013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [chromeos] Remove dependencies of StatisticsProvider on chrome.
>
> BUG=180711
> R=davemoore@google.com
>
> Review URL: https://codereview.chromium.org/14643006
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/14642018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Four lines pushed the image away from the icon, even when there was no
title. Three lines works in all cases.
BUG=236746
Review URL: https://chromiumcodereview.appspot.com/14624003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=237239
TEST=New unit test.
Review URL: https://chromiumcodereview.appspot.com/14600008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move components to zip as per the discussion here:
https://groups.google.com/a/chromium.org/d/topic/chromium-dev/MgbMTQCNzR0/discussion
BUG=
R=agl@chromium.org, gavinp@chromium.org, jam@chromium.org, joi@chromium.org
Review URL: https://codereview.chromium.org/14021015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Non-Aura Windows doesn't support compositor in each view. Just
delete without animation in that case.
Review URL: https://chromiumcodereview.appspot.com/14791008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=222801
Review URL: https://chromiumcodereview.appspot.com/14767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=180711
R=davemoore@google.com
Review URL: https://codereview.chromium.org/14643006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=149583%3A149598&mode=html
TBR=fsamuel
BUG=
Review URL: https://codereview.chromium.org/14858012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current behavior was to move toasts down towards the taskbar after
a fixed time interval following a click-to-close event. This pauses
the timer indefinitely until the mouse leaves the toast. After the
mouse leaves, a short timer is started so that transient mouseout
events don't surprise the user.
R=mukai@chromium.org
TBR=dimich@chromium.org
BUG=236674
Review URL: https://chromiumcodereview.appspot.com/14817004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when build/linux/unbundle is used.
Previously gyp files would contain a giant conditional sections depending on use_system_foo condition. After extracting that to build/linux/unbundle, the nesting depth got reduced by one level, so one less "+" in this .gypi file (otherwise the section does not get applied at all).
BUG=226860
R=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/14806002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See comment in code for explanation.
BUG=236987
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14574003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the HttpResponseHeaders::AddNonCacheableHeaders
to remove the use of local std::string constants, which require
heap allocation/deallocation under the hood.
+ Simplify the parser a bit to avoid more temporary string
creation.
NOTE: There is still a temporary string creation in the
call to EnumerateHeader(), but it can be removed by
applying https://chromiumcodereview.appspot.com/13852014/
See the bug entry for more details.
BUG=233164
R=pliard@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14267009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* local cros was broken because of missing argument
* quotes in dbus-send were messing up startup args.
BUG=236604
TEST=run_tests succeeds, on device and remotely.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14790003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197952 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unittests --gtest_filter=MemoryInfoProviderTest.*
Review URL: https://chromiumcodereview.appspot.com/14639003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=parisa@chromium.org
Review URL: https://codereview.chromium.org/14600005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, correct aura window sizing on desktop aura for Windows.
BUG=230935, 234558, 225252
TEST=NONE (yet)
Review URL: https://chromiumcodereview.appspot.com/13896011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=228940
TEST=Make sure existing Shadow DOM NTP still works just fine.
Review URL: https://chromiumcodereview.appspot.com/14592003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a rough classification of the errors that showed up in the
PlatformFile.UnknownCreateFileErrors histogram. I added an IO entry to
to the enum because a bunch of the errors seem to indicate a low-level
problem that is out of the application programmer's control.
BUG=229252
R=jar@chromium.org
Review URL: https://codereview.chromium.org/14586003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new version contains r3917 (merged from webrtc trunk to stable branch)
and no other changes.
R=alexeypa@chromium.org, niklase@chromium.org
Review URL: https://codereview.chromium.org/14797002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r197789 enabled the Clang warnings for Linux, but Aura-only files weren't fixed
because it wasn't enabled for ChromeOS. Disable the warnings on Aura for now,
until all existing files can be fixed.
BUG=115047
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/14688012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moved Profile-specific code out of BrowserPolicyConnector into a new PKS. This
PKS also owns the policy-specific components that were owned by ProfileImpl.
Refactored users of the removed Profile getters to use the new PKS.
These changes don't change behavior, and all tests should still pass. It also
prepares the introduction of PrefService as a PKS, that will depend on the
ProfilePolicyConnector.
BUG=230349
Review URL: https://chromiumcodereview.appspot.com/14631002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The rest needs swap() functionality.
This gets rid of more places where Persistent handles are copied
(see bug).
BUG=236290
TBR=jamesr
Review URL: https://chromiumcodereview.appspot.com/14840012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Did not solve the problem on the bots that it was intended to solve.
> Teach the ProxyLauncher to kill() child processes in addition to the browser.
>
> The startup performance_ui_tests have been hanging on the perf bots since they
> were upgraded to Precise. The hang is due to the performance_ui_tests binary not
> killing all of its child chrome processes. When that happens, the buildbot step
> hangs until timeout waiting for the process group to end.
>
> I found that simply sending the children a SIGTERM like we do to the browser
> process causes them to exit cleanly. So I'm not sure what the root cause is to
> child processes occassionally being left running after the browser exits, but
> it seems reasonable to me for the ProxyLauncher to be robust against that case
> rather than letting the buildbots hang.
>
> BUG=235893
> TEST=Startup performance_ui_tests
>
> Review URL: https://chromiumcodereview.appspot.com/14559003
TBR=tonyg@chromium.org
Review URL: https://codereview.chromium.org/14854013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories not in "My Drive"
Add MetadataCache to BreadCrumbControler.
For the shared-with-me enrties not in "My Drive", BreadCrumbControler check
"sharedWithMe" property of the first directory and use "Shared With Me" as the
first crumb.
BUG=232992
TEST=Verify that breadcrumbs in UI shows "Shared with me" for shared-with-me and not-in-mydrive directory.
Review URL: https://chromiumcodereview.appspot.com/14676004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces visual jank.
For default and keyword provider results, rather than removing all
non-inlineable results, only remove results until the top result (whether
it's verbatim for that provider, a query suggestion, or a navsuggestion)
is navigation. Let all other results remain.
Obviously, all these results still get replaced when new suggest results
are returned.
Tested interactively.
BUG=173915
Review URL: https://chromiumcodereview.appspot.com/13568002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mkearney@chromium.org
Review URL: https://codereview.chromium.org/14516003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The newly added tests are failing on Linux Clang (dbg).
> Translate: adding new UMAs to know language detection quality
>
> - TranslateContentLanguage:
> Counts Content-Language availability and reliability.
> - TranslateLanguageVerification:
> Counts how CLD think about Content-Language.
>
> BUG=179277
> TEST=unit_tests --gtest_filter='TranslateHelperMetricsTest.*'
>
> Review URL: https://chromiumcodereview.appspot.com/14763002
TBR=toyoshim@chromium.org
Review URL: https://codereview.chromium.org/14854012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The feature is not yet actually used, but will be used for range reading of
DriveFileStreamReader.
BUG=127129
TEST=Ran unit_tests
Review URL: https://chromiumcodereview.appspot.com/14623009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- TranslateContentLanguage:
Counts Content-Language availability and reliability.
- TranslateLanguageVerification:
Counts how CLD think about Content-Language.
BUG=179277
TEST=unit_tests --gtest_filter='TranslateHelperMetricsTest.*'
Review URL: https://chromiumcodereview.appspot.com/14763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When edge anti-aliasing is used, GL renderer forces blending to be used,
which causes hole punching logic to misbehave. Make force anti-aliasing
off option to SolidColorDrawQuad to avoid unwanted anti-aliasing.
TEST=cc_unittests ; content_unittests
BUG=236317
R=enne@chromium.org,danakj@chromium.org,jamesr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13842037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r11270: (sbc) Fix extra rodata segment in ARM irt nexe.
r11271: (eliben) Conditional linking with libgcc_eh to allow stable bitcode pexes not to expose symbols needed by it.
r11272: (bsy) Added NaClDescIoDescFromHandleAllocCtor, deprecated NaClDescIoDescMakeFromHandle. Fixed error propagation bugs.
r11273: (mcgrathr) Never use PNaCl toolchain to build the IRT
r11274: (kschimpf) Update PNaCl LLVM DEPS.
r11275: (eliben) Moving crt1*.x to pnacl/support/bitcode because it's part of the bitcode build process.
r11276: (khim) Disable stub_out_mode if validator does not support it.
r11277: (bradnelson) Relocating nacl_exceptions.h to src/include/nacl.
r11278: (mcgrathr) Get rid of native_code SCons argument, never default to bitcode=1
r11279: (jvoung) Have gcc torture-test buildbot script print STEP_FAILURE on errors.
BUG=none
TEST=nacl_integration
Review URL: https://codereview.chromium.org/14823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check HttpServerProperties to see if the origin server supports SPDY. If so,
start the request. This is a good initial step, although we should fine-tune
the implementation.
BUG=164101
Review URL: https://chromiumcodereview.appspot.com/14694014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
suggest or otherwise restricted.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14362018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The removal of use_system_foo logic from the original
gyp files will follow.
BUG=226860
R=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/14708005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=237536
TBR=lazyboy@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14573007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
11596003 lands.
This patch contains the second part of the ALt+<number> application switching: Switching the content of the chrome icon.
With a landed CL 11596003 this would have been much easier and as such this is partially temporary and will be reverted with the mentioned CL.
BUG=230903
TEST=unittest
Review URL: https://chromiumcodereview.appspot.com/14786011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows other tests (Chrome OS BrowserWithTestWindowTest in particular)
to use AshTestHelper without opening an X window. This speeds up the tests
noticably and makes them less flaky when running locally.
This is a partial revert of https://chromiumcodereview.appspot.com/14284017/ - I was too aggressive in moving code from AshTestBase to AshTestHelper.
BUG=233374
TEST=ash_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/14791002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Find LGTM's in https://codereview.chromium.org/14584002/
Review URL: https://codereview.chromium.org/14582005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some code was creating windows in the renderer process. These windows are
included in Windows' enumeration of a renderer's threads at log off/shutdown.
Renderers do not have a UI message loop (aren't pumped) and so don't respond
to messages that Windows sends during shutdown. As a result, they appear hung,
and shutdown is blocked.
Remove two locations that were creating windows, and add a DCHECK that the
main renderer thread does not create windows.
BUG=230122,236031,236039
Review URL: https://chromiumcodereview.appspot.com/14305025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BluetoothDevice::ConnectToService().
BUG=229636
Review URL: https://chromiumcodereview.appspot.com/14748004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Relanding. It was reverted due to a memory leak.]
* Extracts download filename determination into
DownloadTargetDeterminer. The new class maintains state and observes
the download. Doing so eliminates the need to pass state around as
bound arguments.
* Guarantees that the completion callback to
DownloadManagerDelegate::DetermineDownloadTarget is always invoked,
even if the download is interrupted on initialization. This is
required for reliably resuming downloads.
* The DownloadFilePicker always returns the virtual path for downloads
to Drive. ChromeDownloadManagerDelegate can use it to keep track of
the correct last selected directory for 'Save As' downloads.
* Since no path subsubstituion is necessary during prompting,
DownloadFilePickerChromeOS is no longer necessary.
* Re-orders the sequence of events so that the user is prompted as early
as possible. Expensive history database lookups won't introduce
unnecssary jank.
* History database lookups are only performed if the results of the
lookup are necessary.
* Downloads to Drive don't need the temporary local path to be
determined twice when the default downloads directory is Drive.
BUG=151618
BUG=104335
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197518
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=197578
Review URL: https://chromiumcodereview.appspot.com/14773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, the icon of tasks menu item is located at the right of menu and
no space is inserted for the icon.
This CL moves the icon to the left edge of menu and inserts space in order not to overlap the text label and the icon.
BUG=237157
TEST=Open tasks menu and check the position of icon
Review URL: https://chromiumcodereview.appspot.com/14846005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The OCSP stapling patch has been accepted by the NSS upstream, but the
SSL_GetStapledOCSPResponse function is renamed SSL_PeerStapledOCSPResponses
and the function prototype changed to use the new SECItemArray type.
Many source files contain only a trivial CVS keyword change because the
NSS upstream repository was migrated from CVS to hg (Mercurial).
R=agl@chromium.org,rsleevi@chromium.org
BUG=233732
TEST=no build errors or test failures
Review URL: https://chromiumcodereview.appspot.com/14522022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Service state could arbitrarily become TEMPORARY_UNAVAILABLE for
unknown temporary reasons, and SyncFS should be able to recover
from the status.
- Run timer if service state is TEMPORARY_UNAVAILABLE
- Force running sync (without delay) when a new local change is available
BUG=233096
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/14591006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197917 0039d316-1c4b-4281-b951-d872f2087c98
|