summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix a deprecated use of wstring/GetSwitchValue() for --file-descriptor-limit.viettrungluu@chromium.org2010-04-211-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1764001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45231 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd attempt to land http://codereview.chromium.org/1676002 for njwchocobo@chromium.org2010-04-2111-48/+166
| | | | | | | | | | | | WifiConfigView - support networks with 802.1x authentication by prompting the user to enter an ID, select a certificate/private key file, and enter a password for the key file, if any. Pass these values down the stack into ConnectToWifiNetwork(). TEST=Compiles and login dialog shows new fields when security is 802.1x. BUG=none TBR=njw Review URL: http://codereview.chromium.org/1692005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug whereby an installed page action bubble points not at the page ↵mirandac@chromium.org2010-04-211-2/+5
| | | | | | | | | | action icon. BUG= 41374 TEST= install a page action extension. "installed bubble" points at the icon that was installed. it should work for multiple icons. Review URL: http://codereview.chromium.org/1762001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45228 0039d316-1c4b-4281-b951-d872f2087c98
* Put a button to link to proxy setup into the prefs dialog.avi@chromium.org2010-04-213-25/+174
| | | | | | | | | | | nib changes: Added two static strings, button. BUG=http://crbug.com/22009 TEST=as in bug Review URL: http://codereview.chromium.org/1759001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45227 0039d316-1c4b-4281-b951-d872f2087c98
* Only switch to cf for text/html. With opt-in URLs we could mark a URL to be ↵tommi@chromium.org2010-04-2110-44/+242
| | | | | | | | | | | loaded in CF regardless of the target mime type. If CF turns around and wants to download the target, we would hit an infinite loop. TEST=Verify that issue 40046 is resolved. OptIn urls should work with the moniker patch and downloads should not cause an infinite loop. BUG=40046 Review URL: http://codereview.chromium.org/1715004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45226 0039d316-1c4b-4281-b951-d872f2087c98
* Throw out preferences files that are corrupt rather than keeping them in ↵erikkay@chromium.org2010-04-212-4/+19
| | | | | | | | | | | read-only mode. Also improve data collection a little. See bug for details. BUG=42151 TEST=none Review URL: http://codereview.chromium.org/1691002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45225 0039d316-1c4b-4281-b951-d872f2087c98
* Roll Skia forward to r524.evan@chromium.org2010-04-212-1/+5
| | | | | | | | My target is farther than that, but I'm doing this incrementally. Review URL: http://codereview.chromium.org/1752003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45223 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure tint for frame_incognito is stored in "Cached Theme.pak".erg@chromium.org2010-04-212-0/+2
| | | | | | | | | BUG=41743 TEST=See bug Review URL: http://codereview.chromium.org/1758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45222 0039d316-1c4b-4281-b951-d872f2087c98
* Removing override for media/video-zoom.html as updated baselines and ↵scherkus@chromium.org2010-04-211-3/+0
| | | | | | expectations have landed. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45220 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable TCMalloc on Linux.willchan@chromium.org2010-04-211-1/+1
| | | | | | | | BUG=36687 Review URL: http://codereview.chromium.org/1760002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45219 0039d316-1c4b-4281-b951-d872f2087c98
* NTP: Add some spacing between the app icons.arv@chromium.org2010-04-211-14/+13
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1707005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45218 0039d316-1c4b-4281-b951-d872f2087c98
* A few fixes for GLES2 for the conformance tests.gman@chromium.org2010-04-212-5/+20
| | | | | | | | | TEST=conformance tests BUG=none Review URL: http://codereview.chromium.org/1719003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45215 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix app-modality of the cookie ask dialog.erg@chromium.org2010-04-211-2/+2
| | | | | | | | | | | We need to change the window groupings before we make the new dialog. BUG=37426 TEST=none Review URL: http://codereview.chromium.org/1732002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45214 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Override cursor colors in chrome-theme mode.erg@chromium.org2010-04-214-0/+6
| | | | | | | | | | | On dark gtk themes with light text, the cursor is often white, so in chrome-theme mode we had a white cursor on white background. BUG=40094 TEST=none Review URL: http://codereview.chromium.org/1723001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45213 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the SpdyShark plugin to use the updated compression dictionary.mbelshe@chromium.org2010-04-211-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1695003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45212 0039d316-1c4b-4281-b951-d872f2087c98
* With the GOAWAY code we now can have a case where we attemptmbelshe@chromium.org2010-04-211-1/+2
| | | | | | | | | | | | | | to remove the session from the pool twice. Recover, instead of abort, on that case. Caught by existing test case already. TBR=willchan BUG=none TEST=SpdyNetworkTransactionTest.GoAwayWithActiveStream git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45211 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher on SpdySession teardown. When we close the session on error,mbelshe@chromium.org2010-04-212-0/+33
| | | | | | | | | | | | | | | | | | we can get into a case where we delete the session itself while cleaning out the active streams. This ends up with a re-entrant call into CloseAllStreams. Fix is to self-hold a reference during teardown. The test case crashes without the fix, and works fine with the fix. BUG=42215 TEST=SpdyNetworkTransactionTest.GoAwayWithActiveStream Review URL: http://codereview.chromium.org/1711008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45210 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45203 - Land http://codereview.chromium.org/1676002 for njwjhawkins@chromium.org2010-04-219-160/+43
| | | | | | | | | | | | tbr:njw TEST=Compiles and login dialog shows new fields when security is 802.1x BUG=none Review URL: http://codereview.chromium.org/1712003 TBR=chocobo@chromium.org Review URL: http://codereview.chromium.org/1743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45206 - fix chromium os build.jhawkins@chromium.org2010-04-211-4/+4
| | | | | | | TBR=chocobo@chromium.org Review URL: http://codereview.chromium.org/1697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45208 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind memory leak complain in ViewTestxiyuan@chromium.org2010-04-211-0/+6
| | | | | | | | | BUG=42199 TEST=Verify valgrind issue in 42199 is fixed. Review URL: http://codereview.chromium.org/1761001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45207 0039d316-1c4b-4281-b951-d872f2087c98
* fix chromium os build.chocobo@chromium.org2010-04-211-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45206 0039d316-1c4b-4281-b951-d872f2087c98
* Polish ChromeOS options dialog:xiyuan@chromium.org2010-04-219-6/+361
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Add a chromeos OptionsWindowView that hosts options pages in a ChromeWindow so that it has a frame; This piece of code is based on Chrome's OptionsWindowView. Ideally, we should use Chrome's options view but we still missing underlying controls such as Tree and Table. - Use last active browser window as options dialog's parent; This makes optiosn dialog transient for the browser window and window manager will no longer treat it as top-level window and will not move and resize it; - If user switches to a new browser window and invokes options dialog again, close the existing one and re-opens it for the current browser window. This is currently supported by window manager; - Update CustomerFrameView and WindowDelegate to make client edge optionaly; Options dialog has no client area padding and does not have a client edge per UI mock; - Make NativeViewHost respects its background. This solves the problem that tab pane background is not properly cleared when hosting a native GtkVBox pane in TabbedPane; BUG=<http://crosbug.com/1885> TEST=Verify ChromeOS settings dialog looks like the mocks in http://www.chromium.org/chromium-os/user-experience/settings Review URL: http://codereview.chromium.org/1672003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45204 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/1676002 for njwchocobo@chromium.org2010-04-219-43/+160
| | | | | | | | | tbr:njw TEST=Compiles and login dialog shows new fields when security is 802.1x BUG=none Review URL: http://codereview.chromium.org/1712003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45203 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45169 - Fix compile error in ShownSectionsHandlerTest.erikkay@chromium.org2010-04-211-1/+1
| | | | | | | | | | | TBR=bauerb Review URL: http://codereview.chromium.org/1716002 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1735002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45202 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Check that the current thread is a ModelSafeWorker's home thread.nick@chromium.org2010-04-2111-2/+58
| | | | | | | | | | | | | Use this in sync_backend_host.cc to avoid dispatching to a data type controller except when we're on the DTC's home thread. BUG=41824 TEST=during manual testing of 2-client sync; this code is never active during add/deletes and associates/disassociates. Review URL: http://codereview.chromium.org/1741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45201 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45168 - Reland r45028: Factor out reading and writing of preferences ↵erikkay@chromium.org2010-04-2127-519/+314
| | | | | | | | | | | | | | | | | | into |PrefStore|. In order to implement platformspecific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/1688004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45200 0039d316-1c4b-4281-b951-d872f2087c98
* SPDY: Fix unittest-only leak.willchan@chromium.org2010-04-216-83/+21
| | | | | | | | | | We leaked the SpdySessionPool and SpdySession in the test since they have a circular reference. This is usually broken by a GOAWAY frame in real code, but we have to manually break the circular reference here. BUG=42084 Review URL: http://codereview.chromium.org/1695001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45198 0039d316-1c4b-4281-b951-d872f2087c98
* TCMalloc: don't use initialize hook. Just set the hook pointers directly.willchan@chromium.org2010-04-211-13/+7
| | | | | | | | | | | Don't do this for memalign since it's already done elsewhere. TODO(willchan): Mimic MemalignOverride and get it working for debugallocation and HeapChecker later. BUG=40974,42171 Review URL: http://codereview.chromium.org/1693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45197 0039d316-1c4b-4281-b951-d872f2087c98
* (jrg@chromium.org2010-04-2111-55/+1727
| | | | | | | | | | | | | | | | | | | | | | | | | | | Retry of http://codereview.chromium.org/1731001 Try servers not helpful since this includes a binary file. Unfortunately I did a --gtest_filter=BookmarkBar\* to self-test which did not include BookmarkButton* tests :-( Only change is "size" to "cellSize" on 2nd to last line of TEST_F(BookmarkButtonCellTest, FolderArrow) ) UI review follow-up for m5 bookmark bar deliverables Remove border of the (empty) bookmark item. Add arrow icons for folders in bookmark bar folder windows (but not on the bar) Scroll wheel events now scroll the bookmark bar folder windows (mostly works; has a little leak-thru) BUG=42026 TEST=see description xib change: NSScrollView changes to a BookmarkBarFolderWindowScrollView Review URL: http://codereview.chromium.org/1709004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spelling of Flickr.avi@chromium.org2010-04-213-9/+9
| | | | | | | | | BUG=none TEST=make sure file uploading to Flickr still works. Review URL: http://codereview.chromium.org/1718005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45195 0039d316-1c4b-4281-b951-d872f2087c98
* Disables DownloadTest for Valgrind.bulach@chromium.org2010-04-211-0/+2
| | | | | | | | BUG=42205 Review URL: http://codereview.chromium.org/1736004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45194 0039d316-1c4b-4281-b951-d872f2087c98
* Changed NPAPI include path to be absolute. Since we cannot use ANY npapi ↵alokp@chromium.org2010-04-213-8/+4
| | | | | | | | header, keeping the include path as absolute is less confusing. Review URL: http://codereview.chromium.org/1722001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45193 0039d316-1c4b-4281-b951-d872f2087c98
* Added facility to stub log and check. It is still not ideal but workable.alokp@chromium.org2010-04-212-21/+11
| | | | | | Review URL: http://codereview.chromium.org/1697002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45192 0039d316-1c4b-4281-b951-d872f2087c98
* Client side code should include local logging so it can be stubbed out.alokp@chromium.org2010-04-212-7/+3
| | | | | | Review URL: http://codereview.chromium.org/1714001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45191 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the system to only close browser windows which currently are ↵dhg@chromium.org2010-04-212-10/+35
| | | | | | | | | | | pointed to by the filebrowser. BUG=chromium-os:2547 TEST=NONE Review URL: http://codereview.chromium.org/1690001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45190 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/1610030/show from Luigi:sky@chromium.org2010-04-218-261/+157
| | | | | | | | | | | | | | | | | | This changes makes histograms dynamically defined by external metrics clients, instead of hardcoding them in Chrome source. This is important because making even simple changes to Chrome is laborious and takes a fair amount of learning. Unfortunately user actions still require code in Chrome, because of a pre-processing script that extracts them from the source. BUG=NONE TEST=the included unit test Review URL: http://codereview.chromium.org/1718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45189 0039d316-1c4b-4281-b951-d872f2087c98
* Roll out V8 2.2.4.2, with a bugfix for 42137mnaganov@chromium.org2010-04-211-1/+1
| | | | | | | | BUG=42137 Review URL: http://codereview.chromium.org/1728003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45187 0039d316-1c4b-4281-b951-d872f2087c98
* Rename OnBlockedContentChange to OnContentSettingsChange.bulach@chromium.org2010-04-214-8/+7
| | | | | | | | | | | BUG=None TEST=compiles (Patch from Thiago Farina <thiago.farina@gmail.com> http://codereview.chromium.org/1664003/show) Review URL: http://codereview.chromium.org/1750002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45186 0039d316-1c4b-4281-b951-d872f2087c98
* Update v8 revision in DEPS to latest trunk versionricow@chromium.org2010-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45185 0039d316-1c4b-4281-b951-d872f2087c98
* Increase sleep timeout for valgrind UI tests.bauerb@chromium.org2010-04-211-0/+1
| | | | | | | | | | | | | DownloadTest.CloseNewTab2 is failing (ASSERT failure, not memory leak) under valgrind because of a timeout. This patch increases the sleep timeout for UI tests to the same value as the action timeout (when running the test normally, the default value for the sleep timeout is also the action timeout). BUG=none TEST=DownloadTest.CloseNewTab2 (run under valgrind) Review URL: http://codereview.chromium.org/1725003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45183 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore base/thread_local_storage, not just _posix (ThreadSanitizer)timurrrr@chromium.org2010-04-211-1/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1729004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45182 0039d316-1c4b-4281-b951-d872f2087c98
* Run DiskCache tests under TSan on Wintimurrrr@chromium.org2010-04-211-4/+0
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1746003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45180 0039d316-1c4b-4281-b951-d872f2087c98
* Run more base_ tests under TSan/Wintimurrrr@chromium.org2010-04-211-7/+1
| | | | | | | TBR=glider Review URL: http://codereview.chromium.org/1757001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45177 0039d316-1c4b-4281-b951-d872f2087c98
* Supresses valgrind tests related to AutoFillProfilebulach@chromium.org2010-04-211-0/+52
| | | | | | | | BUG=42185 Review URL: http://codereview.chromium.org/1756001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45176 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 383.0 to 384.0chrome-release@google.com2010-04-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45174 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation details of 1596023 (UI Language switch implemented).glotov@google.com2010-04-2112-116/+72
| | | | | | | | | | | | | DEPENDS_ON=1648004 (http://codereview.chromium.org/1648004/show) DEPENDS_ON=1596023 (http://codereview.chromium.org/1596023/show) DEPENDS_ON=1568033 (http://codereview.chromium.org/1568033/show) BUG=none TEST=none Review URL: http://codereview.chromium.org/1551029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45172 0039d316-1c4b-4281-b951-d872f2087c98
* Roll WebKit to 57959 (from 57955)yuzo@chromium.org2010-04-211-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jamser Review URL: http://codereview.chromium.org/1719004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45170 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error in ShownSectionsHandlerTest.bauerb@chromium.org2010-04-211-1/+1
| | | | | | | | TBR=bauerb Review URL: http://codereview.chromium.org/1716002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45169 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45028: Factor out reading and writing of preferences into |PrefStore|.bauerb@chromium.org2010-04-2127-314/+519
| | | | | | | | | | | | | In order to implement platform-specific policies, reading and writing preferences needs to be abstracted from the |PrefService|. The interface for that is now |PrefStore|, with an implementation |JsonPrefStore|, which stores the pref data in a JSON file. There is another implementation, |DummyPrefStore|, which doesn't store any persistent preferences, and is currently used for tests. Most of the changes are for using the new interface, which is |new PrefService(new JsonPrefStore(filename))| instead of |new PrefService(filename)|. BUG=40259 TEST=PrefServiceTest.*:PrefServiceSetValueTest.*:PrefMemberTest.*:JsonPrefStoreTest.* Review URL: http://codereview.chromium.org/1687001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45168 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare to move an InitWebCoreSystemInterface() call intkent@google.com2010-04-212-0/+9
| | | | | | | | | | | third_party/WebKit/WebKitTools/DumpRenderTree/chromium/DumpRenderTree.cpp to webkit_support. BUG=none TEST=none Review URL: http://codereview.chromium.org/1688003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45167 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 20:56:44 +0000