| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
print_web_view_helper.cc
BUG=none
TEST=printing works after code changes.
Review URL: http://codereview.chromium.org/6165004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Created common test base class for views.
Note: Textfield::RequestFocus is failing because Windows' FocusManager::ClearNativeFocus resets the focused view to NULL for some reason. I don't have win at hand and am now requesting win7. I will look into it once I've got win7.
BUG=none
TEST=native_textfield_views_unittest and textfield_views_model_unittest have been enabled for win.
Review URL: http://codereview.chromium.org/6102003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method.
BUG=chromium:65345, chromium-os:10721
TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps
Review URL: http://codereview.chromium.org/6211005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/test/data/import/firefox/linux.zip
Revert 71180 - Fixed crash caused by ResourceDispatcher::OnReceivedRedirect() indirectly running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method.
BUG=chromium:65345, chromium-os:10721
TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps
Review URL: http://codereview.chromium.org/6211005
TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/6100012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running a nested mesage loop in request_info->peer->OnReceivedRedirect() call. The loop might kill the instance of PendingRequestInfo what caused this crash. The fix simply checks for validity of PendingRequestInfo one more time within this OnReceivedRedirect() method.
BUG=chromium:65345, chromium-os:10721
TEST=sign up with gmail, try to switch account to another one - there should be no crash. see http://crosbug.com/10721 for more detailed repro steps
Review URL: http://codereview.chromium.org/6211005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=13943, 13746, 13749, 13597, 13249, 13145, 12875, 12874, 12871, 12438, 12436, 12431
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6076006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support alpha blending, post-process the
metafile to replace the AlphaBlend calls with BitBlts from a software-composited rendering of the page so far.
BUG=7434
TEST=see bug
Review URL: http://codereview.chromium.org/5362002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=68882
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6121004
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6134010
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/6130008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark PrintPreviewUITest.PrintCommandDisabled flaky.
BUG=69389,69390
TEST=none
Review URL: http://codereview.chromium.org/6184003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=leak 000000002551055A goes away
Review URL: http://codereview.chromium.org/6173009
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/6128010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64870 64922
TEST=none
Review URL: http://codereview.chromium.org/6174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no log parser errors on heapcheck bot
Review URL: http://codereview.chromium.org/6220004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=leak 000000002551055A goes away
Review URL: http://codereview.chromium.org/6173009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=68882
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6121004
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/6134010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68882
TEST=no visible changes; all tests pass
Review URL: http://codereview.chromium.org/6121004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=66822
TEST=None
Review URL: http://codereview.chromium.org/6115004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Requested by William Grosso
BUG=none
TEST=Navigate to https://www.lgelements.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6109009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PrerenderResourceHandler will initiate prerendering of a web page under the following conditions:
- The initial request is a GET for a ResourceType::PREFETCH resource.
- The mime-type (sniffed or explicitly specified) of the resource is text/html.
- The response status code is a 200.
- The top-level page will not need to be revalidated until after it's guaranteed to be removed from potential use.
The handler passes along all data to the backing resource handler.
BUG=61745
TEST=unit_tests --gtest_filter="PrerenderResourceHandlerTest*"
Manual Test: Start Chrome with --enable-page-prerender. Go to a page with a <link rel=prefetch> element. Navigate to that element, and make sure that it uses the prerendered view.
Review URL: http://codereview.chromium.org/5912001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6195003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1d5eb805e2ca9cc97355cd73250f9838a5240a49.
TBR=satorux@chromium.org
BUG=chromium-os:9682
TEST=none
Review URL: http://codereview.chromium.org/6176007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:9682
TEST='emerge-x86-generic chromeos-chrome' from source passes
Review URL: http://codereview.chromium.org/5981001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This was a TODO for phajdan.jr).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6188004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The earlier fix changes the behaviour of the find bar text field such that
whenever the textfield is focused, all of the text inside it is selected. This
was done to fix a regression where the text was not getting selected when
switching tabs (read description on that issue for more info). However, this
new behaviour could be undesirable as we may not need to select the whole text
everytime find bar gains focus. Hence, in this fix, we undo the changes from
the earlier fix and add the selectall behaviour at the right place (when the
tab is switched).
BUG=none
TEST=Test added in the earlier CL still passes.
Review URL: http://codereview.chromium.org/6188005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6173008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5986020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=yurys
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reading of 3rd party cookies
BUG=69066
TEST=net_unittests
Review URL: http://codereview.chromium.org/6207005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit rool 75540:75584.
TEST=none
BUG=69349
TBR=jschuh
Review URL: http://codereview.chromium.org/6139008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=senorblanco
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69324
TEST=manual
Review URL: http://codereview.chromium.org/6151008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6235001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
anything and add webp
BUG=67987
TEST=omnibox can show webp from filer or harddrive when mimetype or extension is wrong
Review URL: http://codereview.chromium.org/6124007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Using the debugger, I can verify that previously we were redrawing the entire list once per row (e.g. 10 times if you delete a row in a list that has 10 rows). Now it only redraws once for the delete.
BUG=69086
TEST=see above
Review URL: http://codereview.chromium.org/6099016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with the fixes needed so we everything will stay green.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6128009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Added new test.
Review URL: http://codereview.chromium.org/6004010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=maruel
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=senorblanco
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for:
- adding UI that will distinguish the keyboard from the client view
- controlling focus behaviour of the keyboard: it is made unfocusable
here as well
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6020013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- webcam (as in youtube.com\my_webcam)
- gtalk
BUG=64356
TEST=see bug
Review URL: http://codereview.chromium.org/6139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
method.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
blacklist matches.
BUG=69172
Review URL: http://codereview.chromium.org/6111005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed console spam while I'm here.
BUG=63842
TEST=none
Review URL: http://codereview.chromium.org/6155008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
builder. I was able to
reproduce it once and it appears to be occuring when the ListenSocket attempts to pass an
OnObjectSignaled notification to a delegate which is the web server which has already been destroyed
Attempted fix is to destroy the ListenSocket in the destructor of the web server.
BUG=none
TEST=Existing chrome frame tests.
TBR=amit
Review URL: http://codereview.chromium.org/6155009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6227002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6212003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69292
TEST=http://www.ninepointfive.org/
Review URL: http://codereview.chromium.org/6099015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Validation feedback still needs polish, but this is completely functional, so I'll leave that for a follow-up.
This introduces a new shared class for editable lists; we should migrate the existing editable lists to it, expanding as necessary, but I didn't want to make this patch too unwieldly.
BUG=63825,61742
TEST=Search engines should be editable and addable inline in DOMUI prefs.
Review URL: http://codereview.chromium.org/6151004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fail to load resources.pak. This allows us to collect more
UMA stats.
BUG=58056
TEST=Delete resources.pak and start chrome. It shouldn't crash.
Review URL: http://codereview.chromium.org/6123006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71117 0039d316-1c4b-4281-b951-d872f2087c98
|