summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Add in Win-XP baselines for ruby laytout tests.ajwong@chromium.org2010-01-2232-16/+0
| | | | | | | | TBR=levin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36856 0039d316-1c4b-4281-b951-d872f2087c98
* Implement layoutTestController.setWillSendRequestReturnsNullkinuko@chromium.org2010-01-225-4/+31
| | | | | | | | | BUG=32305 TEST=fast/loader/onload-willSendRequest-null-for-frame.html Review URL: http://codereview.chromium.org/552009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36855 0039d316-1c4b-4281-b951-d872f2087c98
* Updating calling pattern for bug_32084oshima@chromium.org2010-01-221-6/+6
| | | | | | | | | | TBR=sky@chromium.org BUG=32084 TEST=none Review URL: http://codereview.chromium.org/554050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36854 0039d316-1c4b-4281-b951-d872f2087c98
* Rollling 53585 -> 53655.ajwong@chromium.org2010-01-22108-1176/+548
| | | | | | | | | | Rebaseline ruby tests, and mark 2 consistent failures. BUG=32863,32864 Review URL: http://codereview.chromium.org/553055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36853 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks due to not deleting closures.tim@chromium.org2010-01-222-3/+5
| | | | | | | | TBR=nick@chromium.org Review URL: http://codereview.chromium.org/552102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36852 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing 's' from path. Fixes rebaseline tool.ajwong@chromium.org2010-01-221-1/+1
| | | | | | | | | | | TBR=dpranke BUG=none TEST=ran the rebaseline tool successfully. Review URL: http://codereview.chromium.org/543169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36851 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling ResourceFetcherTests.ResourceFetcherDownload.ajwong@chromium.org2010-01-221-1/+1
| | | | | | | | | | | It is consistently failing after CL 36840. BUG=32869 TEST=none Review URL: http://codereview.chromium.org/546115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36850 0039d316-1c4b-4281-b951-d872f2087c98
* Split platform specific settings out from locale_settings.grd so we cantony@chromium.org2010-01-22214-1467/+1439
| | | | | | | | | | | | | | | | | | have per platform config and overrides. This is easier to manage than the mess of <if>'s in the existing grd and xtb files. Each platform only builds its locale_settings_{win,mac,linux}.grd file. All the grd files generate the same platform_locale_settings.h header (for easy inclusion in .cc files). We use the fallback feature of grit to only specify locale specific values in xtb files if we want to override the default for the locale. BUG=28590 Review URL: http://codereview.chromium.org/545132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36849 0039d316-1c4b-4281-b951-d872f2087c98
* Whoops, fix expectation to be TIMEOUT, not SLOWdpranke@chromium.org2010-01-221-1/+1
| | | | | | | | | | BUG=none TEST=fast/media/lifetime.html TBR=yusukes@chromium.org Review URL: http://codereview.chromium.org/551113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36848 0039d316-1c4b-4281-b951-d872f2087c98
* Update some flaky expectations.dpranke@chromium.org2010-01-221-0/+3
| | | | | | | | | | | BUG=none TEST=fast/media/lifetime.html TEST=storage/domstorage/sessionstorage/delete-removal.html TBR=yusukes@chromium.org Review URL: http://codereview.chromium.org/552100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36844 0039d316-1c4b-4281-b951-d872f2087c98
* Fix path to hard-code http_server python scripts.dpranke@chromium.org2010-01-221-0/+4
| | | | | | | | | | BUG=none TEST=none TBR=yusukes@chromium.org Review URL: http://codereview.chromium.org/552099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36843 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36837 (caused XP unit_tests crashes) - Implement ↵willchan@chromium.org2010-01-223-73/+3
| | | | | | | | | | | | | | NetworkChangeNotifierWin. Uses the NotifyAddrChange() API to detect ip address changes. BUG=http://crbug.com/26156 Review URL: http://codereview.chromium.org/551077 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/543167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36842 0039d316-1c4b-4281-b951-d872f2087c98
* Fix path to lighttpd.confdpranke@chromium.org2010-01-221-1/+2
| | | | | | | | | | BUG=none TBR=pam@chromium.org TEST=none Review URL: http://codereview.chromium.org/549128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo leading to deref and crash.dpranke@chromium.org2010-01-221-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=pam@chromium.org Review URL: http://codereview.chromium.org/546113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36840 0039d316-1c4b-4281-b951-d872f2087c98
* Move the layout_tests scripts into a webkitpy/layout_tests subdir todpranke@chromium.org2010-01-2242-1655/+1675
| | | | | | | | | | | | | | | mirror what the upstream file structure will be. In addition, we add a new run_webkit_tests.py wrapper that calls webkitpy/layout_tests/run_chromium_webkit_tests.py, and modify the latter file to be callable as a module as well as a main. BUG=none TEST=none R=pam@chromium.org, eseidel@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36839 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stupid mistake in sync_session.h, I thought the tests were run on ↵tim@chromium.org2010-01-221-1/+1
| | | | | | | | | | | | | mac/linux (and they were green) but they aren't. TBR=nick@chromium.org Review URL: http://codereview.chromium.org/552098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36838 0039d316-1c4b-4281-b951-d872f2087c98
* Implement NetworkChangeNotifierWin.willchan@chromium.org2010-01-223-3/+73
| | | | | | | | | Uses the NotifyAddrChange() API to detect ip address changes. BUG=http://crbug.com/26156 Review URL: http://codereview.chromium.org/551077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36837 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed format strings from my original CL at ↵zelidrag@chromium.org2010-01-222-9/+11
| | | | | | | | | | | | http://codereview.chromium.org/546091 BUG=32719 TBR=pkasting TEST=none Review URL: http://codereview.chromium.org/543160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36836 0039d316-1c4b-4281-b951-d872f2087c98
* Support for multiple sync ModelSafeWorkers.tim@chromium.org2010-01-2225-251/+401
| | | | | | | | | | | | | | | | | | - Introduce an equivalence class enum to group sync model types that live on the same chrome native model together. - Remove ModelSafeWorkerBridge as it is no longer needed. - Rename BookmarkModelWorker -> UIModelWorker, and make it use the new stuff. - Allow syncable entries belonging to an "unsynced" model type to be just processed "passively" from the SyncerThread (rather than dispatching), and allow this to change as a result of enable/disabling. - Experimenting with a way to complete issue 31909 (the CLASS_UNASSOCIATED stuff). BUG=31925,31911,31909 Review URL: http://codereview.chromium.org/553015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36835 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for testing OpenMAX supporthclam@chromium.org2010-01-221-24/+331
| | | | | | | | | | | | | Added the following test cases: 1. GetComponentsByRole() now works with valid roles 2. GetHandle() / FreeHandle() pair on video decoder component 3. General configuration of video decoder component TEST=omx_unittests Review URL: http://codereview.chromium.org/550051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36834 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from chromium-reviews@googlegroups.com to chromium-reviews@chromium.org.jam@chromium.org2010-01-221-1/+1
| | | | | | | Existing issues will still use the old list. Review URL: http://codereview.chromium.org/551111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36833 0039d316-1c4b-4281-b951-d872f2087c98
* Dropping empty directories.bradnelson@google.com2010-01-220-0/+0
| | | | | | | | | BUG=None TEST=None TBR=wtc git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36832 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for FullTabModeIE_ChromeFrameDeleteCookieTest and issues with deleting ↵tommi@chromium.org2010-01-224-4/+50
| | | | | | | | | | | persistent cookies as reported in bug 30786. TEST=Run FullTabModeIE_ChromeFrameDeleteCookieTest. BUG=32546,30786 Review URL: http://codereview.chromium.org/551101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36831 0039d316-1c4b-4281-b951-d872f2087c98
* fix 32718tim@chromium.org2010-01-221-8/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36829 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit from 53511 -> 53585.ajwong@chromium.org2010-01-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/551109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36824 0039d316-1c4b-4281-b951-d872f2087c98
* There was a crash under certain flip protocol errors when the session is tornmbelshe@chromium.org2010-01-224-16/+131
| | | | | | | | | | | | | | | | | | | | | | down. Basically, an error occurred, and we had cleaned up all streams and removed our last reference from the FlipSessionPool, causing |this| to be destroyed. But on the stack we came through and issued another read off the now defunct FlipSession. Added two new tests for FlipSession errors - one when frame decompression fails, and one when we get a full protocol error on the session. NOTE: Had to remove DCHECK from flip_framer; I'm intentionally triggering that DCHECK, but it fires on our unit tests and windows doesn't support death tests in any reasonable way. Since the check was an arbitrary assist for early debugging, this should be okay. BUG=none TEST=flip_network_transaction_unittest.cc Review URL: http://codereview.chromium.org/549116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36820 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressing two more errors chrome os ui_tests.oshima@chromium.org2010-01-221-1/+45
| | | | | | | | | BUG=32624,32641 TEST=none Review URL: http://codereview.chromium.org/551108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36819 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: remove superflous focus grabbing calls that cause crashes in debug mode.estade@chromium.org2010-01-221-6/+0
| | | | | | | | | | | The body of OnPromptShown handles default focus. BUG=none TEST=middle click on a link that requires http auth in debug mode, the browser shouldn't crash Review URL: http://codereview.chromium.org/554042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36817 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for phantom tabs. A pinned tab becomes a phantom tab whensky@chromium.org2010-01-2225-97/+405
| | | | | | | | | | | | | | | | | it is closed, and effectively unloads the renderer and replaces it with a new TabContents that loads when selected. A phantom tab is currently rendered without a border. Phantom tabs do not prevent a window from closing. Long term only pinned app tabs will have the ability to be made phantom, but this allows us to test the feature until app support is all wired in. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
* If we navigate to a URL which has an anchor in IE, which eventually ends up ↵ananta@chromium.org2010-01-228-13/+115
| | | | | | | | | | | | | | | | | | | | | in ChromeFrame, the actual URL queried from the moniker passed in to our implementation of IPersistStream::Load does not have the anchor. It looks like there are some private interfaces exposed by MSHTML and invoked by IEFrame to pass this information over. Our fix is to save away the url received in our Bho BeforeNavigate2 notification and use this URL if available before querying the moniker for the URL. This needs to be done in IPersistStream::Load and in the OnHttpEquiv patch when we initiate a navigation to the actual URL using the moniker. Fixes bug http://code.google.com/p/chromium/issues/detail?id=27270 Bug=27270 Test=Covered by unit test. Review URL: http://codereview.chromium.org/542096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36814 0039d316-1c4b-4281-b951-d872f2087c98
* Add some extra request information to LoadLog:eroman@chromium.org2010-01-212-0/+17
| | | | | | | | | | | | | | * the error code that URLRequest Start() failed with. * which peer the TCP connection is being made to [Only in full logging mode] (for example, when using a proxy, this may differ from the host:port of the URL). * the type of redirect that was received, and its URL [Only in full logging mode] BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/553043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36813 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: don't get stuck in render view drag.estade@chromium.org2010-01-211-5/+16
| | | | | | | | | | | Everyone once in a while gtk_drag_begin() returns NULL meaning the drag failed to start. Inform webkit of this. BUG=30580 TEST=see bug Review URL: http://codereview.chromium.org/548108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36812 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where needs_reload_ was not getting set to false in somesky@chromium.org2010-01-214-1/+31
| | | | | | | | | | | situations, leading to a stuck throbber. BUG=31462 TEST=see bug Review URL: http://codereview.chromium.org/554025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36811 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a comment long-obsolete.avi@chromium.org2010-01-211-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/545160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36810 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a directory which appears to be unused and no one (?) can rememberdpranke@chromium.org2010-01-2120-1087/+0
| | | | | | | | | | | | what it was for. BUG=none TEST=none R=pam@chromium.org Review URL: http://codereview.chromium.org/555040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36809 0039d316-1c4b-4281-b951-d872f2087c98
* PyAuto: Python Interface to Chromium's Automation Proxy.nirnimesh@chromium.org2010-01-217-97/+479
| | | | | | | | | | | | | | | | | | | | | PyAuto is a python interface to chromium's automation framework. It exposes some of the Automation Proxy functions in Python. This can be used to play around with chromium, or automate functional tests. SWIG is used to bridge Automation Proxy's C++ to Python. This CL addresses Mac-only to begin with. I'll be adding win/linux shortly. Also, this CL breaks down UITest class into parts that does not use gtest (UITestBase) and parts that does (UITest). UITestBase is used by pyauto. BUG=32283 TEST=None Review URL: http://codereview.chromium.org/555022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash in extensions due to painting badges on PageActions.finnur@chromium.org2010-01-211-15/+2
| | | | | | | | | | | It is possible this will move the crash location elsewhere, but since we don't even support showing badges on PageActions, we have no reason to attempt it. BUG=http://crbug.com/31080 TEST=Monitor the crash rate and see if the crash is fixed. Badges should still work on BrowserActions. Review URL: http://codereview.chromium.org/551105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36807 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmarks string1t work.munjal@chromium.org2010-01-217-62/+62
| | | | | | | | | TEST=exists BUG=32013 Review URL: http://codereview.chromium.org/546094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36805 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented Esc/Command-. shortcuts for HTML dialogs.akalin@chromium.org2010-01-211-0/+20
| | | | | | | | | BUG=32216 TEST=manually Review URL: http://codereview.chromium.org/548051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36800 0039d316-1c4b-4281-b951-d872f2087c98
* Removed #ifdef in IncrementErrorCount() now that it's platform-independent.akalin@chromium.org2010-01-211-3/+0
| | | | | | | | | BUG=30728 TEST=trybots Review URL: http://codereview.chromium.org/548062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36799 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest for Negotiate and NTLM auth.cbentzel@chromium.org2010-01-211-3/+2
| | | | | | | | | BUG=NONE TEST=Unittest fix - ran on Vista. Review URL: http://codereview.chromium.org/554040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36798 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2: Disable the test (I accidentally modified the file before checking ↵finnur@chromium.org2010-01-211-57/+8
| | | | | | | | | | | | in in my last checkin and added things I was working on but didn't want checked in yet). :/ TBR=oshima BUG=http://crbug.com/28629, http://crbug.com/16447 TEST=None Review URL: http://codereview.chromium.org/554041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36797 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix a crash in the cookies manager that was caused by an invalid ↵rsesek@chromium.org2010-01-214-29/+105
| | | | | | | | | | | | | | | | selection. XIB change: Change the "Remove" button's |enabled| binding from just looking at the count of the selection to FilesOwner.removeButtonEnabled. BUG=32627 TEST=Covered by unit tests. TEST=Open cookies manager. Select one item, make sure "Remove" is enabled. TEST=Open cookies manager. Try to select two items. You shouldn't be able to. Review URL: http://codereview.chromium.org/546102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36796 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a test on Linux Views. It was marked as flaky, but it is failing all ↵finnur@chromium.org2010-01-211-5/+54
| | | | | | | | | | | | | | the time. See http://crbug.com/28629 for details. TBR=pkasting BUG=http://crbug.com/28629, http://crbug.com/16447 TEST=None Review URL: http://codereview.chromium.org/552086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36795 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] relayout the import data and clear browser data buttons in the prefs ↵thomasvl@chromium.org2010-01-212-39/+19
| | | | | | | | | | for the string changes that already landed. more work will be needed to make the window match the new wants, but this gets the tests passing again. BUG=32719 TEST=unittests green up Review URL: http://codereview.chromium.org/551103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36793 0039d316-1c4b-4281-b951-d872f2087c98
* Check for context changes during Mac plugin event handling.stuartmorgan@chromium.org2010-01-211-1/+10
| | | | | | | | | | | Ensure that we don't use a context that's no longer valid BUG=32773 TEST=Toggle YouTube videos between normal and expanded size. Review URL: http://codereview.chromium.org/555038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36792 0039d316-1c4b-4281-b951-d872f2087c98
* Simplifying appmenu impl.oshima@chromium.org2010-01-212-17/+8
| | | | | | | | | | | Using command id instead of index. BUG=none TEST=none Review URL: http://codereview.chromium.org/554038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36791 0039d316-1c4b-4281-b951-d872f2087c98
* Insert diagnostics in an attempt to track down a crash in popup menuspam@chromium.org2010-01-212-0/+15
| | | | | | | | | | in RenderWidgetHostViewMac::ShowPopupWithItems(). BUG=31716 TEST=should have no user-visible effect; see crash reports Review URL: http://codereview.chromium.org/545159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36790 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hide browser action buttons when they would otherwise overflow with ↵andybons@chromium.org2010-01-215-7/+101
| | | | | | | | | | the omnibar. TEST=none BUG=29838 Review URL: http://codereview.chromium.org/553038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36789 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bugs in libjingle's handling of connection errors.akalin@chromium.org2010-01-212-1/+9
| | | | | | | | | BUG=32819 TEST=see bug Review URL: http://codereview.chromium.org/545150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36787 0039d316-1c4b-4281-b951-d872f2087c98