| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=valgrind test bots work
R=maruel@chromium.org
Review URL: http://codereview.chromium.org/543179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=storage/domstorage/localstorage/iframe-events.html
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/545179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32915
TEST= unit test included
Review URL: http://codereview.chromium.org/553061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* defined UIStyle enum
* fixed #if for compact navbar so that it's enabled only on chromeos
* Moved view initialization and layouts code from NormalExtender to chromeosBrowserView and ChromeosBrowsrViewLayoutManager respectively.
* Removed unnecessary extender code from BrowserView.
* no functional change
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failing one websocket test.
Adding a bunch of other failures that jorlow will resolve with a 2-sided commit.
BUG=32929
TEST=none
Review URL: http://codereview.chromium.org/552123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flakiness from the database layout tests: when a DB test calls
ClearAllDatabases(), we force test_shell to wait for all DBs opened in
previous tests to close before running the test.
TEST=none
BUG=32016,32396,32206,32157,30081
Review URL: http://codereview.chromium.org/549095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Go to http://www.whitehouse.gov/rss and click on any of the links to the feeds. It should take you to the subscription preview page in a new tab.
Review URL: http://codereview.chromium.org/543129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r36138 might have caused a 5-20ms startup perf regression
on linux-release-hardy. Revert to see if the startup
time shows any improvement.
BUG=22614
TEST=watch the linux-release-hardy startup test for
~5 runs
Review URL: http://codereview.chromium.org/555053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
creates.
BUG=30810
TEST=none
Review URL: http://codereview.chromium.org/548113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CreateSyncErrorButton is not unused anywhere.
Original CL by thiago.farina@gmail.com: http://codereview.chromium.org/549003/edit
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/552095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Manual testing.
Review URL: http://codereview.chromium.org/545158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added the following test cases:
- Transition to executing state and back
- Free component handle during executing state to expose leakage.
- Request component handle using callbacks struct on stack and
clear. This exposes bugs in library that doesn't copy the struct.
TEST=omx_unittests
BUG=NONE
Review URL: http://codereview.chromium.org/548095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/543097
Check NPClass::structVersion before accessing fields that don't exist in all versions: NPClass::constructor and NPClass::enumerate
BUG=32387
TESTED=manual and in debugger
Review URL: http://codereview.chromium.org/545176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_frame_unittests on 32 bits OS.
Chromium XP Wine Valgrind Builder wasn't able to link these binaries anymore.
TEST=links
BUG=none
Review URL: http://codereview.chromium.org/548115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There was a problem with pages that call window.close() then immediately open a js alert. The problem was that the TabContents would get destroyed, but the alert would stick around, and when you closed the alert, it would try to call back to the tab contents' js, crashing chrome. The other OSs got around this by closing the alert immediately, but mac didn't implement the CloseModalDialog method. This CL implements that.
BUG=29580
TEST=Run the html attached to the bug
Review URL: http://codereview.chromium.org/549126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window
BUG=32827
TEST=Open incognito window. Wrench menu --> Preferences --> Basics --> Manage. Don't crash.
Review URL: http://codereview.chromium.org/545177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/515076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist implements the following:
- A resize gripper and chevron in the browser action container
- Overflow when icons don't fit
- Snap to multiple of icon size (no excess pixels)
- Animation when resizing container / adding&removing icons (disable, enable).
- Persists the last width of the browser action container.
Known issues:
- No menu (yes, the chevron button doesn't do anything yet).
BUG=32101
TEST=Install and uninstall browser actions & make sure install bubble appears in
the right location. Make sure browser action container does not expand if
chevron is showing when you add browser action. Make sure container loses
chevron when no overflow occurs. Make sure browser action icons never disappear
due to shrinking when you release the mouse (when resizing). Make sure snapping
works.
Review URL: http://codereview.chromium.org/553039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32916
TEST=my build works
Review URL: http://codereview.chromium.org/552116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is half the solution, but it should make some stuff work. This should make
double-clicking on local HTML files (when Chromium is set as default browser)
work more correctly, both when Chromium is already running and when it's not.
(The same, but easier to check: dragging a file or files to the Chromium
application icon.) You should no longer be told that Chromium can't open HTML
files. It's not the full solution since an extraneous (NTP/home page) tab -- or
worse -- will be created if Chromium is not already running; solving this will
require modifying browser startup.
BUG=14808
TEST=Drag a file to the Chromium application icon, both when it's already running and when it's not; file should open in a tab. Do the same, but select multiple files; selected files should open in tabs. Check the same for the Chromium Dock icon (when Chromium is already running). Note that if Chromium is not running, there will be an extraneous (NTP or home page) tab.
Review URL: http://codereview.chromium.org/552109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32844
TEST=URLFetcherCancelTest.CancelWhileDelayedStartTaskPending
Review URL: http://codereview.chromium.org/552107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run unit tests. This change will make the request user agent have a more detailed version number for chrome frame (chromeframe/a.b.c.d instead of chromeframe/a.b)
BUG=29258
Review URL: http://codereview.chromium.org/546117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, it's possible for the window manager
to reparent the toplevel window right before we
try to stack the first-run bubble above it,
leading to a crash (since the two windows are
no longer siblings).
BUG=30498
TEST=not yet
Review URL: http://codereview.chromium.org/545126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/546110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28805
Review URL: http://codereview.chromium.org/555041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rebaselines and new expectations.
2 new regressions:
fast/loader/history-forward-in-head.html = TEXT
http/tests/misc/slow-loading-mask.html = IMAGE+TEXT
Review URL: http://codereview.chromium.org/552113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SharedWorkers now gracefully handle http auth requests after their
initial window has closed.
BUG=27660
TEST=WorkerHttpAuth,SharedWorkerHttpAuth uitests
Review URL: http://codereview.chromium.org/509016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/523120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=asargent
Review URL: http://codereview.chromium.org/553058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added a --enable-openmax switch to enable OpenMAX for video
decoding.
Review URL: http://codereview.chromium.org/555046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
popup is shown would hose the browser.
BUG=32653
TEST=none
Review URL: http://codereview.chromium.org/554044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it depends on how child views are laid out.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It simply records the uptime into the tmp directory for metrics collection
BUG=none
TEST=none
Original review: http://codereview.chromium.org/548044
Patch by sosa@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
New Folder when Bookmark Bar or Others selected.
BUG=32732,32733
TEST=BookmarkTreeControllerTest.NewFolder
Review URL: http://codereview.chromium.org/549125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification.
A noteworthy change here is that OptInUrls doesn't rely on cf: anymore.
TEST=The OptInUrls registry key should start working properly again.
BUG=32660
Review URL: http://codereview.chromium.org/549129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25309
TEST=none
Review URL: http://codereview.chromium.org/551118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
couldn't be loaded. it segfaulted. This makes it not die, disable login, and tell the user. Not so much so that a user could do anything about it, but so that devs can run chromeos chrome on their linux machines and develop the login UI there.
BUG=NONE
TEST=run chromium for chromium OS on your linux box with the --login-manager flag, and watch it not segfault :-)
Review URL: http://codereview.chromium.org/555036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Bug=32857
Test=Create a document with a long title. Open it. Hover over the tab title.
Even if the text is elided it should be only 1 line tall.
Review URL: http://codereview.chromium.org/543166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infobars.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most themes have specific data for a "MetaFrames" class that we weren't using. This fixes the titlebar color
for the xfce themes. I suspect that this also fixes 32173, but I don't have
a Karmic machine yet so I can't test.
BUG=32173
TEST=Themes with different titlebar and selection colors (Xfce-b5 was what I
tested with) shouldn't use the selection color for the titlebar.
Review URL: http://codereview.chromium.org/552092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initialization into IOThread.
The global host resolver and dns master have changed to be member variables of IOThread.
BUG=26156,26159
Review URL: http://codereview.chromium.org/553026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch makes Chromium tests pass when https://bugs.webkit.org/show_bug.cgi?id=28622 is landed. Full support for pause on caught exceptions is to be implemented in Chromium.
BUG=32877
Review URL: http://codereview.chromium.org/551115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and "addSelectionKey" "rangeSelectionkey" modifiers.
They were introduced by http://trac.webkit.org/changeset/53498. The
test will use these features by a patch in http://webkit.org/b/33989.
BUG=10353
TEST=LayoutTests/fast/forms/listbox-deselect-scroll.html
Review URL: http://codereview.chromium.org/545166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset/53592/trunk/WebKitTools/Scripts/runwebkittests
BUG=32863
TEST=websocket/tests/urlnotrailingslash.html passes
Review URL: http://codereview.chromium.org/543171
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/552105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://trac.webkit.org/changeset/53592/trunk/WebKitTools/Scripts/run-webkit-tests
BUG=32863
TEST=websocket/tests/url-no-trailing-slash.html passes
Review URL: http://codereview.chromium.org/543171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36857 0039d316-1c4b-4281-b951-d872f2087c98
|