| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
http://crbug.com/112131
TEST=none
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9455081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Current FileSystemOperationContext has both src and dest path file info in it but this is making the code for cross-FileUtil operations way complex.
This patch removes src/dest information from FileSystemOperationContext and instead:
- introduce new FileSystemPath class, which represents a file path information in a filesystem
- replace all the FilePath args in FileSystemFileUtil with FileSystemPath
The resulting code still has some ugly part, and if we get rid of cross-FU operations from each FU code eventually we may end up converting FileSystemPath back to FilePath, but I think this change is not far from the way we want to go.
BUG=114732, 110121
TEST=existing tests
Review URL: http://codereview.chromium.org/9413009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=115808
TEST=None
Review URL: http://codereview.chromium.org/9463038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123685 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These functions add TimeDelta interfaces in addition to the int ms interfaces,
which will be removed at a later date.
BUG=108171
Review URL: http://codereview.chromium.org/9427023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9465032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/112131
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9460025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the IqRequest class supports setting timeouts for each request, and
JingleSession uses it to disconnect if no response is receive within 10
secons from a request.
BUG=107925
Review URL: http://codereview.chromium.org/9452038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/112131
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123592
Review URL: https://chromiumcodereview.appspot.com/9460025
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9455080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Seems to be the only instance in the project where defines contains a nested list.
Review URL: http://codereview.chromium.org/9465038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is yet another clean-up patch to simplify UploadDataStream
in preparation for making UploadDataStream::Read asynchronous.
Managing the offset and the file stream inside UploadData::Element
is cleaner anyway.
BUG=72001
TEST=net_unittests
Review URL: http://codereview.chromium.org/9452040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=bashi@chromium.org,fischman@chromium.org
Review URL: http://codereview.chromium.org/9447091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes managed mode constrain the height of windows so they don't
overlap the launcher.
BUG=115581
TEST=see bug, covered by unit tests too
R=ben@chromium.org
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9466032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/112131
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123592
Review URL: https://chromiumcodereview.appspot.com/9460025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's failing on the Mac Valgrind bot
TBR=thestig@chromium.org
BUG=10611
TEST=NONE
Review URL: http://codereview.chromium.org/9466039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the audio input and output delegates into their own files.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9430034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
---
When locking the screen via Ctrl-Shift-L from wrench menu,
login screen menus do not work, because wrench menu is not fully closed.
Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event.
Bug=113247
Testing=Manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123500
Review URL: https://chromiumcodereview.appspot.com/9381008
TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9471001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
login screen menus do not work, because wrench menu is not fully closed.
Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event.
Bug=113247
Testing=Manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123500
Review URL: https://chromiumcodereview.appspot.com/9381008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CrosMountPointProvider.
BUG=chromium-os:26006
TEST=coming...
Review URL: http://codereview.chromium.org/9428059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89191
TEST=This is the test itself
Review URL: http://codereview.chromium.org/9466026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The argument was always set as |true| in practice, and is probably needed to prevent infinite navigation loops.
This also simplifies the logic in ChromeContentRendererClient::ShouldFork.
Review URL: http://codereview.chromium.org/9465006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
represents FS abstraction layer between File API and gdata. It autoupdates its content metadata on file/dir lookup requests.
BUG=chromium-os:26006
TEST=GDataFileSystemTest.*
Review URL: https://chromiumcodereview.appspot.com/9437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks Linux Clang.
BUG=none
TEST=none
TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9466037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=bashi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9460041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Open the File Manager. Begin renaming a file. Add an invalid character (like '?'). Press Enter (modal dialog shows). Press Tab several times. Ensure no elements under the dialog got focus.
Review URL: http://codereview.chromium.org/9419007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the ability to authenticate and log in a demo user. This is currently not hooked in to the login UI, hence the lack of PyAuto login tests, but it's been tested with custom code in the browser to drive the login.
BUG=chromium-os:26041
TEST=Tested with custom code added to Chrome to make sure that a user can authenticate and log in as the demo user. Once logged in, tested various GAIA and non-GAIA sites, the cloud printing page and the settings page.
Review URL: http://codereview.chromium.org/9416030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=112096
TEST=*InstallBundle*
Review URL: http://codereview.chromium.org/9456019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
font sizes.
BUG=91922
TEST=When a preset font size is selected in advanced options page, fixed-width font size should change along with default font size.
Contributed by rosen.dash@motorola.com
Review URL: http://codereview.chromium.org/9429051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
TEST=views_unittests
Review URL: https://chromiumcodereview.appspot.com/9447063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
provide mock implementation of the interface.
BUG=chromium-os:19655
TEST=try
Review URL: http://codereview.chromium.org/9455009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The call is no longer necessary because Chrome r100669 or later never starts ibus-daemon on login screen.
BUG=None
TEST=try
Review URL: http://codereview.chromium.org/9454008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
During review of dbus::Property<> bits were moved from the template
into the PropertySet for cleanliness, but one bit was missed out
from the BluetoothProperty<> customisation.
BUG=none
TEST=use of BluetoothProperty<>::Set compiles now
Change-Id: I283141802f61a1fd8ddd2b61c58dd1c63ba695df
Review URL: http://codereview.chromium.org/9467011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added unit tests for direct and navigated download 404 errors.
BUG= 114020
TEST=Set up a server with a web page that has an invalid link. Right click on the link and select Save As to download the file.
Review URL: http://codereview.chromium.org/9378035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=10611
TEST=NONE
Review URL: http://codereview.chromium.org/9463018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=114343
TEST=net_unittests:CertVerifier*, net_unittests:HostCache*
Review URL: http://codereview.chromium.org/9436003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The IconMappingEnumerator is used to iterator all icon_mappings of
the given type.
BUG=
TEST=
Review URL: http://codereview.chromium.org/9464019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=flackr@chromium.org
BUG=114537
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9460037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoids potential problems if $HOME happens to be located on NFS.
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/9467014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=linux clobber builder goes green
R=mdm@chromium.org
TBR=atwilson@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9463037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9455046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is required so that repeated key-down events injected are correctly delivered to X clients.
BUG=115531
Review URL: http://codereview.chromium.org/9466033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We move all histogram code into the base datatype controller implementations.
In addition, we coalesce the histograms that were just counts into enumeration
based on the model type.
BUG=114031
TEST=unit_tests
Review URL: http://codereview.chromium.org/9363060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the IqRequest class supports setting timeouts for each request, and
JingleSession uses it to disconnect if no response is receive within 10
secons from a request.
BUG=107925
Review URL: http://codereview.chromium.org/9452038
TBR=sergeyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9447087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now the IqRequest class supports setting timeouts for each request, and
JingleSession uses it to disconnect if no response is receive within 10
secons from a request.
BUG=107925
Review URL: http://codereview.chromium.org/9452038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=None
TEST=Pressing Esc with content settings doesn't close advanced.
NOTRY=true
Review URL: http://codereview.chromium.org/9464041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e342173b6d83e9528982bf7df9be93dc1c94b856.
This was causing hang in TabClosableStateWatcherTest.CloseIncognitoBrowser.
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tester%20%282%29/builds/190/steps/browser_tests/logs/stdio
TBR=joaodasilva@chromium.org
BUG=114525
TEST=none
Review URL: http://codereview.chromium.org/9464040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123633 0039d316-1c4b-4281-b951-d872f2087c98
|