| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To avoid name conflict when linking DumpRenderTree which has its own implementation of the classes with the same names.
Eventually the related classes will be replaced with V8 API.
BUG=127238
TEST=Build all without error
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10382059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use an OO approach to store the state. Make the code clearer.
1. Remove 'variables' from foo.result and create foo.state for less important
state.
2. Store and manage the file paths in native os.path.sep. Simplify the whole
code.
3. Remove the requirement of providing a .isolate file to isolate.py when
providing an existing .result file. Make it reuse the result file's data as
needed, simplifying user's life.
R=nsylvain@chromium.org
BUG=98637
TEST=manually ran all the tests on linux and windows
Review URL: https://chromiumcodereview.appspot.com/10387037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The class will be used to hold a reference to the thread's task runner.
Review URL: https://chromiumcodereview.appspot.com/10380016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Current code assumes that the current working directory is the same directory
that contains the do_signing.sh script. This chance fixes it so that all
references to local files are relative to the passed-in input directory.
Review URL: https://chromiumcodereview.appspot.com/10381075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This addresses a TODO where we were using buffer_ as a signal to detect we're stopped. In short, we don't need to detect we're stopped since our code already checks for active_loader_.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10381067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
slow shutdown.
This implementation uses the existing OnDestruct method. This is called in
a state where webkit is still intact, so any callbacks by the plugin should
still function properly.
BUG=https://code.google.com/p/flapper/issues/detail?id=120
Review URL: https://chromiumcodereview.appspot.com/10383059
TBR=tsepez@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:71
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10382064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=125846
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10378060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
underlying connection failed.
Previously we would either return a cache miss or a read failure based on whether a read was pending.
BUG=127248
TEST=play a video over the network, disconnect ethernet/wifi and notice that we error immediately
Review URL: https://chromiumcodereview.appspot.com/10375061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This greatly reduces the number of trace events which are generated.
Now, it only traces when the context changes (which is very close to
0% of the time.)
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10181003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pipeline.
BUG=126223
TEST=ChromeFrame metrics should be uploaded to the protocol buffer server.
Review URL: https://chromiumcodereview.appspot.com/10379005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tkent@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10356077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting a custom picture creates a file outside the user's cryptohome.
This should be disallowed for ephemeral users to prevent information
leaking.
BUG=chromium-os:30014
TEST=Manual check that custom pictures are no longer offered
TEST=unit_tests, browser_tests
Review URL: https://chromiumcodereview.appspot.com/10389018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SuggestionsHandler, since the SuggestionsCombiner will be used by another
class in an upcoming CL.
BUG=None
TEST=No user visible changes
Review URL: https://chromiumcodereview.appspot.com/10378049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The manifest package name should not be hardcoded, but instead read from
the context.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10381066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:34
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10380038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
after r136074.
BUG=125807
TEST=none
TBR=hbono
Review URL: https://chromiumcodereview.appspot.com/10389046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will help us to understand what errors are recoverable.
BUG=127119
TEST=compiles
Review URL: https://chromiumcodereview.appspot.com/10356079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This does not include any code that adds notifications yet, that will follow.
BUG=124269
TEST=SystemTrayTest passes, system tray behavior is unchanged.
Review URL: https://chromiumcodereview.appspot.com/10383045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10384084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10389042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A few cleanups were also performed, such as encapsulating the UMA hooks.
BUG= http://code.google.com/p/nativeclient/issues/detail?id=2515
TEST= none
Review URL: https://chromiumcodereview.appspot.com/10377051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126477
TEST=
Review URL: https://chromiumcodereview.appspot.com/10375036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10391030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The clients/consumers of simple_message_box should not worry about this
implementation detail.
R=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10387024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10332043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10389026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=126209
TEST=
Review URL: https://chromiumcodereview.appspot.com/10377041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=122012
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10378027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserGuestSessionNavigatorTest.Disposition_Settings_UseIncognitoWindow
for CL 10384079
TBR=jennb
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10388052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
maintians a pointer that can return null and won't try to initialize the request context on shutdown. Will fix properly in a follow up CL to maintain this getter per profile.
BUG=125292
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10381047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tear down issues, and style issues in TransportSecurityPersisterTest.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10388041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=check_deps stops failing for the metro bits.
Review URL: https://chromiumcodereview.appspot.com/10389043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103513 (this is just clearing the cruft out before implementing the enhancement)
TEST=none: just removing dead code
Review URL: https://chromiumcodereview.appspot.com/10384056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sources do not outlive the suggestions combiner.
BUG=126390
TEST=Enable 'NTP Suggestions page' flag, quickly create (CMD-T) and delete (CMD-W) tabs, ensuring "suggested" pane is selected. Should no longer crash.
Review URL: https://chromiumcodereview.appspot.com/10379037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
names are unique.
BUG=126285
TEST=test should pass more reliably
Review URL: https://chromiumcodereview.appspot.com/10356058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jochen@chromium.org
BUG=126360
TEST=trybot cycles green
Review URL: https://chromiumcodereview.appspot.com/10377048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GDataFileSystem::CheckForUpdates sets the content origin of root directory to
REFRESHING and expects OnFeedFromServerLoaded to set it to FROM_SERVER upon
successful reload of feed. However when we lose network connection, the root
origin is stuck at the REFRESHING state, preventing future updates.
Fix is to implement a callback that checks for failures in reload of feed,
and restores root origin to the initial value when that happens.
BUG=127245
TEST=locally on lumpy device
Review URL: https://chromiumcodereview.appspot.com/10383080
Patch from Haixia Shi <hshi@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1364 | Create a gyp generator for Eclipse CDT settings
r1365 | Fixup dependencies in rules for VS2010 (MSBuild).
r1366 | Fix precompiled headers test
r1367 | Remove duplicate function definitions I accidentally added in r1357.
r1368 | ninja: Add '/', '\', and '.' to the set of shell-safe characters.
r1369 | Let GYP recognize the 'WDK_DIR' environment variable when generating ninja output on Windows.
r1370 | Remove some unused variables reported by pyflakes
r1373 | ninja windows: fix long command lines in more cases
TBR=thakis@chromium.org,grt@chromium.org,alexeypa@chromium.org,mseaborn@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10332066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=103860
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10379032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the GeolocationProviderTest family of tests wait until the
geolocation thread has finished cleaning up during teardown. This
should fix the flakines (*should*, not *will* because I am unable
to reproduce the flakiness myself...).
BUG=126421
TEST=content_unittest GeolocationProviderTest.*
Review URL: https://chromiumcodereview.appspot.com/10382036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are not using a borderbox any more. We are using different shades of gray for the background color instead.
URLs that use to appear as a text are now URL links.
Do not allow wrapping on the first table line where the descriptions of all the columns are.
Rearranging the order of some columns.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9956034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hopefully we'll be able to find out what causes the problem looking at
the crashes (if any).
BUG=123322
TEST=Crash in media::AudioManagerBase::ShutdownOnAudioThread() should go away.
Review URL: https://chromiumcodereview.appspot.com/10383066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using TLS and static function, pass scaling in the skia dictionary.
BUG=125499
TEST=Make sure printing is working.
Review URL: https://chromiumcodereview.appspot.com/10387022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Install cloud_print_service with AUTORUN as LocalService user.
- Disable COM support.
- Enable UAC to get admin.
- Added parameters to start/stop service.
BUG=125026
Review URL: https://chromiumcodereview.appspot.com/10382026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136054 0039d316-1c4b-4281-b951-d872f2087c98
|