| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Also make the accounting of curr_size_bytes_ easier to reason about. It is incremented in the ProgramCacheValue constructor and decremented in the destructor so that it is known to be equal to the total size of all cached values.
BUG=262271
Review URL: https://chromiumcodereview.appspot.com/21676002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=155454:155455&mode=html
TBR=
BUG=
Review URL: https://chromiumcodereview.appspot.com/21667004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/21407002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=267772
Review URL: https://chromiumcodereview.appspot.com/22012002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This removes TestMediaTransferProtocolManagerLinux from the chrome target, and
should hopefully help reduce flakiness.
Review URL: https://chromiumcodereview.appspot.com/21418003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue here is that compositor assumes every draw to match the
viewport exactly, and thus the whole viewport is updated each
draw. But we could be asked to draw a subset of the visible
rect, so there is a mismatch between what is really drawn and
what compositor assume is drawn.
Simple damage tracking inside compositor will not work for
webview because of all the other ways the view could be drawn.
Here is a simple fix. Whenever webview is asked to draw a subset
of the visible rect, invalidate the whole visible rect, regardless
of whether the compositor needs draws.
The assumption here is that the problem only manifests if we draw
a subset of the visible rect, so simply ensure the whole visible
rect drawn is immediately after. Ideally it should only be done if
we can detect the case of mismatch between compositor and what is
drawn, but this requires damage tracking and work through all the
different ways we can draw.
New in reland:
Always query the global visible rect each time it is needed since
the original listener does not always fire when it changes.
BUG=264275
NOTRY=true
Previously committed at r214727
Review URL: https://chromiumcodereview.appspot.com/21191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Waiting on: https://codereview.chromium.org/17569017/
BUG=
Review URL: https://chromiumcodereview.appspot.com/17584005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
internal extensions code.
BUG=267628
Review URL: https://chromiumcodereview.appspot.com/21941002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
abarth doesn't want to own it anymore, so add new people.
Review URL: https://chromiumcodereview.appspot.com/21626006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=234964
Review URL: https://chromiumcodereview.appspot.com/20777008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They may have different sizes, and this is causing a compiler warning
to be issued on win_x64.
e:\b\build\slave\win\build\src\cc\resources\resource_provider.h(69) : warning C4267: 'return' : conversion from 'size_t' to 'unsigned int', possible loss of data
TBR=piman
BUG=
Review URL: https://codereview.chromium.org/22022002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=222252,266346
TEST=none
Review URL: https://chromiumcodereview.appspot.com/21981002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a resubmit of CL 19678018. It was reverted after it was found
to cause a crash in incognito mode. The crash is fixed, and this has been
tested in incognito mode. The code has not changed since CL 19678018
BUG=248331
Review URL: https://chromiumcodereview.appspot.com/21952006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This issue was found by a linter.
R=wtc@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/21877008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=265753
R=jam@chromium.org, jamesr@chromium.org
Review URL: https://codereview.chromium.org/20922004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, MemoryPolicy only limits by number of bytes allocated. For
resources like Android gralloc buffers which also have a process or
system-wide limit, we also need to limit by count of the resource. This
patch implements this and sets a limit of 100 from the AndroidWebView
OutputSurface.
As additional cleanup, I also moved the ignore-0-memory-policy logic to
OutputSurface as it doesn't seem appropriate in CC.
New test parametrization for TileManagerTests.
NOTRY=true
BUG=266619
Review URL: https://chromiumcodereview.appspot.com/20843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many tests call functions on Layer without having the layer assigned
to a LayerTreeHost, but for functions that in production we require
a LayerTreeHost to be present. Add some DCHECKs in these methods that
a layer_tree_host_ is present, and make one present in the tests.
R=enne
BUG=267574
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/21856010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
if codec is not supported, VideoCodecBridge::Create() can return NULL.
In this case, we should check the return value before calling start().
Review URL: https://chromiumcodereview.appspot.com/21860005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows registry.
The delegate supports two different keys for storing privileged (the shared secret) and unprivileged data (the rest of the fields).
BUG=156182
Review URL: https://chromiumcodereview.appspot.com/21641002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed a typo in an argument list.
BUG=
Review URL: https://chromiumcodereview.appspot.com/21700002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The plugins shares the Cocoa class namespace with the Chrome's helper binary hosting the plugin. Because the client plugin is compiled into Chrome, Chrome's instance of NSBundleLocator is passed to NSBundle::bundleForClass, breaking resource loading as the result.
This CL switches to using dladdr() to get the bundle path instead of NSBUndle::bundleForClass.
BUG=267239
Review URL: https://chromiumcodereview.appspot.com/21976003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new strings based on UI reviews.
<bla.exe> may change your Chrome settings.
<bla.exe> may change how your searches work in Chrome.
Currently, downloads that are flagged as POTENTIALLY_UNWANTED by the
safe browsing service will be displayed with the latter
warning. However both messages are being added for translation.
TBR=estade@chromium.org
BUG=262983
Review URL: https://chromiumcodereview.appspot.com/21449002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create one field trial that's intended to rule over all omnibox field
trials. They allows our trials to run correlated. For example, suppose
we have two trials A (with 50-50 groups a1 and a2) and B (with 50-50
groups b1 b2). Currently this yields four conditions users can be in
25% a1-b1, 25% a1-b2, 25% a2-b1, 25% a2-b2.
This would be great, but what if we want to compare a1-b1 and a1-b2 and
a2-b1 but think a2-b2 makes no sense. There's no way to do it with the
current independent field trial framework.
This change creates one field trial that supposed to include all omnibox
field trials that we want to run.
This change converts the SearchHistory field trial to this bundled
field trial.
Obviously, this trials-can-be-dependent property isn't useful until we
add more experiments to this bundled field trial. I'll do that in
another changelist.
This change also gives this new bundled trial the ability to condition
certain experiment on page context. In particular, depending on what
the user is viewing when using the omnibox, the different experiments
can be active. For example, an omnibox on the new tab page can have
different experiments than the omnibox on an arbitrary web page.
Tested using my own variations server with an appropriate config
with various experiment params.
BUG=264062,264065,263823
Review URL: https://chromiumcodereview.appspot.com/20777006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most critically, we need to ignore the congestion window when we're sending
a CHLO. Such packets are notable as they are the only packets send with null
encryption (other than perhaps ACKs, which are generally not restricted anyway).
BUG=266647
Review URL: https://chromiumcodereview.appspot.com/21714002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We can't use this in the PPAPI proxy.
This is a partial revert of https://src.chromium.org/viewvc/chrome?revision=211271
TBR=brettw@chromium.org
BUG=194304
Review URL: https://chromiumcodereview.appspot.com/21988002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Ran cros locally with no --identity specified
Review URL: https://chromiumcodereview.appspot.com/21919002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Review the activity logging (post refactoring) with other authors, and
commit a few fixes to the logging:
- Simplify the DOM action types (merge XHR into ACCESS)
- Fix incognito handling for DOM actions
- Add a few extra comments regarding API logging
BUG=253368, 267025
Review URL: https://chromiumcodereview.appspot.com/21653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sievers@chromium.org, apatrick@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/21914005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=rkc@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/21900002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are two places where we use lists in our REST API - the return of the List API (/hosts), and the tokenUrlPatterns list for each host.
Both places that handle those fields currently assume that an empty list will be returned explicitly as a 0-length array ([]) when in practice the fields are simply undefined. This CL fixes both places to deal with an undefined field correctly.
BUG=267293
Review URL: https://chromiumcodereview.appspot.com/21703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's broken and results in 404 Not Found or 500 Server Error in some
cases (for example,
https://chromiumcodereview.appspot.com/19763008/#ps8001 (patchset 4
resulted in 404 and later patchsets resulted in 500)
and https://chromiumcodereview.appspot.com/18857002/ (500 Server Error) ).
R=kalman@chromium.org
BUG=234022
NOTRY=TRUE
Review URL: https://chromiumcodereview.appspot.com/21523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use this list of RequestProcessGL to drive GL in case when GL
is not allowed.
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/21159005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SyncSourceInfo was a struct that contained a GetUpdatesSource and a
ModelTypeInvalidationMap. Both of these types are in the process of
being deprecated. The SyncSourceInfo itself was used only for debugging
(about:sync), tests (mostly sync_scheduler_unittest.cc) and maintaining
compatibility with some old function signatures.
Removing the SyncSourceInfo allow us to remove dependencies on
ModelTypeInvalidationMap, which is a step towards enabling invalidation
"trickles" support.
BUG=233437
Review URL: https://chromiumcodereview.appspot.com/19982002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=223667
TEST=None.
Review URL: https://chromiumcodereview.appspot.com/21684002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a framework to detect cases when a developer forgets to instrument API calls. Since all our code should execute in instrumented callbacks, 'tasks' check that we are in an instrumented callback at qualifying entrypoints.
Adding missing instrumentations.
BUG=164227
Review URL: https://chromiumcodereview.appspot.com/21661003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Base: FileEnumerator should not follow reparse points.
>
> Following reparse points by default is dangerous because it can easily result
> in infinite loops.
>
> BUG=260360
> TEST=base_unittests
>
> Review URL: https://chromiumcodereview.appspot.com/20610004
TBR=rvargas@chromium.org
Review URL: https://codereview.chromium.org/21898008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep the |visibile_| arg in InProcessViewRenderer for now since it's
only used in devtools.
For RestoreState, we used to wait until the view is visible
before loading, but now need to explicitly call Load after
restore.
Note the DCHECK in InProcessViewRenderer::DrawGL is intentionally
left there to avoid conflict with another CL. Will clean up later.
BUG=250594
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/19540025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=258185
Review URL: https://chromiumcodereview.appspot.com/18804006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
quic_received_packet_manager*.*
TBR=rch@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/21972004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was deriving from contents scaling layer, but as it calculates its
own contents scale on the compositor thread, it's just a confusing
no-op.
R=danakj@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/21951003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=267572
TEST=none
Review URL: https://chromiumcodereview.appspot.com/21944007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AudioBufferTest no longer leaks memory, so remove the suppressions.
BUG=251827
Review URL: https://chromiumcodereview.appspot.com/21938004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Host config was previously passed through stdin by specifying
--host-config=/dev/stdin . But the host process wasn't aware that the
config is read from stdin - it still watched /dev/stdin, which leads
to wrong behaviour when OS is upgraded (watch notification is fired
for /dev/stdin).
2. Previous the daemon script would erase content of the host config
when host exits with the error code indicating that the config is
invalid. There is no reason to do that anymore. Cleanup that code
so the config is erased only when the host is delete from the
directory (crbug.com/179416).
BUG=264910
R=lambroslambrou@chromium.org
Review URL: https://codereview.chromium.org/20776003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/21880005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is legacy code that should have gone away with the offline page
update in crbug.com/170517. As it stands right now, the CSS is broken,
so we never show this option under any condition. Moreover, this code
is also wrong since we now have more than 1 mobile activation flow and
this only works for Verizon 3G.
BUG=none
TEST=offline page should look the same as before
Review URL: https://chromiumcodereview.appspot.com/21806007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need this after all.
TBR=dmichael@chromium.org
BUG=194304
Review URL: https://chromiumcodereview.appspot.com/21990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In early M30 we deprecated this API and are planning on removing
the calling end in the update engine. This CL removes the browser-side
stubs/callbacks and any trace of them left in the code.
BUG=chromium:221850
TEST=try + build
Review URL: https://chromiumcodereview.appspot.com/21015010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Oops.
R=danakj@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/21891004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215430 0039d316-1c4b-4281-b951-d872f2087c98
|