| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the menu could anchor outside an ancestor view.
See before/after pics at http://crbug.com/330496
BUG=330496
TEST=Keyboard-triggered context menus (via the Menu key or Shift+F10) show in reasonable locations.
R=sky@chromium.org
Review URL: https://codereview.chromium.org/179053002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added back double-tap click delay UMA stat tracking that was removed in
https://codereview.chromium.org/82693007
BUG=
Review URL: https://codereview.chromium.org/176973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is not something a typical user should ever see, but assists developers in debugging.
BUG=none
Review URL: https://codereview.chromium.org/178743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=345882
Review URL: https://codereview.chromium.org/175593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL fixes a feature breakage on Chrome OS which happens by
crrev.com/244251 accidentally.
Chrome for Chrome OS should be linked with alsa even if cras is enabled.
This is because Web MIDI implementation for Chrome OS depends on alsa.
Also this changes add trace events for each platform implementation.
This is also useful to know which implementation is enabled in the build.
BUG=335865
Review URL: https://codereview.chromium.org/171603014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the icon does not work well with light themes, this CL specifies
Holo Dark theme for the app, instead of the device default.
Also removed text next to icons, as the keyboard icon does not have
sufficient padding. The icon is descriptive enough in itself, and the
text appears anyway if you long-press the buttons.
BUG=338773
NOTRY=true
Review URL: https://codereview.chromium.org/180703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=306025
NOTRY=true
Review URL: https://codereview.chromium.org/180803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mode.
The flag and the hotkey is only temporary since there is no other way to test the TouchView functionality at this time.
BUG=337563
TEST=visual
Review URL: https://codereview.chromium.org/179063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an event arrives at a WindowEventDispatcher targeted to a Window not owned by
it, then stop the event-dispatch at this dispatcher, and dispatch the event from
the correct dispatcher instead.
To explain with an example:
* There are two WindowEventDispatchers A and B.
* Window W is in A.
* An event comes in (from the native platform) to dispatcher B.
* The event is targeted at W (because it has capture, or because it has focus
etc.)
* Instead of dispatching the event to W from B, stop the event-dispatch in B
and dispatch the event to W from A instead.
BUG=346808
R=oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/180173004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add benchmark for tough_pinch_zoom_cases so it can be run on the bots.
BUG=309484
Review URL: https://codereview.chromium.org/177553006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensure that the dll code is referenced, instead of the target
making its own copy.
BUG=329023
Review URL: https://codereview.chromium.org/176873012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The fix in r252114 can fail since each call is not independent.
To fix this, run each test formerly within
PepperContentSettingsTest.PluginSpecialCases as a separate test.
BUG=306702
Review URL: https://codereview.chromium.org/174643002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/171233006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/179813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChannelProxy currently offers messages to all member MessageFilters. It turns
out that a good portion of the most common message types will never be filtered,
making the O(N) filter walk an unnecessary affair. To prevent this, allow
MessageFilters to indicate which (if any) subset of message classes they may
filter, allowing the ChannelProxy to refine the list of filters that are offered
a particular message. This saves ~35us per message received on the browser IO
thread for a typical Android device.
Relanding with a few more guards for MessageFilter removal, access and message
class subscription.
BUG=340881
TBR=asargent@chromium.org
Review URL: https://codereview.chromium.org/142923005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dsinclair
Review URL: https://codereview.chromium.org/181033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a supervised user is created, it can happen that the syncing
hasn't started already, so we need to store the keys locally such
that they will be merged with managed user data when starting sync.
BUG=244472
Review URL: https://codereview.chromium.org/177813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow the usage of third party policy management
software in enteprise deployments of Chrome on Windows.
BUG=259236
Review URL: https://codereview.chromium.org/152633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/178363006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=338338
Review URL: https://codereview.chromium.org/152133010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connected.
No need to stop dev-tools explicitly before destroying webview widget in root window.
Since the dev-tools will be stopped while destroying webview.
BUG=345588
TEST=Follow steps as the CL says, and no crash.
Review URL: https://codereview.chromium.org/174783004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/177843007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resubmit of: https://codereview.chromium.org/165223003/
TBR=mpcomplete@chromium.org
TBR=joaodasilva@chromium.org
---------------------------------
Add a Restore() method to ValueStore and make StorageAPI use it
Take the first steps in preventing the Storage from getting and staying
corrupted. This lets us Restore() a ValueStore when it's corrputed, and tries to
do so in the StorageAPI calls.
This also refactors so that there's a Local and Sync SettingsBackend - this has
the added advantage of meaning we don't decorate the Local stores with Sync
behavior.
BUG=261623
Review URL: https://codereview.chromium.org/176963006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the short interval between the uploading (= clearing dirty bit) and
metadata feed fetching (= updating metadata cache like file size), the
download operation reported wrong file size. This CL fixes the case.
BUG=346228
Review URL: https://codereview.chromium.org/179453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before, on Chrome OS, JS Entry objects were holding the same DOMFileSystem
object, and they were attached to the same big root. All of the mount points
were first-level directories. This looks like a Linux approach.
However, for better isolation a different approach has been suggested. To have
a separate DOMFileSystem object per every volume on Chrome OS. So, Downloads
and Drive files would be separate, and the filesystem's root would be one of
the mount points.
What is more, restricting DOMFileSystem objects to a mount point is not enough.
In case of `archive` and `removable`, we have two level mount points. The first
level is either `archive` or `removable`. Either of them contains mounted
volumes - archives or removable devices.
This patch restricts DOMFileSystem objects (and thereof Entry objects) to the
inner most mount point. For example: /Downloads, /drive, /archive/archive-1,
/archive/archive-2, /removable/disk-1, /removable/disk-2.
Having this solution it is impossible to access the grand root containing all
of the outer mount points, which was until now restricted in JavaScript. Also,
it doesn't allow to get an Entry for /archive and /removable, which was also
filtered out in JS layer.
Moreover, and what is the most important, this approach allows to map a C++
VolumeInfo to a DOMFileSystem object with 1:1 relationship.
To achieve that, the OpenFileSystem has been renamed to ResolveURL, since this
method has been always used to Resolving a file system URL. Opening the file
system was a side effect. This allowed to unify the code paths for sandboxed
and non-sandboxed file systems. Before, for non-sandboxed file systems, the
root url (and the name) were manually computed using a deprecated utility
function fileapi::GetFileSystemInfoForChromeOS(), which is removed in this
patch.
The drawback of this change was that the root_url and the fs name resolution
became asynchonous. The reason for that is that sandboxed file systems may
perform operations on different threads, therefore they have to be
asynchronous. To simplify migration a utility function has been introduced to
convert FileDefinition vectors to EntryDefinition vectors.
Finally, this change will allow simplifying Files app volumes logic
significantly. The JS VolumeInfo will match C++ VolumeInfo 1:1, as well as
either VolumeInfo will match a DOMFileSystem object 1:1. As a result, we will
be able to remove special cases for inner mount points (for archives and
removables). Another advantage is simple way to pass names of JS-provided file
systems.
The permission management is currently simplified, but the next step will be to
grant permissions per inner-most mount point, which will clean up security
policy comparing to the former implementation.
TBR=phajdan.jr@chromium.org
BUG=318021
TEST=Tested manually.
Review URL: https://codereview.chromium.org/162963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://settings/languages and at login screen.
BUG=345604
Test=None
Review URL: https://codereview.chromium.org/177093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move LoadDirectoryIfNeeded from ChangeListLoader to FileSystem
Remove ChangeListLoader::LoadForTesting().
Add DirectoryLoaderTest.
BUG=335469
TEST=unit_tests
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/179323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables command+<key> shortcuts on Mac. It doesn't disable the ctrl+<key>
versions but I don't think it's problematic to enable both.
BUG=303491
R=koz@chromium.org
TBR=arv@chromium.org
Review URL: https://codereview.chromium.org/180683002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bungeman@chromium.org
TEST=waterfall
BUG=346842
Review URL: https://codereview.chromium.org/180243008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added an OWNERS file to chromeos/dbus and set per-file owners for the Bluetooth
and NFC client code.
BUG=none
R=keybuk@chromium.org, satorux@chromium.org
Review URL: https://codereview.chromium.org/178143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We can now fold it into EnqueueMessage().
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/177003011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For details on the fix see:
https://code.google.com/p/trace-viewer/source/detail?r=1165
R=enne@chromium.org
Review URL: https://codereview.chromium.org/179063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=haraken
Review URL: https://codereview.chromium.org/180943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dsinclair
NOTRY=True
Review URL: https://codereview.chromium.org/180763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, ProxyMessagePipeEndpoint::EnqueueMessage() gets a message with
dispatchers already attached. It will be up to the Channel to force them into a
serialized state.
Note that this is a bit less optimal (especially right now), since we means we
have to create duplicate dispatchers even for things that will be serialized
immediately. However, this structure makes things more flexible, since we can
defer serialization if we want (e.g., we don't want Channel to send everything
to RawChannel in a serialized state immediately).
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/177073015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dsinclair@chromium.org
BUG=346993
Review URL: https://codereview.chromium.org/180243007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=339253
R=tapted@chromium.org
TBR=jochen@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/179993008
Patch from Thanh-Mai Diep <tmdiep@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke 100+ WebKit layout tests.
> Move ContextProvider binding to inside GpuVideoAcceleratorFactory
>
> Bind the ContextProvider inside the GpuVideoAcceleratorFactory itself, so the
> Factory can decide appropriately what to do in casae of binding failure.
>
> Also: replace references to RendererGpuVideoAcceleratorFactory with references
> to its superclass, GpuVideoAcceleratorFactory.
>
> BUG=345424
> TEST=local build on desktop Linux
> R=avi@chromium.org, fischman@chromium.org
>
> Review URL: https://codereview.chromium.org/171773014
TBR=sheu@google.com
Review URL: https://codereview.chromium.org/176923018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=yzshen@chromium.org
Review URL: https://codereview.chromium.org/180423003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=haraken@chromium.org
TBR=haraken
Review URL: https://codereview.chromium.org/180843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/177243013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The split is currently not perfect, but idea is all compositor
interactions dealing with hardware mode is moved to HardwareRenderer.
Should be a no-op change in general.
Also removed the BrowserViewRenderer <- InProcessViewRenderer
inheritance since it is not needed anymore.
Removed other random cruft too.
BUG=344087
NOTRY=true
Review URL: https://codereview.chromium.org/176543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method was previously moved into SourceState, and there is no
longer any definition of this method in ChunkDemuxer. This change
removes the obsolete method's declaration from ChunkDemuxer.
R=acolwell@chromium.org
TEST=All media_unittests pass locally on Linux.
Review URL: https://codereview.chromium.org/179043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the binary potion of:
https://codereview.chromium.org/173423002/
BUG=344442
R=oshima@chromium.org
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/180733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
canonicalizable and has an explicit scheme.
This fixes a DCHECK.
BUG=286457
TEST=See bug comments 0 and 7 for testcases; none should DCHECK.
R=mpearson@chromium.org
Review URL: https://codereview.chromium.org/178673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253310 0039d316-1c4b-4281-b951-d872f2087c98
|