| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
live beside the code they're testing.
-moved some of the logic about renaming intermediate files into content as the tests depended on them
-made the DownloadManagerDelegate interface have empty default implementations. Darin convinced me that it's better to have delegate interfaces in the API have emptry interfaces, for tests and to make life easier for embedders.
-removed the DownloadItemModel checks; these really were duplicating the DownloadItem::GetState call
-removed the MockDownloadManagerDelegate class since it wasn't being used anymore
-removed DownloadManagerDelegate::OnResponseCompleted since it wasn't called anymore
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9224006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=bradchen@google.com,grunell@chromium.org,jennyz@chromium.org
BUG=111317,105580,111922
TEST=waterfall.sh
Review URL: https://chromiumcodereview.appspot.com/9301008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111926
TEST=
Review URL: https://chromiumcodereview.appspot.com/9264036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jkummerow@chromium.org
BUG=chromium:110463
Review URL: http://codereview.chromium.org/9159029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
introducing static initializers.
Member variables can stay TLS::Slots and their behavior doesn't change.
Static instances use TLS::StaticSlot instead.
Kind of like http://codereview.chromium.org/8491043 but for TLS.
BUG=none
TEST=none
TBR=agl
Review URL: https://chromiumcodereview.appspot.com/9297010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
click-on-preview for default action.
BUG=chromium-os:23582,chromium-os:17507,chromium-os:25022
TEST=See bugs.
Review URL: https://chromiumcodereview.appspot.com/9284019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:24984
TEST=manual
Review URL: http://codereview.chromium.org/9302001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9235078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Correctly deal with fullscreen.
. wires up grid size and sets it appropriately.
. maxes windows open initially maximized if necessary.
I've also wired up showing a menu when you right click on the desktop
that lets you configure things. This is only temporary, but I figure
worthwhile to play with various settings.
BUG=111285
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9295024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are repeatedly timing out. They often run in the 42-43 second range on XP debug, which is too close to the global 45 second timeout.
BUG=111914
TEST=none
TBR=rdsmith
Review URL: https://chromiumcodereview.appspot.com/9264035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:102139
TEST=
Review URL: http://codereview.chromium.org/9298029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97465
TEST=try to remote debug a page without a title
Review URL: http://codereview.chromium.org/9232077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119670 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:24883
TEST=manual
Review URL: http://codereview.chromium.org/9225057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23978
TEST=
Review URL: https://chromiumcodereview.appspot.com/9298009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL causes the GpuPixelBrowserTests to load libllvmpipe.so (if it is available) and fallback to standard libGL.so otherwise. This is so that we can do a smoke test of the GPU accelerated display path on the Aura dbg bot on the Chromium waterfall.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9298022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
For real this time (typo in previous attempt r119458).
BUG=111636
TEST=none
TBR=toyoshim
Review URL: https://chromiumcodereview.appspot.com/9104007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=thakis
BUG=110270
Review URL: https://chromiumcodereview.appspot.com/9121076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the UI would make decision based on the enabled() state of
controls, indicating that the control is not relevant for the currently
chosen configuration. This doesn't work for policy-configured networks,
since the control might just be locked down, in which case it is
relevant, but disabled.
BUG=chromium-os:23124
TEST=Configure ONC networks through policy, observe that the connection dialogs show the configured values even though disabled.
Review URL: https://chromiumcodereview.appspot.com/9296009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101338
TEST=Look at a bookmark folder in the bookmarks bar on Mac. Title should be visually aligned with the icon.
Review URL: https://chromiumcodereview.appspot.com/9016013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111841
TEST=content_unittests
Review URL: https://chromiumcodereview.appspot.com/9298055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preparing for using HarfBuzz-ng as a secondary text shaper on mac.
CoreText doesn't support OpenType features so we need additional
text shaper to support -webkit-font-feature-settings property.
I don't think this version is ready for transition on Linux because I
could see considerable performance regressions when I run cycler tests.
BUG=68551
TEST=None. This CL doesn't change build process for now.
Review URL: https://chromiumcodereview.appspot.com/9223010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CHROMEOS suffix is a temporary workaround. It'll be deleted when corresponding item action is implemented in CrOS. Also "<if>" statement will be added.
BUG=chromium-os:24883
TEST=manual
Review URL: http://codereview.chromium.org/9121072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old bubble:
---------------------------------------------
There's a new safer version of Google Chrome
[x] Try it out
[ ] Uninstall
[OK] [Don't Bug Me]
{Why am I seeing this?}
---------------------------------------------
Newer, more compact bubble:
---------------------------------------------
There's a new safer version of Google Chrome
[x] Try it out
[ ] Don't Bug Me
[OK]
---------------------------------------------
BUG=None
TEST=This should be tested like any other attrition toast experiment, but needs a special branded build.
Review URL: https://chromiumcodereview.appspot.com/9129021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:25457
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/9223042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=108740
TEST=Manul: see bug description.
Review URL: https://chromiumcodereview.appspot.com/9113080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111112
TEST=Run chrome with '--enable-shadow-dom' and enter 'new WebKitShadowRoot(document.createElement('div'))' in Console.
Review URL: http://codereview.chromium.org/9285014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
burn_controller.cc
BUG=chromium-os:16553
TEST=chrome://imageburner works
Review URL: https://chromiumcodereview.appspot.com/9235028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=leviw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9232076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
X509CertificateTest.PublicKeyHashes.
This change disables a couple of tests that fails due ot an expired certificate.
TBR=agl
BUG=111893
TEST=make the "XP Tests (dbg)(2)" bot green.
Review URL: https://chromiumcodereview.appspot.com/9225052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=kalman@chromium.org
Review URL: http://codereview.chromium.org/9295042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
specifically listed as web accessible.
BUG=109686
Review URL: http://codereview.chromium.org/9152022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also removes a few unused calls.
BUG=None
TEST=compiles, tests pass
Review URL: http://codereview.chromium.org/9297041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ninja build just works after clang rolls.
TBR=mark
Review URL: https://chromiumcodereview.appspot.com/9225048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- exposing the constants as properties on chrome.storage.{sync,local}, and
- adding a new API call "getBytesInUse".
BUG=110980, 110583, 110663
TEST=unit_tests --gtest_filter=ExtensionSettingsFrontendTest*, browser_tests --gtest_filter=ExtensionSetting*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119598
Review URL: http://codereview.chromium.org/9284013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=111316
TEST=run out/Debug/content_shell --dump-render-tree file://$(pwd)/third_party/WebKit/LayoutTests/fast/html/section-element.html > section-element-actual.txt - should be the same as section-element-expected.txt
Review URL: http://codereview.chromium.org/9289045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97532,111806,111208 (maybe?)
TEST=none
TBR=hans
Review URL: http://codereview.chromium.org/9297028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran "git status"
TBR=mallinath
Review URL: http://codereview.chromium.org/9298047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the first wave of links from
https://www.google.com/support/chrome paths to
https://support.google.com/chrome. We also don't need
locale parameters on these links.
BUG=111556
TEST=manual
TBR=dhollowa
Review URL: http://codereview.chromium.org/9234077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So that this doesn't crash, make ExtensionSettingDataTypeController call
InitExtensions on Profile (like ExtensionDataTypeController already does).
BUG=
TEST=sync_integration_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119615
Review URL: http://codereview.chromium.org/9121068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unrecoverable error.
This change would make the PSS wait for the retry sync and also inform the wizard that we are waiting.
The wizard then can decide to wait and show a screen for that. However currently the wizard would throw the unrecoverable error.
BUG=100076, 111676
TEST=try bots and manual.
Review URL: http://codereview.chromium.org/9235040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=105401
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118790
Review URL: http://codereview.chromium.org/9277001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 119620 - Revert r119614 "Make auto-enrollment client retry after auto-update if the modulus limit was in..."
I initially thought r119615 was the culprit but I was wrong. Only r119614 could
now possibly make ExtensionApiTest.ProcessesVsTaskManager time out reliably on
windows.
TBR=joaodasilva@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/9295039
TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9296037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r119624 I made mistake when copying code from sync_setup_hander.cc to sync_setup_handler2.cc. This caused settings to crash on open.
BUG=
TEST=
TBR=dbeam@chromium.org,jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9298045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
e.g. when switching top-level pages. Fixes a JS exception when clicking
on a nav-item with an overlay open.
BUG=111286
TEST=none
R=csilv
Review URL: https://chromiumcodereview.appspot.com/9121067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The show/hide code for otr lists requires a specific structure.
BUG=110528
TEST=none
R=csilv
Review URL: https://chromiumcodereview.appspot.com/9121066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119626 0039d316-1c4b-4281-b951-d872f2087c98
|