summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Modifies the event handler for WM_APPCOMMAND events to return TRUE if the ↵mma.public@gmail.com2011-05-032-3/+3
| | | | | | | | | | | | | event was handled. Previously it returned 0 causing the event to bubble up to the DefWndProc, which would synthesize keypresses appropriate for the event and cause it to effectively be handled twice. This should fix double handling of events for people with devices that generate WM_APPCOMMAND messages (tablets, Logitech mice, etc...) BUG=19672 TEST=See various cases reported on bug Review URL: http://codereview.chromium.org/6901076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83975 0039d316-1c4b-4281-b951-d872f2087c98
* Add a check to test an assumption about view NULLness.ben@chromium.org2011-05-031-0/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6902210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83974 0039d316-1c4b-4281-b951-d872f2087c98
* Rename suid python binary used for enabling testing interface on chromeosnirnimesh@chromium.org2011-05-032-4/+3
| | | | | | | | | | | s/python/suid-python/ so that we don't end unintentionally using suid python. BUG= TEST= Review URL: http://codereview.chromium.org/6910031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83973 0039d316-1c4b-4281-b951-d872f2087c98
* Use single command line flag for all pure Views situations,saintlou@chromium.org2011-05-038-12/+43
| | | | | | | | | | | rather than enabling case by case BUG=none TEST=none Review URL: http://codereview.chromium.org/6911018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83972 0039d316-1c4b-4281-b951-d872f2087c98
* Should be isEqual: not isEqualTo:thomasvl@chromium.org2011-05-031-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6912042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83971 0039d316-1c4b-4281-b951-d872f2087c98
* Rename View::GetCursor and simplify arguments.msw@chromium.org2011-05-0322-125/+96
| | | | | | | | | | | | | | | | Simplify RootView::UpdateCursor with MouseEvent ctor support. Restore pre-r83123 WigetWin::SetCursor(NULL) behavior. Cleanup (function ordering, OVERRIDEs, unnecessary "views::"). This originates from changes and comments of Patch Set 3 at: http://codereview.chromium.org/6893096/ BUG=72040 TEST=Mouse cursors. Review URL: http://codereview.chromium.org/6910032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83970 0039d316-1c4b-4281-b951-d872f2087c98
* Add tracking for scorer creation failures.noelutz@google.com2011-05-031-2/+32
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/6910008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83969 0039d316-1c4b-4281-b951-d872f2087c98
* File Manager: Add production artrginda@chromium.org2011-05-0317-33/+69
| | | | | | | | | BUG=chromium-os:14844 TEST=manual testing in chromeos-chrome on linux Review URL: http://codereview.chromium.org/6912041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83967 0039d316-1c4b-4281-b951-d872f2087c98
* Move favicon from TabContents to TabContentsWrapper.avi@chromium.org2011-05-0330-192/+233
| | | | | | | | | BUG=71097 TEST=no visible change Review URL: http://codereview.chromium.org/6909027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83966 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto notification test.sunandt@google.com2011-05-031-0/+1
| | | | | | | | BUG=80510 TEST=notifications.NotificationsTest.testKillNotificationProcess Review URL: http://codereview.chromium.org/6909036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83965 0039d316-1c4b-4281-b951-d872f2087c98
* Update set printer function to be local-only to avoid permission issues.arthurhsu@chromium.org2011-05-031-10/+35
| | | | | | | | | | BUG=80760 TEST=none Review URL: http://codereview.chromium.org/6893149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83964 0039d316-1c4b-4281-b951-d872f2087c98
* Print Preview: Fixing print header overflow issues.dpapad@chromium.org2011-05-031-6/+2
| | | | | | | | | | | | | | | When the "Print Preview" header is long (happens in many languages) it is wrapped on the next line without hiding any of the print options anymore (since it no longer absolutely positioned). BUG=NONE TEST=launch using LANGUAGE=el_GR ./out/Release/chrome --enable-print-preview, no printing options should be hidden by the header. Review URL: http://codereview.chromium.org/6912033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83963 0039d316-1c4b-4281-b951-d872f2087c98
* Use a MessageLoopProxy to forward PAC script errors to the network delegatejochen@chromium.org2011-05-034-18/+31
| | | | | | | | | | | | This fixes a race/crash when the worker threads of the multi threaded proxy resolver outlive the io thread BUG=none TEST=none Review URL: http://codereview.chromium.org/6914026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83962 0039d316-1c4b-4281-b951-d872f2087c98
* Use a MessageLoopProxy rather than manual Lock + MessageLoop* in ↵eroman@chromium.org2011-05-031-71/+32
| | | | | | | | | | | | HostResolverImpl::Job. This is strictly a re-factor, however it should also enable r83641 to be re-landed without tickling the shutdown bug described in 81136. BUG=81136 Review URL: http://codereview.chromium.org/6910015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83961 0039d316-1c4b-4281-b951-d872f2087c98
* PreviewableContentsController::hidePreview works with prerender on OSX.cbentzel@chromium.org2011-05-032-5/+6
| | | | | | | | | | BUG=81268 TEST=go to prerender page with UseTabContents set to true, make sure debug build does not crash when swapping in prerendered page. Review URL: http://codereview.chromium.org/6909029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83953 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove the chrome.gyp dependency in ui.gyp.thestig@chromium.org2011-05-031-1/+0
| | | | | | | | BUG=77100 TEST=none Review URL: http://codereview.chromium.org/6904150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83952 0039d316-1c4b-4281-b951-d872f2087c98
* Add HostObserverInterface and decouple HeartbeatSender and ChromotingHost.sergeyu@chromium.org2011-05-0311-112/+155
| | | | | | | | | BUG=None TEST=Everything still works. Review URL: http://codereview.chromium.org/6911024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83951 0039d316-1c4b-4281-b951-d872f2087c98
* Safebrowsing download UMA results shouldn't be set when safebrowsing is ↵mattm@chromium.org2011-05-032-12/+21
| | | | | | | | | | | disabled. BUG=80620 TEST=see bug Review URL: http://codereview.chromium.org/6901145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83950 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto tests for DevTools.sunandt@google.com2011-05-031-0/+2
| | | | | | | | BUG=81440 TEST=enterprise.EnterpriseTest.testDisableDevTools, shortcuts.ShortcutsTest.testDeveloperToolsShortcut, shortcuts.ShortcutsTest.testJavaScriptConsoleShortcut Review URL: http://codereview.chromium.org/6912035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83949 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate wstring from base/utf_offset_string_conversions.h, ↵pkasting@chromium.org2011-05-0321-1445/+974
| | | | | | | | | | net/base/escape.h, and net/base/net_util.h, and reduce the API surfaces in various places slightly where possible. BUG=23581 TEST=none Review URL: http://codereview.chromium.org/6898026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83948 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Fix up the stack for bug 58074 now that DOMUI->WebUI.jhawkins@chromium.org2011-05-031-3/+3
| | | | | | | | | | BUG=58074 TEST=none TBR=thestig Review URL: http://codereview.chromium.org/6907025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83947 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the security infobar for --enable-nacl, which is in about:flagsdmichael@chromium.org2011-05-031-3/+0
| | | | | | | | | BUG=77590 TEST=start chrome with '--enable-nacl', or turn it on in about:flags and restart. Confirm that _no_ infobar appears saying 'You are using an unsupported command-line flag: --enable-nacl. Stability and security will suffer.'. Review URL: http://codereview.chromium.org/6913029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83945 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a bunch of browser tests as flaky on Mac.jam@chromium.org2011-05-033-1/+28
| | | | | | | | BUG=81451 TBR=mark Review URL: http://codereview.chromium.org/6907024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83944 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Remove a duplicate suppression.thestig@chromium.org2011-05-031-33/+15
| | | | | | Review URL: http://codereview.chromium.org/6915010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83943 0039d316-1c4b-4281-b951-d872f2087c98
* Partial revert of 82061 so we keep the initial unbounded range request.scherkus@chromium.org2011-05-033-13/+60
| | | | | | | | | | | Also loosened restrictions for detecting servers that support range requests. Sending "Accept-Ranges: bytes" is optional so if we attempt a range request and a server replies correctly we should assume that it does indeed support range requests. BUG=80187 TEST=test_shell_tests --gtest_filter=Buffered* Review URL: http://codereview.chromium.org/6889019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83942 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling pyauto tests that use flash.sunandt@google.com2011-05-031-0/+10
| | | | | | | | BUG=81396 TEST=NONE Review URL: http://codereview.chromium.org/6911032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83941 0039d316-1c4b-4281-b951-d872f2087c98
* Modify screen reader detection to use the AXEnhancedUserInterface attribute ↵dtseng@chromium.org2011-05-034-18/+26
| | | | | | | | | | set on AXApplication when VoiceOver's turned on. This gives us the ability to turn on ax even after a render widget host has started. BUG=none TEST=manually with VoiceOver. Launch Chrome, VoiceOver, windows, tabs (permuted order) and verify that ax is on. This sometimes required navigation to a different page or efreshing the current page. Review URL: http://codereview.chromium.org/6909013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83940 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for the chrome frame test failures seen on the per user builder IE8 ↵ananta@chromium.org2011-05-031-1/+2
| | | | | | | | | | | | | | | | builder. The tests fail because of a missing navigation manager instance on the IE thread. This object is registered when the bho is dynamically added to the WebBrowser object by the chrome frame helper. On the IE8 builder we attempt to register the bho multiple times as we expect the return variant type from the IWebBrowser2::GetProperty call to be VT_DISPATCH. It returns VT_UNKNOWN. This causes the navigation manager to be unregistered in the destructor of the variant object thus leading to the failure. BUG=80820 TEST=ChromeFrame tests should pass on the IE8 windows 7 per user builder. Review URL: http://codereview.chromium.org/6907014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83939 0039d316-1c4b-4281-b951-d872f2087c98
* Instrument Pepper IPCs with the tracing stuffpiman@google.com2011-05-032-0/+14
| | | | | | | | | BUG=none TEST=about:gpu with Pepper Flash Review URL: http://codereview.chromium.org/6913019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83938 0039d316-1c4b-4281-b951-d872f2087c98
* Automation hook FillAutofillProfile now waits for the web data service to be ↵dennisjeffrey@chromium.org2011-05-033-18/+151
| | | | | | | | | | | | | | | | | | updated. The FillAutofillProfile automation hook sets autofill profiles and credit cards in the web data service. Previously, the hook did not wait for the web data service to be updated before returning, even though updating to the web data service is asynchronous. This is now fixed. This change improves -- but does not yet completely solve -- pyauto autofill flakiness. BUG=80336 TEST=None Review URL: http://codereview.chromium.org/6880281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83937 0039d316-1c4b-4281-b951-d872f2087c98
* Have the phishing classifier guard against extra PageCaptured calls.bryner@chromium.org2011-05-032-18/+100
| | | | | | | | | | | Currently, the classifier assumes that any PageCaptured call will be preceded by a DidCommitProvisionalLoad. This seems to not always be the case, and is causing occasional crashes. Cancel classification in this situation so that we don't swap out the page text from under the term feature extractor. BUG=80325 TEST=PhishingClassifierDelegateTest.DuplicatePageCapture Review URL: http://codereview.chromium.org/6902171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83936 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to pass information to Pepper Flash from the command-line (e.g., ↵viettrungluu@chromium.org2011-05-0316-3/+148
| | | | | | | | | | | | | | for debugging). This also adds a |ProxyModule| singleton object to the Pepper proxy, which we may eventually use for communicating directly with the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/6910007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83932 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress layout test failure due to r83848hclam@chromium.org2011-05-031-0/+3
| | | | | | | | TBR=morrita BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83931 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the network_delegate_ and fix stylejochen@chromium.org2011-05-033-3/+7
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6912029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83930 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Add a suppression for IPC::SyncChannel::ReceivedSyncMsgQueue.jhawkins@chromium.org2011-05-031-0/+18
| | | | | | | | | | BUG=81441 TEST=none TBR=thestig Review URL: http://codereview.chromium.org/6911033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83927 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Suppress a leak in IPC::ChannelProxy::Context.jhawkins@chromium.org2011-05-031-0/+16
| | | | | | | | | | BUG=81438 TEST=none TBR=thestig Review URL: http://codereview.chromium.org/6914023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83926 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to extension webRequest API.mpcomplete@chromium.org2011-05-0310-82/+239
| | | | | | | | | | | | | | | - onBeforeSendHeaders respects extraInfoSpec. - request headers are now an array of {name, value} objects instead of a flat string. - onBeforeRequest is sent after redirects now. This allows extensions to intercept redirects and cancel/redirect them elsewhere. BUG=60101 TEST=no Review URL: http://codereview.chromium.org/6912008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83925 0039d316-1c4b-4281-b951-d872f2087c98
* Allow gpu ringbuffer to wrap around.jbauman@chromium.org2011-05-032-13/+27
| | | | | | | | | | | The ringbuffer was unwilling to wrap around unless the last block filled it up completely - otherwise it would have to wait until it was completely empty. Fix this in the most straightforward way by filling the ringbuffer up with a padding block if necessary. BUG=80946 TEST= Review URL: http://codereview.chromium.org/6901138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83924 0039d316-1c4b-4281-b951-d872f2087c98
* Add method IsPassphraseRequiredForDecryption to ProfileSyncServicersimha@chromium.org2011-05-035-34/+31
| | | | | | | | | | | | | | | | | | ProfileSyncService needs to know in multiple places whether a passphrase is required for decryption. Right now, the logic involves checking passphrase_required_reason_ against a couple of states. This patch refactors this logic into the methods: IsPassphraseRequired IsPassphraseRequiredForDecryption BUG=81313, 81341, 81018 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6910012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83923 0039d316-1c4b-4281-b951-d872f2087c98
* Add Indic and Thai fonts to install-build-deps.sh.tony@chromium.org2011-05-031-1/+2
| | | | | | | | | | | This will make it easier for people to run webkit layout tests on Lucid. BUG=80681 Review URL: http://codereview.chromium.org/6912031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83922 0039d316-1c4b-4281-b951-d872f2087c98
* Only enable vsync if a compositing window manager is not in use. Thiskbr@chromium.org2011-05-031-1/+20
| | | | | | | | | | | | | | restores performance and latency on Linux to previous levels before the bug fix enabling vsync for the first time. Tested manually both with and without Compiz enabled and verified the detection logic works. BUG=81333 TEST=none Review URL: http://codereview.chromium.org/6911030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83921 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83730: Revert 83687 - Remove ExtensionMsg_UpdatePageActions.mpcomplete@chromium.org2011-05-036-62/+13
| | | | | | | | | | | | Trying again. The previous checkin broke browser tests, but I could not reproduce either on the trybot or locally. BUG=70516 TEST=no Review URL: http://codereview.chromium.org/6907007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83920 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Hook up Create New Profile menu itemsail@chromium.org2011-05-031-3/+11
| | | | | | | | | | | | This change hooks up the Create New Profile menu item to the backend action. BUG=None TEST=Ran and verified that the menu item works correctly. Review URL: http://codereview.chromium.org/6909008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83919 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang buildjam@chromium.org2011-05-032-5/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83918 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83822 - Update Flash and Reader metadata.cevans@chromium.org2011-05-031-12/+2
| | | | | | | | | | BUG=81293 Review URL: http://codereview.chromium.org/6909006 TBR=cevans@chromium.org Review URL: http://codereview.chromium.org/6909032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83917 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 83826 - Oops... forgot the typo fix in the previous patch.cevans@chromium.org2011-05-031-4/+4
| | | | | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6879130 TBR=cevans@chromium.org Review URL: http://codereview.chromium.org/6910027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83916 0039d316-1c4b-4281-b951-d872f2087c98
* Added some more OWNERS in places where we don't have any.estade@chromium.org2011-05-033-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6911015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83914 0039d316-1c4b-4281-b951-d872f2087c98
* Add v8 as a dependency for unit_testsvangelis@chromium.org2011-05-031-0/+1
| | | | | | | | | | | BUG=Compile fails on Windows shared lib builder. TEST=Compile succeeds on Windows shared lib builder. Original CL by asanka. http://codereview.chromium.org/6911029 Review URL: http://codereview.chromium.org/6911029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83913 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/3451017/sky@chromium.org2011-05-0336-73/+73
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6910024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83912 0039d316-1c4b-4281-b951-d872f2087c98
* Start moving content_settings code out of content code.jam@chromium.org2011-05-0326-230/+280
| | | | | | | BUG=76793 Review URL: http://codereview.chromium.org/6913013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83910 0039d316-1c4b-4281-b951-d872f2087c98