| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Use immediate assignment when reading from external
external programs, in this case nacl_config.py.
Review URL: https://codereview.chromium.org/133603005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now UI code of input methods -- candidate window, infolist
window, and mode indicator -- is pure views and doesn't need
to be in c/b.
I chose ash/ime because they are ash-specific UI, but I'm
okay to move to another place. Please tell me if you have
other ideas.
BUG=325813
R=oshima@chromium.org, komatsu@chromium.org
TEST=no functional changes, compile succeeds
Review URL: https://codereview.chromium.org/132083009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=331749
NOTRY=true
Review URL: https://codereview.chromium.org/131483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements nacl_irt_fdio for non-sfi mode.
Note that getdents is currently not supported because there is no good way to
implement it in a sane manner. Now it always returns ENOSYS.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.
TEST=Make sure lseek and fstat refer to lseek64 and __fxstat64.
Review URL: https://codereview.chromium.org/131133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
swarming/client DEPS roll introduced two new third parties, httplib2 and
oauth2client.
BUG=334668
R=vadimsh@chromium.org
TBR=phajdan.jr@chromium.org, vadimsh@chromium.org
Review URL: https://codereview.chromium.org/134313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is timing out on most platforms.
TBR=rtenneti@chromium.org,dominikg@chromium.org
NOTRY=True
BUG=
Review URL: https://codereview.chromium.org/138143007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The simple cache tests don't need to cleanup cache dir
after dooming the entire cache; in fact it causes races with
index creation.
R=pasko@chromium.org, clamy@chromium.org
BUG=333527
Review URL: https://codereview.chromium.org/136563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
$ git log 3ae9e6e792..8cacaaaffc --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2014-01-14 vadimsh Remove dependency on oauth2client.tools module.
2014-01-14 maruel Fix code duplication between 'remap' and 'run'.
2014-01-13 vadimsh Use file-based storage for OAuth2 credentials if keyring is not available.
2014-01-13 vadimsh Client side support for OAuth2 authentication.
R=vadimsh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/135193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Speeds up running grit on this step from 53s to 40s on my Mac.
BUG=
Review URL: https://codereview.chromium.org/137393007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the STYLE_NATIVE_TEXTBUTTON native style enum.
STYLE_NATIVE_TEXTBUTTON was replaced by STYLE_BUTTON in M29.
See http://crrev.com/194673 for the effective deprecation.
Uses STYLE_BUTTON in client callsites, remove old code.
BUG=155363
TEST=No behavior or appearance changes.
R=sky@chromium.org
TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/137383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add VP8 support to VEA API hardware encode accelerator unittest.
BUG=311540
TEST=run
Review URL: https://codereview.chromium.org/119293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This matches the behavior of all the other CancelRequestsFor*() on
ResourceDispatcherHostImpl.
BUG=324525
R=darin@chromium.org
R=asanka@chromium.org
Review URL: https://codereview.chromium.org/103553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jkummerow@chromium.org
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/137443010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Internally Chrome tracing needs to be turned on for each Chrome process
separately, so this is done asynchronously. This patch makes Tracing.start
complete asynchronously after all processes have acknowledged the start of
tracing.
Without this synchronization telemetry may start running a benchmark
before tracing was fully enabled, leading to missed timeline events.
Depends on https://codereview.chromium.org/134253002/.
BUG=307841
Review URL: https://codereview.chromium.org/134263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, these are used interchangably, as android is the platform where
there is mobile safe browsing (2). But we'd like to be able to build full
safe browsing on android or mobile safe browsing on linux for testing and
development purposes.
The change to chrome_browser.gypi ensures that download_completion_blocker.cc
is built when full safe browsing is enabled, not when OS==android. This class
is called from code that is conditioned by safe_browsing, not OS, and should
be treated the same.
The change to chrome_browser_ui.gypi ensures that libusb is not built on android
no matter what the setting of safe_browsing. This hasn't been built on android
in some time, and in fact fails to compile on android due to missing system
header libudev.h. It doesn't appear to be related to safebrowsing in any
manner, and the exclusion should be by platform, not by this feature.
BUG=
Review URL: https://codereview.chromium.org/133683006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has a few changes rolled into one:
-Several renames to add the "Extension" prefix, since I discovered another
unrelated histogram with a InstallVerifier* name.
-Merges a few UMA_HISTOGRAM_BOOLEAN's with different names into
UMA_HISTOGRAM_ENUMERATION's with the same name.
-Adds one extra histogram to measure count of forced disabled extensions
BUG=332952
Review URL: https://codereview.chromium.org/132373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
worker thread.
BUG=324454
Review URL: https://codereview.chromium.org/130253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium base revision: 244810 / 0cb3b607
Old Skia revision: 13059
New Skia revision: 13077
Control CL: https://codereview.chromium.org/138803003
This CL was created by Skia's roll_deps.py script.
R=reed@google.com
Review URL: https://codereview.chromium.org/138783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The world id -1 is no longer used.
BUG=none
R=dcarney@chromium.org
Review URL: https://codereview.chromium.org/136813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initialization calls were missing, which caused the command line switch
--enable-gpu-service-logging to not show detailed information on GL calls
with their parameters on Android.
BUG=333261
TEST=Ran WebGL conformance tests with the switch enabled.
Review URL: https://codereview.chromium.org/133933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Separate RendererCapabilities and RendererCapabilitiesImpl classes to
separate out capabilities that are not needed on main thread to be
not copied to main thread. This is to prepare for the future when main
and impl RendererCapabilities copies can temporarily get out of sync,
and there are less values to worry about.
BUG=332616
Review URL: https://codereview.chromium.org/133063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It hasn't done anything for a year and a half now.
BUG=none
TEST=no behavior change.
Review URL: https://codereview.chromium.org/131743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
result.
This types will be used to manage discovered media locations.
BUG=161119
Review URL: https://codereview.chromium.org/131223008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=
BUG=
Review URL: https://codereview.chromium.org/138053007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- incorrect uses of zone allocator in V8 (issue 244755)
- races between PostponeInterruptsScope ctor/dtor and v8::internal::StackGuard::RequestInstallCode (issue 290964)
- races in OutOfProcessPPAPITest.FlashFullscreen (issue 327330)
BUG=244755,290964,327330
TBR=yangguo@chromium.org
Review URL: https://codereview.chromium.org/132063007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165040:165090&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/139333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pickled entries might contain inconsistent data and trigger the check in the
network stack.
BUG=334125
R=marja@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/137893006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test for the correct referrer only works by accident. file URLs
shouldn't have referres.
BUG=none
R=bauerb@chromium.org
Review URL: https://codereview.chromium.org/139283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--ash-enable-alternate-caption-button is specified.
When --ash-enable-alternate-caption-button is specified
- phantom windows fade in and expand slightly to the target bounds passed into PhantomWindowController::Show()
- PhantomWindowController::phantom_widget_in_start_root_ is not used
BUG=328930
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/130913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cannot AFAIK be done via passing the length in a custom binding, as base::Value does not support int64 a.k.a. 'long long' types.
The total blob length is going to be used in media_galleries_api.cc to construct the SafeMediaMetadataParser in a followup CL. It appears unused in this patch.
BUG=
Review URL: https://codereview.chromium.org/129823003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The synchronous readback path adds complexity through ui and cc
compositors and will ideally be removed. The screenshots already use a
post task mechanism to save to disk, so making them use the asynchronous
readback path instead is straightforward.
BUG=332167
Review URL: https://codereview.chromium.org/126373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
long.
BUG=326259
NOTRY=true
Review URL: https://codereview.chromium.org/116633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UploadData and UploadFileElementReaderSync were used only by Chrome Frame
BUG=None
TEST=build
R=mmenke@chromium.org
TBR=jam@chromium.org for content/child/resource_dispatcher_unittests.cc
Review URL: https://codereview.chromium.org/131903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=cdn@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/138023006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were hitting this error on some bots:
"Uncaught TypeError: Cannot call method 'addIceCandidate' of null",
source: http://127.0.0.1:50344/webrtc/jsep01_call.js (125)
We're not particularly worried about the shutdown sequence of events,
so I'll just discard message that arrive after disconnecting.
R=perkj@chromium.org
TBR=perkj@chromium.org
BUG=334192
NOTRY=True
Review URL: https://codereview.chromium.org/138043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A backup roll attempt to the revision immediately before
r165040, which had to be reverted due to failing tests. See
https://codereview.chromium.org/138183003/
BUG=none
TBR=tdanderson@chromium.org
Review URL: https://codereview.chromium.org/132853004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium code style says:
"Prefer putting delegate classes in their own header files. Implementors
of the
delegate interface will often be included elsewhere, which will often
cause more
coupling with the header of the main class."
http://www.chromium.org/developers/coding-style - Code formatting
section
BUG=None
R=sky@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/118623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements TYPE_REMOVE_DEFAULT_APP. It also includes a fair bit
of cleanup of AppListSyncableService, which on the one hand I apologize
for, but on the other hand I think the result is more straightforward.
BUG=258758
Review URL: https://codereview.chromium.org/118463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This requires NSS version 3.15 or greater. Since Linux Chrome is using the system NSS it may not work for Linux users unless they have a more recent NSS version. Mac and Windows builds however are not affected by this and it should just work.
BUG=245025
Review URL: https://codereview.chromium.org/115653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=322820
TEST=manual tests on Lumpy
Review URL: https://codereview.chromium.org/105573008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
start cleaning up assumptions.
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/138333006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
render views.
BUG=304341
R=tburkard@chromium.org
Review URL: https://codereview.chromium.org/138613004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This sets use_aura on Windows in all cases (fixes base build).
Passes new argument to gyp link wrapper (GYP revision 1835).
R=sky@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/137993014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This emulates optimize=max from GYP. One difference is that this applies for all build types. The GYP one only applied optimize=max for the Official build. I can't think of why this should be the case, and it seems confusing to have such arbitrary official build differences.
R=bbudge@chromium.org
Review URL: https://codereview.chromium.org/138903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244839 0039d316-1c4b-4281-b951-d872f2087c98
|