summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update the overview for the post-toolstrip world.kathyw@google.com2009-11-046-195/+206
| | | | | | | | | | | | | This CL isn't ready yet (e.g., we need to change the code samples that use toolstrips), but it's a good time to start reviewing it. BUG=26164 TEST=none Review URL: http://codereview.chromium.org/348068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30960 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tab closing animations.pinkerton@chromium.org2009-11-047-96/+376
| | | | | | | | BUG=14919 TEST=tab opening and closing, tab dragging, trying to drag tabs while animating closed, http auth, tab modal sheets, anything involving tabs. Review URL: http://codereview.chromium.org/348061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30959 0039d316-1c4b-4281-b951-d872f2087c98
* Implement undo/redo so they will be properly enabled when the web content ↵pinkerton@chromium.org2009-11-041-0/+8
| | | | | | | | | | has focus. BUG=26112 TEST=per bug. Review URL: http://codereview.chromium.org/355016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30958 0039d316-1c4b-4281-b951-d872f2087c98
* Fix nonsense.mark@chromium.org2009-11-041-1/+1
| | | | | | | | | | Too much cut'n'paste. My eyes must have been closed when I screwed this up. BUG=nope TEST=read Review URL: http://codereview.chromium.org/360008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30957 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative backout of r30849 to determine what impact it has on startup time.avi@chromium.org2009-11-041-5/+1
| | | | | | | TBR=mmentovai git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30956 0039d316-1c4b-4281-b951-d872f2087c98
* EN, mf, DO YOU SPEAK IT?mark@chromium.org2009-11-049-52/+84
| | | | | | | | | | | | | | | | | | | | | | | | No more symbolic links in the .app. Except for the ones that codesign adds. The en_US.lproj directory should not exist, there should be only en.lproj. Formerly, there was a symbolic link from en.lproj to en_US.lproj. BUG=25578, 19165 TEST= - find C.app -name en_US.lproj should return nothing. - find C.app -name en.lproj should show en.lproj in C.app, C F.framework, and C H.app. - find C.app -type l should return nothing, however, on a signed build, it will still show symbolic links for CodeResources. - Say "What" again. Say "What" again. I dare you. I double-dare you. - With English or U.S. English as the top or only choices in the International (10.5) or Language & Text (10.6) system preference pane's Language tab, the localized language should be English. - In this configuration, the Accept-Language header field should be "en-US,en;q=0.8". See http://whatsmyuseragent.com/ and look for HTTP_ACCEPT_LANGUAGE. Review URL: http://codereview.chromium.org/345057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30955 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BlacklistManagerBrowserTest.Basic to be more solid.phajdan.jr@chromium.org2009-11-041-5/+13
| | | | | | | | | | | | | | It turns out it was flaky (was waiting for an event that already happened). When running the message loop to wait for extension loading changes, it was executing BlacklistManager tasks as well. TEST=Covered by browser_tests. BUG=21541 TBR=aa Review URL: http://codereview.chromium.org/361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30954 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: fix categories alignment.pfeldman@chromium.org2009-11-041-0/+4
| | | | | | | TBR: yurys git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30953 0039d316-1c4b-4281-b951-d872f2087c98
* Implement loading blacklists from extensions.phajdan.jr@chromium.org2009-11-0417-90/+294
| | | | | | | | | | | | It doesn't yet work in full-browser scenario, but allows me to write a simple test. TEST=Covered by browser_tests. BUG=21541 Review URL: http://codereview.chromium.org/341050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30952 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in WebSocketThrottle.ukai@chromium.org2009-11-041-1/+3
| | | | | | | | | | TBR=yuzo, tyoshino BUG=none TEST=net_unittests no memory leak in WebSocketThrottleTest Review URL: http://codereview.chromium.org/364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30951 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 234.0 to 235.0chrome-bot@google.com2009-11-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30950 0039d316-1c4b-4281-b951-d872f2087c98
* Implement websocket throttling.ukai@chromium.org2009-11-049-25/+743
| | | | | | | | | | | | | | | | Implement the client-side requirements in the spec. 4.1 Handshake 1. If the user agent already has a Web Socket connection to the remote host (IP address) identified by /host/, even if known by another name, wait until that connection has been established or for that connection to have failed. BUG=none TEST=net_unittests passes Review URL: http://codereview.chromium.org/342052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30949 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for getting the real process id from within the suid sandbox. ↵thestig@chromium.org2009-11-0410-80/+328
| | | | | | | | | | | | | | | | | | The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. Original review: http://codereview.chromium.org/262020 This is try 2 - initialize the sandbox host and zygote for InProcessBrowserTest. TBR=agl BUG=20012, 20714, 23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30948 0039d316-1c4b-4281-b951-d872f2087c98
* Add some more new baselines since we don't yet support the URL in storage ↵jorlow@chromium.org2009-11-044-6/+176
| | | | | | | | | | | events. TEST=none BUG=none Review URL: http://codereview.chromium.org/347007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30947 0039d316-1c4b-4281-b951-d872f2087c98
* Added scale hack to work around Windows font metric issue.akalin@chromium.org2009-11-041-3/+14
| | | | | | | | | BUG=none TESTED=tested sync setup wizard on OS X Review URL: http://codereview.chromium.org/348070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30946 0039d316-1c4b-4281-b951-d872f2087c98
* First half of http://codereview.chromium.org/274014/showjorlow@chromium.org2009-11-0415-92/+152
| | | | | | | | | | | | This fixes storage events in single process mode, fixes a bug due to the glue/webkitclient_impl not being updated when I introduced quota support, introduces a params struct for storage events, and is general cleanup. Submitting this first since the change to add the url param made things bigger than I liked. TBR=darin TEST=none BUG=25427 Review URL: http://codereview.chromium.org/348071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30945 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for broken mini_installer_testcpu@chromium.org2009-11-041-1/+1
| | | | | | | | | | | | | - Definitely broken. Nice to have these tests BUG=none TEST=none TBR=kuchhal Review URL: http://codereview.chromium.org/360002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30944 0039d316-1c4b-4281-b951-d872f2087c98
* Add default implementations for WebViewClient and WebWidgetClientdarin@chromium.org2009-11-047-320/+70
| | | | | | | | | | | | | | | methods. Once these interfaces live upstream, we'll want to allow the addition of new methods w/o requiring the consumer (chrome) to implement the new methods. That'll make webkit merging easier, and it'll also make it possible to use a newer webkit with an older chrome. Obviously, this only works if the methods are not crucial to webkit working properly, but that is generally the case for *Client methods. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/346042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30943 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2009-11-0428-164/+297
| | | | | | | | | | | | | | | Gets find bar animation/clipping to work on views/gtk. The only difference between this and the first version is fixing an include in extension_host that was triggering mac to build views, as well as an extraneous SetSlideDuration I had used for testing. BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/342116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30942 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate mime_util dependency in FrameLoaderClientImpl.darin@chromium.org2009-11-046-22/+100
| | | | | | | | | | | | | | This is a revision of http://codereview.chromium.org/344018 that adds an implementation of WebMimeRegistry for the worker process. We need this to support the dummy WebView created for workers. R=jam BUG=24604 TEST=covered by worker ui tests Review URL: http://codereview.chromium.org/342104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30941 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30938 - Add support for getting the real process id from within the ↵thestig@chromium.org2009-11-049-300/+80
| | | | | | | | | | | | | suid sandbox. The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. BUG=20012,20714,23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/262020 Review URL: http://codereview.chromium.org/359001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30939 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for getting the real process id from within the suid sandbox. ↵thestig@chromium.org2009-11-049-80/+300
| | | | | | | | | | | | The browser processes gets the real process ids, so they look correct in the task manager. When it asks the zygote to reap a process, we use the process ids internal to the sandbox. While we are at it, reap the sandbox process after it clones the zygote and figure out zygote's actual process id. Save the actual process id rather than that of the sandbox. BUG=20012,20714,23072 TEST=Process IDs for renderers should be correct in the task manager and you should be able to use the end process button to kill them. Review URL: http://codereview.chromium.org/262020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30938 0039d316-1c4b-4281-b951-d872f2087c98
* Minor fixes in SocketStream.ukai@chromium.org2009-11-041-2/+8
| | | | | | | | | | | Commented on http://codereview.chromium.org/345025 BUG=none TEST=none Review URL: http://codereview.chromium.org/355022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30937 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind error in SocketStreamDispatcherHostukai@chromium.org2009-11-042-21/+1
| | | | | | | | | BUG=26324 TEST=none Review URL: http://codereview.chromium.org/342113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30936 0039d316-1c4b-4281-b951-d872f2087c98
* Update linux baselines that broke in the win -> win7 movedpranke@google.com2009-11-042-0/+75
| | | | | | | | | R=TBR BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30935 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite of chrome.exe startup codecpu@chromium.org2009-11-048-391/+225
| | | | | | | | | | | | | | | | | | | | | | | A lot of cruft and repeated code has deposited over the years on chrome's initialization code. This CL makes it all much more clear and straightforward. There is no fundamental change of behavior except the order of certain things is different but it should not alter the observed operation. - chrome's and chromium load is fundamentally the same but most of the code was repeated - chrome's way to load the dll was incorrect: using a relative path with LOAD_WITH_ALTERED_SEARCH_PATH - Use of SearchPath() was dangerous and not needed - removed google_update_client.cc and .h - removed bunch of #ifdefs TEST=all convered by UI tests already except [1] BUG=none [1] The only thing I don't see convered by test is the restart dialog ('woa! chrome crashed'). Review URL: http://codereview.chromium.org/345036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30934 0039d316-1c4b-4281-b951-d872f2087c98
* Correct line-endings for recently added files.dglazkov@google.com2009-11-041-45/+45
| | | | | | | | | TBR=yaar TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30933 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily make checkbins.py print debugging information.scherkus@chromium.org2009-11-041-1/+4
| | | | | | | | | TEST=build bots should start spitting out debug info to stdio BUG=25952 TBR=maruel Review URL: http://codereview.chromium.org/342115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30932 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chrome_sandbox to act as a helper program and find the socket with a ↵thestig@chromium.org2009-11-044-4/+168
| | | | | | | | | | given inode number. BUG=none TEST=none Review URL: http://codereview.chromium.org/312003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30931 0039d316-1c4b-4281-b951-d872f2087c98
* Keep track of when file dialogs are destroyed.thestig@chromium.org2009-11-041-14/+23
| | | | | | | | BUG=none TEST=Open two windows, open a file dialog in one, quit the browser in other. There should not be any GTK assertion errors. Review URL: http://codereview.chromium.org/339096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30930 0039d316-1c4b-4281-b951-d872f2087c98
* Check in new Windows 7 baselines, revised Vista baselines.dpranke@google.com2009-11-0491-41/+187
| | | | | | | | | R=ojan@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30929 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing what appears to be a typo. This will unbreak CF's command-linejoi@chromium.org2009-11-041-1/+1
| | | | | | | | | | | whitelisting of this flag. BUG=none TEST=The following command should not assert: chrome\Debug\servers\chrome_launcher.exe --enable-experimental-extension-apis Review URL: http://codereview.chromium.org/353026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30928 0039d316-1c4b-4281-b951-d872f2087c98
* Minor change to scary download UI text for extension install.aa@chromium.org2009-11-041-1/+1
| | | | | | | | | | BUG=19316 TEST=Install an extension. Text in download UI should mention both themes and extensions, not just extensions. Review URL: http://codereview.chromium.org/351032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30927 0039d316-1c4b-4281-b951-d872f2087c98
* Check in new XP baseline as part of correcting Win7, Vista baselines.dpranke@google.com2009-11-043-0/+36
| | | | | | | | | BUG=none TEST=none R=ojan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30926 0039d316-1c4b-4281-b951-d872f2087c98
* Add first class support for user scripts.aa@chromium.org2009-11-0427-101/+676
| | | | | | | | | | | | Original review: http://codereview.chromium.org/340057 TBR=mpcomplete@chromium.org BUG=22103 TEST=Install a user script (such as from userscripts.org). You should get the extension install UI and the script should show up in the extension management UI. It should also work, though some scripts use Firefox-specific APIs and those won't work in Chromium. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30925 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30903 - Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-0427-295/+160
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the windows search path to look in oldest applicable platform dir firstdpranke@google.com2009-11-041-4/+4
| | | | | | | | | | | | (was looking in newest dir before). TEST=none R=ojan@chromium.org BUG=none Review URL: http://codereview.chromium.org/353014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30912 0039d316-1c4b-4281-b951-d872f2087c98
* Flip: FlipSessionPool changes.willchan@chromium.org2009-11-0411-90/+130
| | | | | | | | | | | (1) Move it into the HttpNetworkSession so that HttpNetworkTransaction can access it. This is in anticipation of switching HTTP/HTTPS connections over to FLIP. (2) Add some more functionality to FlipSessionPool, allowing HttpNetworkTransactions to check for the existence of other, reusable FlipSessions. Review URL: http://codereview.chromium.org/348066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30909 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add more sanity checking to help track down a crash.pkasting@chromium.org2009-11-046-19/+46
| | | | | | | | BUG=20511 TEST=none Review URL: http://codereview.chromium.org/342112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30908 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 233.0 to 234.0oritm@chromium.org2009-11-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30907 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add whitespace in an error messageevan@chromium.org2009-11-041-1/+1
| | | | | | This has been bugging me. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30905 0039d316-1c4b-4281-b951-d872f2087c98
* Update valgrind_webkit_tests.sh to use the same version ofdkegel@google.com2009-11-042-2/+156
| | | | | | | | | | | valgrind as valgrind.sh. Add script to locally reproduce the nonleak valgrind errors found recently by the linux valgrind layout bot. Review URL: http://codereview.chromium.org/351017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30904 0039d316-1c4b-4281-b951-d872f2087c98
* Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-0427-160/+295
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98
* Update the FLIP session to use the FlipIOBuffer.mbelshe@google.com2009-11-044-121/+49
| | | | | | | | | | | | | | | | | | | | | | Also removed some of the testing hacks for URL rewriting that are no longer needed. This change removes the 'batching' of frames written to the socket. The reason for doing this is because I'm going to need to start notifying to the upper layer as progress is made on the writes (e.g. upload notifications). When the frames are batched (potentially from different transactions), it becomes very difficult to know when each write completes. I don't think that batching is necessary, as writes will accummulate in the socket buffer, so this should be a better approach. BUG=none TEST=flip_session_unittest.cc Review URL: http://codereview.chromium.org/342088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30898 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30879.jcampan@chromium.org2009-11-042-11/+5
| | | | | | | | | | | Some devtool tests hang on Windows, one fails on Linux. I need to investigate more. BUG=None TBR=rafael Review URL: http://codereview.chromium.org/348067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30897 0039d316-1c4b-4281-b951-d872f2087c98
* Make gyp build get idl files from only one location.gman@google.com2009-11-042-58/+27
| | | | | | Review URL: http://codereview.chromium.org/346043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30896 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for build.gman@google.com2009-11-041-1/+1
| | | | | | | | | | The if was wrong. If the jscompiler exists we DON'T want the non-compiled files. Review URL: http://codereview.chromium.org/342108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30895 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug introduced during merging.sky@chromium.org2009-11-041-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=rafaelw Review URL: http://codereview.chromium.org/358001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30894 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Enables animations for the infobar. Changes the control flow for ↵rohitrao@chromium.org2009-11-038-230/+458
| | | | | | | | | | | | | | | infobar opening/closing to match Windows more closely. Nib file changes: - Embedded the InfoBarGradientView inside an AnimatableView. - Rebound [controller view] to the AnimatableView and added an infoBarView_ IBOutlet. - Bound the AnimatableView's delegate_ to the InfoBarController. BUG=http://crbug.com/25599 TEST=Infobars should animate in and out, except for during tab switches. Review URL: http://codereview.chromium.org/354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30893 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore to use a normal load rather than preferringsky@chromium.org2009-11-0317-83/+212
| | | | | | | | | | | | the cache. We need to do this else we don't honor page expiration and end up showing stale data for some sites. BUG=21195 TEST=make sure session restore works. Review URL: http://codereview.chromium.org/341043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30892 0039d316-1c4b-4281-b951-d872f2087c98