summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Pixel diffing for fun and profit.finnur@chromium.org2009-03-0322-22/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | 10 more tests taken off the dirty laundry pile. One pixel is shaded slightly differently: fast/backgrounds/repeat/negative-offset-repeat-transformed.html (slight shading in a few letter in the slanted picture) fast/layers/opacity-outline.html one pixel (third table, first cell, top right corner) fast/text/stroking-decorations.html ('a' in 'black' (first two lines) and 'm' in 'complex') fast/transforms/transformed-document-element.html (the 'b' in 'by' and the 's' in 'should') svg/carto.net/combobox.svg (a few pixels in letters in the second tilted sentance (on the right)) svg/W3C-SVG-1.1/metadata-example-01-b.svg (the letters in the address of the letter on the table in the picture) svg/batik/text/textGlyphOrientationHorizontal.svg (the 's' in the word 'is' in the upper right corner) svg/batik/text/textOnPathSpaces.svg (the 'p' in 'sample' 3 right and 3 down) svg/text/text-text-07-t.svg (see the 'h' in 'together') Expectations changed upstream (see diff files) and now we match: fast/js/switch-behaviour.html Review URL: http://codereview.chromium.org/28344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10762 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/apps/result_codes.h to chrome/common/result_codes.hthestig@chromium.org2009-03-0319-31/+22
| | | | | | Review URL: http://codereview.chromium.org/28279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10761 0039d316-1c4b-4281-b951-d872f2087c98
* Register an onmessage handler with the external host binding instead of ↵ananta@chromium.org2009-03-0312-37/+36
| | | | | | | | | | | explicitly passing in a target Javascript function to execute. The onmessage handler is a one argument Javascript function for now. Review URL: http://codereview.chromium.org/28291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10760 0039d316-1c4b-4281-b951-d872f2087c98
* Start stitching GYP-generated files into the Linux build:sgk@google.com2009-03-036-521/+543
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add a GYP=1 command-line variable to use the gyp-generated files (which are generated side-by-side until everything's okay enough to cut over for real). * Rearrange existing *.scons files to match the layout of the gyp-generated ones, so the transition will be easier: * base.scons (the wrapping logic that calls the other *.scons files) => base_sln.scons * base_lib.scons (the library itself) => base.scons (matching the gyp target generation) * gfx/base_gfx.scons => base_gfx.scons (with necessary prepending of "gfx/" to path names) build/SConscript.main fixes: * Use an internal ${_GYP} infix variable to select the right flavor of *.scons file (multiple places) * When building with GYP=1, only load the one component *_sln_gyp.scons file, because gyp has already created it with knowledge of all the right dependent *_gyp.scons files to load. Linux gyp build fixes: * Add -32 to $ASFLAGS for generating a 32-bit libicudata.a from the now-checked in .s. * Add -Wno-unused and -Wno-unused-function to skia. Review URL: http://codereview.chromium.org/28207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10759 0039d316-1c4b-4281-b951-d872f2087c98
* Support DWM switching.ben@chromium.org2009-03-0341-1943/+1375
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This completes the collapsing of window types and browser frames around a single class: views::Window. CustomFrameWindow is removed with this change. The Browser window is represented by a single views::Window subclass: BrowserFrame, which replaces both AeroGlassFrame and OpaqueFrame. NonClientView is now a container of two sibling classes - the Window's ClientView (in the Browser's case, BrowserView), and a NonClientFrameView subclass, which provides the rendering for the non-client portions of the window. These Views are siblings rather than the ClientView a child of the NonClientFrameView because when the DWM is toggled, the ClientView would have to be re-parented. Many Views make the assumption they are only inserted into a View hierarchy once, and so this is problematic. By having the views be siblings, this is avoided. With this in mind, all of the former NonClientViews now become NonClientFrameView subclasses: DefaultNonClientView -> CustomFrameView (non-existent, NonClientView) -> NativeFrameView AeroGlassNonClientView -> GlassBrowserFrameView OpaqueNonClientView -> OpaqueBrowserFrameView The latter two derive from NonClientFrameView via BrowserNonClientFrameView, which adds some extras. I also had to modify the TabRenderer class to know how to drop its cache of tab background images when the theme changes since it uses different ones for Glass and non-Glass. This change also fixes a few non-client flicker issues relating to window non-client activation by using more ScopedRedrawLocks. (Touches info_bubble.cc, window.cc) Bugs fixed: http://crbug.com/153 http://crbug.com/747 http://crbug.com/2371 http://crbug.com/3264 http://crbug.com/8234 Plumbing for http://crbug.com/8247 Design docs: http://dev.chromium.org/developers/design-documents/views-windowing http://dev.chromium.org/developers/design-documents/browser-window Review URL: http://codereview.chromium.org/27317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10757 0039d316-1c4b-4281-b951-d872f2087c98
* Add reliability test data (known crashes).patrick@chromium.org2009-03-031-0/+76
| | | | | | Review URL: http://codereview.chromium.org/28330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10756 0039d316-1c4b-4281-b951-d872f2087c98
* Enable spellcheck_unittest.cc.mark@chromium.org2009-03-033-6/+12
| | | | | | Review URL: http://codereview.chromium.org/28335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10754 0039d316-1c4b-4281-b951-d872f2087c98
* Add some speculative MessageLoop::RunAllPending calls to IPC::SyncChannel ↵jam@chromium.org2009-03-031-6/+17
| | | | | | | | unittest to try to solve intermittent memory leaks in those tests. Review URL: http://codereview.chromium.org/27360 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10753 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the RenderThread:: message leaks from the known leak list.jam@chromium.org2009-03-031-99/+0
| | | | | | Review URL: http://codereview.chromium.org/27359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10752 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash introduced in r10563 where we modified a RenderWidgetHost after it ↵erg@google.com2009-03-032-4/+12
| | | | | | | | had been deallocated. Review URL: http://codereview.chromium.org/27363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExtensionViewTest and reenable it.mpcomplete@google.com2009-03-034-10/+38
| | | | | | | | | Also, normalize extension IDs to lower case when reading them in. GURL lower cases them when used as hostnames, so string comparisons need to be done in lower case to work. Review URL: http://codereview.chromium.org/28331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10750 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage (take 2).darin@chromium.org2009-03-021-0/+1
| | | | | | | | TBR=mark Review URL: http://codereview.chromium.org/28343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage.darin@chromium.org2009-03-023-0/+5
| | | | | | | | TBR=mark Review URL: http://codereview.chromium.org/28342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10748 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup in webkit/glue:darin@chromium.org2009-03-0220-131/+151
| | | | | | | | | | | | | | | - created dom_operations_private.h for things that mention WebCore types that are only needed within webkit/glue. - moved contents of webkit_glue.h to the right locations. - moved FilePath::StringType <-> WebString conversion out of glue_util into webkit_glue since it is part of the public API. - minimized includes in webkit_glue.h R=dglazkov Review URL: http://codereview.chromium.org/27351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10747 0039d316-1c4b-4281-b951-d872f2087c98
* This CL provides new baselines for the following tests (which were fixed insenorblanco@chromium.org2009-03-028-4/+4
| | | | | | | | | | | | upstream WebKit and have now merged down): LayoutTests/svg/custom/js-late-gradient-and-object-creation.svg LayoutTests/svg/custom/js-late-gradient-creation.svg LayoutTests/svg/custom/js-late-pattern-and-object-creation.svg LayoutTests/svg/custom/js-late-pattern-creation.svg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10746 0039d316-1c4b-4281-b951-d872f2087c98
* Proposed change to support resource loading for media files.hclam@chromium.org2009-03-0219-16/+505
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Highlights of changes: - Added methods to disk_cache::Entry: - Entry::PrepareTargetAsExternalFile(int index) Prepare a stream in an entry to use external file for storage. - Entry::GetExternalFile(int index) Get the external file backing the stream in the entry. - Added a property "CacheType type_" to HttpCache, along with setter and getter. There shall be two cache types, COMMON_CACHE and MEDIA_CACHE for distinguishing between different purpose of HttpCache. We have this property to trigger special behavior for caching needs of media files. - Added static methods to ChromeURLRequestContext - ChromeURLRequestContext::CreateOriginalForMedia Create a URLRequestContext for media files for the original profile. - ChromeURLRequestContext::CreateOffTheRecordForMedia Create a URLRequestContext for media files for off the record profile. - Added method to Profile interface. - GetRequestContextForMedia To get the request context for media files from the context. Design decissions: - Enforce writing to external file by calling methods to Entry rather than construct Backend by a different flag. Since we only want a valid and full response to go into an external file rather than redirection response or erroneous response, we should let HttpCache::Transaction to decide when to have an external file for response data. We eliminate a lot of useless external cache files. - Adding the CacheType enum and property to HttpCache, we could allow possible (?) future extensions to HttpCache to handle other different caching needs. And there's no need to add change constructors of HttpCache, but maybe we should add a specific constructor to accomodate a media HttpCache? - Adding Profile::GetRequestContextForMedia() Since we will need to use this new request context in ResourceDispatcherHost, I think the best place to keep it is in the profile. Also we will expose to user that there's a separate cache for media, so it's better to expose it in the Profile level to allow settings to the media cache, e.g. max file size, etc. Review URL: http://codereview.chromium.org/19747 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10745 0039d316-1c4b-4281-b951-d872f2087c98
* Add file that got missing from main checkin.ericroman@google.com2009-03-021-0/+2
| | | | | | | TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/27357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10744 0039d316-1c4b-4281-b951-d872f2087c98
* Improve comments in FieldTrial class.jar@chromium.org2009-03-021-13/+7
| | | | | | | tbr=mbelshe Review URL: http://codereview.chromium.org/28334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10743 0039d316-1c4b-4281-b951-d872f2087c98
* 15 more layout tests taken off the pile from svg/custom.finnur@chromium.org2009-03-0227-30/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Slight shading differences in the outer edge: container-opacity-clip-viewBox-expected.png Mask now working properly: mask-changes-expected.png mask-child-changes-expected.png mask-inside-defs-expected.png visibility-override-mask-expected.png Expectations changed upstream, we now match those changes (see diff files in review folder): pointer-events-path-expected.txt This test is already passing now on the buildbot: pointer-events-text.svg Single pixel difference in the shading in the second 'e' in the word 'see': use-on-disallowed-foreign-object-1-expected.png use-on-disallowed-foreign-object-2-expected.png use-on-disallowed-foreign-object-3-expected.png use-on-disallowed-foreign-object-4-expected.png use-on-disallowed-foreign-object-5-expected.png use-on-disallowed-foreign-object-6-expected.png use-on-non-svg-namespaced-element-expected.png Also moving one test to ignore list (dashboard compatibility mode, not planning to support: svg-disallowed-in-dashboard-object.html Review URL: http://codereview.chromium.org/27350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10742 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing header (breaks on linux).ericroman@google.com2009-03-021-0/+1
| | | | | | | | TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/27356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10741 0039d316-1c4b-4281-b951-d872f2087c98
* Convert encryptor.cc and friends to string16.thestig@chromium.org2009-03-027-55/+68
| | | | | | Review URL: http://codereview.chromium.org/28292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10740 0039d316-1c4b-4281-b951-d872f2087c98
* split up proxy_service into several files (one per class).ericroman@google.com2009-03-0228-456/+677
| | | | | | Review URL: http://codereview.chromium.org/28278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10739 0039d316-1c4b-4281-b951-d872f2087c98
* Merge the latest version of PR_ParseTimeString. Thiswtc@chromium.org2009-03-022-148/+456
| | | | | | | | | | | requires us to bring in two more functions: PR_NormalizeTime and PR_GMTParameters. R=eroman BUG=4387 Review URL: http://codereview.chromium.org/27339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10738 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unittest to match new querystring parsing rules.mbelshe@google.com2009-03-021-3/+3
| | | | | | | | (See also http://codereview.chromium.org/27342) Review URL: http://codereview.chromium.org/28320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10737 0039d316-1c4b-4281-b951-d872f2087c98
* Port SortedDisplayURL, fix up some chrome_font_{gtk,skia} bugs, port ↵estade@chromium.org2009-03-027-53/+80
| | | | | | | | | text_elider_unittest. BUG=8061 Review URL: http://codereview.chromium.org/28285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10736 0039d316-1c4b-4281-b951-d872f2087c98
* Fix order of downloads list (HTH it happened, I don't know).glen@chromium.org2009-03-021-1/+1
| | | | | | | | BUG=8283 Review URL: http://codereview.chromium.org/28328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10735 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the problem that Worker is not treated as active DOM object.jianli@chromium.org2009-03-022-3/+7
| | | | | | Review URL: http://codereview.chromium.org/27295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10734 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pick up disabling overhead accounting.dglazkov@chromium.org2009-03-021-1/+1
| | | | | | | | TBR=darin Review URL: http://codereview.chromium.org/27352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10733 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark and menu drag images by making a halo around them. This makesbrettw@chromium.org2009-03-0224-33/+158
| | | | | | | | | | | | | the ClearType composited on the correct color to fix the semitransparent pixels into 1-bit transparency pixels. Remove some unnecessary header file dependencies on ChromeCanvas I noticed when compiling this patch. BUG=8258 Review URL: http://codereview.chromium.org/27321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10732 0039d316-1c4b-4281-b951-d872f2087c98
* Add js bindings layer for ProxyResolverV8 {"alert()", "dnsResolve()", ↵ericroman@google.com2009-03-027-62/+627
| | | | | | | | | | | "myIpAddress" <-- [partial]}. Also adds a utility function to net_util for turning a addrinfo into an IP address string. BUG=2764 Review URL: http://codereview.chromium.org/31009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10730 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline an SVG layout test. The difference is that we draw two additional ↵sidchat@google.com2009-03-024-8/+7
| | | | | | | | one-pixel-wide black lines, one horizontal and one vertical, which occur on the top and left of the box respectively. This gives the box a 3-D appearance. After reviewing the SVG code, it seems we are doing the right thing; i.e., the code specifies to draw these lines with stroke-width="1" to give the 3-D appearance. I am thinking that in the original mac baseline, these lines are not prominent due to difference in Skia SVG line handling and shading. Review URL: http://codereview.chromium.org/28321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the IPC::SyncChannel leaks with RenderThread in the callstack. This ↵jam@chromium.org2009-03-022-8/+21
| | | | | | | | works by emptying the IPC message loop of its tasks, which frees the SyncContext object. After this is checked in, I'll keep an eye to see if the same thing needs to be done for the SyncChannel tests (they seem to not be generating errors, from looking at the last dozen runs). Review URL: http://codereview.chromium.org/28307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10727 0039d316-1c4b-4281-b951-d872f2087c98
* Add site_instance_unittest.cc to the Posix build.jhawkins@chromium.org2009-03-023-4/+2
| | | | | | Review URL: http://codereview.chromium.org/27299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10726 0039d316-1c4b-4281-b951-d872f2087c98
* Enable focus-change via tabbing on Linux.estade@chromium.org2009-03-027-19/+91
| | | | | | Review URL: http://codereview.chromium.org/28248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10725 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded macros that required WTL includes.maruel@chromium.org2009-03-021-3/+0
| | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/27348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10723 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a slight error in the atl includes. We are using the CRect class from ↵maruel@chromium.org2009-03-021-1/+2
| | | | | | | | | WTL and not from ATL... TBR=deanm Review URL: http://codereview.chromium.org/28326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilations errors introduced by revision 10712.maruel@chromium.org2009-03-025-13/+21
| | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/27347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10721 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the order of files in gyp.dglazkov@google.com2009-03-021-2/+2
| | | | | | | | TBR=mark Review URL: http://codereview.chromium.org/27346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10720 0039d316-1c4b-4281-b951-d872f2087c98
* Re-include ScriptController into the gyp file.dglazkov@google.com2009-03-021-0/+2
| | | | | | | | TBR=mark Review URL: http://codereview.chromium.org/28322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10719 0039d316-1c4b-4281-b951-d872f2087c98
* Add V8WebKitCSSMatrixConstructor to Linux builddglazkov@google.com2009-03-021-0/+1
| | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/27343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10718 0039d316-1c4b-4281-b951-d872f2087c98
* Fix windows build: include the webkit chromium directory intc@google.com2009-03-022-2/+1
| | | | | | | | | | | all of our webkit projects. Glue was missing it, so it didn't compile. TBR=darin Review URL: http://codereview.chromium.org/31019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux tree (move static const definition out of class and into cc file)jar@chromium.org2009-03-022-1/+4
| | | | | | | TBR=mbelshe Review URL: http://codereview.chromium.org/27341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove includes to the newly removed edit_drop_target.h header.deanm@chromium.org2009-03-022-2/+0
| | | | | | Review URL: http://codereview.chromium.org/28319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10715 0039d316-1c4b-4281-b951-d872f2087c98
* Renovate FieldTrial class to better bit with histogram usage.jar@chromium.org2009-03-023-47/+236
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/28226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10714 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up upstreamed V8 bindings, Chromium sidedglazkov@google.com2009-03-0218-2030/+194
| | | | | | | | R=mark Review URL: http://codereview.chromium.org/27336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10713 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the AutocompleteEditView from the cross-platform code.deanm@chromium.org2009-03-0215-2662/+2806
| | | | | | | | | | | | Separate the platform specific AutocompleteEditView from the cross-platform model and controller. This leaves the model/controller in autocomplete_edit.{h,cc}, and moves the view into autocomplete_edit_view.h and autocomplete_edit_view_win.{h,cc}. There is now an abstract interface (AutocompleteEditView) which the model uses to talk to the view. Other views (for example, the LocationBarView) will still talk directly to the AutocompleteEditViewWin, which is the full Chrome view. This change also pulled in the Windows specific edit_drop_target code into autocomplete_edit_view_win.cc. Review URL: http://codereview.chromium.org/27327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the non-Windows builds. This makes makes the Windows code conditional on ↵brettw@chromium.org2009-03-021-0/+16
| | | | | | | | Windows. Review URL: http://codereview.chromium.org/28318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10710 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and uncomment the tests I broke in my transparency patch. Turns outbrettw@chromium.org2009-03-021-6/+4
| | | | | | | | we should only be making opaque the part of the layer that we actually drew to (since the layer opaquifier doesn't know about clip masks). Review URL: http://codereview.chromium.org/28284 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10709 0039d316-1c4b-4281-b951-d872f2087c98
* bulk mac test updatethomasvl@chromium.org2009-03-021-46/+43
| | | | | | | | | | - we had a large pile passing, but expected to fail, fixed. - updated for a few tests that aren't always passing on the bots. w/ these we should be green on the debug bot, but the release bot still sees some random patterns i can't prevent failures w/ yet. Review URL: http://codereview.chromium.org/27338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10708 0039d316-1c4b-4281-b951-d872f2087c98
* Create the PopupView from the EditView, not the PopupModel.deanm@chromium.org2009-03-029-228/+245
| | | | | | | | | | | | | | It is hard to instantiate platform-specifc classes (like the AutocompletePopupView) from cross-platform classes (like the model). This does what makes more sense, create platform specific instances from platform specific code. The AutocompleteEditView now creates the AutocompletePopupView. The AutocompletePopupView now creates the AutocompletePopupModel. This also requires exposing AutocompletePopupViewWin, so that in the future the AutcompletePopupViewWin will be able to be created with an AutocompleteEditViewWin pointer. This sort of reverts some of my previous changes, as is pulls the interface out of autocomplete_popup_view_win.cc and into autocomplete_popup_view_win.h. This is sad but neccessary. This removes the AutocompletePopupView::CreatePopupView factory, and replaces it by directly instantiating the platform-specific view instance. Review URL: http://codereview.chromium.org/28313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10707 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 17:47:05 +0000