summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Create the download folder if it doesn't exist. That is, the actual download ↵thestig@chromium.org2009-09-255-53/+88
| | | | | | | | | | folder, not the default one. BUG=21759 TEST=none Review URL: http://codereview.chromium.org/219017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27266 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: rafaelw,leizerikkay@chromium.org2009-09-251-1/+3
| | | | | | disable a ExtensionApiTest.Toolstrip which is flaky on linux git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27265 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TestOverrideEncoding test. It's been hanging the XP Tests (dbg)(3) ↵thestig@chromium.org2009-09-251-1/+1
| | | | | | | | | | | ui_test all day. BUG=23121 TEST=none TBR=jnd Review URL: http://codereview.chromium.org/252007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27264 0039d316-1c4b-4281-b951-d872f2087c98
* A change to make popups work correctly in the GTK build brokedavemoore@chromium.org2009-09-251-0/+6
| | | | | | | Chrome OS panels...this fixes them. Review URL: http://codereview.chromium.org/242011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27263 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension installation work when the "ask for destinationaa@chromium.org2009-09-251-2/+7
| | | | | | | | | | | of every download" preference is set. BUG=23011 TEST=Set the preference in question, install an extension. You should not get a save as dialog and it should install correctly. Review URL: http://codereview.chromium.org/252005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27262 0039d316-1c4b-4281-b951-d872f2087c98
* Actually run directory validation code on install.aa@chromium.org2009-09-254-3/+18
| | | | | | | | | BUG=23084 TEST=Install extensions attached to referenced bug. You should get an error dialog, not a crash. Review URL: http://codereview.chromium.org/244012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27261 0039d316-1c4b-4281-b951-d872f2087c98
* linux: port some of the download manager unit testevan@chromium.org2009-09-252-28/+137
| | | | | | | | | | | | Mostly lots of #ifdefs tracking platform behaviors. I tried to make the logic correct for Mac, too, but I didn't enable Mac here. BUG=21632 Review URL: http://codereview.chromium.org/220025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27260 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline tests to adjust for changes upstream.dglazkov@chromium.org2009-09-2523-308/+425
| | | | | | | | | | | | | | | http://trac.webkit.org/changeset/48701 (xhr-related changes) http://trac.webkit.org/changeset/48690 (chromium-only test migration) http://trac.webkit.org/changeset/48699 (chromium-only test migration) R=jparent BUG=none TEST=none Review URL: http://codereview.chromium.org/246002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27259 0039d316-1c4b-4281-b951-d872f2087c98
* Make --show-extensions-on-top look exactly, pixel-for-pixelaa@chromium.org2009-09-253-24/+40
| | | | | | | | | | | | | | | identical to the bookmark bar. Used the same semi-transparent image for the button background that the bookmarkbar uses, so that it will work for themes. The upside of this is that we look the same as the bookmark bar. The downside is that we look the same as the bookmark bar (which currently looks pretty bad with some themes). However, with the default theme, I think that the bookmark bar currently looks better than our toolstrips. The UI team should probably create some images that look good with different themes for the bookmark bar, then we can update this again. Review URL: http://codereview.chromium.org/225025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few \r\ns I accidentally added to a comment.jamesr@chromium.org2009-09-251-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/245006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27257 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: stop the window reconfigure debounce timer when a window is closed.mdm@chromium.org2009-09-251-0/+3
| | | | | | | | | BUG=23085 TEST=none Review URL: http://codereview.chromium.org/245010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27256 0039d316-1c4b-4281-b951-d872f2087c98
* Mark destroy-during-npp-new test as flaky.thestig@chromium.org2009-09-251-0/+1
| | | | | | | | | BUG=21841 TEST=none TBR=senorblanco Review URL: http://codereview.chromium.org/246008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27255 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky FTPCacheURLCredentials test.thestig@chromium.org2009-09-251-2/+1
| | | | | | | | | BUG=23108 TEST=none TBR=senorblanco Review URL: http://codereview.chromium.org/243009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27254 0039d316-1c4b-4281-b951-d872f2087c98
* Re-ban chrome:// URLs from being added to history until I can craft a more ↵pkasting@chromium.org2009-09-252-3/+5
| | | | | | | | | | fine-grained solution. BUG=23076 TEST=Hit ctrl-t, then ctrl-h, and verify you didn't just add "New Tab" to your history. Review URL: http://codereview.chromium.org/248005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27253 0039d316-1c4b-4281-b951-d872f2087c98
* Refuse to start if we can't get the user data directory.evan@chromium.org2009-09-252-8/+22
| | | | | | | | | | | The alternative is spewing private user data in random directories. BUG=22277 TEST=chmod -x ~/.config; Chrome should refuse to start Review URL: http://codereview.chromium.org/219043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27252 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add three simple unit tests to the bookmark bar.erg@google.com2009-09-257-14/+122
| | | | | | Review URL: http://codereview.chromium.org/249004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27251 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the new mixed content API callbacks to the tab contents. We'll actuallyabarth@chromium.org2009-09-258-2/+47
| | | | | | | | | | | | use these notifications in a future patch. No behavior change. R=agl Review URL: http://codereview.chromium.org/241004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27249 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix depressed baseline in Omnibox.shess@chromium.org2009-09-251-2/+1
| | | | | | | | | | | | | | A previous change converted AutocompleteTextFieldCell to rely more on -drawingRectForBounds: rather than tweaking the baseline in an ad-hoc fashion in many places. This adds a place I missed. http://crbug.com/23096 TEST=Browse to www.google.com. When putting focus in the page the url should stay at the same spot as when focus is in the Omnibox. Review URL: http://codereview.chromium.org/242010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27248 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: work around browser windows that get stuck maximized by the WM.mdm@chromium.org2009-09-253-2/+17
| | | | | | | | | BUG=22807 TEST=none Review URL: http://codereview.chromium.org/218040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27247 0039d316-1c4b-4281-b951-d872f2087c98
* Add an additional test for dnsDomainIs() to verify that it doesn't simply ↵eroman@chromium.org2009-09-251-2/+3
| | | | | | | | | | | | match any substring. This is working correctly, but since it was failing in WinHTTP we should have a regression test. BUG=18511 Review URL: http://codereview.chromium.org/245008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27246 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: initialize created_theme_provider_ in the other constructor.mattm@chromium.org2009-09-251-0/+1
| | | | | | | | | | CID=6160 BUG=none TEST=none Review URL: http://codereview.chromium.org/252002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27245 0039d316-1c4b-4281-b951-d872f2087c98
* Run the unit tests in 5 chunks instead of just 1.nsylvain@chromium.org2009-09-252-8/+50
| | | | | | | BUG:19833 Review URL: http://codereview.chromium.org/212040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27244 0039d316-1c4b-4281-b951-d872f2087c98
* The shadow drawn by the browser window was being drawn over bydavemoore@chromium.org2009-09-252-9/+13
| | | | | | | the status area view. Review URL: http://codereview.chromium.org/249002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27243 0039d316-1c4b-4281-b951-d872f2087c98
* L10N pass through download item and download shelf.thomasvl@chromium.org2009-09-255-79/+282
| | | | | | | | | | | | | - l10n the menus - l10n the dangerous item buttons - make view auto size for the dangerous item buttons TEST=download shelf item buttons and menus are localized BUG=20529 BUG=20530 Review URL: http://codereview.chromium.org/245009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27242 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old Mac First Run Migration code.jeremy@chromium.org2009-09-253-147/+0
| | | | | | | | | We've gone through 2 dev release cycles so most users should be upgraded by now, removing code. Review URL: http://codereview.chromium.org/244011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27240 0039d316-1c4b-4281-b951-d872f2087c98
* Force garbage collection after running any unit tests that initialize WebViews.jorlow@chromium.org2009-09-252-14/+19
| | | | | | | | | | | | | It's quite possible that we just plain shouldn't allow any unit tests to initialize WebKit for philosophical and theoretical reasons. But this does seem to work, so I guess we should just go this route for now. BUG=22971 TEST=none Review URL: http://codereview.chromium.org/240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27239 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unnecessary vbox from the widget hierarchy.tony@chromium.org2009-09-252-35/+31
| | | | | | | | | | | | | | | | | | | | | Previously, it was: vbox (window_vbox) ..eventbox ..vbox (content_vbox_) ....eventbox ....eventbox ....eventbox ....eventbox I removed content_vbox_ and just put everything into the window vbox. There was no padding, so it's pretty straight forward. Some points for drawing the custom frame border were taken relative to content_vbox_, so those points are adjusted. Review URL: http://codereview.chromium.org/239007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27238 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up external protocol handler to user gestures to prevent malicious ↵estade@chromium.org2009-09-254-1/+26
| | | | | | | | | | | sites from popping up a lot of dialogs (or in the case of whitelisted protocols, launching a lot of programs). BUG=3628 TEST=test.html from crbug.com/21049 Review URL: http://codereview.chromium.org/240002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27237 0039d316-1c4b-4281-b951-d872f2087c98
* Combining suppressions for linux, win and mac into single file (with ↵dimich@google.com2009-09-252-44/+2
| | | | | | | | | | widening of the call stack). BUG=22923, 22932 TEST=Suppressed tests will work again, when fixed. Review URL: http://codereview.chromium.org/235020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27236 0039d316-1c4b-4281-b951-d872f2087c98
* Shortening a recently-added stack prefix for reliability builder a bit, so ↵senorblanco@chromium.org2009-09-251-1/+1
| | | | | | | | | | | | it covers more crashes. BUG=23043 TEST=green is good TBR=maruel Review URL: http://codereview.chromium.org/252003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27235 0039d316-1c4b-4281-b951-d872f2087c98
* posix: fix a bug estade found in the review but I misunderstood his commentevan@chromium.org2009-09-251-1/+1
| | | | | | We still need the "break;" to happen on all platforms. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27234 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "Remove" from download item context menu on linux.thakis@chromium.org2009-09-251-2/+0
| | | | | | | | | BUG=23078 TEST=Download something, open item's context menu. "Remove from list" should no longer be in there. Review URL: http://codereview.chromium.org/246006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27233 0039d316-1c4b-4281-b951-d872f2087c98
* Cut down on flakiness of automated ui tests by changing message ↵estade@chromium.org2009-09-252-66/+32
| | | | | | | | | | | sending/waiting logic. BUG=none TEST=a lot less flaky on linux Review URL: http://codereview.chromium.org/235019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27232 0039d316-1c4b-4281-b951-d872f2087c98
* Invert the new incognito tab Spyman orientation and location for RTL.estade@chromium.org2009-09-251-2/+7
| | | | | | | | | | | Also, make the in-page spy man face the text. Thus he will face the opposite direction of the titlebar spy guy. BUG=22872 BUG=22935 Review URL: http://codereview.chromium.org/238005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27231 0039d316-1c4b-4281-b951-d872f2087c98
* Reenables BookmarkHTMLWriterTest. I couldn't repro a failure on mysky@chromium.org2009-09-251-19/+60
| | | | | | | | | | | | | machine after running the test all night, so I'm reenabling the test and making the output more humany readable so that if it does fail hopefully we can figure out where it's going wrong. BUG=17592 TEST=this is only a test change Review URL: http://codereview.chromium.org/244007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27230 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add ctrl-shift-w to Close Window, which I mistakenly removed long ago.pkasting@chromium.org2009-09-251-0/+1
| | | | | | | | BUG=none TEST=ctrl-shift-w should close your current window. Review URL: http://codereview.chromium.org/231025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27229 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup. Converts Browser from storing a vector of pendingsky@chromium.org2009-09-252-58/+24
| | | | | | | | | | | updates to a map. This simplifies processing and removal. BUG=1209369 TEST=none Review URL: http://codereview.chromium.org/250003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27228 0039d316-1c4b-4281-b951-d872f2087c98
* Use delegates in AutocompleteEditViewMac and do other stuff to get it to buildmark@chromium.org2009-09-252-2/+4
| | | | | | | with the 10.6 SDK. Review URL: http://codereview.chromium.org/244009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27227 0039d316-1c4b-4281-b951-d872f2087c98
* Add a valgrind suppression.thestig@chromium.org2009-09-251-0/+8
| | | | | | | | BUG=22031 TEST=none Review URL: http://codereview.chromium.org/235024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27226 0039d316-1c4b-4281-b951-d872f2087c98
* Committing change for Roger. Silencing turning GetTypeInfo DCHECK into a DLOG.tommi@chromium.org2009-09-251-5/+5
| | | | | | | | | | TEST=none BUG=none TBR=robertshield Review URL: http://codereview.chromium.org/242008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27225 0039d316-1c4b-4281-b951-d872f2087c98
* Dynamically loads d3d9 and d3dx9 dlls on Windows.apatrick@google.com2009-09-257-63/+219
| | | | | | | | | | | It's so chrome.exe does not have to load these dlls even when there's no 3D going on. TEST=none BUG=none Review URL: http://codereview.chromium.org/237004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27224 0039d316-1c4b-4281-b951-d872f2087c98
* GPUProcessor uses NPN_PluginThreadAsyncCall to schedule future command ↵apatrick@google.com2009-09-257-6/+36
| | | | | | | | | | | | | processing instead of Chromium MessageLoop. Now it'll work in other browsers. TEST=none BUG=none Review URL: http://codereview.chromium.org/219041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27223 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. Cleanup related to OOP Profile Importjeremy@chromium.org2009-09-2511-10/+23
| | | | | | | | | * Add PROFILE_IMPORT_PROCESS type to ChildProfileInfo. * Other small bits of cleanup. Review URL: http://codereview.chromium.org/220027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27222 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stale WebKit/WebKit/chromium directory in 27219.maruel@chromium.org2009-09-251-1/+1
| | | | | | | | TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27221 0039d316-1c4b-4281-b951-d872f2087c98
* Comment changes from post-LGTM comments on 219031.shess@chromium.org2009-09-252-2/+2
| | | | | | | | TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/246003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27220 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so that you shouldn't be able to get a big fat bookmarksky@chromium.org2009-09-2515-41/+100
| | | | | | | | | | | | | | | | | | | bar. This happened because when we changed from needing a bookmarkbar/extension-shelf to not needing one we processed the layout change asynchronously, but could paint immediately and painting always checks the current state. I initially made painting/layout stay in sync with regards to whether they thought the bookmark bar should be shown, which also fixes this, but because we process the change async there was still some noticable jank. Instead I've changed processing of the transition from needing bars to not (or vice-versa) to be synchronous. BUG=22165 TEST=see bug Review URL: http://codereview.chromium.org/219034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27218 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Manually reposition Omnibox field editor rather than using focus ↵shess@chromium.org2009-09-256-59/+90
| | | | | | | | | | | | | | | | | machinery. Previously this code abused the Cocoa focus machinery to move the field editor around when needed, which required the code to mess around with delegation to make sure the changes didn't leak out to the core autocomplete code. Unfortunately, it also messes with other features, like undo. This change does the positioning manually, which should let everything just work. TEST=Tab-to-search and keyword hints shouldn't cause the field to break. Review URL: http://codereview.chromium.org/219031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27217 0039d316-1c4b-4281-b951-d872f2087c98
* Adds three new off-by-default columns to the task manager to track WebCore ↵jamesr@chromium.org2009-09-259-1/+202
| | | | | | | | | | | | | caches These values are currently exposed via about:histograms/WebCoreCache. This change allows for users to monitor the cache sizes in real-time broken out by renderer. TEST=Open task manager, right click on chrome, select columns, observe that they update along with browsing. BUG=16221 Review URL: http://codereview.chromium.org/217010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27216 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize file_loop_ and io_loop_ in the constructor.jhawkins@chromium.org2009-09-251-0/+2
| | | | | | | | | CID=1405 BUG=none TEST=none Review URL: http://codereview.chromium.org/245004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27215 0039d316-1c4b-4281-b951-d872f2087c98
* Update test_expecations for some flaky tests.senorblanco@chromium.org2009-09-251-5/+7
| | | | | | | | | | BUG=9798,10475,22014 TEST=green is good TBR=dglazkov Review URL: http://codereview.chromium.org/248002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27214 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 21:27:10 +0000