summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Improve memwatch tool.jar@chromium.org2009-10-312-28/+24
| | | | | | | | | | | | | | I removed a leak of "stack" objects, and made them a little more lightweight by removing an unused member. This change is only part of an option for chrome, that is not currently linked in during any tests. It can only currently be used under XP, so build-bot tests are not currently appropriate. r=mbelshe Review URL: http://codereview.chromium.org/345033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98
* To facilitate apatrick's work on the 3D renderer for Pepper,sehr@google.com2009-10-317-162/+178
| | | | | | | | | | I am splitting out the pepper-specific portions of npapi.h. This is because his code currently relies on a version of npapi.h different from third_party\npapi\bindings. Review URL: http://codereview.chromium.org/343069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30671 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable PosixSessionEnd test.johnnyg@chromium.org2009-10-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30670 0039d316-1c4b-4281-b951-d872f2087c98
* linux: Fix build on Karmicjoel@chromium.org2009-10-311-1/+3
| | | | | | | | | | gcc-4.4 produces the warning "declaration does not declare anything", which becomes an error due to -Werror. BUG=26413 Review URL: http://codereview.chromium.org/343072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30669 0039d316-1c4b-4281-b951-d872f2087c98
* DeferredAutoreleasePool didn't work on Snow Leopard.mark@chromium.org2009-10-314-297/+63
| | | | | | | | | | | | | | | | | | | This is a backout of r30647, but also resurrects the change from http://codereview.chromium.org/341022 to work around the crash that r30647 solved much more elegantly. We can't really leave things broken on 10.6, though. I killed most of a perfectly good Friday evening trying to figure out how to salvage r30647, but the DeferredAutoreleasePool approach seems doomed without making private calls. This makes me really sad. BUG=25857, 26399, 26402 TEST=Does it launch on Snow Leopard now? Does it crash when you close windows? Review URL: http://codereview.chromium.org/339095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30668 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Re-enable omnibox select-all-on-click for Chrome OS builds.derat@chromium.org2009-10-312-0/+101
| | | | | | | | TEST=built chrome-os and non- binaries and made sure they worked as expected Review URL: http://codereview.chromium.org/342069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30667 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 230.0 to 231.0chrome-bot@google.com2009-10-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30666 0039d316-1c4b-4281-b951-d872f2087c98
* Widen an existing suppression a little bittimurrrr@chromium.org2009-10-311-0/+1
| | | | | | | | TBR=dank TEST=media should stop being flaky on TSAN/Mac bot Review URL: http://codereview.chromium.org/344046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add all scripts from afterCompile events when scripts panel is ↵yurys@google.com2009-10-313-7/+79
| | | | | | | | | | shown for the first timeBUG=26312 TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh Review URL: http://codereview.chromium.org/341057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30664 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some histograms that have not provided benefit.jar@chromium.org2009-10-311-28/+0
| | | | | | | | | | I added these to try to look at exit codes in crashes, but we didn't find antyhing surprising. I'm now removing them. r=nsylvain Review URL: http://codereview.chromium.org/343053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30663 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the way the FindBrowserWithProfile/Type methods work.ben@chromium.org2009-10-314-49/+65
| | | | | | | | | | | | | | | | | We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated. This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab. http://crbug.com/17498 TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659 Review URL: http://codereview.chromium.org/330013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30662 0039d316-1c4b-4281-b951-d872f2087c98
* roll back 30659 since it still breaks browser_testsben@chromium.org2009-10-313-34/+37
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30661 0039d316-1c4b-4281-b951-d872f2087c98
* Change notification cmd line enabling to use the new RuntimeEnabledFeatures ↵johnnyg@chromium.org2009-10-3111-17/+28
| | | | | | | | | | | code. BUG=25318 TEST=none Review URL: http://codereview.chromium.org/339093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98
* Update: I removed TYPE_ANY to see if I could fool the builders into letting ↵ben@chromium.org2009-10-313-37/+34
| | | | | | | | | | | | | | | | | | | this pass without crashing in browser_tests. It makes the code uglier, but I want to debug and figure out what's going on. Rework the way the FindBrowserWithProfile/Type methods work. We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab. http://crbug.com/17498 TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531 Review URL: http://codereview.chromium.org/330013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30659 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable PosixSessionEnd test to make sure it's not masking other ↵johnnyg@chromium.org2009-10-311-1/+1
| | | | | | | | | | failures. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30658 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30656.johnnyg@google.com2009-10-313-45/+24
| | | | | | Review URL: http://codereview.chromium.org/342072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30657 0039d316-1c4b-4281-b951-d872f2087c98
* When the user has highlighted something like a URL, in the context menu show ↵pkasting@chromium.org2009-10-313-24/+45
| | | | | | | | | an options to navigate rather than searching. Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me. BUG=1978 TEST=Highlight "google.com" and right-click. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30656 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build by removing some not implemented macros.johnnyg@chromium.org2009-10-312-2/+0
| | | | | | | | | | TBR=atwilson BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30655 0039d316-1c4b-4281-b951-d872f2087c98
* Webkit roll to 50358.johnnyg@chromium.org2009-10-313-1/+5
| | | | | | | | | | BUG=none TEST=none TBR=rolandsteiner Review URL: http://codereview.chromium.org/348030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30653 0039d316-1c4b-4281-b951-d872f2087c98
* Now that the UI layer is accessible cross-platform, coalesce the ↵johnnyg@chromium.org2009-10-305-158/+75
| | | | | | | | | | | DesktopNotificationService layer into one common module. BUG=none TEST=none Review URL: http://codereview.chromium.org/343066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression introduced in fixing 19597. This change effectivelysky@chromium.org2009-10-301-2/+6
| | | | | | | | | | | | | | reverts menu_button to what it was before the fix. This way 19597 is still fixed, and we don't have this crash. I'm working on a regression test for coverage of this, but I don't want to hold up anything with the fix. BUG=26279 TEST=see bug Review URL: http://codereview.chromium.org/344043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30651 0039d316-1c4b-4281-b951-d872f2087c98
* API test for CL http://codereview.chromium.org/347016erikkay@chromium.org2009-10-304-0/+33
| | | | | | | | | | | I'm submitting this as a separate CL so that the binary file lands and that I can get good try server results. TBR=mpcomplete Review URL: http://codereview.chromium.org/339091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30650 0039d316-1c4b-4281-b951-d872f2087c98
* Mark the flaky iframe post test as such.slightlyoff@chromium.org2009-10-301-1/+3
| | | | | | | | | | R=ananta TEST=none BUG=26372 Review URL: http://codereview.chromium.org/348026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30649 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use background images for location bar, instead of faking it.erg@google.com2009-10-301-50/+30
| | | | | | | | | BUG=26258 TEST=Border color of location bar matches the buttons on each side. Review URL: http://codereview.chromium.org/348029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30648 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up our autorelease handling so that we don't create a layered dmaclach@chromium.org2009-10-304-54/+293
| | | | | | | | | | | | | | | | | autorelease pool in our run loop source if there is one already on the stack above us. This allows Cocoa to clean up all the objects at the same time as it expects to do. There may be more "interesting" code that can be removed now that this is in. Initially we were going to implement it by checking the nesting levels of the runloops, but it turns out by the time sendEvent is called at the upper level we are already out of the "CFRunloopRun" call so our nesting count isn't a valid indicator of our state. TEST=1) See bug 25857. 2) Start up. Open 3+ windows. Quit. BUG=25857 Review URL: http://codereview.chromium.org/343024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30647 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed glGetActiveAttrib and glGetUniformLocation to not eagerly checkkbr@google.com2009-10-301-12/+0
| | | | | | | | | | | | | | the incoming index. Callers expect GL errors to be raised for out of range indices. BUG=http://crbug.com/26331 TEST=WebKit/LayoutTests/fast/canvas/webgl/getActiveTest.html (preexisting test; there are two remaining failures which are bugs in the test) Review URL: http://codereview.chromium.org/348027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30646 0039d316-1c4b-4281-b951-d872f2087c98
* Merge themes/default.pak into chrome.pak for Mac and Linux builds.tony@chromium.org2009-10-303-55/+23
| | | | | | | | | | | | | In theory this should result in a slightly faster app startup. I will do a follow up change to merge it on Windows and get rid of the code related to the extra file. BUG=24035 Review URL: http://codereview.chromium.org/344038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98
* Add in bzip2 runtime and development packages.ajwong@chromium.org2009-10-301-4/+4
| | | | | | | | | BUG=22307 TEST=none Review URL: http://codereview.chromium.org/340051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30643 0039d316-1c4b-4281-b951-d872f2087c98
* Show a warning when the history files can't be read correctly.pkasting@chromium.org2009-10-3017-37/+45
| | | | | | | | | | This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages. BUG=25822 TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog. Review URL: http://codereview.chromium.org/342048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30642 0039d316-1c4b-4281-b951-d872f2087c98
* The fix for bug 24248 did not fully bullet-proof the RenderWidgetHostViewWinjcampan@chromium.org2009-10-301-0/+12
| | | | | | | | | | | | | | for messages recieved after the render view host has been NULLed, causing crashers with select drop-downs. BUG=25290 TEST=Make sure select drop-downs work and don't crash the browser. Review URL: http://codereview.chromium.org/348022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix conditional for ffmpegsumo build.ajwong@chromium.org2009-10-301-1/+1
| | | | | | | | | | | ajwong basic math: FAIL. BUG=22307 TEST=Clobber built test shell in release and found sumo built. Review URL: http://codereview.chromium.org/342066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30640 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily make checkbins.py return status 0 until I fix offending binaries.scherkus@chromium.org2009-10-301-1/+2
| | | | | | | | | | BUG=25952 TEST=always exists "successfully" Review URL: http://codereview.chromium.org/343068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30639 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several MAJOR crashers in Chrome+LocalStorage/Extensions. Need to ↵jorlow@chromium.org2009-10-301-0/+1
| | | | | | | | | | | | | explicitly call Stop() in destructor (before the vtable is torn down) since we override CleanUp(). Filed bug to make this impossible in the future: http://code.google.com/p/chromium/issues/detail?id=26365 TEST=DOMStorageTests UI tests don't fail. BUG=25413,25746 Review URL: http://codereview.chromium.org/345028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30638 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist the O3D plugin on the Macstuartmorgan@chromium.org2009-10-301-0/+2
| | | | | | | | | BUG=25068 TEST=Install O3D, open about:plugins; O3D should not be listed. Review URL: http://codereview.chromium.org/341058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30637 0039d316-1c4b-4281-b951-d872f2087c98
* Make --ignore-in-dtor=no the default ThreadSanitizer option.timurrrr@chromium.org2009-10-301-1/+7
| | | | | | | | | | | My local bots (both Linux and Mac) were cycling green with this option all the last week except for one real race (fixed tonight) and two benign reports suppressed recently. This option will help us find more races, especially my beloved ref-counter races. TEST=TSAN bots should remain green Review URL: http://codereview.chromium.org/348020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing line in suppression; move the suppression to the more ↵timurrrr@chromium.org2009-10-301-13/+14
| | | | | | | | | appropriate place. TBR=dank Review URL: http://codereview.chromium.org/344040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we can still navigate to URLs when the History DB can't be loaded.pkasting@chromium.org2009-10-302-4/+19
| | | | | | | | BUG=25822 TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation. Review URL: http://codereview.chromium.org/343051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30633 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TemporaryGlue::popupsAllowed by just having thedarin@chromium.org2009-10-304-18/+2
| | | | | | | | | | | | | | | | corresponding ChromiumBridge method return false. It turns out that NPP is always null in Chrome (due to out-of-process plugins), and as a result, we were always returning false anyways. R=jam BUG=none TEST=none Review URL: http://codereview.chromium.org/346026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30632 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up extension badge text drawing.estade@chromium.org2009-10-3011-54/+90
| | | | | | | | | | | | | | | Fall abck to the system default font if the preferred font isn't available. Also, only create the SkPaint struct once, not on every paint. Also, make some more things const. BUG=25693 TEST=badge still looks good, that crash goes away Review URL: http://codereview.chromium.org/341045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30631 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed style nits.atwilson@chromium.org2009-10-304-12/+13
| | | | | | | | | | | Style fixes to reflect belated review feedback on http://codereview.chromium.org/340036. BUG=26233 TEST=None Review URL: http://codereview.chromium.org/342064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30630 0039d316-1c4b-4281-b951-d872f2087c98
* Show status bubble for links that have keyboard focus. estade@chromium.org2009-10-307-4/+46
| | | | | | | | | | | | | I tried to just piggy-back off of existing chrome client calls (particularly focus()), but that didn't handle blurs. webkit side is here: http://codereview.chromium.org/328034/show BUG=453 original review: http://codereview.chromium.org/337032/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30629 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that NPN_PluginThreadAsyncCall callbacks are not invoked after ↵apatrick@google.com2009-10-307-1/+181
| | | | | | | | | | | NPP_Destroy. TEST=none BUG=none Review URL: http://codereview.chromium.org/338050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30628 0039d316-1c4b-4281-b951-d872f2087c98
* Roll for another gyp make update.mmoss@chromium.org2009-10-301-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/344036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30627 0039d316-1c4b-4281-b951-d872f2087c98
* Use HANDLE_EINTR when calling waitpid.mark@chromium.org2009-10-301-1/+1
| | | | | | | | BUG=arthropod TEST=none Review URL: http://codereview.chromium.org/340046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30625 0039d316-1c4b-4281-b951-d872f2087c98
* Use the original profile to get the sync service when building the app menu.tim@chromium.org2009-10-302-6/+9
| | | | | | | | | | BUG=23993 TEST=Open incognito window. Click the bookmark sync button. Either the signin dialog or the options panel should open. Review URL: http://codereview.chromium.org/350005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30624 0039d316-1c4b-4281-b951-d872f2087c98
* Need to load the permissions lists every time at startup for notifications.johnnyg@chromium.org2009-10-303-12/+8
| | | | | | | | | BUG=26274 TEST=grant notifications permissions and restart browser Review URL: http://codereview.chromium.org/339077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30623 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome_url_data_manager (previously a global) into a Singleton. Thistony@chromium.org2009-10-3012-32/+38
| | | | | | | | | | | | is just cleanup. Take 2 with a fix in sync code. TBR=evanm Review URL: http://codereview.chromium.org/350007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30622 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable ffmpegsumo, and also readd the use_system_ffmpeg flag.ajwong@chromium.org2009-10-301-6/+3
| | | | | | | | | BUG=22307 TEST=built. Review URL: http://codereview.chromium.org/343064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30621 0039d316-1c4b-4281-b951-d872f2087c98
* Improve error message in the extension api docs build script. When the json ↵skerner@chromium.org2009-10-301-3/+13
| | | | | | | | | | | file used to build the html documentation is unreadable or has a syntax error, gives a clear error message. BUG=18717 TEST=Manualy tested a missing input file and a file with a syntax error. Review URL: http://codereview.chromium.org/343052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30620 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented most of HtmlDialogWindowController, which is a Cocoa portakalin@chromium.org2009-10-3010-20/+534
| | | | | | | | | | | | | | | | | | | | of HtmlDialogView. Added TODO to fix inaccurate font height metric for OS X font class (and maybe width). Added the BrowserCommandExecutor protocol so that not just a BrowserWindowController can be the window controller for a ChromeEventProcessingWindow. Added unittests. Also tested manually with the bookmark sync setup wizard dialog. BUG=23073 TEST=added unittests, trybot, and manual testing Review URL: http://codereview.chromium.org/344008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30619 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:40:56 +0000