| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
turned out to be that TabContentsView::GetContainerBounds() was
returning the actual bounds, not the requested bounds, which are not
always the same. We need to return the requested bounds from this
call, otherwise bad things happen.
BUG=31132
TEST=see bug
Review URL: http://codereview.chromium.org/549009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=johnnyg
TEST=none
BUG=23901
Review URL: http://codereview.chromium.org/546014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add Cut/Copy/Paste items to the bookmark bar menu.
Also, removes Remove. This is a Linux only change.
BUG=25640
TEST=manually
Review URL: http://codereview.chromium.org/545015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
been invoked). We need to allow this so that GetBounds works if
CloseNow is invoked but the destructor hasn't yet run.
BUG=31975
TEST=see bug
Review URL: http://codereview.chromium.org/536018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35971 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
loose_values_ vector.
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/536012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/542020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/545014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Browser should pop up status when usb is inserted.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/547009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/550006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27214
TEST=Install Porsche theme. Change the window size. The silhouette of the Porsche should stay the same size (and not be stretche), remain the same absolute distance from the left, and be clipped off (and not shown) when the window is too narrow. Compare the behaviour on Windows.
Review URL: http://codereview.chromium.org/545018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add overloads to bookmark model for string16. Wrap wstring
versions in #if !defined since string16 is just a typedef of
wstring on windows.
TEST=exist
BUG=32013
Review URL: http://codereview.chromium.org/536013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to wrar42 for pointing it out.
BUG=30657
TEST=set nonexistant PATH, run chrome, try to open proxy configuration
Review URL: http://codereview.chromium.org/541014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/545019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=ajwong
TEST=none
BUG=32003
BUG=31998
BUG=31997
Review URL: http://codereview.chromium.org/546011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Consolidate modifier mapping, fix the swapping of option and command, and make sure mouse clicks get all modifiers.
BUG=30141
TEST=Use command keys in Flash 10.0
Review URL: http://codereview.chromium.org/549012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In an earlier checkin I had removed the images from the IB files that used HoverCloseButtons, relying on them to be set programmatically. It seems that this causes a flaky sizing problem when loading from a NIB, which only manifested in the DownloadShelf for some reason.
Also change DownloadShelf.xib so that the close button is a child of the main view, not of the GTMWidthTweaker, which seems to eat redraw messages.
BUG=31785
TEST=Try out the download shelf a few times. You need to quit the whole app a few times to ensure it doesn't come back.
Review URL: http://codereview.chromium.org/540001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/26159
Review URL: http://codereview.chromium.org/545003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the renderer for a snapshot of the page.
BUG=19274
TEST=Manual testing on Mac,Linux,Win
Review URL: http://codereview.chromium.org/502034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26947
TEST=bookmark menu should behave normally but folders should now have icons too.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=31857
TEST=none
Mike Pinkerton recommended I use the cross-platform menu utilities for this; I decided not to do that yet, in this patch, for a few reasons:
(1) I'm in the midst of doing heavy refactoring of the tree/list controller classes in a local branch, so anything I do now would have to get changed a lot in that branch anyway.
(2) The Windows and GTK bookmark managers don't use them, so there's not existing common code to hook into. This means I'd have to write all that code, and presumably retrofit the other platform managers to use it. But we really want to get this patch into the upcoming (tonight?) dev-channel build to avoid user confusion.
I have not added a menu to the nib. I've added code to BookmarkManagerController to create the NSMenu programmatically. I can switch to the cross-platform utilities after my refactoring.
Another note: Yes, there is some duplication of code between the Groups and Tree controller classes. I'm not worrying about this because the Groups controller class is going away completely in my refactoring, so it only has a few more days to live. :-)
Review URL: http://codereview.chromium.org/549010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This leak occurs in an Apple library, so the bug is marked as WontFix, and it
has been reported in radar.
BUG=20459
TEST=Mac Valgrind net_unittests
Review URL: http://codereview.chromium.org/549011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This patch completes http://codereview.chromium.org/503082/show and corresponds with https://bugs.webkit.org/show_bug.cgi?id=32870.
Review URL: http://codereview.chromium.org/505070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/536015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/542015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=johnnyg
TEST=none
BUG=31991
BUG=23490
BUG=10333
Review URL: http://codereview.chromium.org/546010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Augments the loadTimes() API with a new field, "wasFetchedViaSpdy".
BUG=31615
TEST=flip_network_transaction_unittest
Review URL: http://codereview.chromium.org/518039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Animation operations will be done in a subsequent patch.
Corresponds with upstream changes: https://bugs.webkit.org/show_bug.cgi?id=32866
Review URL: http://codereview.chromium.org/503082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31985
TEST=Mac Valgrind UI (3)
Review URL: http://codereview.chromium.org/545013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if they aren't at the beginning of a line. Greasemonkey
allows this.
BUG=31076
TEST=Install http://userscripts.org/scripts/review/29876. The
install dialog should say 'Sans-serif default', not
29876.user.js.
Review URL: http://codereview.chromium.org/545002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=not yet
BUG=none
Review URL: http://codereview.chromium.org/545001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when trying to unload a half-crashed extension.
TEST=none
BUG=30405
Review URL: http://codereview.chromium.org/523163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add debugging code to get more info about further issues I couldn't reproduce
and fix yet.
TEST=none
BUG=19607
Review URL: http://codereview.chromium.org/541004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RenderViewHost for the TabContents of a DraggedGtkTab was changing,
and the dragged tab was using the backing store associated with the invalidated
RenderViewHost.
BUG=22731
TEST=See issue description
Patch from Garret Kelly <gdk@chromium.org>
Review URL: http://codereview.chromium.org/550002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This partially solves the issue in 30721, as it makes sure that
there is a Chrome message loop for the SSL socket adapter on
OS X/Linux. However, although it has stopped crashing, gaia
authentication still times out.
Renamed GaiaAuth::WorkerThread to GaiaAuth::WorkerTask and cleaned
it up.
BUG=30721
TEST=manual
Review URL: http://codereview.chromium.org/542003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
'YOU HAVE x FLAKY TESTS' as a test name.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- -[NSTableView selectRow:byExtendingSelection:] was deprecated in 10.3 and
is superseded by -[NSTableView selectRowIndexes:byExtendingSelection:].
- -[BookmarkGroupsController tableView:shouldEditTableColumn:row:] must be
declared in an @interface if it is to be called.
- In BookmarksOutlineView, -[NSOutlineView delegate]'s
id<NSOutlineViewDelegate> must be cast to BookmarkTreeController* before
using as a BookmarkTreeController*.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Refactored CompactLocationBar to Host/View to use DropdownBarHost/View.
* Changed the logic to show/hide. Per cole's request, losing focus now hides the location bar.
Following features are not implemented yet.
* Window cripping while animating.
* Adjust location when toolbar is shown (it's always under tab)
* clipping autocomplete dropdown.
Timer code is no longer used right now, but is left intentionally as we may put it back.
BUG=None
TEST=None
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35674
Review URL: http://codereview.chromium.org/525018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/547005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updating test_expectations while i take a look at it.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/548005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/519009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids retaining navigation history relating to the incognito window.
I piggy-back off of the dns prefetcher's OffTheRecordObserver to do this. In the future I hope to have a separate host resolver for off the record mode, so this won't be necessary.
BUG=24629
Review URL: http://codereview.chromium.org/523076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation. This verb is supported
in the Chrome network stack.
Added a urlrequest test for the HTTP PUT verb and corresponding support in the HTTP test server.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=31629
Bug=31629
Test=Covered by net tests.
Review URL: http://codereview.chromium.org/538012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
All are pretty obvious rebaselines.
TBR=hamaji
BUG=31146
TEST=none
Review URL: http://codereview.chromium.org/543011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none (no code change)
Review URL: http://codereview.chromium.org/524074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
infobar has been shown to the user. autofill.enabled is true if the user has accepted the autofill confirmation infobar.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/541001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
item for "common missteps" (was in the wrong section).
BUG=31655
TEST=None
Review URL: http://codereview.chromium.org/541011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=20337
TEST=NetUtil.GetSuggestedFilename
Patch from Garret Kelly <gdk@chromium.org>.
Review URL: http://codereview.chromium.org/536005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to the loose_values_ vector.
TBR=jschuh@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=timurrrr,dank
Review URL: http://codereview.chromium.org/547004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35912 0039d316-1c4b-4281-b951-d872f2087c98
|