| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
two pieces of information to the StartDragging IPC:
1. Whether the drag was started by a touch event or mouse event
2. The location of drag start. This information is needed for chromeos and was
currently being read from the platform. But that is not possible (also not
correct) for touch based drag/drop. So we pass this information from the
renderer.
BUG=114755
Review URL: https://chromiumcodereview.appspot.com/11369102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=159726
TEST=ran chromeos_unittests with valgrind
Review URL: https://chromiumcodereview.appspot.com/11369113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This switches back to using if (m_resource) in pushPropertiesTo() since
it may be called before setNeedsDisplay(). Also, switch to
checking if resourceId == 0 instead of backingResourceIsDeleted() since
that asserts it's only called on the impl thread.
Review URL: https://chromiumcodereview.appspot.com/11377017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=129187
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11369111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also sets up a fixture for further testing of DevTools on packaged
apps.
R=koz@chromium.org
BUG=153235
TEST=browser_tests --gtest_filter=PlatformAppDevToolsBrowserTest.*
Review URL: https://chromiumcodereview.appspot.com/11358110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server side
The left nav bar would jostle because it was being processed client side with
JS. Now, it is stored as JSON, and there is minimal client side JS processing.
BUG=144291
Review URL: https://chromiumcodereview.appspot.com/11185020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AddUploadedFile was doing completely different things based on the value of |upload_mode|.
upload_mode==UPLOAD_EXISTING_FILE case was only used by OnUpdatedFileUploaded(), now the code used to handle this case is merged to OnUpdatedFileUploaded().
AddUploadedFile and UpdateEntryData's argument callback type changed from base::Closure to FileOperationCallback.
These methods no longer allow null callbacks to be passed as their arguments.
BUG=159368
TEST=unit_tests --gtest_filter="Drive*" and download files to Drive directory (both overwriting case and not-overwriting case).
Review URL: https://chromiumcodereview.appspot.com/11361030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=137569
Review URL: https://codereview.chromium.org/11361125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove tracking of the historical maximum, since it wasn't used.
Also move the ifdef-heavy const function out of the header and into
the source file.
BUG=134750
Review URL: https://chromiumcodereview.appspot.com/11366082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11341021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=137569,159801
Review URL: https://codereview.chromium.org/11275185
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11369098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Subtle bug. Previously, it wouldn't escape properly and would do a splice on
an indexOf without a value in the array. indexOf() returns -1 on not found, and
splicing with -1 removes the last element. This fixes it.
Review URL: https://chromiumcodereview.appspot.com/11366126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=157748
TEST=Apps should not show up in omnibox results but should still show up in app list search.
R=pkasting@chromium.org,mihaip@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/11363064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=128346
Review URL: https://chromiumcodereview.appspot.com/11377007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dalecurtis@chromium.org
BUG=157793
TEST=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11366125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before initializing window_ member variable by calling CreateBrowserWindow().
CreateBrowserWindow() calls Windows API CreateWindowEx() and it dispatches WM_NCACTIVATE.
It seems some tools, such as RocketDoc(http://rocketdock.com/) and Matrox PowrDesk(http://www.matrox.com/graphics/en/products/multi_display_software/), are involved this symptom.
BUG=159146
Review URL: https://chromiumcodereview.appspot.com/11361091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11368116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some Thai input requires surrounding text feature.
This patch implement full-spec surrounding text feature for ibus.
BUG=158111
TEST=Ran ui_unittests and manually done on lumpy.
Review URL: https://chromiumcodereview.appspot.com/11275148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is 2nd try of http://codereview.chromium.org/11366012/
- Introudced ibus namespace for IBusPanelService which collisions original ibus's class name.
BUG=158264
TEST=ran chromeos_unittests, unit_tests
Review URL: https://chromiumcodereview.appspot.com/11365104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
having an entropy source.
This can be removed after we're done investigating this logging issue.
BUG=None
TEST=No user visible changes.
Review URL: https://chromiumcodereview.appspot.com/11358124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome doesn't support plugins on Android, so we shouldn't monitor the plugins
directory for any new ones that appear.
BUG=159063
Review URL: https://chromiumcodereview.appspot.com/11364106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/11368111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can be NULL (when menu is run from status tray). I'm going to TBR this
since its just NULL checks.
BUG=159717
TEST=none
R=ben@chromium.org
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11361135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The intention for this class is to provide up-to-date state information about the network for the majority of the network related UI. It should also serve as a foundation for classes monitoring the state of the active network.
This code is not designed to provide detailed information about specific network service or device properties, not should it provide the ability to set (configure) those properties.
BUG=154072
Review URL: https://chromiumcodereview.appspot.com/11192024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=159543
Review URL: https://chromiumcodereview.appspot.com/11293112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=109215
Review URL: https://chromiumcodereview.appspot.com/11366102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously Opus and Speex decoders didn't validate number of frames in
the incoming packets, so there was a potential buffer overflow when
there are enough frames in a packet to cause integer overflow.
BUG=159553,159229
Review URL: https://chromiumcodereview.appspot.com/11368112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11363002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11275121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%281%29&number=21644
http://build.chromium.org/p/chromium.win/buildstatus?builder=XP%20Tests%20%28dbg%29%281%29&number=28760
eg
[10776:10780:1106/215239:1089468:INFO:safe_browsing_test.cc(443)] Start test
browser\safe_browsing\safe_browsing_test.cc(491): error: Value of: ParsePhishingUrls(safe_browsing_helper->response_data(), &phishing_urls)
Actual: false
Expected: true
Google Test trace:
browser\safe_browsing\safe_browsing_test.cc(466): step=2
browser\safe_browsing\safe_browsing_test.cc(492): error: Expected: (phishing_urls.size()) > (0U), actual: 0 vs 0
Google Test trace:
browser\safe_browsing\safe_browsing_test.cc(466): step=2
browser\safe_browsing\safe_browsing_test.cc(517): error: Expected: (safe_browsing_helper->response_data().size()) > (0U), actual: 0 vs 0
Google Test trace:
browser\safe_browsing\safe_browsing_test.cc(466): step=2
browser\safe_browsing\safe_browsing_test.cc(524): error: Value of: safe_browsing_helper->response_data()
Actual: ""
Expected: "yes"
)- Try #2: Run safebrowsing_service_test through the net testserver code.
Allows us to use ephemeral ports.
Original review: https://chromiumcodereview.appspot.com/10073033
BUG=96459,119403
Review URL: https://chromiumcodereview.appspot.com/10918251
TBR=mattm@chromium.org
Review URL: https://codereview.chromium.org/11369114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=danakj@chromium.org, enne@chromium.org
TBR=enne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11312113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
method from Skia.
This method exists in Skia, but is not publicly consumable/linkable with a
component build. Skia will expose this (or a similar) method through a proper
public API, and we should use it. But in the meantime, we make a copy of the
method in timing_function.cc, and use it there in place of WebCore's UnitBezier
class.
Tests:
cc_unittests:TimingFunctionTest.CubicBezierTimingFunction
This test compares the output of the timing function against baseline values
recorded with WebCore's UnitBezier class. If new methods are able to come
closer to those values, we should decrease the epsilon used in the test
accordingly.
R=jamesr
BUG=147395
Review URL: https://chromiumcodereview.appspot.com/11359077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11366105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11272047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=116317
TEST=browser_tests, PPB_Core
Review URL: https://chromiumcodereview.appspot.com/11363114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For Apps and Extensions with a lazy background page, this will delay installing
an update until the background page gets unloaded (or next chrome restart).
Also adds a chrome.runtime.onUpdateAvailable event which is fired when an update is
available but isn't being installed immediately because the app is not idle.
It doesn't change anything yet for Extensions with a persistent background page
(or extensions without a background page at all). Those still get updated as soon
as an update is found.
BUG=37971
BUG=143260
TBR=nick@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11293002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixes testshell to support launching with a URL and triggering
new intents (and fixes it's adb_run_chromium_testshell.
BUG=159602
Review URL: https://chromiumcodereview.appspot.com/11377011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=try bots
Review URL: https://chromiumcodereview.appspot.com/11365122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
running until we figure out the cause.
Review URL: https://chromiumcodereview.appspot.com/11293134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
before comparing to the nonFastScrollableRegion.
The hit test resulting point that the tryScroll() method gets is in content
space, since it is the result of mapping via the inverse screenSpaceTransform.
However, the nonFastScrollableRegion is in layer space, so it should not compare
the point against the region directly. We add a conversion from content to layer
space before doing the test.
This is now covered by the following tests. Because the layer is given a
contentsScale, the tests fail without the above change made to tryScroll.
Tests:
cc_unittests:LayerTreeHostImplTest.nonFastScrollableRegionBasic
cc_unittests:LayerTreeHostImplTest.nonFastScrollableRegionWithOffset
R=enne
BUG=159676
Review URL: https://chromiumcodereview.appspot.com/11377006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BluetotohAdapterWin is not fully implemented and causes a lot of noises in other tests, so we are removing it for now.
BUG=135470
Review URL: https://chromiumcodereview.appspot.com/11377003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This allows the browser and renderer processes to get new unique mailbox names without syncing with the GPU process main thread.
Review URL: https://chromiumcodereview.appspot.com/11362053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=159744
Review URL: https://chromiumcodereview.appspot.com/11377009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, if chrome is already running and the launcher is run it does not get activated, causing it to close after 2 seconds.
BUG=159667, 159713, 159618
Review URL: https://chromiumcodereview.appspot.com/11362126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Issue 151985 caused a one pixel wide column of white on the right side
of the Calculator app on OS X. To make this less visible, elements were
added to the Calculator in http://crrev.com/11091078 that would mask
that column on OS X only. Since then the area next to the Calculator
keyboard has been made gray on all platforms to mitigate any bug that
would allow the Calculator window to be resized. This effectively hides
the one-column-of-white-pixels on OS X so the pixel-hiding hack can be
removed.
BUG=155383
Review URL: https://chromiumcodereview.appspot.com/11368033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166348 0039d316-1c4b-4281-b951-d872f2087c98
|