| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
base test files dependent on test_support_base.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3179017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3136012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
browser window while the first run bubble is showing, the First Run Bubble will close before the cleanup code has had a chance to fire.
This change fixes that.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3120013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up PLT gathering in preparation for moving it
to take place in navigation_state.cc, during the
instance destructor. This CL should have almost
no semantic impact, and I'm submitting it separately
so that when I move large blocks, I can mostly move
them unchanged.
Add a bunch of DCHECKs to be sure that finish and finish_doc
times are only set once, and that they are set only in
the correct order.
In a future CL, I expect to push a lot of the time-gathering
code into navigation_state.cc, along with the generation
of the final histograms. The challenge is to mark the
NavigationState instances that are worthy of recording
(which looks like it MAY be done by marking the state
with the boolean to indicate it is part of an HTTP or
HTTPS connection), and make sure we have good numbers
throughout.
bug=48970
r=mbelshe
Review URL: http://codereview.chromium.org/2993004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Transition from using a DNS observer, to using the
TCP/IP connection interceptor (which is used for
preconneciton and pre-resolution) to acquire the
list of hosts to resolve at startup.
BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3169006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Patch by Mihai Parparita <mihaip@chromium.org>
TEST=rebuild Xcode projects
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow on to r56040, "Rework gfx::Font by moving platform-specific code into inner classes"
These two lines are inside #if defined(GOOGLE_CHROME_BUILD) and only
get compiled for Google Chrome official builds (which have been broken
for Windows and ChromeOS since r56040).
TBR= ben
BUG= none
TEST= Google Chrome builders pass
http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Google%20Chrome%20ChromeOS
http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Google%20Chrome%20XP
Review URL: http://codereview.chromium.org/3161019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ignore errors when cleaning up.
shutil.rmtree() works by os.listdir() followed by rm'ing each entry.
If a file goes missing after os.listdir(), a os.remove will be attempted for it resulting in an exception.
In this case it might happen so (in once in a blue moon) because chrome creates temp files while downloading and cleans them up.
Review URL: http://codereview.chromium.org/3143017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17870
TEST=launch chrome, open the wrench menu, see if the 'Preferences' menu is in
there instead of the 'Options' menu.
Review URL: http://codereview.chromium.org/3060050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
change
BUG=chromium-os:5539
TEST=make sure there are no JS errors on chrome:options page and that download location can't be changed
Review URL: http://codereview.chromium.org/3167012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
static function.
BUG=52067
TEST=none
Review URL: http://codereview.chromium.org/3175012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
src/base.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3173020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3187003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: This type is not really used and is just adding duplicated code.
We are using the same color scheme for both WARNING_TYPE and ERROR_TYPE, so
there is no really reason to both exists. Staing with WARNING_TYPE because
it used more than ERROR_TYPE and looks like it captures the idea better than
ERROR_TYPE.
BUG=39102
TEST=trybots
Review URL: http://codereview.chromium.org/3128007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think this kills off the remaining uses of the now-deprecated wstring
DictionaryValue methods.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3125010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3124023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3130020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3108019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/3133015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3146015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3121017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DictionaryValue::Get...WithoutPathExpansion()s.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3116013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the default arguments from the constructor.
- Add a empty constructor to handle the case of the default arguments were used.
BUG=44644
TEST=trybots
Review URL: http://codereview.chromium.org/3172009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3142011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DictionaryValue::Get{Dictionary,List}WithoutPathExpansion() overloads.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3163015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
its punctuation messed up.
BUG=none
TEST=Force a browser crash while running with --lang=he and look at the "Woah!" string in the popup
Review URL: http://codereview.chromium.org/3187001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3123017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This helps keep our patches, build files, and metadata separate.
(Note that src/ is not purely what upstream has, since it has our
patches applied.)
Review URL: http://codereview.chromium.org/3160012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3143016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* In RTL, the options dropmarker button was still on the right (overlaying the Chrome logo and opposite where the dropdown menu would actually appear)
* Missing a <head> tag
* Made the "attribution" block at the bottom corner of the NTP be at the end rather than always on the right
BUG=none
TEST=Use NTP with --lang=he and check dropmarker and custom theme attribution position
Review URL: http://codereview.chromium.org/3122015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Instead use AppendArg variants which accept a FilePath or an ASCII string.
Review URL: http://codereview.chromium.org/3134008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49227,49993
TEST=ExtensionsServiceTest.InstallAppsWithUnlimtedStorage
Review URL: http://codereview.chromium.org/3053048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49093
TEST=None
Review URL: http://codereview.chromium.org/3161012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Further tighten down what URLs can be loaded in Chrome Frame.
Based on the feedback from the security review and code
inspection, restrict about: scheme only to about:blank
and about:version by default. Factor out logic blocking logic
including for URL zone checking so that all ActiveX, ActiveDoc
and NPAPI will follow the same path. As a result we now block
restricted URL zones in NPAPI instance as well.
Another side effect of this refactoring is that the registry
flag, EnableGcfProtocol, is replaced by AllowUnsafeURLs. If
If this flag is set, then all the security related checking
is turned off.
BUG=50741
TEST=By default gcf: works only for about:blank, about:version and
view-source of http and https. Setting AllowUnsafeURLs to a non
zero value should allow any URL be loaded via gcf:
Review URL: http://codereview.chromium.org/3159006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
we need enable bitstream converter by which decoder is actually in pipeline.
instead of use command line.
Review URL: http://codereview.chromium.org/3159014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
regressed in r48691
BUG=51963
TEST=TODO
Review URL: http://codereview.chromium.org/3150012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
But, still accept the old value for backwards compatability.
BUG=51970
TEST=Extensions should get unlimited storage quota for localStorage and web
databases using either "unlimitedStorage" or "unlimited_storage" in their
manifest's permissions key.
Review URL: http://codereview.chromium.org/3109013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52086
tbr=japhet
Review URL: http://codereview.chromium.org/3132009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a simple offline startup integration test. This change also includes the groundwork for more complex offline startup test cases, including the ability to enable and disable network connectivity as well as configure the mock sync server with a username.
BUG=47918
Review URL: http://codereview.chromium.org/3078031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=48544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://support.apple.com/kb/HT4290
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/3159016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This forces all the ReadParam template junk to expand once in the *_messages.cc
file, instead of at every Read() call site. Without the compiler-specific
annotation, this builds and links in debug mode, but doesn't link in release
mode because the individual Read() methods generated were inlined into the
subclass Log() methods, causing disaster on the release builders, but not on
the trybots or locally.
BUG=51411
TEST=none
Review URL: http://codereview.chromium.org/3160008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56081 0039d316-1c4b-4281-b951-d872f2087c98
|