summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTRxji@chromium.org2009-09-168-24/+91
| | | | | | | | | | | | | | | | | | | directionality in download shelf. File names in download shelf are forced to be LTR in DownloadItemView and through ElideFileName(). BUG=http://crbug.com/10860 TEST=1. Open chrome with Hebrew UI. 2. Right click a link and chose Save As... (4th item from the top for non-Hebrew speakers) 3. In the save as dialog name the file קובץ.html 4. In the download shelf the filename should display as קובץ.html (not html.קובץ) Review URL: http://codereview.chromium.org/131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98
* Build the sync unit tests:nick@chromium.org2009-09-166-39/+75
| | | | | | | | | | | | | | | | | | | - Remove old main(argc, argv) from syncable_unittest. - Since the old notifier target had only one unittest, merge it with the syncer tests. - Remove listener_unittest.cc entirely. - Don't compile natserver_main.cc, which has another main() - Use a test main from the test_support_unit library. This has the downside of pulling in a lot of deps we don't need, but it gives us a run_all_unittests.cc. - Fix a few compile errors in test code. TEST=unit tests pass BUG=none Review URL: http://codereview.chromium.org/205021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26358 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that HTML can't be executed when entered on the "Search History" or ↵mirandac@chromium.org2009-09-162-2/+2
| | | | | | | | | | | "Search downloads" pages. BUG= http://crbug.com/17892 TEST= Open history / downloads page. Search for "<h1>HI</h1>". Note that the HTML is not interpreted, but displayed as text. Review URL: http://codereview.chromium.org/201129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26357 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebViewClient, part 1.darin@chromium.org2009-09-1626-746/+695
| | | | | | | | | | | | | | This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/196128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
* Improve tab-closability of right-most tab.thakis@chromium.org2009-09-161-5/+15
| | | | | | | | | BUG=21903 TEST=Open 20 tabs. Put mouse over close button of some tab in the middle and keep clicking to close tabs. When the tab below the mouse is right-most, closing it should cause the other tabs to grow so that another close box ends up below the cursor (until the remaining tabs have reached the maximum tab width). Review URL: http://codereview.chromium.org/196137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26354 0039d316-1c4b-4281-b951-d872f2087c98
* disable extension bar for nowthakis@chromium.org2009-09-161-0/+4
| | | | | | | | | BUG=none TEST=extension bar is no longer visible Review URL: http://codereview.chromium.org/206030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26352 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix to use file_util::SetCurrentDirectory method instead of the ↵erikkay@chromium.org2009-09-163-22/+6
| | | | | | | | | | | | PathService method, also avoids the conflict with the the windows function. BUG=None TEST=None Review URL: http://codereview.chromium.org/196072 Patch from thiago.farina@gmail.com. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26351 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/svg/hixie/error/012.xml flaky for Win debug as well as Mac ↵tyoshino@google.com2009-09-161-1/+1
| | | | | | | | | | | | and Linux. TBR=agl BUG=21958 TEST=none Review URL: http://codereview.chromium.org/204040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26350 0039d316-1c4b-4281-b951-d872f2087c98
* Cast the TabWindowController object to the correct type before treating it asmark@chromium.org2009-09-161-3/+6
| | | | | | | a TabWindowController. Review URL: http://codereview.chromium.org/204030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26349 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversionsmark@chromium.org2009-09-165-10/+11
| | | | | | | | | The SDK has gotten stupider in 10.6, and has conspired with the compiler, which now thinks that when the receiver is held in a scoped_nsobject, NSColor and NSSize arguments should be converted to their CG cousins. Review URL: http://codereview.chromium.org/205016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26348 0039d316-1c4b-4281-b951-d872f2087c98
* Don't redefine what Snow Leopard provides if Snow Leopard has provided it.mark@chromium.org2009-09-161-1/+3
| | | | | | Review URL: http://codereview.chromium.org/205015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26347 0039d316-1c4b-4281-b951-d872f2087c98
* Mac about box shouldn't be a floater.mark@chromium.org2009-09-161-6/+6
| | | | | | | | | | | | | | Nib changes: - Remove the "utility," "minimize," and "hide on deactivate" bits from the window. - Remove the "rich text" bit from the title text field. - Remove the "selectable" bit from the version text field. BUG=21918 TEST=About box should not float above other windows Review URL: http://codereview.chromium.org/206019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26346 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky DiskCacheBackendTest.NewEvictionDisableSuccess4.phajdan.jr@chromium.org2009-09-161-1/+3
| | | | | | | | | | This is #9 flaky test and rising (#5 in tests failing recently). TBR=rvargas Review URL: http://codereview.chromium.org/193127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26345 0039d316-1c4b-4281-b951-d872f2087c98
* Add pause and resume to Linux download shelf.craig.schlenter@chromium.org2009-09-162-1/+6
| | | | | | | | BUG=16929 Review URL: http://codereview.chromium.org/203069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26344 0039d316-1c4b-4281-b951-d872f2087c98
* Properly only add linker flag for linux/freebsd.thomasvl@chromium.org2009-09-161-8/+10
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/195103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26343 0039d316-1c4b-4281-b951-d872f2087c98
* Edit Search Engine fix up:thomasvl@chromium.org2009-09-163-875/+510
| | | | | | | | | | | | | Fix the class name to match a rename that happened before commit. Make the label size changes force the fields over, but not string the fields (window grows). Make the url description autosize to the text it gets. Make the window track the height needed for the url description field. BUG=21893 TEST= The url description text should stay under the url box in all languages. The labels should never clip or overlap the text fields. Review URL: http://codereview.chromium.org/195096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26342 0039d316-1c4b-4281-b951-d872f2087c98
* Provide a baseline for the rotated hindi layout test.brettw@chromium.org2009-09-167-1/+72
| | | | | | | | BUG=21919 TEST=covered by layout test Review URL: http://codereview.chromium.org/201123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26341 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26300 - Fix installer scripts so they don't look for pthreads.dll.nick@chromium.org2009-09-162-0/+2
| | | | | | | | | | | | | | We statically link this. TEST=none BUG=none Review URL: http://codereview.chromium.org/193120 TBR=nick@chromium.org Review URL: http://codereview.chromium.org/205020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26339 0039d316-1c4b-4281-b951-d872f2087c98
* Roll pthread-win32 deps to pick up linkage change, r26337.nick@chromium.org2009-09-161-1/+1
| | | | | | | | | TBR=tim TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26338 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.3.11.1.ager@chromium.org2009-09-161-1/+1
| | | | | | | | | Patching in a 64-bit crash fix. TBR=whesse@chromium.org Review URL: http://codereview.chromium.org/206028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26334 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26329 to re-land 26326tyoshino@google.com2009-09-161-1/+1
| | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=26326 It came out that your change didn't cause purify failure. I'd like to reland reverted change. Sorry. TBR=sgk Review URL: http://codereview.chromium.org/204037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26331 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new entry to reliability test known_crashes.txt file.tyoshino@google.com2009-09-161-0/+3
| | | | | | | | | | BUG=21978 TBR=agl TEST=none Review URL: http://codereview.chromium.org/206027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26330 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 26326.tyoshino@google.com2009-09-161-1/+1
| | | | | | | | | | | | | | XP Unit (purify) failed on r26326. r26325: fine http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5564 (please cut and paste the address or %20 will be URLencoded...) r26326: failure http://build.chromium.org/buildbot/waterfall/builders/XP%20Unit%20(purify)/builds/5563 TBR=sgk Review URL: http://codereview.chromium.org/196138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26329 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools heap profiler: Add a stub for heap-js-ret-item log record.mnaganov@chromium.org2009-09-161-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/195100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26328 0039d316-1c4b-4281-b951-d872f2087c98
* Add space between TYPE and colon in entries in known_crashes.txt file.tyoshino@google.com2009-09-161-3/+3
| | | | | | | | Looks like without this, pattern match doesn't work on reliability test. Review URL: http://codereview.chromium.org/193124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26327 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to latest GYP revision:sgk@google.com2009-09-161-1/+1
| | | | | | | | | | * Fix options in variants like SYMBOLS=1. * Generated Makefiles auto-regenerate when .gyp files change. BUG=none TEST=none Review URL: http://codereview.chromium.org/196129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26326 0039d316-1c4b-4281-b951-d872f2087c98
* Move tests marked as crashing/hanging on Mac valgrind to mac-specific ↵dank@chromium.org2009-09-162-18/+26
| | | | | | | | | | | disable file. Add top six tests causing the most recent crashes/hangs on the mac valgrind ui bots. BUG=21949 Review URL: http://codereview.chromium.org/196134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26325 0039d316-1c4b-4281-b951-d872f2087c98
* Use "FAIL PASS" for flaky test.tyoshino@google.com2009-09-161-1/+1
| | | | | | | | | BUG=21958 TBR=agl Review URL: http://codereview.chromium.org/196136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26324 0039d316-1c4b-4281-b951-d872f2087c98
* Mark flaky layout test LayoutTests/svg/hixie/error/012.xml expected to FAIL.tyoshino@google.com2009-09-161-0/+3
| | | | | | | | | BUG=21958 TBR=agl Review URL: http://codereview.chromium.org/206023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26323 0039d316-1c4b-4281-b951-d872f2087c98
* Another try to fix a build break caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | This change just adds a namespace. I wish this fixes. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/201132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26322 0039d316-1c4b-4281-b951-d872f2087c98
* A quick build fix caused by r26312.hbono@chromium.org2009-09-161-1/+1
| | | | | | | | | | | It seems this "static_cast<GtkWidget*>(window)" has been moved from a static member "InfoBubble::Show()" to a non-static member "InfoBubble::Init()". So, we don't need this cast. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/204036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26321 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION build from 211.0 to 212.0jon@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26320 0039d316-1c4b-4281-b951-d872f2087c98
* Roll pthread deps to 26317 (to pick up gyp change).nick@chromium.org2009-09-161-1/+1
| | | | | | | | | | TBR=brg TEST=none BUG=none Review URL: http://codereview.chromium.org/194125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26318 0039d316-1c4b-4281-b951-d872f2087c98
* Roll deps, pick up xdg-settings change.thestig@chromium.org2009-09-161-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26316 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 21587, a regression of CL 196020.suzhe@chromium.org2009-09-163-20/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input. It's a regression of my CL: http://codereview.chromium.org/196020, which reverts the text of omnibox in OnAfterPossibleChanges(), when enter key is pressed: ... // If the change is caused by an Enter key press event, and the event was not // handled by IME, then it's an unexpected change and shall be reverted here. // {Start|Finish}UpdatingHighlightedText() are called here to prevent the // PRIMARY selection from being changed. if (enter_was_pressed_ && (char_inserted_ == '\n' || char_inserted_ == '\r')) { StartUpdatingHighlightedText(); SetTextAndSelectedRange(text_before_change_, sel_before_change_); FinishUpdatingHighlightedText(); return false; } ... Unfortunately, this piece of code causes the char_inserted_ to be set to wrong value in HandleInsertText(), if the text has only one character. See the source code of HandleInsertText(): ... // Filter out new line and tab characters. // |text| is guaranteed to be a valid UTF-8 string, so it's safe here to // filter byte by byte. // // If there was only a single character, then it might be generated by a key // event. In this case, we save the single character to help our // "key-press-event" signal handler distinguish if an Enter key event is // handled by IME or not. if (len == 1) char_inserted_ = text[0]; ... This CL uses a boolean |enter_was_inserted_| instead of char |char_inserted_| to record the enter key status, to make sure it won't be reset unexpectly. The test has been updated to cover this case. An unexpected dns lookup issue in the test which causes a failure on Windows was also fixed. BUG=21587: REGRESSION: Omnibox does nothing when pressing enter after a single character of input. TEST=Input one character in omnibox and press enter, the default link matched with the character should be opened. Review URL: http://codereview.chromium.org/200131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26315 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed scons build after upgrade to August 2009 DirectX SDK.kbr@google.com2009-09-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/196135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26313 0039d316-1c4b-4281-b951-d872f2087c98
* More miscellaneous cleanup bits to try and move info_bubble.* closer to my ↵pkasting@chromium.org2009-09-163-67/+51
| | | | | | | | | | locally rewritten versions, so that the diff will be readable. BUG=none TEST=none Review URL: http://codereview.chromium.org/196131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26312 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bare-bones extension shelf that displays extension items on OS X.thakis@chromium.org2009-09-1615-30/+858
| | | | | | | | | | | | | | | | | | | This brings our extension support to about the level it has on linux. One issue is that the toolstrips are webpages with a background image that just happens to look like the shelf they are on. But the background images are not updated on key->nonkey window changes, so the toolstrip backgrounds look slightly off in one of the two cases. If we decide to keep the shelf, we should fix this, but see the bug for erikkay's stance on this. Also, the NTP is only loaded after all toolstrips have been loaded for some reason. That's what happens on the other platforms too, I believe. The extension shelf uses the DownloadShelfView as background view for now. Screenie: http://imgur.com/wSHgU.png BUG=19073 TEST=Extensions that live in the shelf should show up. They should be clickable, resize correctly (e.g. the build status extension), and the shelf should interact in a sane way with the status bubble. Review URL: http://codereview.chromium.org/175025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26311 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage concerning CreateTemporaryFile vs CreateTemporaryFileName.maf@google.com2009-09-162-5/+5
| | | | | | Review URL: http://codereview.chromium.org/193122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26310 0039d316-1c4b-4281-b951-d872f2087c98
* Remove valgrind filters for GTK unittests as the bots now run the tests with ↵mattm@chromium.org2009-09-161-6/+0
| | | | | | | | | | xvfb. BUG=15445 Review URL: http://codereview.chromium.org/204032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26309 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: print page to file rather than using shared memory to send it to the ↵estade@chromium.org2009-09-1612-164/+174
| | | | | | | | | | | | browser. BUG=9847 adapted from patch by <minyu.huang [at] gmail> Review URL: http://codereview.chromium.org/203062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26308 0039d316-1c4b-4281-b951-d872f2087c98
* Add SSL icons on Mac OS Xhawk@chromium.org2009-09-165-1/+122
| | | | | | | | BUG=14899 TEST=https sites have a lock icon in the address field, plain http sites do not Review URL: http://codereview.chromium.org/199072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26307 0039d316-1c4b-4281-b951-d872f2087c98
* Layout test: video-document-types.html is now timing out.agl@chromium.org2009-09-161-2/+2
| | | | | | | | | (It was previously flakly, so this isn't a huge step backwards). BUG=13907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26306 0039d316-1c4b-4281-b951-d872f2087c98
* More correctly handle username and password in FtpNetworkTransaction.phajdan.jr@chromium.org2009-09-169-86/+226
| | | | | | | | | | | | - prevent newline injection attacks - correctly unescape credentials provided in the URL TEST=Covered by net_unittests. http://crbug.com/20336 Review URL: http://codereview.chromium.org/183046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26305 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Snow Leopard SDK errorsmark@chromium.org2009-09-162-2/+2
| | | | | | | error: cannot convert 'scoped_nsobject<N>' to 'objc_object*' in argument passing Review URL: http://codereview.chromium.org/204028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26304 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-1562-180/+80
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Fix installer scripts so they don't look for pthreads.dll.nick@chromium.org2009-09-152-2/+0
| | | | | | | | | | We statically link this. TEST=none BUG=none Review URL: http://codereview.chromium.org/193120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26300 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing newline at end of file. Quiet a compiler warning.mark@chromium.org2009-09-151-1/+1
| | | | | | Review URL: http://codereview.chromium.org/204031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26299 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.agl@chromium.org2009-09-159-22/+621
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) (Reland. First landed in r26264, reverted in r26276. This reland hopefully doesn't build tcmalloc on Linux.) Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26298 0039d316-1c4b-4281-b951-d872f2087c98
* Print a stacktrace when we can't find a string resource (on Windows).phajdan.jr@chromium.org2009-09-151-0/+3
| | | | | | | | | | | This should help debug the linked bug, or at least rule out some possibilities. TEST=none BUG=21925 Review URL: http://codereview.chromium.org/196132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26297 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 22:30:21 +0000