| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Introduced in http://codereview.chromium.org/6469081
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7495046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
coordinates of the mouse event were run. I'm also making the code wait
for a mouse motion.
BUG=none
TEST=none
R=estade@chromium.org
Review URL: http://codereview.chromium.org/7495039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/7497032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add WeakHandle class, which makes cross-thread method calls safe and easy
Use WeakHandle to solve a long-standing sync issue where SyncManager would
need to pump the sync thread loop on shutdown, since arbitrary threads
may post tasks on it for SyncManager.
Clean up SyncManager::SyncInternal.
BUG=78190, 89266
TEST=
Review URL: http://codereview.chromium.org/7461086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This deletes LanguageComboboxModel class now that native options dialog is gone.
This was introduced at revision r23683.
BUG=None
TEST=None
R=evan@chromium.org,yusukes@chromium.org,knostylev@chromium.org,glotov@chromium.org
Review URL: http://codereview.chromium.org/7497005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows UDP sockets will return a WOULDBLOCK but a writeable
notification will never happen in libjingle code. When we receive
such error in the glue code we should report a success and drop
the packets.
BUG=None
TEST=Connect to a windows box to itself, network will be alright.
Review URL: http://codereview.chromium.org/7380003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=88213,90654
TBR=bruening
Review URL: http://codereview.chromium.org/7497031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some processes [e.g. the GPU process] do not set up a SystemMonitor object, since the startup code was changed to always allocate the Power notification IO port [http://codereview.chromium.org/7235023/] these processes were causing a delay in sleep as the power manager was trying to contact the process.
This change whitelists the IO port allocation in ChromeMain() to only include process types that allocate a SystemMonitor which fixes the sleep issue.
If a process not in the whitelist attempts to use the SystemMonitor it will hit a DCHECK in a debug build and the error will be ignored in release (see SystemMonitor::PlatformInit()).
BUG=88867
TEST=When Chrome is running, Macs should sleep immediately.
Review URL: http://codereview.chromium.org/7491038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New reliability crash:
http://build.chromium.org/p/chromium/builders/Win%20Reliability/builds/5237/steps/reliability%3A%20partial%20result%20of%20current%20build/logs/stdio
BUG=89679
TEST=none
TBR=tyoshino
Review URL: http://codereview.chromium.org/7461113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no compile error
Review URL: http://codereview.chromium.org/7480020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/7517011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This uses the feature added in WebKit: https://bugs.webkit.org/show_bug.cgi?id=64580
BUG=89346
TEST=manually
Review URL: http://codereview.chromium.org/7484061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
once this has landed, will rebaseline those images
Review URL: http://codereview.chromium.org/7480024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/drmemory/issues/detail?id=499,http://code.google.com/p/drmemory/issues/detail?id=511
TBR=bruening
Review URL: http://codereview.chromium.org/7461110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
As Clang now (since #13349 -- hans) supports asm .common directive, we may re-enable chrome-sandbox for Clang builds.
BUG=chromium-os:16717, chromium:70871, chromium-os:88578
TEST=none
Review URL: http://codereview.chromium.org/7233011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Disable AutomatedUITestBase.OpenNewTab on the Mac UI Valgrind bot (issue 51716)
TBR=timurrrr
BUG=51716,65680
Review URL: http://codereview.chromium.org/7480043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=FileSystemQuotaClientTest.*
Review URL: http://codereview.chromium.org/7517008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-Wno-unused-result is not supported by gcc 4.3.4, which is used for building
chrome in chroot, and setting this option causes build error when building
chrome from the source in chroot for Chrome OS.
http://build.chromium.org/p/chromiumos/builders/x86%20generic%20tot%20chrome%20pre%20flight%20queue
(Need to copy URL text instead of clicking the link to see the page above.)
BUG=chromium-os:18272
TEST=emerge-x86-alex chromeos-chrome succeeds.
Review URL: http://codereview.chromium.org/7517007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProtocolHandlerRegistry::MaybeCreateJob)
Extend the suppression for issue 89677 (leak in ThreadWatcher::PostPingMessage)
TBR=timurrrr
BUG=88735,89677
Review URL: http://codereview.chromium.org/7477043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17712
TEST=PyAuto tests.
Review URL: http://codereview.chromium.org/7461108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Suppress leaks in PosixDynamicThreadPool::AddTask (issue 90642)
Suppress leaks in ppapi tests (issue 90644)
BUG=90642,90640,90644
TBR=timurrrr
Review URL: http://codereview.chromium.org/7497027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminate heapcheck and valgrind suppressions.
BUG=90370
TEST=none
Review URL: http://codereview.chromium.org/7466043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This causes reliability bot crashes, see:
http://code.google.com/p/chromium/issues/detail?id=90553#c1
Review URL: http://codereview.chromium.org/7477041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Refactor the views about dialog to use shared code for generating the version string.
- Remove the OS version string from the views about dialog because it is no longer needed to differentiate between Windows and ChromeOS.
We decided to split the changes of issue 7104106 (http://codereview.chromium.org/7104106/) into the following steps. This is the third step of them:
(1) Add CreateVersionString() to chrome_version_info.*, update the GTK+ code to use it. (reviewer: erg, tony)
(2) Update the mac code to use CreateVersionString(). Update About.xib. (reviewer: mark)
(3) Update the views code to use CreateVersionString(). This can happen at the same time as (2). (reviewer: davemoore, tony)
(4) Update version.bat to use lastchange.py. (reviewer: evan, mark)
(5) Update tweak_info_plist to use lastchange.py. This can happen at the same time as (4). (reviewer: mark)
(6) Make changes to lastchange.py and webkit_version.py. (reviewer: evan, mark)
BUG=37186
TEST=Observe that "About Chromium" dialog shows the version string like "14.0.787.0 (Developer Build 88242 Windows)" on Windows.
Review URL: http://codereview.chromium.org/7489036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileUtils.
Based on the discussion at http://codereview.chromium.org/7174002/diff/26001/webkit/fileapi/local_file_system_file_util.h#newcode38, this change
* also reduces dependency between FileUtils,
* enables more flexible stacking of -FileUtils, such as QuotaFileUtil over other -FileUtils, and
* makes -FileUtils symmetry so owner handling for these objects gets unified.
BUG=none
TEST=FileSystemFileUtilTest.*,FileSystemOperationTest.*,FileSystemOperationWriteTest.*,FileSystemQuotaTest.*,FileWriterDelegateTest.*,LocalFileSystemFileUtilTest.*,ObfuscatedFileSystemFileUtil.*,QuotaFileUtil.*,SandboxMountPointProviderTest.*
Review URL: http://codereview.chromium.org/7312023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JingleStreamConnector.
Fix JingleStreamConnector and JingleDatagramConnector tear-down semantics in case of failure.
BUG=88130,90624
TEST=
Review URL: http://codereview.chromium.org/7501007
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/7497026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix JingleStreamConnector and JingleDatagramConnector tear-down semantics in case of failure.
BUG=88130,90624
TEST=
Review URL: http://codereview.chromium.org/7501007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Needed for RTL issues - minimum font was (wrongly) right aligned in RTL before, since it had no class.
BUG=87690
TEST=Open font settings in RTL language - all sample text should be left-aligned
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/7517005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix TestTexture and ViewLayerTest compile.
BUG=90548
TEST=none
Review URL: http://codereview.chromium.org/7470030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dup() call was unnecessary. The subsequent call,
internal_->sockets_for_sel_ldr.clear()
frees the array contents and prevents ~NaClProcessHost() from closing
the FDs.
The leak is bad because it will cause a renderer process to hang if
the NaCl process crashes during startup. Worse, the file descriptor
table of the browser process will eventually become full.
The Mac-specific dup() call should be correct, however, because the
destructor for base::SharedMemory closes its FD.
BUG=90611
TEST=manual: on Linux, added printf() to log the file descriptor number
* before: the FD numbers increase
* after: the FD numbers hover around 83-87
Review URL: http://codereview.chromium.org/7477023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Added --random-seed flag
BUG=89737
Review URL: http://codereview.chromium.org/7461103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the API can fabricate a key event which is supported by src/ui/base/keycodes/keyboard_codes_posix.h. This means the API only supports ASCII characters (<= 0x7f).
However, since some i18n virtual keyboards need to call the API to generate a key event which is not supported by the header, it'd be better to relax the limitation. For example, French virtual keyboard might call the API with U+00E1 (LATIN SMALL LETTER A WITH ACUTE), Russian one might do it with U+0410 (CYRILLIC CAPITAL LETTER A).
BUG=chromium-os:18048
TEST=run browser_tests
Review URL: http://codereview.chromium.org/7473025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89967
TEST=no
R=abarth@chromium.org
Review URL: http://codereview.chromium.org/7497024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test currently fails with "Uncaught Error: SECURITY_ERR: DOM Exception 18."
Now it does not.
BUG=89964
TEST=gpu_tests --gtest_filter=GpuPixelBrowserTest.WebGLTeapot
Review URL: http://codereview.chromium.org/7514019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that may occur when using the server's public key in NSS's
ssl3_HandleServerKeyExchange and ssl3_SendClientKeyExchange functions.
R=agl@chromium.org
BUG=88044
TEST=none
Review URL: http://codereview.chromium.org/7495006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/7458009 .
BUG=none
TEST=none
TBR=mark
Review URL: http://codereview.chromium.org/7465062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert r94208 (re-land r94196), add missing NET_API decl.
TBR=willchan@chromium.org
BUG=84078
TEST=everything compiles
Review URL: http://codereview.chromium.org/7477035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=90605
TEST=Manual
Review URL: http://codereview.chromium.org/7477037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a new PrintResult method in SyncTimingHelper that should print timings in a format appropriate for use with the chromium perf dashboard. It is a much simpler replication of the methods found in chrome/test/ui/ui_perf_test.{h,cc}.
Also cleanup TODOs that are no longer needed or relevant.
BUG=90441
TEST=sync_performance_tests
Review URL: http://codereview.chromium.org/7464046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7517002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
English, it is the smallest natural number with seven letters in its spelled name.
In speech, the numbers 15 and 50 are often confused. When carefully enunciated, they differ in which syllable is stressed: 15 /fɪfˈtiːn/ vs 50 /ˈfɪfti/. However, in dates such as 1500 ("fifteen hundred") or when contrasting numbers in the teens, the stress generally shifts to the first syllable: 15 /ˈfɪftiːn/.
Fifteen is:
The number of days in each of the 24 cycles of the Chinese calendar.
The number of guns in a gun salute to Army, Marine Corps, and Air Force Lieutenant Generals, and Navy and Coast Guard Vice Admirals.
The designation of Interstate 15, a freeway that runs from California to Montana.
The designation of U.S. Route 15, a highway that runs from South Carolina to New York.
The number of checkers each side has at the start of a backgammon game.
The 15 puzzle.
A restaurant in London, built by celebrity chef Jamie Oliver
15 minutes of fame
The 15th is a Wire song
The number of balls in the eight ball variant of billiards
The number of function keys on most Mac keyboards
The number of letters in the words "uncopyrightable", "dermatoglyphics", "misconjugatedly", and "hydropneumatics", which are the longest words in the English language that do not repeat a letter.[citation needed]
15 is one of The Numbers - 4, 8, 15, 16, 23, and 42 - featured in Lost.
The number to dial for SAMU in case of an emergency in France.
The number of minutes in one quarter of an hour; 15 minutes past or before an hour is often known as quarter past and quarter to, respectively.
The number of the French department Cantal
The number corresponding to The Devil in tarot cards.
Credit: http://en.wikipedia.org/wiki/15_(number)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
test support in order to fix DRT chromium port crash
BUG=90503
TEST=None
Review URL: http://codereview.chromium.org/7461079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
glFlush now has barrier semantics and is now used as an alternative.
This patch is dependent on https://bugs.webkit.org/show_bug.cgi?id=65043, now landed as webkit r91736.
Review URL: http://codereview.chromium.org/7495009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cause the item to be uneditable after the drag.
BUG=89620
TEST=none
R=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/7503001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:17013
TEST=Open two windows on device, open wrench menu, use Alt-Tab to switch windows and check that menu closes.
Review URL: http://codereview.chromium.org/7484048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=17969
TEST=manually
Review URL: http://codereview.chromium.org/7479005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94211 0039d316-1c4b-4281-b951-d872f2087c98
|