| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
crypto_helpers only depends on resources in base and is used by sync and
password_manager.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6873156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6933026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1742
TEST=./out/Debug/chrome --nacl-loader-cmd-prefix='strace -c'
Review URL: http://codereview.chromium.org/6883220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6903156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=happy bots
TBR= dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6932032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6929026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
TBR= dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6935019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a part of the work to switch the Mac build to use bitmaps instead of PDFs.
This change updates ImageButtonCell to use ThemeProvider to load images. This allows us to get properly tinted images.
BUG=75812
TEST=Ran and verified that toolbar buttons were tinted correctly.
Review URL: http://codereview.chromium.org/6913035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsing with lookahead.
* Adds an AutofillScanner class to help with lookahead parsing.
* Remove the NULL-termination from FormStructure's fields vector
* Remove some redundant DCHECKs
* Refactor PersonalDataManager::ImportFormData() to take a single form, not a vector of forms.
* Move EmailField class to its own file
* Remove some obsolete billing/shipping address distinguishing code
* Refactor the code to remove the really wonky FormFieldSet() class
* Refactor some interfaces to take |size_t| rather than |int|
* Remove some unused fields from FormStructure
* Const-correctness
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6910018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=PanelBrowserWindowCocoaTest.AssignedBounds, NativeBounds
Review URL: http://codereview.chromium.org/6913016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6904147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I had assumed that didReceiveData() would only be called after Open(), but WebPluginImpl::didReceiveResponse() creates a PPB_URLLoader_Impl and immediately calls didReceiveData(). This correctly handles this case.
BUG=80684
TEST=PDFBrowserTest
TBR=brettw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6883291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
one error, we need to count two when the malformed body is reported,
against the one success reported based on the response code from what
must have been a successful HTTP request.
Updated a unit test that previously should have caught this but was
making incorrect assumptions.
BUG=81587
TEST=net_unittests
Initially Committed: r84196
Reverted: r84200
Re-landed after fixing compile error.
Review URL: http://codereview.chromium.org/6932013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=71209
TEST=browser_tests --gtest_filter="*PrerenderSSLErrorSubresource*"
Review URL: http://codereview.chromium.org/6912037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
counting
one error, we need to count two when the malformed body is reported,
against the one success reported based on the response code from what
must have been a successful HTTP request.
Updated a unit test that previously should have caught this but was
making incorrect assumptions.
BUG=81587
TEST=net_unittests
Review URL: http://codereview.chromium.org/6932013
TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/6932029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
disable field trials. I am going to have a need for both soon.
Cleaning up some comments about empty trial names, adding static
method TrialExists() and simplifying many call sites by using this
method.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
BUG=none
TEST=base_unittests
TBR=jam@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
one error, we need to count two when the malformed body is reported,
against the one success reported based on the response code from what
must have been a successful HTTP request.
Updated a unit test that previously should have caught this but was
making incorrect assumptions.
BUG=81587
TEST=net_unittests
Review URL: http://codereview.chromium.org/6932013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-virtual one. This is a step along the way to killing it entirely. This also adds a lot of OVERRIDE markers and does some other cleanup in a few places.
The original (stupid) design for the delegate class left subclasses great flexibility in how they mapped infobars to delegates. In practice, no one ever wanted multiple infobars driven off a single delegate, so the mapping was always one-to-one. As a result, it was always correct for InfoBarClosed() to "delete this", but because the base class did not do so, every subclass needed to. Most did; the others leaked memory and failed to run their destructors.
This change forces the base class to delete itself. This fixes the delegate leaks in the couple subclasses that failed to do this. It also eliminates a lot of copy-and-pasted "delete this" implementations.
Ultimately, we'll be moving to a model where the InfoBar "view" class owns the delegate and deletes it directly, which will eliminate InfoBarClosed() completely.
BUG=62154
TEST=none
Review URL: http://codereview.chromium.org/6926001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logging. VLOG(0) is used only in conditions that are guaranteed to trigger this bug. Other places are now VLOG(1).
There are 2 VLOG(0) that will still print in normal scenario. They are:
1. SyncShare is about to be called.
2. DTM is informing sync configure is done.
I think the above 2 cases are after the bug, meaning the bug happens before either of the above 2 conditions are hit. This will prove that or disprove it.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6933018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=80902
TEST=Invoke print preview with no printer installed. "Print to PDF" should be
selected and the previewed doc should be in color.
Review URL: http://codereview.chromium.org/6928019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=80431
TEST=we should not prompt to become the default every time if ~/.local/share/applications/mimeapps.list does not exist
Review URL: http://codereview.chromium.org/6929027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
while.
BUG=none
TEST=PrerenderBrowserTest.PrerenderInfiniteLoopMultiple
Review URL: http://codereview.chromium.org/6930031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14770
TEST=manually test to make sure it doesn't crash.
Review URL: http://codereview.chromium.org/6928022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* The infobar wouldn't tell the browser it was done animating when the height hadn't also changed from the previously-calculated height, so frequently the content wouldn't properly relayout after infobar animation. I think this was the cause of bug 79108.
* A silly bug in ToolbarSizeChanged() meant that we never did re-layout on the content area when the toolbar stopped animating, because we were checking for "call_state == NORMAL" while the AutoReset object was still alive and guaranteeing that the state would not be NORMAL. This caused bug 80142.
* I reversed the enum values for the recursive call state, so recursive ToolbarSizeChanged() calls were all getting "can use fast resize" backwards.
BUG=79108,80142
TEST=Visit a page with a vertical scrollbar. Toggle the bookmark bar on. Once the bar stops animating the scrollbar should redraw so it's once again fully on-screen.
Review URL: http://codereview.chromium.org/6927032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds BrightnessLibrary::IncreaseScreenBrightness()
and DecreaseScreenBrightness().
Contributed by Chris Wolfe <cwolfe@chromium.org>. I am
checking this in on his behalf from
http://codereview.chromium.org/6928011/.
BUG=chromium-os:13281
TEST=cwolfe tested manually in conjunction with other changes that use these functions; i tested that it builds at ToT
TBR=cwolfe
Review URL: http://codereview.chromium.org/6935017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=tim@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
by refreshing the page after adding the data through the DOMUI.
TEST=none
BUG=80682
Review URL: http://codereview.chromium.org/6944002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=81453
Review URL: http://codereview.chromium.org/6933001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch introduces the notion of non-blocking conflicts. These are conflicts that do not result in the
syncer getting stuck. They affect the HasConflictingUpdates status call, so we attempt to reapply updates
when they occur, but they are not passed to the conflict resolver, and hence do not result in the syncer being stuck. All cases where we have a conflict due to encryption/decryption result in a new
ENCRYPTION_CONFLICT, which are treated as nonblocking conflicts.
Updated sync's protocol_version to 27 so the server can tell which clients understand encryption.
Also, due to this change, it's more likely that local/server changes will be overwritten in the conflict
resolver (since encryption conflicts are kept as unapplied while they can't be decrypted). Added
counters for how often this happens, which will appear on about:sync, and filed follow up bug
crbug.com/76596.
BUG=59242
TEST=new session sync_integration tests, modified apply_updates_command unit tests
Review URL: http://codereview.chromium.org/6714002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on tab_strip_gtk.cc.
BUG=58030
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/6930026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build:
Autofill phone number enhancements and integration of Phone Number Util Library: part 1
Temporarily the whole library is included, until the patch is upstreamed.
BUG=71443
TEST=Unit-tested
Review URL: http://codereview.chromium.org/6930013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in brightness-related code for cwolfe.
BUG=chromium-os:13281
TEST=manual: synced to this revision and checked that the chromeos-chrome package builds and appears to function as before
TBR=cwolfe
Review URL: http://codereview.chromium.org/6930028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81427
TEST=PrerenderBrowserTest.*Alert*
Review URL: http://codereview.chromium.org/6915018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80895
TEST=Compiles
Review URL: http://codereview.chromium.org/6930014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
were missing them.
BUG=chromium-os:14769, chromium-os:14821
TEST=no crashes on the crash server with these stacks anymore
Review URL: http://codereview.chromium.org/6940001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert GetSyncData() to taking a const Extension& instead of an ID, as
the service may not know about the extension via ID anymore.
BUG=81470
TEST=
Review URL: http://codereview.chromium.org/6931019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Roll WebKit to 85784.
TBR=morrita
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove HandleGoToDashboard, which is also unused.
BUG=none
TEST=none
R=tim@chromium.org
Review URL: http://codereview.chromium.org/6944003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use camelCase for i18n values.
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6927035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=(internal i10n bug)
TEST=ran on device
Review URL: http://codereview.chromium.org/6927026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initial inclusion of Proxy tests
The following tests will test that the Proxy settings are saved properly
using different types of input. It does not test that the fields are actually
functional and that the device is using the proxy. That will come later.
BUG=None
TEST=Run it
Review URL: http://codereview.chromium.org/6914013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
across platfroms.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6932021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
tree red.
R=isherman@chromium.org
Review URL: http://codereview.chromium.org/6927033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80755
TEST=Install extensions with background pages, make sure View Background Pages wrench menu item has the correct count.
Review URL: http://codereview.chromium.org/6929001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Element IDs are dash-form.
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6929023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12641, chromium-os:12851
R=dtu@chromium.org
TEST=
Review URL: http://codereview.chromium.org/6932022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutomationProxyMock test. This is
an attempt to fix the flaky ChromeFrame.RequestStart and ChromeFrame.Launch tests
BUG=none
TEST=The ChromeFrame.RequestStart and ChromeFrame.Launch tests should hopefully be more reliable.
Review URL: http://codereview.chromium.org/6927031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes header files for the abstract base classes necessary for lower level parts necessary for video capturing in Chromium as well as an implementation of these classes on Linux. This patch is the first in a series necessary for implementing video capture in the browser process. Tested on Linux.
This patch also includes a fake implementation of VideoCaptureDevice to be used with unittests for testing Video Capture classes.
Patch by perkl@google.com:
http://codereview.chromium.org/6878013/
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Close the file browser window in C++, rather than via window.close() in JavaScript
because window.close() is no longer working. This prevents crashes in listeners
that expect to only be called once.
BUG=chromium-os:14524
TEST=Exercise file browser: Hit control-O to open, then cancel the dialog. Hit control-O to open, then open an image. Right-click save an image, cancel dialog. Right-click save an image, save it. Insert USB drive with images, preview individual images, open them, run a slideshow.
Review URL: http://codereview.chromium.org/6935006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84146 0039d316-1c4b-4281-b951-d872f2087c98
|