| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
BUG=76793
Review URL: http://codereview.chromium.org/6913013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing unnecessary "To be printed" label and moving the print/
cancel buttons in the center.
Also in this CL:
1) Restricting the width of the printer drop-down list. It was overflowing the available space when a printer with a long named existed (e.g. "Microsoft XPS Document Writer").
2) Making print/cancel button size equal.
3) Removing localized string that is not used anymore.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6883292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added error logging
BUG=
TEST=Copy installer and port monitor dlls to the same folder.
Run the installer as admin.
Success message should display.
Open the printers dialog.
A Cloud print printer should exist.
Make sure you have a recent build of chrome dev channel installed.
Print something.
Run the installer again as admin with --uninstall on the command line.
The cloud print printer should be removed.
Review URL: http://codereview.chromium.org/6880300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=80879
TEST=Wrench and back/forward menus work as before.
Review URL: http://codereview.chromium.org/6909028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also add myself to OWNERS for chrome/browser/ui/webui
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6883305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/6907009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=64568
TEST=Manually verify that bookmark bar is gone when visiting a ssl-page with a self-signed certificate.
Review URL: http://codereview.chromium.org/6912020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a bad_message parameter in order to simulate EXTENSION_FUNCTION_VALIDATE. This allows the Proxy Settings API to terminate extensions that circumvent the input parameter validation performed by the generic extension api.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6902039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is identical to http://codereview.chromium.org/6893107/. The original commit was reverted because of a DEPS issue in a different tree which has since been resolved.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6889020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a call like the following: checkDeepEq([{abc: 'def'}], [])
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6912022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(the IDR_ value) in the filename so we don't have naming clashes.
BUG=69633
Review URL: http://codereview.chromium.org/6910005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
R=mmenke
Review URL: http://codereview.chromium.org/6907022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=81341
Review URL: http://codereview.chromium.org/6911028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r81859 made Chrome first ask the window manager to focus a
panel after its titlebar was clicked and then ask the WM to
expand the panel. The window manager would expand the panel
in response to the focus request and then ignore the
expansion request; as a result, it wouldn't show the little
"collapse anchor" button underneath the mouse pointer. This
change makes us expand the panel first and then focus it.
BUG=chromium-os:14735
TEST=manual: checked that the anchor is shown after expanding a panel, and that collapsing a panel still works as expected (and dismisses its urgent state if present)
Review URL: http://codereview.chromium.org/6910014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=77177
TEST=PrerenderBrowserTest.PrerenderXhr*
Review URL: http://codereview.chromium.org/6901128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
level used by the NetLog.
BUG=80851
TEST=none
Review URL: http://codereview.chromium.org/6893131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dragging from one row to another should cause an effect where tiles, instead of jumping between rows, slide off the side and reappear/slide into the correct place.
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/6902186
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6913023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening
BUG=http://code.google.com/p/drmemory/issues/detail?id=45
Review URL: http://codereview.chromium.org/6913025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is longer than the available space to display it. In this case, it no longer
matters whether the text is to aligned on the left or right, we only need to
take into consideration whether the icon is displayed to the left or right in
order to make room for it on the correct side.
It also broke the case centered buttons with no text string.
BUG=81188,81053
TEST=for 81188, create bookmark on the bookmark bar, and edit it to make sure
its name is very long. Make sure that the name is clipped correctly and
appears with ellipsis. To test 81053, install one or more extensions that
have browser actions and make sure the icons appear correctly.
Review URL: http://codereview.chromium.org/6901157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening
BUG=http://code.google.com/p/drmemory/issues/detail?id=45
Review URL: http://codereview.chromium.org/6911027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fetched or is invalid.
The optional blocking is currently only exposed to the Proxy Settings API, not to command-line parameters or policies.
BUG=79344
TEST=Install the sample proxy extension and enter a non-existing url and a URL that does not point to a valid JavaScript file. In either case, the request should fail.
Review URL: http://codereview.chromium.org/6871019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83882 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add a wrapper class to avoid passing around raw NULL pointers, and a bridge so I can invoke the method from other than the IO thread
BUG=48930
TEST=net unittests
Review URL: http://codereview.chromium.org/6822026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
introduced by http://codereview.chromium.org/6883177.
This makes the buttons on interstitial pages work again.
Committed by sfeuz
Review URL: http://codereview.chromium.org/6904159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also make sure the icon shows up on Linux and Mac (we were accidentally returning false from GetIconForCommandId, which works on Windows because we were not checking the return value).
BUG=80647
TEST=Same as in http://codereview.chromium.org/6840038/, but for Linux and Mac.
Review URL: http://codereview.chromium.org/6904129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening
BUG=75020
Review URL: http://codereview.chromium.org/6907018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also cleaned up some dead code and obsolete comments.
BUG=80726
TEST=
Review URL: http://codereview.chromium.org/6909001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=dev tools should be enabled by default
TEST=manual
Review URL: http://codereview.chromium.org/6911013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=bruening
Review URL: http://codereview.chromium.org/6907017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83870 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=80970
TEST=Visit ftp://plan9.bell-labs.com/, the directory listing should be displayed.
Review URL: http://codereview.chromium.org/6903166
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change enabled -> terminated state transition to be atomic.
Added unit tests for various functions' behavior with terminated
extensions.
Fix incorrect use of extension_id parameter in UninstallExtension (by renaming the parameter to extension_id_unsafe and the copy to extension_id).
Cleaned up unit tests a bit.
BUG=80756,80752
TEST=
Review URL: http://codereview.chromium.org/6889015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Windiows shared builder failed building unit_tests.
TBR=sgjesse@google.com
Review URL: http://codereview.chromium.org/6910017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused carrier deal notification text.
BUG=chromium-os:14575
TEST=None.
Review URL: http://codereview.chromium.org/6905129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ager@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6883300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=14381
TEST=unit tests
Review URL: http://codereview.chromium.org/6902147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6909022
Patch from Kris Rambish <krisr@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6903051
Patch from Kris Rambish <krisr@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the browser process to open the IRT file and send it to the
nascent NaCl process.
If the IRT file is not present, handle this gracefully while still
allowing the NaCl process to run. This is because there may be corner
cases to sort out for getting the IRT into the various Chrome install
images. In the mean time, NaCl executables that are not built to use
the IRT should continue to work.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=nacl_integration on the Chrome trybot
Review URL: http://codereview.chromium.org/6873133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TwoClientLivePasswordsSyncTest.SetPassphraseAndThenSetupSync is flaky. A
fix is in review at http://codereview.chromium.org/6910012. Marking the
test as flaky until then.
TBR=jam@chromium.org
BUG=81341
TEST=TwoClientLivePasswordsSyncTest.SetPassphraseAndThenSetupSync
Review URL: http://codereview.chromium.org/6909023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
spellchecking on mac. I made RenderWidgetHostViewMac filter the message itself.
Review URL: http://codereview.chromium.org/6889008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6910009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This pulls in a change that makes IPv6 parsing with embedded IPv4 literals more permissive.
BUG=76954
Review URL: http://codereview.chromium.org/6889022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6889023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=New automation.
Review URL: http://codereview.chromium.org/6905163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=kalman
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=python flatten.py <path/to/chrome/test/data/autofill/merge/output/filename.out> should look better for multivalued output
Review URL: http://codereview.chromium.org/6903164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PrerenderContents.
Also update PrerenderContents to pass plugin
and HTML5 prerender tests.
BUG=81229
TEST=PrerenderBrowserTests (Once the new code is enabled)
Review URL: http://codereview.chromium.org/6905169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires disabling most /W4 warnings so the patch doesn't get too large.
I still fixed a few bugs so I didn't have to disable some more serious warnings. Most of these warnings are already enabled on gcc so it's mostly windows-specific code that is affected.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6902069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6913015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83838 0039d316-1c4b-4281-b951-d872f2087c98
|