| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename HostMessage and ClientMessage to Chromoting{Host|Client}Message to
avoid conflicts with messages in X11.
Actually, only ClientMessage needs to be changed due to conflict, but HostMessage is changed to keep the names consistent.
BUG=none
TEST=remoting unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57112
Review URL: http://codereview.chromium.org/3161034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
per stream.
TEST=unittests
BUG=39825
Review URL: http://codereview.chromium.org/3185022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Useful for plugins that make heavy use of background threads.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=57233
Review URL: http://codereview.chromium.org/3104031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r57234
TBR: stevenjb
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in http://crbug.com/49862. That crash no longer occurs.
Fix cpplint.py nit: add a "// namespace" comment.
R=vandebo
BUG=49862
TEST=none
Review URL: http://codereview.chromium.org/3165057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=53176
TEST=None.
Review URL: http://codereview.chromium.org/3204003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flipped as the RTL dialog top.
BUG=none
TEST=search engine dialog looks fine in LTR and RTL modes
Review URL: http://codereview.chromium.org/3171028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pass important values (the return value of WaitForSingleObject
and the error code) as function arguments so that they are
available in crash dumps.
R=eroman
BUG=51950,52008
TEST=none
Review URL: http://codereview.chromium.org/3107032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dell.com
Modifies AutoFill heuristics to match middle initial at end of string instead of strict match of whole string. Also, adds form_field_unittest.cc with specific unit tests for pattern matching.
BUG=45123
TEST=FormFieldTest.Match, NameFieldTest.MiddleInitialAtEnd
Review URL: http://codereview.chromium.org/3127030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, the feature extractor will keep track of how long it has been
working, and if it exceeds a predefined time limit, it will pause and post a
task to continue extraction. This will allow other MessageLoop tasks to run on
the render thread. There is also a total time limit, after which the extractor
will give up altogether -- this is a sanity check in case of a bug or an
especially large page. Also includes some UMA histograms so that we can see
how well this performs in practice.
TEST=PhishingDOMFeatureExtractorTest.Continuation
BUG=none
Review URL: http://codereview.chromium.org/3130039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=browser_tests
BUG=53247
Review URL: http://codereview.chromium.org/3141040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=rohitrao
Review URL: http://codereview.chromium.org/3110036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49094
TEST=none
Review URL: http://codereview.chromium.org/3140026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
cause the calculation for DIR_SOURCE_ROOT to go wrong. Avoid this by not using the value from the path service.
BUG=52918
TEST=green tree
Review URL: http://codereview.chromium.org/3176036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to avoid crashes.
TBR=dhollowa, sky, erikkay
TEST=unit_tests, browser_tests
BUG=52731, 52643
Review URL: http://codereview.chromium.org/3150034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r57233
TBR: brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:5601 (http://code.google.com/p/chromium-os/issues/detail?id=5601)
TEST=Check that hover text over status bar icons seems reasonable. Test different states of network (disconnected, ethernet, connecting to a wifi network, connected to a wifi network) and battery (plugged in, unplugged).
Review URL: http://codereview.chromium.org/3158014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Useful for plugins that make heavy use of background threads.
Review URL: http://codereview.chromium.org/3104031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a check to make sure the helper isn't used without --type
- Add a check to make sure the main app isn't used with --type.
- Make inproc browser tests invoke the helper that is within the app bundle on disk to recreate the real world environment.
BUG=23645,52858
TEST=green tree, invoking the main app with --type fails, and invoking the helper without it fails.
Review URL: http://codereview.chromium.org/3171027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
around nav bar items.
BUG=chromium-os:6059
TEST=none
Review URL: http://codereview.chromium.org/3157037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new file, render_messages_params.h, is included in 57 files, while
render_messages.h is included in 176 files. Moving the Params structs to their
own file allow pruning the included headers.
(Part 2 of this cleanup will be sorting the individual structs into themes
to further minimize header inclusion.)
BUG=51411
TEST=compiles
Review URL: http://codereview.chromium.org/3119035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3165050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Cleanup all files the tests might have created in the download dir.
Review URL: http://codereview.chromium.org/3141039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is based on existing code/math. I have removed all the unused code for our usage and adapted to the chromium coding style.
TEST=unit_tests --gtest_filter=EndpointerTest.*
BUG=none
Review URL: http://codereview.chromium.org/3117026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53173
TEST=none yet (will add tests when BackgroundModeManager handles prefs notifications)
Review URL: http://codereview.chromium.org/3200007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3108043
TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/3203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Treats ASCII double/single quoation marks between Hebrew letters as MidLetter
for Hebrew spellchecker because they're commonly used in place of Geresh and Gershayim.
2. Pass through ASCII double/single quotation marks and Geresh and Gershayim in OutputHebrew.
See http://www.unicode.org/reports/tr29/proposed.html (version 6.0.0.0 draft2) about Hebrew
tailoring.
This alone does not fix bug 22909 completely. This CL will be followed with an ICU data fix.
BUG=22909
TEST=unit_tests --gtest_filter=SpellcheckWordIteratorTest.*
Review URL: http://codereview.chromium.org/3112015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
by enumerating all the files in the selected directory.
BUG=47162
TEST=layout test input-file-directory-upload.html, or www/~johnnyg/dir_upload/ demo page
Review URL: http://codereview.chromium.org/2825051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53200
TEST=n/a
Review URL: http://codereview.chromium.org/3162034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
load that resource will fallthru to the network instead of promptly failing. See bug 50657. This is just a first step, a repair step will follow on in a future change.
BUG=50657
TEST=none
Review URL: http://codereview.chromium.org/3187017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for easier use on CrOS.
BUG=none
TEST=Verify CrOS preferences working properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3174032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53035
TEST=none
Review URL: http://codereview.chromium.org/3151033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we are simulating non-shared resources on top
of shared resources we can't actually let contexts
use texture 0 because they are all sharing it.
Also, moved the black textures to the texture manager.
TEST=unit tests and ran conformance tests
BUG=none
Review URL: http://codereview.chromium.org/3150026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50254
TEST=unittests
Review URL: http://codereview.chromium.org/3136030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unittests
Review URL: http://codereview.chromium.org/3181034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux+OSX.
This will be yanked out, but is being used to triage a bug.
BUG=50517
TEST=None
Review URL: http://codereview.chromium.org/3150033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pointer of the backend is valid until the callback fires,
even after the http cache is deleted.
BUG=52387
TEST=net_unittests
Review URL: http://codereview.chromium.org/3195017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=53141
TEST=none
Review URL: http://codereview.chromium.org/3159035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52765
TEST=Bookmark sites in a language different than the language Chrome is configured in (you should have few of them, with titles long enough, so there are more than 100 characters in that language). Go to the bookmark manager, no translate infobar should be shown.
Review URL: http://codereview.chromium.org/3130045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=TEST=none
Review URL: http://codereview.chromium.org/3142035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be shared between PepperView and X11View.
Have View create appropriate decoder based on encoding of the update stream.
Add state to decoder to keep track of whether Begin/End has been called in the
correct order.
Add unittests for new routines.
BUG=none
TEST=remoting unit tests
Review URL: http://codereview.chromium.org/3124005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tabcontents after an animation that would result in a gray rect.
BUG=53083
TEST=see bug
Review URL: http://codereview.chromium.org/3142034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
what this cl is:
- a REALLY bare skeleton implementation of ProxyConfigService for chromeos (lots of design details remain to be worked out on the chromeos side, but i needed to get something basic up)
- focused on getting chrome part correct, extracting design flow and implementation from linux variant that are relevant to chromeos, e.g.:
- provide access of ProxyConfigService interface on IO thread
- provide methods on UI thread for UI to read/modify proxy config (like linux's GConf notifications on UI thread)
- fetch initial config on UI thread (this is not absolutely necessary for chromeos, 'cos i don't use GConf, but i just follow linux for now)
- however, the class is RefCountedThreadSafe (so that both net::ProxyService and DOMUI can access it), and the code resides in chrome/browser/chromeos dir instead of net/proxy.
- design details are in .h files
- initial config is hardcoded as pac script and loaded as owner (TODO: load this from cros settings persisted on chromeos device)
- this should work like the current chromeos session manager which sets the auto-proxy environment variable in login script to the same pac script
- implement an augmented analogue to net::ProxyConfig to hold actual proxy config and UI settings (e.g. source and readonly attributes)
- backend uses this as the main proxy config, and only converts it to net:::ProxyConfig for network stack on the IO thread in net::ProxyService::GetLatestProxyConfig.
- UI methods also use this structure
- provide methods to get and set configs from UI thread
- UI can use dom_ui->GetProfile()->GetChromeOSProxyConfigServiceImpl() to access these methods on the UI thread
- these methods are by no means final
- i only added them here to verify the design flow that modifications can be made from UI thread and picked up by IO thread.
- david and i will improve or modify them to whatever works best for frontend and backend.
- unittest that tests most functionalities: socks and bypass_rules will be enabled in a later cl.
TODOs after this cl:
- work with UI, load initial config as owner from cros settings
- implement policy mechanism, merge it with owner during initial load and modifications
- persist proxy settings
- etc etc etc
BUG=chromium-os:5127
TEST=nothing yet.
Review URL: http://codereview.chromium.org/3047052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41762
TEST=none
Review URL: http://codereview.chromium.org/3165055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Configure the opengl view to draw below the window, draw the view with NSClearColor so that's transparent, and make the window non-opaque while plugins are showing, so that the opengl surface can show through.
This is a bit slower than previously without this patch, but it's about as fast as it was when we used CoreAnimation to show IOSurfaces.
Parts of this code are from Simon Fraser's MacTierra code (with permission).
BUG=44087,51748
TEST=
* Go to youtube. Findbar should show up on top of video. Go fullscreen. Tab overlay should show up on top of video.
* Go to youtube, drag tab with video out and to a new window. Video should continue playing.
* Install https://chrome.google.com/extensions/detail/bdnkaenpadjoldiddfdidinjmjeagaji , click browser action. Should still work.
* Install a transparent theme such as https://tools.google.com/chrome/intl/cy/themes/theme_at_mecko.html or http://chromium.googlecode.com/issues/attachment?aid=3778755830122130591&name=theme-bug.crx&token=27908ca7e699a023c8446657b24c4696 . Browser window shouldn't become transparent while videos are playing.
Review URL: http://codereview.chromium.org/3176027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3153034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I have not implemented the Mac/Linux part yet, will do so in a subsequent CL (does InfoBubble exist for Mac?).
This info bubble remains visible on screen until recognition ends or the user cancels it.
It also tracks the html element which requested speech recognition if it changes position
on screen (e.g. user scrolls the page or moves the browser window).
To get this working, I extended InfoBubble to query the delegate if it can be closed when
another window gets activated, as well as to reposition it when required.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3133034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
run on my next changlist.
(I thought we wanted separate sets for Identity and Connect column, but UI leads said we should consolidate here)
TBR=jcivelli
TEST=None
BUG=52916
Review URL: http://codereview.chromium.org/3120028
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3162035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
KeepAlive mode. The condition to check that in CanAutorestartForUpdate() is
reversed.
BUG=none
TEST=On Linux - Change BrowserProcessImpl::StartAutoupdateTimer() function to
change the timer from 6hrs to 30 seconds. Build and run chrome with
--no-startup-window and --keep-alive-for-test flags. Run "touch" on browser
exe to fake an update. Wait for 30 seconds and verify that the browser shuts
down and restarts.
Review URL: http://codereview.chromium.org/3206003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3137033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57196 0039d316-1c4b-4281-b951-d872f2087c98
|