| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=antonm
Review URL: http://codereview.chromium.org/7014027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unrelated changes:
- Tweak several comments, rephrasing some of them and matching the style when
referring to parameters.
- Put some arguments onto the same line when they fit.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7015025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
once the user has confirmed the preferences.
BUG=82376
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/7015030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
page names that actually are camelCase.
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6973042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=82348
Review URL: http://codereview.chromium.org/7015015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a hostname has both IPv6 and IPv4 addresses, and the IPv6 address is listed first, we start a timer (300ms) (deliberately chosen to be different from the backup connect job). If the timer fires, that means the IPv6 connect() hasn't completed yet, and we start a second socket connect() where we give it the same AddressList, except we move all IPv6 addresses that are in front of the first IPv4 address to the end. That way, we will use the first IPv4 address. We will race these two connect()s and pass the first one to complete to ConnectJob::set_socket().
Adds 4 new TCP connection latency histograms to assess the new behavior:
IPv6 raceable (includes both when it races and doesn't, which are distinguished
by whether or not the samples exceed the race timeout of 300ms)
IPv6 solo (no IPv4 addresses to race against)
IPv4 no race (IPv4 is the first address, so we're not racing)
IPv4 wins race (IPv4 raced and won, even though it started behind).
BUG=81686
TEST=On Linux, drop ip6 packets via `sudo ip6tables -A OUTPUT -p tcp -j DROP`. Then test against a site with both IPv6 and IPv4 addresses (such as www.ripe.net). It should load without hitting 20s connect() timeouts on the IPv6 addresses.
Review URL: http://codereview.chromium.org/6969028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This modifies the compositor to hold DoDeferredUpdate until the previous frames are ack'd by the GPU.
This vastly improves rendering smoothness.
There is some complexity in the way we intercept the SwapBuffers callback due to the different types of GraphicsContexts that get scheduled by render_widget.
BUG=80480,53051
Review URL: http://codereview.chromium.org/6902106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:15256
TEST=added new test cases that utilize Entry.toURL() to FileSystemExtensionApiTest.FileBrowserTest
Review URL: http://codereview.chromium.org/7015023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
COMMON_API is the public interface for the module.
COMMON_TEST is intended to be used for symbols that have to be
exported only in order to test them.
BUG=82326
Review URL: http://codereview.chromium.org/7011007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81985,82299
TEST=PrerenderBrowserTest.PrerenderDownloadLocation,
PrerenderBrowserTest.PrerenderDownloadIframe
Review URL: http://codereview.chromium.org/6973030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It should render on all windows boxes with working GL. The GPU process creates a child window to render to again, but only if desktop GL has been enabled. The child window is not created by default so there should not be issues with deadlocks. Resizing flickers for some reason.
TEST=WebGL works, trybots.
BUG=none
Review URL: http://codereview.chromium.org/6991002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:15271
TEST=StatusAreaViewTest.IsVisible
Review URL: http://codereview.chromium.org/7013033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for now.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6973016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6973038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/6982014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way, when touch-typing, keys are emitted as soon as touch is made,
ie. finger down, not when finger up which is what onclick does. We
still keep onclick for mouse to work.
BUG=
TEST=Tested on device by pointing browser to the keyboard index.html and alert() on sendKey events.
Review URL: http://codereview.chromium.org/6969018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=71209
TEST=browser_tests --gtest_filter=*PrerenderSSLErrorIframe
Review URL: http://codereview.chromium.org/7016018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=71209
TEST=browser_tests --gtest_filter=*PrerenderSSLErrorTopLevel
Review URL: http://codereview.chromium.org/6969043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
codereview.chromium.org/6969027
Trigger GPU acceleration in the picture slide show and the media player.
This change adds a noop (-webkit-transform: translateZ(0)) property to the file manager's picture slideshow and to the media player. This triggers GPU acceleration and avoids tearing in Chrome OS.
BUG=chromium-os:14881
TEST=Run the picture slide show, go from one picture to the other and check that there is no tearing.
Review URL: http://codereview.chromium.org/7016020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When the user hits escape, we need to call FileSelectionCanceled on the listener. Added OnWindowClosed() to HtmlDialogUIDelegate so we can catch this case.
BUG=chromium-os:14698
TEST=Find or make a web page with a <input type=file /> element. Click on it to select a file. Cancel the file browser dialog with the escape key. Click on it again. Verify that the file browser reopens and works normally.
Review URL: http://codereview.chromium.org/7014007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Enable DownloadTest.DownloadCancelled for Cros.
Also update code to check for download shelf visibility on Cros. As a result of this change,
DownloadTest.IncognitoDownload needed a modification too.
BUG=80327
TEST=Ran DwonloadTest.DownloadCancelled 100 times, no failures. Ran the rest of the DownloadTest suite.
Review URL: http://codereview.chromium.org/7002026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes an issue with the Sync setup UI where closing the tab in the middle
of a setup operation would hose the setup UI because the backend thought a
setup operation was still in progress.
BUG=81564
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6973031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65953
TEST=TabContentsTest.CrossSiteBoundariesAfterCrash
TBR=mpcomplete
Review URL: http://codereview.chromium.org/7011019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69939
TEST=net_unittests --gtest_filter=NetUtilTest.GetSuggestedFilename
Review URL: http://codereview.chromium.org/7005003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Gnome Keyring may pop up additional UI during browser tests that may cause tests to fail or time out.
BUG=none
TEST=browser_tests --gtest_filter=LoginPromptBrowserTest.*
Review URL: http://codereview.chromium.org/6995020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Since we only use the variable in one place, move its definition
into that one place.
Review URL: http://codereview.chromium.org/6969045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7011016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80706
TEST=
Review URL: http://codereview.chromium.org/7016009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
target directory heirarchy (regression introduced in r75899).
BUG=82424
TEST=Install system-level Chrome as some admin user X. Switch to admin user Y and try to uninstall.
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/7011018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST= This is a test.
Review URL: http://codereview.chromium.org/6969024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and submitting a form
as the same set of code were used in multiple tests.
- testAggregatesMinValidProfile
- _FillFormAndSubmit
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6959001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
URL-looking so they'll be easier to copy and handle.
BUG=28846
TEST=
Review URL: http://codereview.chromium.org/6949005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
// QuotaClients should call this method when storage is accessed.
// Used to maintain LRU ordering.
void NotifyStorageAccessed(client, origin, type);
// Used to avoid evicting origins with open pages.
// A call to NotifyOriginInUse must be balanced by a later call
// to NotifyOriginNoLongerInUse.
void NotifyOriginInUse(origin);
void NotifyOriginNoLongerInUse(origin);
Implemented the latter two along with an IsOriginInUse(origin) method.
2) Added a quota_manager() getter to the proxy interface for use only on the IO thread.
3) Removed GetUsageAndQuota from the proxy interface, since the impl does not support that. Changed the callsite for that to use proxy->quota_manager()->GetUsageAndQuota().
4) Virtualized the proxy interface to make client testing easier.
5) Use raw MessageLoopProxy ptrs for ctor args instead of scoped_refptr<T> to avoid having to inlude as much.
BUG=61676
TEST=added tests for OriginInUse bookeeping
Review URL: http://codereview.chromium.org/6973017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
defined os_posix, toolkit_gtk, and use_x11 in common.gypi to handle them. I used something similar when porting Chromium 10 and 11 to OpenBSD and Solaris, plus a version of this patch has been tested on FreeBSD.
Chromium has also been built on other BSDs, so rather than adding each Unix to every gyp file individually every time another port is added, these broad defines can be used instead and modified with specific logic only where necessary.
I included a few modified gyp files so the usage can be seen. I also added sunos5 to some grd/html files and set the default host_arch on i86pc solaris to ia32.
BUG=0
TEST={}
Patch by ruben <chromium@hybridsource.org>.
Review URL: http://codereview.chromium.org/6965007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
checking if using file system is fine. Depends on https://bugs.webkit.org/show_bug.cgi?id=60683
BUG=76793
Review URL: http://codereview.chromium.org/7012007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we not just call it from chrome.exe (chrome/app) but it
is also called periodically from chrome.dll itself
BUG=82180
TEST=see bug
Review URL: http://codereview.chromium.org/7005008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=none
Review URL: http://codereview.chromium.org/7013009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used order returned by DirectoryReader.
BUG=chromium-os:14344
TEST=Open directory with a fiew image files (jpeg|png|gif). Select one. Click the 'Preview image' button. Click prev/next icons in the slideshow tab.
Review URL: http://codereview.chromium.org/6901092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=loislo@chromium.org
BUG=none
TEST=compile using MSVS 2005
Review URL: http://codereview.chromium.org/7014014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Cloud print connector notifications
Review URL: http://codereview.chromium.org/6973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See http://bugs.gentoo.org/show_bug.cgi?id=365841
BUG=none
Review URL: http://codereview.chromium.org/6969030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
do a pseudo case-insensitive lookup.
BUG=81699
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/7015018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bitmaps.
BUG=0
TEST=Ensure the find bar appears the same way it usually does, with multiple Chrome windows.
Review URL: http://codereview.chromium.org/7011001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is debt promised in http://codereview.chromium.org/6913026.
BUG=0
TEST=The wrench menu for the toolbar should behave normally.
Review URL: http://codereview.chromium.org/7002036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The pp:VarPrivate is broken in out-of-process mode
BUG=82356
TEST=none
Review URL: http://codereview.chromium.org/7016008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes subtle bug introduced by http://crrev.com/84492, which could cause DoCapture()
to be called twice in succession, breaking the correct interleaving of
capturing/encoding tasks.
Problem was seen when trying to implement full-screen polling on Linux.
BUG=None
TEST=Changing screen-resolution still works.
Review URL: http://codereview.chromium.org/7011013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7014017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this, I am reliably getting the following crash. It looks like the timer may fire (in the nested MessageLoop run call inside TestCompletionCallback::WaitForResult) before the expected num_callbacks_ gets set.
[ RUN ] DiskCacheTest.CacheBackendPerformance
[18893:18893:0511/165403:1994535049146:FATAL:disk_cache_test_util.cc(174)] Check failed: false.
Backtrace:
base::debug::StackTrace::StackTrace() [0x4ed37e]
logging::LogMessage::~LogMessage() [0x4fdd12]
MessageLoopHelper::TimerExpired() [0x4d2589]
DispatchToMethod<>() [0x4d2b42]
base::BaseTimer<>::TimerTask::Run() [0x4d29d2]
(anonymous namespace)::TaskClosureAdapter::Run() [0x4ffac9]
base::internal::Invoker1<>::DoInvoke() [0x503624]
base::Callback<>::Run() [0x504799]
MessageLoop::RunTask() [0x50241c]
MessageLoop::DeferOrRunPendingTask() [0x502553]
MessageLoop::DoDelayedWork() [0x502f49]
base::MessagePumpLibevent::Run() [0x4d9e8b]
MessageLoop::RunInternal() [0x50222b]
MessageLoop::RunHandler() [0x5020de]
MessageLoop::Run() [0x501af9]
TestCompletionCallback::WaitForResult() [0x4d1681]
TestCompletionCallback::GetResult() [0x4d16e6]
(anonymous namespace)::TimeWrite() [0x4136cc]
DiskCacheTest_CacheBackendPerformance_Test::TestBody() [0x41407b]
testing::internal::HandleSehExceptionsInMethodIfSupported<>() [0x588785]
testing::internal::HandleExceptionsInMethodIfSupported<>() [0x585206]
testing::Test::Run() [0x579066]
testing::TestInfo::Run() [0x57988a]
testing::TestCase::Run() [0x579f80]
testing::internal::UnitTestImpl::RunAllTests() [0x57ed57]
BUG=None
TEST=net_perftests
Review URL: http://codereview.chromium.org/7001028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't checking that XOpenDisplay was actually succeeding before
attempting to use the display.
BUG=82308
TEST=none
Review URL: http://codereview.chromium.org/7015007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65953
TEST=Compiles on Clang.
TBR=thakis
Review URL: http://codereview.chromium.org/7014016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85137 0039d316-1c4b-4281-b951-d872f2087c98
|