| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113477
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugins display alerts via the NPN_Evaluate API. The browser signals an event handle to ensure that the plugin starts peeking for messages while waiting for the NPN_Evaluate call to return. When the dialog is dismissed by the user, windows does send some messages to the plugin window underneath, like activation messages, etc. These don't get dispatched as the event is reset when the dialog is dismissed, i.e. much before the window is actually
destroyed.
The fix is to reset the event handle after the window is actually destroyed. To achieve this I added an OnClose virtual function to the DialogDelegate interface, which is overridden by the JavascriptMessageBoxDialog class which eventually ensures that the event is reset.
This fixes http://code.google.com/p/chromium/issues/detail?id=10799
I updated the AlertInWindowMessage npapi test to display two alerts instead of one.
Bug=10799
Review URL: http://codereview.chromium.org/113464
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
connect will ever return 0, and therefore we don't know if the
event object will be signaled in that case.
R=rvargas
http://crbug.com/9258
TEST=N/A
Review URL: http://codereview.chromium.org/113474
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=abarth
BUG=11909
TEST=0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
can accurately log the original test url.
Review URL: http://codereview.chromium.org/113379
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few new baselines for tests.
R=levin
BUG=0
TEST=0
Review URL: http://codereview.chromium.org/115407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113470
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113468
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jcampan
TEST=The whole CL is a test. :)
Review URL: http://codereview.chromium.org/113446
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
move around when resizing the window.
BUG=11900
TEST=Open the 'Show saved passwords' dialog in the Minor Tweaks pane. Resize the window, the buttons (i.e Remove) should not move.
Review URL: http://codereview.chromium.org/115393
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10738,10748
Review URL: http://codereview.chromium.org/115392
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=10502
Review URL: http://codereview.chromium.org/87047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I noticed this issue is caused by the IMF_AUTOKEYBOARD option of a RichEdit control, an option that allows a RichEdit control to automatically change the input language with a selection. (An omnibox changes a selection to display a styled text.) A RichEdit control automatically turns on the IMF_AUTOKEYBOARD option when we input an RTL character and start changing the input language with a selection. So, this change checks the IMF_AUTOKEYBOARD option and disable it before decorating a text to prevent it from changing the input language while decorating a text.
BUG=11683 "RTL: IME changes when writing a Hebrew character inside an English string in the omnibox"
TEST=Change the input language to English, type "abcd" in an omnibox, change the input language to Hebrew, type an 'a' key, and verify the input language is Hebrew.
Review URL: http://codereview.chromium.org/113394
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
failing on the buildbot).
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that were minor pixel changes (or major ones that bring us closer to webkit
mac results) have been rebaselined. The rest have been sorted by
probable cause and assigned bugs.
glyph-orientation-rounding-test.xhtml is from http://crbug.com/11502, whose
crash I couldn't reproduce (seems to be also passing on the buildbots).
Review URL: http://codereview.chromium.org/113416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113450
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11066
Review URL: http://codereview.chromium.org/113406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rename files too.
TBR=brettw
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Haven't hooked this up to anything yet though. Still trying to figure out the best way to shut everything down, so I figured I'd send this easy part out alone.
Review URL: http://codereview.chromium.org/113376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=11200
R=aa,rafaelw
http://codereview.chromium.org/115250
Review URL: http://codereview.chromium.org/113442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tests!
TBR=jcampan
BUG=http://crbug.com/8782
Review URL: http://codereview.chromium.org/115389
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
never return NULL when we get a certificate error.
R=wtc
BUG=11646
TEST=access https://www.cdep.ro/
Review URL: http://codereview.chromium.org/113330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gyp change.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113431
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
gtk side yet.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113424
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Does not rename the files yet.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move resource.h to app.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also changed the name of all the SDCH histograms so that
there would be no confusion about the data.
I also added one new problem code, but that recordation
doesn't have any semantic impact. I added it to help
make it easier to diagnose dictionary specification
errors in SDCH.
bug=12012
R=wtc
Review URL: http://codereview.chromium.org/115377
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to fix bug 8551.
http://crbug.com/8551
TEST=Launch Chrome with '--lang=fr' (or switch your spellcheck language to French).
In an textarea, type a paragraph of random text. Quit chrome or change the
spellcheck language to English. Chrome should not crash.
TBR=sidchat
Review URL: http://codereview.chromium.org/115390
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: http://codereview.chromium.org/112027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the content.
Review URL: http://codereview.chromium.org/109031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
entry titles or by making the window narrow enough to truncate the
text.
BUG=9712
TEST=Bookmark a page and go to the history page. Resize the window so
that it is narrow enough to truncate the entry title of the page you
just bookmarked. You still be able to see the star icon.
Review URL: http://codereview.chromium.org/113434
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
default button (for which
GetDialogButtonLabel returns an empty string), the width is always set to kDialogMinButtonWidth. It's sufficiently large for 'Ok', 'Close' and 'Cancel' in most languages, but not large enough for some
languages. For those languages, this CL sets the button width to max(preferred_width, kDialogMinButtoWidth),
the former of which is calculated using the translated strings for Ok/Close/Cancel.
This needs to be merged to 2.0 branch (the location of views has moved from under chrome\ to the top-level
source directory in the trunk)
http://crbug.com/11710
TEST: Start Chrome with '--lang=ml' cmd line flag. Open up the option dialog and see 'Close' button
at the bottom is large enough for the label ('Close' in Malayalam) and some space around it.
Review URL: http://codereview.chromium.org/113250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The linux crash fix to test shell (r16119) seems to have fixed this
crash on the mac.
TBR=evan
Review URL: http://codereview.chromium.org/113429
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are testing the opacity values of iframes. E.g., the
first test loads a lime green background (#00ff00). Over
the background, it loads a black iframe with 50% opacity. With
skia, we end up with a green color of (#008000). The upstream
expected result has a different green (#0e6c00) with an embedded
color profile. When I load the png in the gime and appy the
color profile, I get (#007c00).
I think the difference is just the color profile and that skia is
doing the right thing.
BUG=11933
Review URL: http://codereview.chromium.org/115386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/114030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115387
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113427
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
square brackets around an IPv6 literal address. Rename
the method HostNoBrackets() to be consistent with GURL's
new HostNoBrackets() method.
When resolving an address, use the new HostNoBrackets()
method instead of host().
Part of this changelist was contributed by Paul Marks
of Google.
Original review: http://codereview.chromium.org/115342
R=eroman
http://crbug.com/12005
TEST=covered by new test cases in unit test
Review URL: http://codereview.chromium.org/114029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
app/gfx/gtk_utils.h
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115382
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
but the rest is unchanged.
Review URL: http://codereview.chromium.org/115384
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
A rare combination of events results in there being no last committed
entry. Adding a NULL check prevents the crash.
BUG=11935
Review URL: http://codereview.chromium.org/113419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16119 0039d316-1c4b-4281-b951-d872f2087c98
|