summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Rebaseline LayoutTests/editing/selection/select-all-iframe.html which Ojan ↵tc@google.com2009-02-263-6/+5
| | | | | | | | | | | | changed upstream. Defer new tests. Fix wdiff to have deletes be red and new lines be green (it was reversed). Review URL: http://codereview.chromium.org/28213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10531 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where bookmark bar would appear all black. Actually,sky@google.com2009-02-263-23/+9
| | | | | | | | | | | | | | it wasn't that the bookmark bar was all black, rather that BrowserView thought the bookmark bar was parented when in fact it wasn't. The black was the result of BrowserView reserving the space for the bookmark bar and not painting anything in it's space. BUG=7922 TEST=see bug Review URL: http://codereview.chromium.org/28191 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10530 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce new id format (hex str of sha-1)erikkay@google.com2009-02-268-27/+34
| | | | | | Review URL: http://codereview.chromium.org/27236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10529 0039d316-1c4b-4281-b951-d872f2087c98
* Make importer.cc compile on Posix.jhawkins@chromium.org2009-02-265-8/+36
| | | | | | Review URL: http://codereview.chromium.org/27242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10528 0039d316-1c4b-4281-b951-d872f2087c98
* Add some missing files to net.gyp.ericroman@google.com2009-02-261-0/+5
| | | | | | | | | This corresponds with <http://codereview.chromium.org/28049>. BUG=2764 Review URL: http://codereview.chromium.org/28220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10526 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where the flattened HTML file was not gettingtc@google.com2009-02-261-4/+3
| | | | | | | | | included in data pack files. Review URL: http://codereview.chromium.org/28222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a NOTIMPLEMENTED() in l10n_util.cc from it expecting .dll in the file name.evan@chromium.org2009-02-261-11/+13
| | | | | | | | While I'm at it, remove references to .dll in comments in the file. Review URL: http://codereview.chromium.org/27223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10524 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: support displays without Xrender support.agl@chromium.org2009-02-265-9/+151
| | | | | | | | | | | VNC servers don't support Xrender. For this use case, we implement a slow fallback which byte-fiddles the Skia bitmaps as needed to support 32 and 24 bit visuals. Review URL: http://codereview.chromium.org/27227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10523 0039d316-1c4b-4281-b951-d872f2087c98
* 9 more layout tests taken off the pile.finnur@google.com2009-02-2622-27/+363
| | | | | | | | | | | | | | | | | | | | | | | | | | | The tests below have had their baseline changed upstream and we need to follow suit (see diffs in review folder): -LayoutTests/fast/events/offsetX-offsetY.html -LayoutTests/editing/selection/select-from-textfield-outwards.html -LayoutTests/editing/selection/select-missing-image.html NOTE: For the last test above, we now match the mac baseline so I just removed our text baseline. New tests that just needed to be baselined (only differ in font metrics): -LayoutTests/fast/lists/list-marker-with-line-height.html -LayoutTests/fast/overflow/overflow-float-stacking.html -LayoutTests/fast/overflow/overflow-stacking.html -LayoutTests/fast/replaced/embed-display-none.html -LayoutTests/fast/replaced/applet-display-none.html -LayoutTests/fast/replaced/object-display-none.html Review URL: http://codereview.chromium.org/28211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10522 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "ASCII <-> UTF16 conversion functions. These are just copies ↵kuchhal@chromium.org2009-02-262-8/+29
| | | | | | | | | | | of WideToASCII and"" This reverts commit 25b05025dae174c94e6de74fa697a3338175f957. Review URL: http://codereview.chromium.org/27243 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10521 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test to DelayTimer ensure that the callback is neveragl@chromium.org2009-02-262-0/+34
| | | | | | | | | made once the DelayTimer has been destroyed. Review URL: http://codereview.chromium.org/27234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10520 0039d316-1c4b-4281-b951-d872f2087c98
* fix the grd scanner to only include files that we're usingtc@google.com2009-02-261-5/+2
| | | | | | | | | bug=8139 Review URL: http://codereview.chromium.org/28225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10519 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FileVersionInfo NOTIMPLEMENTED()s into a bug.evan@chromium.org2009-02-261-25/+5
| | | | | | Review URL: http://codereview.chromium.org/27232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10518 0039d316-1c4b-4281-b951-d872f2087c98
* Revert brett's code, for real this time.nsylvain@chromium.org2009-02-265-43/+31
| | | | | | Review URL: http://codereview.chromium.org/28224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10517 0039d316-1c4b-4281-b951-d872f2087c98
* Fix scons build where the internal theme files don't exist.tc@google.com2009-02-261-1/+6
| | | | | | | Review URL: http://codereview.chromium.org/28218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10515 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "ASCII <-> UTF16 conversion functions. These are just copies of ↵kuchhal@chromium.org2009-02-262-29/+8
| | | | | | | | | WideToASCII and" Review URL: http://codereview.chromium.org/28217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10512 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old comment. TBR=kuchhaljam@chromium.org2009-02-261-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10508 0039d316-1c4b-4281-b951-d872f2087c98
* Fix BrowserTest.ThirtyFourTabs and possibly other ui tests in single-process ↵jam@chromium.org2009-02-262-5/+9
| | | | | | | | mode. The problem was that RenderProcess was being destructed on both threads at the same time because of the scoped_ptr. Review URL: http://codereview.chromium.org/27228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10507 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r10487 toomark@chromium.org2009-02-2613-43/+37
| | | | | | Review URL: http://codereview.chromium.org/28209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10506 0039d316-1c4b-4281-b951-d872f2087c98
* Attempting backout of r10495 due to ui_tests:mark@chromium.org2009-02-261-1/+0
| | | | | | | | | | ResourceDispatcherTest.CrossSiteAfterCrash PageLoadTest.Reliability CrashRecoveryUITest.Reload CrashRecoveryUITest.LoadInNewTab Review URL: http://codereview.chromium.org/28208 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10505 0039d316-1c4b-4281-b951-d872f2087c98
* This CL addresses several issues with focus in application mode:jcampan@chromium.org2009-02-263-2/+6
| | | | | | | | | | | | | - when started, the focus was not on the page (it was on the location bar, which is not shown) - ALT-F4 would not work at that point since the location bar was focused but not showing - since the location bar was focusable, tabbing through would focus it (causing the focus to go to the top window). BUG=8124,6046,8126 TEST=See bugs. R=sky Review URL: http://codereview.chromium.org/28202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10504 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file extension from r10491.jhawkins@chromium.org2009-02-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/28203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10503 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so windows opened from links in Windows Live Messenger cause the ↵ben@chromium.org2009-02-262-4/+9
| | | | | | | | | | | | | | | window to appear instead of being invisible. The discovery is that Windows enforces that you call ShowWindow with the value of STARTUPINFO's wShowWindow field first before calling it with any other value, otherwise all subsequent calls are ignored. I used to have code that flattened the return value of a function into something that would ensure the window is visible, but what I actually needed to do was show the window twice in this case. Ick. http://crbug.com/3126 TEST=Have someone send you a link in a Windows Live Messenger window, click it without Chrome running (Chrome must be default browser), and a Chrome window should appear, visible, loading the link. Also try running chrome.exe from bash to make sure that still works. Review URL: http://codereview.chromium.org/27190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10502 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused variable that came from r10497 which breaks compile on Linux.jhawkins@chromium.org2009-02-261-1/+0
| | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/31012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10501 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change made in http://codereview.chromium.org/10925.mad@chromium.org2009-02-261-9/+4
| | | | | | | | | | It was mistakenly resting the wrong iterator, so I also renamed the outer one to avoid confusion. BUG=2569 Review URL: http://codereview.chromium.org/28200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10500 0039d316-1c4b-4281-b951-d872f2087c98
* Fix incorrect map usage in the WebPluginImpl::didReceiveData function, which ↵ananta@chromium.org2009-02-261-3/+5
| | | | | | | | | | | | | | | | | | caused a response to be incorrectly treated as a multipart response. This would eventually end up sending the ViewHostMsg_DidStopLoading IPC to the browser, which would treat the page as loaded, when it has not. This fixes http://code.google.com/p/chromium/issues/detail?id=7916, which would cause the favicon to not show up on trunk. Bug=7916 Review URL: http://codereview.chromium.org/28199 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10499 0039d316-1c4b-4281-b951-d872f2087c98
* Bugify another NOTIMPLMENTED.evan@chromium.org2009-02-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10498 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up inspector highlighting again. This time we useojan@google.com2009-02-267-32/+11
| | | | | | | | | upstream's drawNodeHighlight methods. BUG=5178 Review URL: http://codereview.chromium.org/31010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10497 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit tests.brettw@chromium.org2009-02-261-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grit include dependencies in the scons build.tc@google.com2009-02-263-19/+55
| | | | | | | | | | | | | | | Re-enable the scons code that walks a grd file and adds its dependencies as build dependencies. This requires that all our dependencies are files in our source tree (which is what motivated getting rid of the tld data as a generated resource). I had to fix up the terms of service for this. Also remove some code that disabled .pak file generation on windows which was broken because it couldn't find the tld data. Review URL: http://codereview.chromium.org/28194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10494 0039d316-1c4b-4281-b951-d872f2087c98
* ASCII <-> UTF16 conversion functions. These are just copies of WideToASCII anddarin@chromium.org2009-02-262-8/+29
| | | | | | | | | | ASCIIToWide but they work with string16 instead of wstring. R=brettw Review URL: http://codereview.chromium.org/28189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10493 0039d316-1c4b-4281-b951-d872f2087c98
* Add a missing header from r10487.jhawkins@chromium.org2009-02-261-0/+1
| | | | | | TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10492 0039d316-1c4b-4281-b951-d872f2087c98
* Update tests_fixable.txt to match current buildbot results for Linux and ↵jhawkins@chromium.org2009-02-261-5/+5
| | | | | | | | | Win. Adds a crash regression from the latest merge for Linux. TBR=estade Review URL: http://codereview.chromium.org/28197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10491 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 8063: Find-in-page remains open on History/Downloads page.finnur@google.com2009-02-263-6/+48
| | | | | | | | | | Added a UI test to catch this in the future. Also, in some of the UI tests I added a generic URL for pages that don't care about the content of the page and are just testing visibility of the Find box, etc. TEST=Covered by tests already. BUG=8063 Review URL: http://codereview.chromium.org/28162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10490 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing crash in StartFinding (2nd attempt).finnur@google.com2009-02-261-4/+6
| | | | | | | | | | | | | | | | | | | | The first attempt to fix this was unsuccessful and crashes showed up again during the automated ui testing. I still can't reproduce locally, but when I look again at the crash dump I think that the fact that it looked like the FindBarView was destroyed is misleading and the real issue is the same as with the crash in StopFinding (that web_contents has been destroyed moments before we receive the request). I am therefore removing the code I added earlier and replacing it with a null check for web_contents. TEST=Covered by automated ui tests. BUG=8048 Review URL: http://codereview.chromium.org/27219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10489 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the following:jcampan@chromium.org2009-02-263-6/+10
| | | | | | | | | | | | | | When restoring a session, the browser is shown after a tab is selected causing the focus to be on the location bar (not tab contents for web pages). This CL ensures the tab decides where the focus should be after the browser is shown. BUG=6000 TEST=See bug R=sky Review URL: http://codereview.chromium.org/28156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10488 0039d316-1c4b-4281-b951-d872f2087c98
* More URL constants replacement.brettw@chromium.org2009-02-2618-44/+62
| | | | | | Review URL: http://codereview.chromium.org/28170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10487 0039d316-1c4b-4281-b951-d872f2087c98
* Remove view_source_contents.cc from the porting list as this file was ↵jhawkins@chromium.org2009-02-261-1/+0
| | | | | | | | | removed in r10346. TBR=brettw Review URL: http://codereview.chromium.org/28195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10486 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent the display of the resize corner bitmap on top of the download shelf ↵mad@chromium.org2009-02-261-5/+14
| | | | | | | | | when the browser window is maximized. BUG=8025 Review URL: http://codereview.chromium.org/28168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10485 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix XRENDER support for NXagl@chromium.org2009-02-261-2/+7
| | | | | | | | | | | | | | | The NX X server doesn't support xRGB32 XRENDER picture formats. So, if we don't find one of those formats, fall back on ARGB32, which is fine, except that the X server will spend time dealing with an alpha channel which is all 254 or 255. ARGB32 support is required by the XRENDER spec. (This doesn't fix VNC, a patch for that is forthcoming.) Review URL: http://codereview.chromium.org/28192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10484 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the base64 stop sign graphic and use CSS instead. (R=agl)evan@chromium.org2009-02-261-13/+18
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in extension install.erikkay@google.com2009-02-261-1/+11
| | | | | | Review URL: http://codereview.chromium.org/27215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10482 0039d316-1c4b-4281-b951-d872f2087c98
* remove chrome_kjs.sln and related filestc@google.com2009-02-264-3346/+0
| | | | | | | Review URL: http://codereview.chromium.org/28169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10481 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary include. Also add copyright to the new files.tc@google.com2009-02-263-3/+8
| | | | | | | Review URL: http://codereview.chromium.org/28127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10480 0039d316-1c4b-4281-b951-d872f2087c98
* properly initialize resource manager on mac for unittests.thomasvl@chromium.org2009-02-262-12/+30
| | | | | | Review URL: http://codereview.chromium.org/28185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10479 0039d316-1c4b-4281-b951-d872f2087c98
* Handle repack.py and .pak files in the GYP-based build.mark@chromium.org2009-02-262-3/+74
| | | | | | Review URL: http://codereview.chromium.org/27216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10478 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability for tree model to reorder its children. I'm going to usesky@google.com2009-02-263-15/+68
| | | | | | | | | | | this when sorting the contents of a bookmark folder. BUG=1750 TEST=none Review URL: http://codereview.chromium.org/28175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10477 0039d316-1c4b-4281-b951-d872f2087c98
* Do not map virtual keycodes (VK_0 - VK_9) to characters when accelerators in ↵jungshik@google.com2009-02-261-2/+11
| | | | | | | | | | | | | | | the UI. If we do that, the result is the layout-dependent. For instance, in fr-FR layout, we get 'a with grave' in place of '0' for Ctrl+0 (normal in Zoom menu). Besides, in Slovak lazout, we get 'e with accent' This CL does not affect the actual behavior of accelerators (see issue 8043 for that), but only change the way they're displayed in the menu (even without this CL, ctrl-0 works fine in fr-FR AZERY layout and Slovak layout). BUG=7444 TEST=Change your kbd layout to French Azery and see what key is shown next to 'Normal' in Page-Zoom menu. It should be 'Ctrl+0'. Review URL: http://codereview.chromium.org/28121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10476 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling ThirtyFourTabs test.kuchhal@chromium.org2009-02-261-2/+2
| | | | | | | | | | TBR=jam BUG=8119 Review URL: http://codereview.chromium.org/28190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10475 0039d316-1c4b-4281-b951-d872f2087c98
* Make render_view_context_menu.cc compile on Posix.jhawkins@chromium.org2009-02-266-10/+45
| | | | | | Review URL: http://codereview.chromium.org/27193 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10474 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 01:55:16 +0000