| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SO_REUSEADDR is useful for server sockets to bind to a recently unbound port. When a socket is closed, the end point changes its state to TIME_WAIT and wait for 2 MSL (maximum segment lifetime) to ensure the remote peer acknowledges its closure. For server sockets, it is usually safe to bind to a TIME_WAIT end point immediately, which is a widely adopted behavior.
On Linux SO_REUSEADDR does not enable the TCP socket to bind to an end point that is already bound by another socket. To do that one must set SO_REUSEPORT instead.
However, on Windows, SO_REUSEADDR works as if both SO_REUSEDPORT and SO_REUSEADDR are set. Furthermore, A bound end point can be hijacked by another process by setting SO_REUSEADDR. Therefore a Windows-only option SO_EXCLUSIVEADDRUSE was introduced in Windows NT 4.0 SP4. If the socket that is bound to the end point has SO_EXCLUSIVEADDRUSE enabled, it is not possible for another socket to forcibly bind to the end point until the end point is unbound. Also, unlike on *nix, on Windows a TCP server socket can always bind to an end point in TIME_WAIT state without setting SO_REUSEADDR, therefore we cannot emulate a similar behavior of disabling SO_REUSEADDR here.
This is considered a security issue and MSDN (http://goo.gl/M6fjQ) recommends all server applications to use SO_EXCLUSIVEADDRUSE.
BUG=173533
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15179003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thic change moves...
- DriveFileSyncService
- DriveMetadataStore
- LocalSyncOperationResolver
- RemoteSyncOperationResolver
- RemoteChangeHandler
- some utilities
BUG=252100
TEST=should pass all existing tests
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18647010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unit_tests
R=hidehiko@chromium.org
Review URL: https://codereview.chromium.org/18068009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As a first step, I added a method for returning the default crash dump location
and use this on all three platforms.
BUG=247431
R=thestig@chromium.org,joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18341002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exploratory CL to cause new windows created as the result of a drag operation to be sized according to the restored window bounds. This applies to the "detach into new window while dragging" code path used by Aura, not the "make a semi-transparent preview window while dragging codepath" used on non-Aura Windows.
Also, always position tabs of such new windows to the left of the tabstrip. If this isn't done, then when dragging a tab from the right of a maximized window, the tab will be placed beyond the bounds of the restored window.
BUG=175448
TEST=Maximize a window in WinAura, then drag tabs off it.
Review URL: https://chromiumcodereview.appspot.com/17724003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is for removing the dependency to content/ from c/b/google_apis/ and
moving the directory content to top level google_apis/.
BUG=256109
Review URL: https://chromiumcodereview.appspot.com/18659002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
start/end.
BUG=241474
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/18614005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=230257
Review URL: https://chromiumcodereview.appspot.com/18560007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make GL_ASYNC_READ_PIXELS_COMPLETED_CHROMIUM wait for readpixel transfers.
PLEASE NOTE: glMapBuffer does not wait for the readpixels transfer to complete anymore.
Nobody is currently relying on that behaviour.
Update gl_helper.cc and gl_renderer.cc to use queries.
This CL is the same as https://codereview.chromium.org/16831004/
but includes fixes for:
OutOfProcessPPAPITests.Graphics3D (removed a check in query_tracker.cc)
GLReadbackTest.ReadPixelsWithPBO (removed, no longer a valid test)
GLReadbackTest.ReadPixelsWithPBOAndQuery (now uses the correct query)
BUG=249925
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209873
Review URL: https://chromiumcodereview.appspot.com/18555006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplifies SourceState initialization and removes code
that routes buffers through ChunkDemuxer on their way to
ChunkDemuxerStream. This is the first in a series of
changes to move the SourceBufferStreams from
ChunkDemuxerStream to SourceState.
BUG=239506
TESTS=All existing unittests and LayoutTests still pass.
Review URL: https://chromiumcodereview.appspot.com/18501010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=browser_tests --gtest_filter=AutofillDialogControllerTest
TBR=groby@chromium.org,tedchoc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18500013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Unsurprisingly, verifying details about the stack doesn't work too well if Valgrind creates a different stack for your program.
BUG=256941
Review URL: https://chromiumcodereview.appspot.com/18328027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Custom wallpapers are now specified via command-line flags.
BUG=248764
Review URL: https://chromiumcodereview.appspot.com/18298009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed when wrapping file descriptors in NaCl, since it changes
the behavior of the descriptor. Other open flags aren't needed, since those
only make sense when the file is opened, which should have already happened.
BUG=194304
Review URL: https://chromiumcodereview.appspot.com/18264002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we install stripped binaries in APKs, print out object file names and relocatable addresses that can be used on the host machine to complete symbolizing and demangling the stack trace using unstripped binaries.
In addition the implementation of StackTrace::PrintBacktrace() was changed to log the stack trace instead of sending SIGSTKFLT.
BUG=248775, 248784
Review URL: https://chromiumcodereview.appspot.com/16770006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/18259013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some methods lacked comments, the .cc order was not the same as the .h
file order, and the method order didn't follow a logic that I could
follow. Now I've fixed the method order, and reordered things roughly
into a big-picture-to-little-picture order. I also added comments
describing each method, and shortened overly long comments.
I'm doing this in preparation for the generational patch; I found the
files hard to edit without this.
R=pasko
BUG=None
Review URL: https://chromiumcodereview.appspot.com/18233014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL depends on
https://codereview.chromium.org/18570002/
BUG=238755
R=kbr@chromium.org, senorblanco@chromium.org, marcheu@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/18125009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FileSystem deletion (reset) should only work for sandboxed
filesystems, and the method must not be on the generic
FileSystemMountPointProvider interface.
BUG=241701
TEST=manual (devtools -> delete root -> see the filesystem goes away), layout tests
NOTRY=true
R=satorux@chromium.org, tzik@chromium.org, vandebo@chromium.org
Review URL: https://codereview.chromium.org/18586006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash when starting an app with an app shim for a profile
that is not yet loaded. ExtensionAppShimHandler now cancels the shim
launch, loads the profile asynchronously and launches the app when the
profile is ready. The existing behavior will start the shim when the
app activates.
BUG=168080
TEST=Make sure there are multiple profiles.
Switch to profile A and close all other windows.
Restart Chrome, only profile A should be open.
Start an app belonging to profile B with its shim.
The app should start without crashing.
Review URL: https://chromiumcodereview.appspot.com/16972014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac.
ResourceDispatcherHostBrowserTest.SyncXMLHttpRequest_DuringUnload just started timing out consistently on two bots:
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%281%29/builds/42253
http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/13928
See the bug for more info
BUG=56264
TEST=Test disabled, tree green.
TBR=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/18664002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this fix we hit a DCHECK in the ctor of AudioTimestampHelper that
bytes_per_frame > 0.
BUG=233420
TEST=none
Review URL: https://chromiumcodereview.appspot.com/18656003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
override all the builtins to pass. It slows down startup, so be minimal.
BUG=252984
R=jyasskin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18580006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::Closure
BUG=None
TEST=chromeos_unittests
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/18609003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also change how we compute the title bounds, which provides better vertical
centering for popup window titles.
This broke due to panels changes crrev.com/183369 and crrev.com/157042
BUG=257068
TEST=added ash_unittests FramePainterTest.TitleIconAlignment
Review URL: https://chromiumcodereview.appspot.com/18652005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/18514003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestingProfile was only being used in order to retrieve a
net::TestURLRequestContextGetter. google_apis tests can do this themselves
using a combination of MessageLoop and MessageLoopProxy.
This one more step forward on moving these tests to a google_apis_unittests
target.
BUG=255301
TEST=unit_tests
R=joi@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If |is_video_encrypted_| is true, always request a protected surface from MediaPlayerManager.
If manager denies the request, playback will fail. Otherwise, SetVideoSurface(surface, true) will be called later.
TBR=sievers@chromium.org
BUG=163552
Review URL: https://chromiumcodereview.appspot.com/18591002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This abstracts away RectangleUpdateDecoder's direct use of the the former class. It will ease the development of non--Web app client implementations.
BUG=255309
TBR=brettw (third_party/webrtc dependency)
Review URL: https://chromiumcodereview.appspot.com/18233015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=166165
Test=WebViewInteractiveTest.NewWindow_Close
Review URL: https://chromiumcodereview.appspot.com/18280003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome://extensions page.
BUG=255374
Review URL: https://chromiumcodereview.appspot.com/18272024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Reduced the size of quick menu buttons and increased the margin, so that
buttons do not overlap the corners.
BUG=256767
Review URL: https://chromiumcodereview.appspot.com/18486004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalDomainResolver unit tests are failing due to
https://codereview.chromium.org/17922002/. Fix them by adding a StartListening
call to the test.
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18164005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently CopyFromCompositingSurface does an async texture readback of
current_surface_ which depends on the renderer compositor sending
textures to the browser compositor. Under ubercomp, however, the
current_surface_ will not exist.
The cc/ compositor now supports async readback of layers. This uses the
new mechanism to get the contents of the RWHVA's ui::Layer instead which
is always available. The result of this readback can be a texture or a
bitmap (when using software compositing). The result read by the
compositor will already be cropped.
If the result is a texture, we use the GLHelper to scale the result to
the desired size. If it is a bitmap, we use skia::ImageOperations::Resize
to do the same.
R=piman
BUG=162291
Review URL: https://chromiumcodereview.appspot.com/17971002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is the pages themselves that are incompatible with our deterministic JS shim,
not the measurements. This became obvious for the tough_canvas_cases.json page
set which isn't compatible with deterministic JS. However, it is run with the
smoothness_measurement which runs against other page sets that require
deterministic JS (like top_25).
BUG=257212
TEST=tools/perf/run_measurement --browser=system robohornetpro
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/18595005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=224684
Review URL: https://chromiumcodereview.appspot.com/18615002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
roll has brought in the new baselines.
TBR=crogers@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/18441004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Minor shaders clean up.
>
> R=reveman
>
> Review URL: https://chromiumcodereview.appspot.com/18164006
TBR=skaslev@chromium.org
Review URL: https://codereview.chromium.org/18658002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This converts some floating point math to integer math
to avoid rounding errors.
- Assigns last_tick_time_ to be the time it was *supposed*
to tick and no longer uses it as a synonym for "now".
- Adds trace events to help debug when the interval or
phase changes.
BUG=256650
Review URL: https://chromiumcodereview.appspot.com/18589002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows Cocoa UI code outside of chrome/browser to use it.
This is a precursor to http://crrev.com/18326006
BUG=138633
TEST=No functional changes.
Review URL: https://chromiumcodereview.appspot.com/18355002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- A recent change to compositor broke the rasterize_and_record_benchmark,
because tiles were created before the LayerTreeImpl's source_frame_number
was updated.
- Switching the order of these operations fixes the problem.
BUG=226489
R=enne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18233022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tile needs the raster mode and tile priority, which are
currently included via raster_worker_pool, which is included
by the tile manager. Since tile at the layer's level, it really
shouldn't include raster worker pool at any point.
This patch moves raster mode and tile priority to a separate
tile data file. This would also be a good spot for combining
content_rect and contents_scale into TileRect (which is something
I'd like to do)
BUG=253972
Review URL: https://chromiumcodereview.appspot.com/17625002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
The previous version of the test would just create the print preview dialog it is checking for if the dialog was not created already.
Review URL: https://chromiumcodereview.appspot.com/18422004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=248359
Review URL: https://chromiumcodereview.appspot.com/18647003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Implemented comments from wtc in CL https://chromiumcodereview.appspot.com/17385010/#ps170001 (Patch Set 12).
R=wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18033005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=152006
Review URL: https://chromiumcodereview.appspot.com/18271002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is added to handle layout margins in all Android versions.
BUG=
Review URL: https://chromiumcodereview.appspot.com/18444002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Based on request in:
https://chromiumcodereview.appspot.com/15675024
BUG=178915
Review URL: https://chromiumcodereview.appspot.com/17648003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210092 0039d316-1c4b-4281-b951-d872f2087c98
|