summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Disable DirectoryLister.* on TSan/Mactimurrrr@chromium.org2010-03-221-0/+4
| | | | | | | | BUG=38926 TBR=glider Review URL: http://codereview.chromium.org/1142009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42242 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup testing objects.vandebo@chromium.org2010-03-221-13/+13
| | | | | | | | | BUG=NONE TEST=Heapchecker errors eliminated Review URL: http://codereview.chromium.org/1108004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42241 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame net tests would crash on startup while initializing the ↵ananta@chromium.org2010-03-221-1/+4
| | | | | | | | | | | | | extensions service. The crash occured while dereferencing a NULL manifest. Fix is to check for the same and avoid initializing the extension if we don't have a manifest. TBR=aa Review URL: http://codereview.chromium.org/1107013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42240 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus.", rev 42234 and ↵maruel@chromium.org2010-03-2240-807/+52
| | | | | | | | | | 42236. TBR=dmazzoni Review URL: http://codereview.chromium.org/1158004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42239 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit test to check for zero length dir in FTP PWD response. inferno@chromium.org2010-03-221-0/+11
| | | | | | | | BUG=38845 TEST=FtpNetworkTransactionTest.ZeroLengthDirInPWD Review URL: http://codereview.chromium.org/1166001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in Mac mergedmazzoni@chromium.org2010-03-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42236 0039d316-1c4b-4281-b951-d872f2087c98
* Extended the suppression for 30547 (leak destroying BookmarkModel)glider@chromium.org2010-03-221-1/+19
| | | | | | | | | | | | Suppressed bug 38895 (leaks in KeywordEditorView::SetColumnValues) Suppressed bug 18698 (leak in IPC::ChannelProxy::Context::OnAddFilter) BUG=30547,38895,18698 TBR=timurrrr Review URL: http://codereview.chromium.org/1157004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42235 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2240-52/+807
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42234 0039d316-1c4b-4281-b951-d872f2087c98
* Update expectations for xpdual/moz/vm_peak_*.chase@chromium.org2010-03-221-2/+2
| | | | | | | | | | | | | | | There was a vm_peak_* improvement recently, possibly caused by WebKit roll in r42192, 56306:56312, but more likely due to an infrastructure change made by maruel around r42200. BUG=none TEST=moz perf step is green TBR=nsylvain@chromium.org Review URL: http://codereview.chromium.org/1142008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42233 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dependency on layout_package.path utils from the heapcheck runnerglider@chromium.org2010-03-222-14/+4
| | | | | | | | | | (see http://codereview.chromium.org/669031) TBR=timurrrr,dpranke Review URL: http://codereview.chromium.org/1167001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42232 0039d316-1c4b-4281-b951-d872f2087c98
* Implement SOCKSClientSocketPoolvandebo@chromium.org2010-03-2225-262/+1183
| | | | | | | | | | | | | | This is the first layered pool, so there are several infrastructure changes in this change as well. Add a ConnectionTimeout method to pools so that layered pools can timeout each phase. Add a name method to pools to support per pool UMA histograms. Change SOCKS sockets to take a ClientSocketHandle instead of a ClientSocket BUG=30357 (blocks an SSL Pool) TEST=existing unit tests Review URL: http://codereview.chromium.org/668097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42231 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the raw history backend pointer to the gmock action rather than the refptr.skrul@chromium.org2010-03-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1072009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42230 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug with native text field where if there's a visibility change, the ↵chocobo@chromium.org2010-03-223-26/+18
| | | | | | | | | | native control gets recreated without updating the properties. For chromeos login, the password field becomes a normal textfield. BUG=chromeos:2023 TEST=during login, we should not show the password in the clear. Review URL: http://codereview.chromium.org/1076008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42229 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the order of the context menu in the tabbed bookmark manager.arv@chromium.org2010-03-221-3/+5
| | | | | | | | | | | | | | | The "Delete" menu item should be right after the "Paste" menu item. As it's in the bookmarks bar and in the old bookmarks manager. BUG=None TEST=open the tabbed bookmarks manager and see if the "Delete" menu item is right after the "Paste". Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1159001 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42228 0039d316-1c4b-4281-b951-d872f2087c98
* Merging the translate manager UMA stats from the 249 branch to the trunk.jcampan@chromium.org2010-03-222-0/+11
| | | | | | | | | | | | Original review: http://codereview.chromium.org/853010 BUG=None TEST=None TBR=kuan Review URL: http://codereview.chromium.org/1111006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42227 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r41641 "Make DevTools open docked by default..."xiyuan@chromium.org2010-03-2211-415/+144
| | | | | | | | | | | | | | - Fix DevToolsSanityTest time out. The timeout is because the tests wait for Browser closed notification. However, docked DevTools does not have its own Browser object and hence the wait times out. BUG=none TEST=none Review URL: http://codereview.chromium.org/1025005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42226 0039d316-1c4b-4281-b951-d872f2087c98
* Command-click on a bookmark folder button will now open all injrg@chromium.org2010-03-222-11/+73
| | | | | | | | | | | | | | | | background tabs. BUG=34288 TEST=\ 1) Make sure normal clicking will open bookmarks, bookmark folders. 2) Make sure right-click opens context menus on folders 3) command-click a folder --> opens all the marks in that folder in background tabs Review URL: http://codereview.chromium.org/1115004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42225 0039d316-1c4b-4281-b951-d872f2087c98
* Move importer data types into a separate file to prepare for moving importermirandac@chromium.org2010-03-2240-241/+359
| | | | | | | | | | into its own process. BUG= 18774 TEST= none Review URL: http://codereview.chromium.org/1110005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42224 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the memory leaks in RSAPrivateKeyUnitTest.* and glider@chromium.org2010-03-222-0/+17
| | | | | | | | | | SignatureCreatorTest.BasicTest. BUG=34742 TBR=wtc Review URL: http://codereview.chromium.org/1117007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42223 0039d316-1c4b-4281-b951-d872f2087c98
* Make SDCH experiment significant on the dev channel populationjar@chromium.org2010-03-221-2/+2
| | | | | | | | | | | | | The experiment was reduced to a low level to avoid impacing much of the standard release population. Now that we've adjusted the definition of the page-load-time metrics, I'd like to see the results of the experiment, and I need a larger participation rate to be visible on the dev channel. r=willchan Review URL: http://codereview.chromium.org/1162001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42222 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the extensions service after fixing the bug.phajdan.jr@chromium.org2010-03-221-17/+1
| | | | | | | | | | | | | This removes excessive debugging code I added to gather more info about the crashes. They have now disappeared, and the checks obscure the code now. TEST=extension browser tests, unit_tests, etc BUG=30405 Review URL: http://codereview.chromium.org/1078006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42221 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.1.7.whesse@chromium.org2010-03-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1155007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42220 0039d316-1c4b-4281-b951-d872f2087c98
* Filtered out ExtensionTest.InitFromValueInvalid from being executed underglider@chromium.org2010-03-221-0/+3
| | | | | | | | | | | ThreadSanitizer on Mac BUG=38889 TBR=timurrrr Review URL: http://codereview.chromium.org/1111009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42219 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Keyboard accessibility for the page and app menus."maruel@chromium.org2010-03-2240-811/+52
| | | | | | | | | | This reverts commit 42217. TBR=dmzazzoni Review URL: http://codereview.chromium.org/1154003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42218 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-2240-52/+811
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42217 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the IPCChannelTest.ChannelProxyTest suppression to match broken stacks.glider@chromium.org2010-03-221-1/+1
| | | | | | | | TBR=timurrrr Review URL: http://codereview.chromium.org/1163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42216 0039d316-1c4b-4281-b951-d872f2087c98
* Disables temporarily IFramesWithFreshPosition.bulach@chromium.org2010-03-221-1/+3
| | | | | | Review URL: http://codereview.chromium.org/1082009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42215 0039d316-1c4b-4281-b951-d872f2087c98
* Disables Geolocation tests for macbulach@chromium.org2010-03-221-2/+11
| | | | | | | | | | (follow on up http://codereview.chromium.org/1134001) TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1149007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42214 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce number of automation methods ending with WithTimeout.phajdan.jr@chromium.org2010-03-2224-473/+157
| | | | | | | | | | | | | | | | | | | | | They are just too easy to misuse. People started inventing their own hardcoded timeouts all over the place. Also, the is_timeout return parameter was not checked consistently. Additionally, some calls actually had no timeout at all, making hangs possible. This change also removes useless DLOG statements. We should get the required info from the ASSERT/EXPECT macros in test code, which is quite well checked by WARN_UNUSED_RESULT. TEST=all ui-based BUG=none Review URL: http://codereview.chromium.org/1076005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42213 0039d316-1c4b-4281-b951-d872f2087c98
* Adds browser tests exercising multiple iframes for geolocation.bulach@chromium.org2010-03-223-20/+129
| | | | | | | | | | Adds a disabled test waiting for rolling https://bugs.webkit.org/show_bug.cgi?id=36315 TEST=geolocation_browsertest.cc Review URL: http://codereview.chromium.org/1134001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42212 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] GTM role to pick up a newer GTM that include a workaround for when ↵thomasvl@chromium.org2010-03-221-1/+1
| | | | | | | | | | | Cocoa lies on sizing checkboxes. TBR=pinkerton BUG=37743 TEST=en startup wrapps correctly Review URL: http://codereview.chromium.org/1092006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42211 0039d316-1c4b-4281-b951-d872f2087c98
* tweak translate infobar uikuan@chromium.org2010-03-223-25/+57
| | | | | | | | | | | | | | | | - remove button from options menu and only show it on hover - allow MenuButton to be created with or without border for normal state - make font size and color of all labels, buttons and dropdowns black and medium font respectively - extract creation of label into private function to reduce code - use new special image for all menu drop arrows - modify base class MenuButton's menu_marker_ image to a non-const and allow it to be set BUG=38296 TEST=verify per bug report. Review URL: http://codereview.chromium.org/1150002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42210 0039d316-1c4b-4281-b951-d872f2087c98
* Annotated the known leak in TestServerLauncher::LoadTestRootCertglider@chromium.org2010-03-222-0/+12
| | | | | | | TBR=wtc Review URL: http://codereview.chromium.org/1155001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42209 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for developer-reported crash.aa@chromium.org2010-03-221-0/+3
| | | | | | | | | | Following bug instructions, the only crash I could reproduce was this timer-related one. TBR=erikkay@chromium.org BUG=35815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42207 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: For now only import data from the uploaded form.jhawkins@chromium.org2010-03-221-1/+5
| | | | | | | BUG=38104 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42206 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the out-of-bounds array read in the ftp response.inferno@chromium.org2010-03-221-1/+1
| | | | | | | | BUG=38845 TEST=Pass a ftp server response having two double quotes with no character in between and verify no browser crash happens. Review URL: http://codereview.chromium.org/1082008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42204 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to force a buildmaruel@chromium.org2010-03-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42200 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WindowGetViewBounds bustage... I had the sense of this conditional inverted.ben@chromium.org2010-03-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42193 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 56306:56312.dglazkov@chromium.org2010-03-211-1/+1
| | | | | | | | | | TBR=dpranke TEST=rarely BUG=verily Review URL: http://codereview.chromium.org/1142006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42192 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: More transitions to thunk definition macros.erg@chromium.org2010-03-208-371/+229
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1118005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42191 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Roll 56272:56306.dglazkov@chromium.org2010-03-202-2850/+6
| | | | | | | | | | | | Switch over to use test_expectations upstream. TBR=dpranke TEST=never BUG=often Review URL: http://codereview.chromium.org/1093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42190 0039d316-1c4b-4281-b951-d872f2087c98
* When testing, we don't want to know about 'component' or 'external'joi@chromium.org2010-03-202-2/+11
| | | | | | | | | | | | extensions, and if there are loaded extensions we probably loaded them explicitly (and got a notification thereof) so don't list them either. BUG=none TEST=none Review URL: http://codereview.chromium.org/1081008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42189 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 359.0 to 360.0chrome-release@google.com2010-03-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42185 0039d316-1c4b-4281-b951-d872f2087c98
* fix mac bustage by adding NL to end of fileben@chromium.org2010-03-201-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42183 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-20101-812/+915
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* 2 experiments: DNS prefetch limit concurrency: TCP split a packetjar@chromium.org2010-03-204-13/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some firewalls apparently try to preclude a "syn flood to host" by limiting the number of syn's (used to open a TCP/IP socket) that are outstanding without having received a syn-ack. Presumably this is to prevent a user from participating in a syn-flood attack (which traditional sends a lot of syn packets, with false return addresses, resulting in no responses). Apparently this firewall technology has in some cases been extended to include UDP sessions for which there has been no response, and this may include DNS resolutions. Since the prefetcher currently resolves as many as 8 names simultaneously, this is remarkably close to the reported threshold of 10 un-answered connections. This test attempts to limit connections to 2, 4, or 6, so that we can see if this helps users. In TCP, the RTO remains (under windows) at a full 3 seconds until after the first ack is received. As a result, if the first data packet sent (after the SYN) is lost, then TCP won't resend until after 3 seconds without an ack. As a test, we split up the first packet into two parts (the second part containing only one byte). This is done as an A/B test, and we'll see if we get a measurable improvement in page-load-time latency. Finally, to get better page load stats, I adjusted the PLT histograms so that we record a "final" time for abandoned pages when they are closed (even if they didn't finish rendering, etc.). This should give a much more fair PLT comparison for all network latency experiments. BUG=3041 BUG=12754 r=mbelshe,darin Review URL: http://codereview.chromium.org/1088002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42181 0039d316-1c4b-4281-b951-d872f2087c98
* Bump GYP dep to get fixes for escaping/quoting in 'defines'.tschmelcher@chromium.org2010-03-201-1/+1
| | | | | | | | | TEST=built on Linux BUG=none Review URL: http://codereview.chromium.org/1125005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42180 0039d316-1c4b-4281-b951-d872f2087c98
* Disable backup connect jobs for all pools except TCPClientSocketPoolvandebo@chromium.org2010-03-204-14/+16
| | | | | | | | | BUG=36629 TEST=net_unittests Review URL: http://codereview.chromium.org/1120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42179 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42156, r42157, r42160. Allow dynamic switching in and out of ↵thestig@chromium.org2010-03-2034-341/+59
| | | | | | | | | | | | sidetabs mode. Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1141005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42176 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: link with --as-needed to eliminate direct dependencies on 15 shared ↵tschmelcher@chromium.org2010-03-191-6/+20
| | | | | | | | | | | libraries that we don't actually use. TEST=built on Linux and ran it BUG=none Review URL: http://codereview.chromium.org/1072008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42173 0039d316-1c4b-4281-b951-d872f2087c98