| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
| |
bots due to a gyp/incredibuild issue.
Review URL: http://codereview.chromium.org/1109008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=temporary
Review URL: http://codereview.chromium.org/1140002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We keep track of which plugins we've already considered loading,
and skip them if we encounter them again. This situation is common
on Linux where people have many different symlinks pointing to the
same plugin.
BUG=38764
TEST=See bug for bad output without this patch; output with this patch is now good.
Review URL: http://codereview.chromium.org/1149005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=38575
TEST=Valgrind Linux goes green.
Review URL: http://codereview.chromium.org/1096007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Second try with the following changes:
- Remove FLAKY_ from Feed tests and makes sure they pass.
BUG=4890,38609
TEST=browser_test.exe
Run Chrome, Press Ctrl+Shift+B. The new bookmark manager should open in a tab.
Review URL: http://codereview.chromium.org/1127006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38611
TEST=Built the mini_installer and verified that the files are in chrome.7z.
Review URL: http://codereview.chromium.org/1082006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=srsly
Review URL: http://codereview.chromium.org/1095006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14184
TEST=see bug
Review URL: http://codereview.chromium.org/1105006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the panel)
so that a user can delete multiple notification by clicking mouse on the same position.
BUG=33306
TEST=none. I will add tests next week.
Review URL: http://codereview.chromium.org/1147003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of gdk gdk itself maintains the mask to apply and ends up blowing away
our request for property change events. Using gdk_set_events doesn't
seem to have this problem.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1076007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1001003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36587
TEST=Open an incognito window and open the Downloads page for it. Now download something in the OTR window. The item should show up in the downloads page but it should be lighter and have a OTR icon background.
Review URL: http://codereview.chromium.org/1126005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file.
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
BUG=30850
Review URL: http://codereview.chromium.org/541022
TBR=vandebo@chromium.org
Review URL: http://codereview.chromium.org/1145004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=521
TEST=none
Review URL: http://codereview.chromium.org/1079007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If one tries to upload a file that one doesn't have read access to,
the browser livelocks. It tries to read from the file, gets nothing
but spins forever because it knows that it hasn't finished reading.
To address this, firstly we add a check at stat() time to make sure
that we can read the file. However, this doesn't take care of the case
where the access() call was incorrect, or the permissions have changed
under us. In this case, we replace the missing file with NULs.
BUG=30850
Review URL: http://codereview.chromium.org/541022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=12673,20459,20504
TEST=Valgrind Mac UI tests go green.
Review URL: http://codereview.chromium.org/1107009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/1084012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
We now guarantee the server cert is verified before sending a client cert.
BUG=38550
TEST=none (manual testing with five different public sites that use client certs)
Review URL: http://codereview.chromium.org/1116003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
chromium-linux-fontconfig-renderstyle.html to work.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1075010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
so that they don't include the name 'app'.
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=38704,38706
TEST=none
Review URL: http://codereview.chromium.org/1079008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37100
TEST=added new ui test
Review URL: http://codereview.chromium.org/1047006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35248
TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard.
Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"):
out/Debug/chrome --login-manager --login-screen=network
Review URL: http://codereview.chromium.org/1148003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
trunk/tools/dashboards.
TBR=ojan
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog. If the user has opened the dialog, AutoFill is implicitly enabled.
BUG=38538
TEST=none
Review URL: http://codereview.chromium.org/1077003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1142001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This undoes r42117 as I figured out what was going on.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=thestig
BUG=38694
TEST=none
Review URL: http://codereview.chromium.org/1137002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1155002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from the sync engine rather than waiting for "a couple syncs" to happen
before declaring sync "done".
BUG=37351
Review URL: http://codereview.chromium.org/1042008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=open login dialog, type in password, and click on the lock image to toggle showing password.
Review URL: http://codereview.chromium.org/1113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
failing under Valgrind.
TBR=thestig
BUG=38657
TEST=none
Review URL: http://codereview.chromium.org/1105005
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/1124004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1085004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark import approach.
BUG=32728
TEST=existing test passes
Review URL: http://codereview.chromium.org/1122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
No functional change (but I have a functional change to follow this).
Review URL: http://codereview.chromium.org/1115006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=9619
TEST=open AccExplorer.exe, open bookmarks manager dialog, point it to the search Textfield (edit box)
and see it if has the correct information for role (editable text), name (the label within it's connected) and state (read only).
Review URL: http://codereview.chromium.org/1058002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Continuation of http://codereview.chromium.org/875004 after a revert.
BUG=http://crbug.com/12673
TEST=run out of memory and die
Review URL: http://codereview.chromium.org/1039007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=it was
Review URL: http://codereview.chromium.org/1083004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed kNumBytesToSniff in 41687, it was left behind.
Contributed by tonyg@chromium.org
(original review http://codereview.chromium.org/1111003/show)
BUG=15314
TEST=There is no clear way to test this, ideas?
Review URL: http://codereview.chromium.org/1153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1109007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
warning about json support.
Use filter=1 to remove false and null data
TEST=presubmit check passes
BUG=none
Review URL: http://codereview.chromium.org/1156001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1142002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1089005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
thread, then being sent a notification after it was deleted.
BUG=38374
Review URL: http://codereview.chromium.org/995007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=japhet
TEST=none
BUG=inexplicably
Review URL: http://codereview.chromium.org/1117004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when we are likely to be missing intermediate CA certificates.
Work around the SEC_ERROR_POLICY_VALIDATION_FAILED error from
CERT_PKIXVerifyCert by retrying CERT_PKIXVerifyCert with the
certificate policy in the certificate.
Map SEC_ERROR_POLICY_VALIDATION_FAILED to ERR_CERT_INVALID
if we can't work around the error.
Start the migration away from test_certificate_data.h to the
certificate files in the src/net/data/ssl/certificates
directory.
R=eroman
BUG=31497,30891,37549
TEST=A new unit test. To verify the fix for issue 31497
manually, must install the "DoD Root CA 2" certificate first
(see comment 9 of bug 31497).
Review URL: http://codereview.chromium.org/545103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42118 0039d316-1c4b-4281-b951-d872f2087c98
|