| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
DriveResourceMetadata::GetEntryInfoByResourceId() was called twice.
BUG=143873
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/10911132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a window is removed from the root-window, and some descendant window of
the removed window is set as a target in the gesture-recognizer, then the
GR needs to be reset to remove this from the target list.
BUG=146970
Review URL: https://chromiumcodereview.appspot.com/10918114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10915112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10911118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll see if original code works for Windoes as well as it doesn't use win specific api.
TBR=derat@chromium.org
BUG=145173
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10918121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
First cut of the long awaited feature. There is no undo but there is a (quite out of style) confirmation dialog.
BUG=129717
Review URL: https://chromiumcodereview.appspot.com/10909095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=grt
Review URL: https://chromiumcodereview.appspot.com/10911150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=144152
Review URL: https://chromiumcodereview.appspot.com/10910109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=146106
TEST=Verify app name is spoken when selected in accessibility mode.
R=dmazzoni@chromium.org,sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10908126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unit_tests target in chrome_tests.gypi.
The other one (https://chromiumcodereview.appspot.com/10914118), switched to Windows-only at the last minute, but was added in the wrong place. That didn't make anything fail, but simply didn't solve the problem either...
TBR=thakis@chromium.org
NOTRY=True
BUG=146769
TEST=Run unit_tests.exe --gtest_filter=ProfileShortcutManagerTest* with a branding=Chrome build.
Review URL: https://chromiumcodereview.appspot.com/10908134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=derat@chromium.org
BUG=145173
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10910133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
matches the enterprise domain of the device.
BUG=chromium-os:33879
Review URL: https://chromiumcodereview.appspot.com/10868076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66884
Review URL: https://chromiumcodereview.appspot.com/10907109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=oshima@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10910132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds tests that have been renamed / added:
https://chromiumcodereview.appspot.com/10826257
The original suppresion was added by:
https://chromiumcodereview.appspot.com/9104002
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10909121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This file contains the "package-specific" documentation and generates
documentation for each tool with their module docstring.
Rename shard.py to shard_test_cases.py to stay consistent with the
naming convention.
R=csharp@chromium.org
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/10909118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Compilation on iOS was broken by CL https://chromiumcodereview.appspot.com/10874077.
net.gyp was trying to build files depending on v8 on iOS, which is not possible.
This CL properly excludes v8-related files from iOS builds of net.
BUG=137800
Review URL: https://chromiumcodereview.appspot.com/10919071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=145173
TEST=manual. see bug for repro step.
Review URL: https://chromiumcodereview.appspot.com/10916121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10907087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
move methods not in install_worker.h to the unnamed namespace
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10914126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
error codes can be returned. Where applicable, convert net errors to base platform errors.
Compile error:
../../webkit/fileapi/local_file_system_test_helper.cc:180:76:error: too few arguments to function call, expected 2, have 1
file_system_context_->CreateFileSystemOperation(CreateURL(FilePath())));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../webkit/fileapi/file_system_context.h:132:3: note: 'CreateFileSystemOperation' declared here
FileSystemOperation* CreateFileSystemOperation(
^
http://build.chromium.org/p/chromium.memory/builders/Mac%20ASAN%20Builder/builds/4001/steps/compile/logs/stdio#error1
BUG=141617
TBR=tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10920087
TBR=calvinlo@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10928052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/10911105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be returned. Where applicable, convert net errors to base platform errors.
BUG=141617
TBR=tony@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10920087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Specifically "ALTERNATE" caused a conflict problem on Windows build.
BUG=146809
Review URL: https://chromiumcodereview.appspot.com/10918101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ALso fix a clang issue.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10928045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=145854
Review URL: https://chromiumcodereview.appspot.com/10914043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146228
Review URL: https://chromiumcodereview.appspot.com/10907043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
already implemented for GTK and Views (r154927).
Overview of .xib changes:
Increased the height of the dialog.
Added a link [Manage Shortcuts] in the bottom right corner of the bubble.
BUG=145951
TEST=Install an extension with an extension command and verify the [Manage Shortcuts] link appears.
Review URL: https://chromiumcodereview.appspot.com/10914098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We were losing .5 in integer division :/
TEST=manual
BUG=144545
Review URL: https://chromiumcodereview.appspot.com/10918107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DCHECKs.
We were using last_sync_session_end_time, which would effectively allow config jobs to cancel nudges that were scheduled to start before the config ended. There was code to reset the start time of nudges to hack around this, (which is removed in this patch) which was pretty confusing because after executing
if (scheduled_start < Now())
scheduled_start = Now();
scheduled_start is less than Now() again. This check was purely to get around the freshness check (AFAICT), and I think the new code is clearer. It also affects the Sync.Freq histogram, see bug for detail.
The integration tests also caught the fact that we weren't checking Succeeded() before updating that time, which means failed jobs could have caused legitimate nudges to be cancelled -- note this probably wasn't a big problem in practice due to the hack mentioned above. We now check Succeeded().
This also adds a few DCHECKs for situations that were previously unsupported but would technically squeak through. For example, there's a DCHECK in ScheduleConfiguration that there is no pending config job, but that situation could have arisen if we swapped to NORMAL_MODE and back before the config job executed -- in fact, one of the tests was doing this, but it's clearly unsupported.
Also fixes an issue with test_util::SimulateSuccess where we would not set ModelNeutralState results for config jobs, which meant that in some cases, tests would *not* reset wait_interval_ on successful backoff relief. The changes to the test file now ensure this can't regress.
BUG=143595
Review URL: https://chromiumcodereview.appspot.com/10825439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146840
Review URL: https://chromiumcodereview.appspot.com/10914124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename StringOrdinal to Ordinal, move it to sync/, and templatize it.
Make StringOrdinal be an instantiation of Ordinal that matches its
previous behavior.
Create NodeOrdinal, which is another instantiation of Ordinal for
the ordinal_in_parent field in SyncEntity.
Rework Ordinal to handle arbitrary byte ranges and to simplify the
interpolation code a bit.
Generalize StringOrdinal unit tests for Ordinal.
Update users of StringOrdinal to prepend syncer::.
BUG=145412
TBR=estade@chromium.org,jianli@chromium.org,brettw@chromium.org,
Review URL: https://chromiumcodereview.appspot.com/10920017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115047
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10915137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=146606
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10918090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The HTTP-based Public Key Pinning Internet Draft
(tools.ietf.org/html/draft-ietf-websec-key-pinning) requires this.
Per wtc, give the *Fingeprint* types more meaningful *HashValue* names.
Cleaning up lint along the way.
BUG=117914
TEST=net_unittests, unit_tests TransportSecurityPersisterTest
Review URL: https://chromiumcodereview.appspot.com/10826257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://build.chromium.org/p/chromium/builders/Win7%20Sync/builds/25157/steps/sync_integration_tests/logs/stdio .
Specifically:
Sendin[1920:3900:0907/000156:407089812:FATAL:url_request_context.cc(99)] Check failed: false. Leaked 2 URLRequest(s). First URL: https://www.google.com/cloudprint/search?requestor=chrome-to-mobile.
[1920:3900:0907/000156:407089812:FATAL:url_request_context.cc(99)] Check failed: false. Leaked 2 URLRequest(s). First URL: https://www.google.com/cloudprint/search?requestor=chrome-to-mobile.
My suspicion is that by increasing retries, it ended up that a request was still going when the browser is shutting down.
Verify that these requests are being properly stopped/destroyed before the context they are using goes away.
------
Increase kMaxRetries for URLFetcher to 5 (common elsewhere).
Decrease kDelayHours for URLFetcher to 1hr (w/exp backoff).
Clear |access_token_| with new kGaiaOAuth2LoginAccessToken.
Clear |access_token_| *and devices* on OnGetTokenFailure().
Handle invalid login refresh tokens as OnGetTokenFailure().
Clear token, devices, retry on 403 (auth) search responses.
Add and log some new BAD_* UMA Metric enum values.
(407 related to Issue 146685 and perhaps Issue 137267)
LOG (Chrome, not UMA) send response data on failure.
Corresponding src/tools/histograms/histograms.xml change:
https://chromereviews.googleplex.com/4782033
BUG=102709,120941,146685
TEST=Less Chrome To Mobile failures, additional insightful logging.
Review URL: https://chromiumcodereview.appspot.com/10913089
TBR=msw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10909115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused sync failures:
http://build.chromium.org/p/chromium/buildstatus?builder=Win7%20Sync&number=25157
http://build.chromium.org/p/chromium/buildstatus?builder=Mac10.6%20Sync&number=21887
http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29&number=20966
Original review URL: https://chromiumcodereview.appspot.com/10907100
TBR=fsamuel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10907113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
printing/backend/cups_helper.cc wasn't compiling on Linux with gcc 4.6.
TBR=gene
Review URL: https://chromiumcodereview.appspot.com/10905147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bigger icons. Rest of items should use default margins.
BUG=125307
Review URL: https://chromiumcodereview.appspot.com/10905111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some unlucky users have been hit by issue 142587. They're crashing on
startup because their database has a next_id value that leads them to
reuse client IDs that have already been committed to the server.
This patch will cause all users, not just those affected by the bug, to
increment their next_id values once. This will be harmless for those
not affected by the bug. Those who were affected will skip past the
already used IDs and start using new IDs.
Note that r152706 ensures users are guaranteed to no longer enter into
this state. Otherwise, this one-time fix to move users out of the buggy
state would be insufficient to fix the bug.
BUG=142587
Review URL: https://chromiumcodereview.appspot.com/10919112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=bauerb@chromium.org
BUG=139028
Review URL: https://chromiumcodereview.appspot.com/10832089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Android API needs to be able to insert and retrieve arbitrary favicons from the history backend.
http://codereview.chromium.org/10891007/ changed the API such that it returns favicons resized to 16x16 which broke the API.
This changes GetRawFaviconForID to return unresized favicons and renames the method to GetLargestRawFaviconForID.
Bug=145799
Test=SQLiteCursorTest passes
Review URL: https://chromiumcodereview.appspot.com/10916144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=138333
TEST=Ran new unittest
Review URL: https://chromiumcodereview.appspot.com/10826026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
state, persistence, temporariness, or save page.
Also change some callers from SearchDownloads() over to GetAllDownloads().
This is an experiment in preparation for DownloadHistory-that-is-an-Observer, which removes the persisted concept from content. http://codereview.chromium.org/10665049/
I tried to inspect each caller in this CL to check that it would be ok with this change, but I might have missed something.
Reviewers breakdown:
Done:
rdsmith: *
jam: chrome/browser/automation
michaeln: chrome/browser/browsing_data
jcivelli: content/public/test
Review URL: https://chromiumcodereview.appspot.com/10913015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146754
Review URL: https://chromiumcodereview.appspot.com/10908128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=120950
Review URL: https://chromiumcodereview.appspot.com/10909090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dtu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10916136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
R=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10910115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155347 0039d316-1c4b-4281-b951-d872f2087c98
|