| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build and Unittests
Review URL: http://codereview.chromium.org/1995008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window class in DllMain on attach and tag it with our module handle, then unregister said window class on detach.
BUG=43343
Review URL: http://codereview.chromium.org/1994007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync. Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."
BUG=maybe in chrome OS tracker?
TEST=build chrome OS. log in to chrome OS with a new account. Immediately check wrench>options>personal stuff. It should not say "your account is not set up to sync..."
Review URL: http://codereview.chromium.org/2023004
TBR=dantasse@chromium.org
Review URL: http://codereview.chromium.org/2049002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excerpt from: http://codereview.chromium.org/1991004/show
----------------
Put version information into header file for easy consumption by RC files.
RC files can use an #include to pull in this header, rather than being each
dynamically generated.
BUG=none
TEST=none
----------------
Review URL: http://codereview.chromium.org/2020003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When you first logged in to Chrome OS, it used to say "your account is not set up to sync" until you downloaded the initial sync. Now it follows the regular sync signup flow where it's "account details are not yet entered" until the authentication happens, then it's "setup in progress" while downloading the initial download, then it's "your account is set up to sync."
BUG=maybe in chrome OS tracker?
TEST=build chrome OS. log in to chrome OS with a new account. Immediately check wrench->options->personal stuff. It should not say "your account is not set up to sync..."
Review URL: http://codereview.chromium.org/2023004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for instrumenting Chrome and Chrome Frame for performance measurements with ETW.
BUG=none
TEST=Unittests in this CL.
Review URL: http://codereview.chromium.org/2020002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=jhawkins
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1979005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42645
TEST=Existing plugin tests continue to pass; nothing should change.
Review URL: http://codereview.chromium.org/2011005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43347
TEST=included
Review URL: http://codereview.chromium.org/2003006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=43347
TEST=included
Review URL: http://codereview.chromium.org/2048002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it so that the code carefully shuffled rects, points, and sizes
through the right conversions as it moves from view coordinates to
screen coordinates (to position the popup).
This only really comes up when you're debuggin whether your pretty
scalable PDF graphics really work by using Quartz Debug to set the
scale factor to 3 or something.
BUG=40999
TEST=See bug
Review URL: http://codereview.chromium.org/2028004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1969004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Reduce the rate at which we upload UMA stats.
r=laforge
Review URL: http://codereview.chromium.org/1999003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The interface (for perf reasons) snapshots the histogram
name, and reuses it in future calls. As a result, any attempt
to modulate (change) the name between call is ignored.
This change uses a DCHECK to detect such abuse.
BUG=43377
BUG=43375
r=vandebo
Review URL: http://codereview.chromium.org/2019001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more unit tests for Delete.
BUG=42374
TEST=included
Review URL: http://codereview.chromium.org/1763008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugzilla.redhat.com/show_bug.cgi?id=581256
The SELinux policy doesn't let chrome_sandbox touch other processes' oom_adj
and we're spamming the log.
(See comments in the patch for details)
http://codereview.chromium.org/2005006/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4ab711db8ace2106fea6a95e12d2da6fbe4f78f7.
TBR=tommi
Review URL: http://codereview.chromium.org/2014004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46723 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
themselves, navigate to other pages in the same extension, persist their
state using # after the URL, etc.
TEST=write an extension that reloads its page action pop-up (e.g. on a button click), see that before this change it does not work, after it does
BUG=none
Review URL: http://codereview.chromium.org/1947002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=34176
TEST=none
Review URL: http://codereview.chromium.org/1794009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flaky instead of disabled. Add the corresponding bug to the comment.
BUG=43586
TEST=none
Review URL: http://codereview.chromium.org/1979004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=jhawkins
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1985008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac OS X uses a fixed default stack size of 512kB, which is too small for some
purposes. glibc on Linux uses ulimit -s, which is both a more reasonable thing
to do, and is generally set to a rational limit, such as 8MB.
BUG=43422
TEST=None really on the trunk. On the Mac 375 branch, using the .pac file on
the bug, Chrome should not crash on startup.
Review URL: http://codereview.chromium.org/2035007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We cache and suppress sending progress notifications till
we get the first OnDataAvailable. This is to prevent
mshtml from making up its mind about the mime type.
However, this is the invasive part of the patch and
could trip other software that's due to mistimed progress
notifications. It is probably not good to hide redirect
and some cookie notifications.
We only need to suppress data notifications like
BINDSTATUS_MIMETYPEAVAILABLE,
BINDSTATUS_CACHEFILENAMEAVAILABLE etc.
This is an atempt to reduce the exposure by starting to
cache only when we receive one of the interesting progress
notification.
BUG=42611
TEST=none
Review URL: http://codereview.chromium.org/2046003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than for every
item in a WriteTransaction originals array, and make sure to restore items into dirty_metahandles
on save changes failure to avoid data loss.
This prevents a situation where after a SaveChanges, a "clean" (not dirty) item will pass the
SafeToPurgeFromMemory filter because is_dirty is false, but it is in fact still in dirty_metahandles,
and we yank it from metahandles_index. This causes a crash later on as GetByHandle will return NULL
for items in this boat. The other part of this fix makes sure we don't lose a bookmark change on
browser restart due to a single sqlite operation failing during SaveChanges by restoring items into the
dirty index.
BUG=43047,40341
Review URL: http://codereview.chromium.org/2043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46712 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/1735018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
implementation is a copy of the WebKit code, I will figure out how to reuse it soon.
Review URL: http://codereview.chromium.org/2011004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of using #if 0.
TBR=maruel
TEST=none
BUG=10611
Review URL: http://codereview.chromium.org/1990007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=johnnyg
Review URL: http://codereview.chromium.org/2040004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
out.
BUG=43434
TEST=Verify the splitted tests no longer flakily times out on try bots and build bots.
Review URL: http://codereview.chromium.org/2040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change GetHistory time value from int to float to keep precision.
BUG=none
TEST=run pyautolib
Review URL: http://codereview.chromium.org/2036004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure "bookmarks go here" text goes away when adding the 1st
bookmark (and comes back when deleting the last one).
When deleting the last item from an "off the side menu" (which would
cause the "off the side" chevron button to go away), close that menu.
Make sure the "off the side" button is deleted in the autorelease
pool, like all other buttons, in case "just one more" event is about to come in.
This is an attempt at fixing the top Mac browser crash.
BUG=43345,43501,43502
TEST=\
1)
New profile.
Open bookmark bar --> see "bookmarks go here"
Add bookmark --> text goes away
Delete bookmark --> text comes back.
2)
Add enough bookmarks so the "off the side" menu just barely appears.
Open the off the side menu, and right click --> delete the bookmark.
Expect to see the menu go away and the off-the-side button to go away.
Review URL: http://codereview.chromium.org/2025002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
interleaved.
BUG=31737
TEST=none
Review URL: http://codereview.chromium.org/1921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
accidentally match an ignored field instead of matching a field we care about.
BUG=43260
TEST=FormStructureTest.HeuristicsStateWithProvince
Review URL: http://codereview.chromium.org/2006005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(Reviewed by dumi.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/1985006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Widen the regexp for Expiration Month.
* DCHECK that the number of fields matches between the FormStructure and the FormData results.
* Remove the awful N^2 loop that was too paranoid now that we verify the field counts are the same.
BUG=43365
TEST=CreditCardFieldTest.*,AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/2048003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is using the gpu process for painting its contents so that the browser will stop rendering from its own backing surface. This will currently only trigger if a page
uses the accelerated compositing path.
This patch can only land _after_ https://bugs.webkit.org/show_bug.cgi?id=38220
BUG=42677
TEST=NONE
Review URL: http://codereview.chromium.org/1696014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46697 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This time reference the external bug number.
Bug=none
Test=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This one was really easy, since they weren't even used.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/2042004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
with app tabs).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2043003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=arv
Review URL: http://codereview.chromium.org/1989006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/2012004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exceeds test timeout.
TBR=jcivelli
TEST=none
BUG=43575
Review URL: http://codereview.chromium.org/2019004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1980005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
closed (the browser's current tab instead of the app launcher's one).
This was causing a crasher with the context menu and possibly way more
bad things.
BUG=43480
TEST=See bug
Review URL: http://codereview.chromium.org/1979002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the NavigateToRestrictedSite
test is behind the console window.
Fix is to not attempt to close the dialog by clicking on it. We now close the window by the DoClosewindow
helper which posts the WM_CLOSE message to it.
TBR=amit
Review URL: http://codereview.chromium.org/2041003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently only set focus to the widget's hWnd, but we really want
to also notify assistive technologies that a child view received focus
so that it can know to obtain an IAccessible for that custom child
view using the widget hWnd. The widget hWnd has our implementation of
IAccessible through AccessibilityWrapper/ViewAccessibility.
Original code review: http://codereview.chromium.org/1985002
BUG=43363
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data segment.
Change logging_win to use same.
BUG=none
TEST=Unittests in this change.
Review URL: http://codereview.chromium.org/2023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46686 0039d316-1c4b-4281-b951-d872f2087c98
|