| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
| |
BUG=103433
TEST=none
TBR=yusukes
Review URL: http://codereview.chromium.org/8495028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This behaviour breaks IncognitoModeAvailability policy in case the latter
is set to "Incognito forced". The changelist aims to fix this problem:
when the above described situation is encountered, neither Bookmark manager
nor Settings page are opened. Besides that, it disables menu items that
open the mentioned pages.
BUG=97677
TEST=chrome/browser/ui/browser_navigator_browsertest.cc
Review URL: http://codereview.chromium.org/8342067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
REASON_ENCRYPTION and REASON_DECRYPTION should both result in the user
being prompted for a passphrase if encrypted datatypes are enabled. Modified
IsPassphraseRequiredForDecryption to account for this (and added todo to rename
it). Currently REASON_ENCRYPTION will never result in the user being prompted
for a passphrase, even if we know the user has encrypted datatypes they will
not be able to encrypt.
In addition, we should only ever need to unblock the DTM if an encrypted type
is enabled. In that case, the passphrase must have been accepted. Cases where
encrypted datatypes are not enabled (which is the only way we accept not having a
valid passphrase now) do not need to unblock the DTM, and if the user disables
an encrypted type it will trigger a reconfiguration organically.
Because we can only automatically enter a passphrase twice (for the two cached
passphrases), and only one of these will succeed anyways, we no longer have the
possibility of infinite configuration loops.
BUG=102757
TEST=Manually forcing a migration on the same sync cycle
we are downloading a new datatype doesn't trigger infinite sync loops.
Review URL: http://codereview.chromium.org/8423066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broken by r109069.
TBR=stevenjb@chromium.org
BUG=103427
TEST=
Review URL: http://codereview.chromium.org/8501020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8496025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
iterator).
BUG=
TEST=ValuesTest.DictionaryIterator
Review URL: http://codereview.chromium.org/8351059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8503029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:21435
TEST=verify per bug rpt.
Review URL: http://codereview.chromium.org/8496017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r7109: (pdox) Stop building and merging llvm-gcc. Remove old libgcc_eh build script.
r7110: (bsy) zero out memory of sbrk region.
r7111: (mcgrathr) Remove weak references in startup code, always use __libc_{init,fini}_array
r7112: (krasin) Update PNaCl UPSTREAM_REV to 43e0e25ca86f
r7113: (mcgrathr) Update chrome_rev
r7114: (jvoung) First cut at a case-by-case calling convention test. This tests passing
r7115: (krasin) Remove llvmgcc frontend support from SCons.
BUG=none
TEST=nacl_integration
Review URL: http://codereview.chromium.org/8492026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:100732
TEST=Launch ChromeOS and go the the system settings page. Adjust the screen brightness using the buttons on the display. Test that the rate of change of screen brightness is appropriate. Known issue that the screen can be made too dark.
Review URL: http://codereview.chromium.org/8479014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103318
TEST=
Review URL: http://codereview.chromium.org/8502007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
moving them from #ifdef'ed code in LocationBarView behind OmniboxView.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8457006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8498023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium:100392,chromium:102139
TEST=
Review URL: http://codereview.chromium.org/8495018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Objects may be added to the JavaBridgeDispatcherHostManager before any
RenderViewHosts are present. This means that we need to take a reference to the
object to keep it alive until a RenderViewHost becomes present.
Also adds a method to TabContents to access the JavaBridgeDispatcherHostManager.
BUG=96703
Review URL: http://codereview.chromium.org/8501007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This pyautolib-based test verifies the fix for https://bugs.webkit.org/show_bug.cgi?id=70974 by preparing a database, starting a VERSION_CHANGE transaction, crashing the browser mid-transaction, then validating that nothing was committed.
BUG=98562
TEST=python chrome/test/functional/indexeddb.py
Review URL: http://codereview.chromium.org/8341092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103183
TEST=none
Review URL: http://codereview.chromium.org/8496004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change takes advantage of recent refactoring and adds support for
Elf X86 32 executables to courgette. It should have no effect on handling
of Windows PE executables.
We have planned ahead to be able to restrict the code size of the courgette
library in different cases to reduce patcher sizes, but this change does
not yet take advantage of that (all platforms are supported everywhere).
Also, the patcher class currently contains a very small amount of Elf/PE
specific code for recreating relocation tables that cannot (currently) be
compiled out.
BUG=chromium-os:22149
TEST=Please verify that Chrome/Chromium patches can still be generated and
work.
Also, please see how much the updater executable which is downloaded to
users has changed in size since R16.
Review URL: http://codereview.chromium.org/8477045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
#ifdef'ed code in LocationBarView behind OmniboxView.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8457006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8357030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=103406
TEST=none
TBR=zelidrag
Review URL: http://codereview.chromium.org/8498021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no plan to switch to using gclient's From() syntax: it is
considered obsolete. I have a script (nacl_deps_bump.py) which
automates the chore of updating these derived revisions in DEPS
instead.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8501014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/8497018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The function started to show up in valgrind reports. It's unlikely this
change will improve this.
BUG=103391
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/8501013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL http://codereview.chromium.org/8368018/ was sort of
aggressive in some areas. I reveiewed it and this pulls back the
cases I'm pretty sure should be kept. My basic approach was to keep
things which would probably never happen in development, and which
signal a problem which is unlikely to be transient.
- important_file_writer.cc getting impossible amounts of data.
- cfbundle_blocker.mm logs blocked bundles so user can see.
- objc_zombie.mm crashes if the objc runtime is unexpectedly bizarre.
- multi-process lock logs failure.
I've actually seen that last before when a test nested a profile too
deeply, in which case knowing the filename was the key hint.
Review URL: http://codereview.chromium.org/8477018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, painting from a TransportDIB onto a BackingStoreGtk would queue
several X drawing commands (which are asynchronous by nature) and then call
XSync(), which blocks the UI thread until the current event queue has been
handled. For full content area redraws, this can block the UI thread for 100ms.
Now, as long as the X server has the XSyncExtension, instead of blocking the UI
thread until the drawing queue has been cleared, we push a special command onto
the drawing queue which sends us an XEvent after that command was handled on
the X server. RenderWidgetHost::OnMsgUpdateRect() has been split into the part
that happens before and after the paint that sends the ACK back to the renderer.
We call that via a base::Closure if we can do the asynchronous trick.
This really helps message throughput.
BUG=83106
TEST=none
Review URL: http://codereview.chromium.org/8438054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TemplateURLService level. Ensure that TemplateURLs loaded from the database without a sync_guid is assigned one in memory and updated in the database. Update unit tests to reflect this.
BUG=102038
TEST=Ensure that you can sync a basic set of Search Engines without any sync errors. Ensure that TemplateURLServiceTest.PatchEmptySyncGUID passes.
Review URL: http://codereview.chromium.org/8496018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=groby@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8491027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=tony@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8502025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kkania@chromium.org
BUG=103396
TEST=
Review URL: http://codereview.chromium.org/8503025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=101387
TEST=compiles
Review URL: http://codereview.chromium.org/8495021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation behind this cleanup pass is to move (and maintain) as much Aura specific initialization as possible in ChromeBrowserPartsAura.
In the process some other cleanup was necessary or expedient.
BUG=chromium-os:102137
TEST=All tests pass on all platforms
Review URL: http://codereview.chromium.org/8476011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
settings type is managed.
BUG=98029
TEST=HostContentSettingsMap*
Review URL: http://codereview.chromium.org/8493013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ran 'git status'
TBR=avayvod
Review URL: http://codereview.chromium.org/8495023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is NULL.
BUG=102828
TEST=1. Open https://bugs.webkit.org/
2. Focus input field using 'Tab' key.
3. Press menu or Shift+F10 key to open context menu.
4. This should open a menu.
Review URL: http://codereview.chromium.org/8503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
wglGetExtensionsStringARB.
This crashed because they have different signatures.
I switched to always use wglGetExtensionsStringEXT because it avoids the need to get the DC of a surface which was always a bit awkward.
Also fixed a bug where WGL contexts were not put in the right share group.
Review URL: http://codereview.chromium.org/8481012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The patch https://bugs.webkit.org/show_bug.cgi?id=62284 adds an additional enumeration member; this CL lets Chromium compile/test both with and without that patch. Once this Chromium patch and that WebKit patch have landed, the new type of keys are sent as "invalid" across IPC. Finally, http://codereview.chromium.org/8417055/ hooks up real IPC support for the new keys.
BUG=92038
TEST=
Review URL: http://codereview.chromium.org/8491025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scalePage is getting renamed to setPageScaleFactor to match WebCore.
Once this patch lands, WebViewImpl::scalePage will be deleted.
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/8477033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab strip context menu.
BUG=81221
TEST=Right click on the new tab button and make sure the context menu appears.
Make sure to click inside the button's irregular shape.
Review URL: http://codereview.chromium.org/8386052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=kkania@chromium.org
R=kkania@chromium.org
BUG=66072
TEST=
Review URL: http://codereview.chromium.org/8501015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splits printing_context_cairo into gtk and no system dialog versions. No system dialog versions are used in Chrome OS and Aura.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=13915
TEST=Build Chrome with Aura. Hit ctrl-p from any web page. Print preview page should come up and should be able to print via Cloud Print.
Review URL: http://codereview.chromium.org/8372030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8491022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8495014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=tony
BUG=
TEST=
Review URL: http://codereview.chromium.org/8200001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109055 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=No visible changes
Review URL: http://codereview.chromium.org/8500001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
selected in the list.
BUG=99068
TEST=Select any item in the task manager. Click on the empty region in the list box so that the currently selected item gets deselected. The kill process button should become disabled in this case.
Review URL: http://codereview.chromium.org/8499014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109052 0039d316-1c4b-4281-b951-d872f2087c98
|