| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
[The Win components build was already fixed, and the broken unrevert reverted. The original review was here: http://codereview.chromium.org/8357030 .]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8496045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
GL_CHROMIUM_copy_texture_to_parent_texture and GL_CHROMIUM_latch.
Not sure how I missed these first time around...
Review URL: http://codereview.chromium.org/8481014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change EXTENSION_HOST_CREATED to be fired on RenderViewReady.
Remove the EXTENSION_PROCESS_CREATED notification.
This is related to fixing bug 71629, in particular, making the correct things appear in the task manager when the extension host reuses a process. This affects the new reload path (but only for unpacked extensions), but it's also visible when a process isn't created for a popup in lots-of-tabs situations.
The extension settings page (the other observer) already listens to enough notifications that it updates properly (too many of them, but that's another story -- see bug).
BUG=102950
TEST=TaskManagerBrowserTest.* and also: Open Task Manager. Open an extension popup, extension notification, and extension page in a tab; check that they all appear. Kill an extension with a background page and reload it from the notification bubble; check that it reappears.
Review URL: http://codereview.chromium.org/8480007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before the change we had polling for 1st buffer but not for subsequent ones. Do it in simplest possible way -- poll and sleep in the loop. It is probably not the best approach, but simplest and most reliable. We had lot of problems adding polling for 1st buffer in the existing message loop, do not want to introduce new message loop where we had not such loop before. In any case loop usually is not executed, otherwise we would have more audible glitches when starting the stream.
Windows and Mac only change, we have only single buffer on Linux.
TEST=Start playing HTML5 audio on extremely busy Win/MAC
TEST=system with single core. Before the change you will
TEST=almost always here the glitch in the beginning.
TEST=That should become much more rare now.
Review URL: http://codereview.chromium.org/8496022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dealing with PP_Flash_NetAddress.
[The Win components breakage should be fixed by r109156.]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8357030
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/8499045
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8496043
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/8498037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PP_Flash_NetAddress.
[The Win components breakage should be fixed by r109156.]
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8357030
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/8499045
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8496043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=ben
Review URL: http://codereview.chromium.org/8495041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a LayoutManager instead of manual sizing/layout.
Don't allow bubbles off-screen by default (like old bubbles).
Don't let CriticalNotificationBubble close on deactivate.
BUG=98323
TEST=CriticalNotificationBubble works/acts as before.
Review URL: http://codereview.chromium.org/8334005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we record. In the past two weeks, I've only seen one recovery
in the histograms. I'm hoping we just aren't waiting long enough.
R=eroman
BUG=69198
Review URL: http://codereview.chromium.org/8437065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should fix the component build on Windows.
Review URL: http://codereview.chromium.org/8502041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Goals:
1 - Make it so that chrome.experimental.settings.get() can take an object with the default values to return in settings if any settings aren't set.
2 - Make it so that options pages get change events when the background page changes a setting.
3 - To solve the above: make it so that onChanged events are sent to all registered listeners, not just those which are on different processes (i.e. the incognito extension process).
4 - Remove any result in the callback from chrome.experimental.settings.set(), so that there is an unambiguous way to get changed settings (the event). It's also just generally pointless.
BUG=100825,101452,101459
TEST=*ExtensionSetting*
Review URL: http://codereview.chromium.org/8465002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8357030
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/8499045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like this may be causing BrowserMainTest.WarmConnectionFieldTrial_WarmestSocket to fail. If not, please reland.
Explicitly shutdown the network change notifier before
DBusThreadManager's shutdown.
Like crrev.com/108564, the motivation is to solve a dependency
issue between NetworkChangeNotifierChromeos and DBusThreadManager,
that'll replace CrosLibrary (i.e. NetworkChangeNotifierChromeos
will be using DBusThreadManager internally once sque's change
is checked in).
BUG=chromium-os:22459
TEST=networking on Chrome OS works as before.
Review URL: http://codereview.chromium.org/8496023
TBR=satorux@chromium.org
Review URL: http://codereview.chromium.org/8498035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
#ifdef'ed code in LocationBarView behind OmniboxView.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109088
Review URL: http://codereview.chromium.org/8457006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
below _ZNK7WebCore12NamedNodeMap20mappedMapsEquivalentEPKS0_
BUG=103467
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/8497031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses logic lifted from |SkCanvas::DrawTextDecorations()|.
Also, fixes some 'gcl lint' warnings in render_text_win.cc.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8440038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=93932
TEST=none
TBR=acolwell
Review URL: http://codereview.chromium.org/8496040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also provide appropriate test support, which will allow content/
clients of ScopedSendingEvent to participate.
BUG=102224
Review URL: http://codereview.chromium.org/8432014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103285
TEST=See steps in bug.
Review URL: http://codereview.chromium.org/8497024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
components build.
BUG=102738
TEST=none
Review URL: http://codereview.chromium.org/8496034
TBR=rvargas@chromium.org
Review URL: http://codereview.chromium.org/8495036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turned Mac valgrind bots red:
OutOfProcessPPAPITest.PostMessage_MessageEvent
OutOfProcessPPAPITest.PostMessage_ExtraParam
PPAPITest.PostMessage_NoHandler
OutOfProcessPPAPITest.PostMessage_SendInInit
Probably others
- Make it possible to enable/disable specific ppapi tests. Migrate PostMessage tests.
Most of these files were changed by a sed script, so it's not as bad as it looks.
The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before.
This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces.
BUG=102885,95557
TEST=N/A
Review URL: http://codereview.chromium.org/8477015
TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/8497030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaking apart changes in http://codereview.chromium.org/8041002/ to only
include the infrastructure portion, as well as merging to account for moving
PepperPluginInfo into content/public/common/pepper_plugin_info.*
BUG=none
TEST=Manual, set is_sandboxed to false in chrome_content_client and observe
Review URL: http://codereview.chromium.org/8477007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
web intents services.
R=groby@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8501019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103433
TEST=none
TBR=yusukes
Review URL: http://codereview.chromium.org/8497029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102738
TEST=none
Review URL: http://codereview.chromium.org/8496034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stephen pointed out that he doesn't like the "bool ok" style and prefers
the early return style during an earlier code review. I agree, but was
using this style to match existing code.
This CL switches a number of methods over to the early return style.
BUG=None
Review URL: http://codereview.chromium.org/8499034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This file has been removed from downstream
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/8500003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make bubbles' BorderContentsView fill the BubbleFrameView.
Fixes a sizing issue with the in-progress bubble conversions.
BUG=97248,98312
TEST=none (size fix for codereview.chromium.org/8368016, etc.)
Review URL: http://codereview.chromium.org/8477047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
xp-release-dual-core/moz: http://build.chromium.org/f/chromium/perf/xp-release-dual-core/moz/report.html?history=350&rev=107986
BUG=103459
TBR=cmp
Review URL: http://codereview.chromium.org/8498030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
first to chromium win by command line flag. (This and corresponding changset in webkit should be removed after this feature is enabled without command line flag).
This is chromium side's change that
1. adds command-line flag: --enable-visual-word-movement
2. passes this per-page setting to WebCore::Settings through WebPreferences.
The dependent WebKit change is in
http://trac.webkit.org/changeset/99255
workflow:
1. adds command line flag --enable-visual-word-movement, pass it to WebCore::Settings through WebPreferences.
2. (WebKit) in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings, trigger visual word movement instead of logical one.
Review URL: http://codereview.chromium.org/8400078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89273,94501,99889
TEST=./net_unittests
Review URL: http://codereview.chromium.org/8503019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DesktopHostWin::SetSize sets the window size, but ::GetSize return client area size which is smaller.
Sets the correct window origin when setting the size instead of (0,0).
BUG=none
TEST=SetBounds/DragWindow tests now pass on windows.
Review URL: http://codereview.chromium.org/8478008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
linux-release/intl2/times/t: http://build.chromium.org/f/chromium/perf/linux-release/intl2/report.html?history=150&rev=108459
BUG=103454
TBR=cmp
Review URL: http://codereview.chromium.org/8502034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103434
TEST=none
Review URL: http://codereview.chromium.org/8495029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- make type_bubble widget a gtk popup window, so that window manager will respect the popup placement. this is inline with how native_widget_win treats this widget type.
also add 'show even when screen locked code' in old bubble code into setting level bubble.
BUG=chromium-os:22429, chromium-os:22579,chromium-os:22546
TEST=on alex, with fix, volume and brightness shows up at bottom of screen, and when in screenlocked mode.
Review URL: http://codereview.chromium.org/8463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids sending each cookie one by one to the cookie manager UI, which
makes it really janky. This behavior appears to have regressed in r95534.
This fix should be merged to M16 and possibly also M15.
BUG=100391
Review URL: http://codereview.chromium.org/8483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=103291
TEST=
Review URL: http://codereview.chromium.org/8495004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in preperation for moving StatusAreaView to ui: so that it is available for Aura.
* Remove button specific accessors from StatusAreaView
* Replace StatusAreaHost with StatusAreaButton::Delegate, eliminating unnecessary methods
BUG=97263
TEST=Thoroughly test the status area on ChromeOS (there should be no visible or functional changes)
Review URL: http://codereview.chromium.org/8438064
Change-Id: I29bdc1cdbc8a2287ab4920b94fea2b22235088b9
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Explicitly shutdown the network change notifier before
DBusThreadManager's shutdown.
Like crrev.com/108564, the motivation is to solve a dependency
issue between NetworkChangeNotifierChromeos and DBusThreadManager,
that'll replace CrosLibrary (i.e. NetworkChangeNotifierChromeos
will be using DBusThreadManager internally once sque's change
is checked in).
BUG=chromium-os:22459
TEST=networking on Chrome OS works as before.
Review URL: http://codereview.chromium.org/8496023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Initially ProfileInfoCache didn't store the sync user name. Later when we added support for this field we only updated it if the sync user name value changed.
This meant that for existing multi-profiles users we didn't cache their sync user name.
To fix this I'm adding code to make sure that the sync user name is up to date when we create a new ProfileSyncService.
BUG=99531
TEST=
Review URL: http://codereview.chromium.org/8498026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8476008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The "large" version of the first run bubble is being depreciated. With this CL I'm simply disabling it form M16 but alicet is working on removing it all together.
BUG=103417
TEST=
Review URL: http://codereview.chromium.org/8496029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
RenderViewHostManager. The latter's destruction can call into RenderViewHost's destructor, which can call back to TabContents which in turn can use the observers.
BUG=101954
Review URL: http://codereview.chromium.org/8497022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=100992
Review URL: http://codereview.chromium.org/8503027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests.
Most of these files were changed by a sed script, so it's not as bad as it looks.
The testcase attribute now can include a 'filter'. If it's omitted, everything works the same as before. This way we can migrate tests over bit-by-bit if we want to. We can also still run the tests manually the same way as before.
This only runs PostMessage testss the new way, and re-enables all oop PostMessage tests that pass on Windows. I can do the other tests in this CL if desired, but it might be easier to land in a few pieces.
BUG=102885,95557
TEST=N/A
Review URL: http://codereview.chromium.org/8477015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broken by r108720
Flimflam dir /home/chronos/user/flimflam is owned by root.
Split out cleaning of flimflam dir to a separate script which can be called
using suid_python binary (when running pyauto functional tests as chronos).
BUG=None
TEST=desktopui_PyAutoFunctionalTests runs on ChromeOS.
R=stanleyw@chromium.org
Review URL: http://codereview.chromium.org/8499003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing a change from ferringb@chromium.org to update the
static HTML served at chrome://os-credits.
BUG=chromium-os:20098
TEST=visual inspection of changes from R15
Review URL: http://codereview.chromium.org/8501016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for the availability of certain shared libraries to determine of a GL implementation is feasible. You really have to actually create a context and check pixel formats to determine the feasibilty. Thsi patch refactors GLSurface::InitializeOneOff() to do further checking.
BUG=102672
Review URL: http://codereview.chromium.org/8451008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109111 0039d316-1c4b-4281-b951-d872f2087c98
|