summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert of [NaCl SDK] Remove support for bionic toolchain (patchset #3 ↵scheib2015-12-0125-28/+847
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/1269623004/ ) Reason for revert: Broke build: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/12371 ninja -w dupbuild=err -C /b/build/slave/Linux_x64/build/src/out/Release chrome gn_all -j50 ninja: Entering directory `/b/build/slave/Linux_x64/build/src/out/Release' [1/1] Regenerating ninja files ninja: error: '../../native_client_sdk/src/libraries/nacl_io/kernel_wrap_bionic.cc', needed by 'newlib_pnacl/obj/native_client_sdk/src/libraries/nacl_io/nacl_io/kernel_wrap_bionic.o', missing and no known rule to make it Original issue's description: > [NaCl SDK] Remove support for bionic toolchain > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk > > Committed: https://crrev.com/2bd1f02649d6fe8b0a5616932e40b67478c58174 > Cr-Commit-Position: refs/heads/master@{#362454} TBR=binji@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1493443002 Cr-Commit-Position: refs/heads/master@{#362480}
* Drop [LegacyInterfaceTypeChecking] for PagePopupControllerphilipj2015-12-012-4/+4
| | | | | | | | | | | This is an internal API, used only by web/resources/listPicker.js, where document is passed as an argument, which is not null. BUG=561338 Review URL: https://codereview.chromium.org/1485123002 Cr-Commit-Position: refs/heads/master@{#362479}
* Add missing check for null network delegateestark2015-12-011-1/+3
| | | | | | | | | | | Follow-up to https://codereview.chromium.org/1393193005/ BUG=541511 TBR=mmenke@chromium.org Review URL: https://codereview.chromium.org/1488693005 Cr-Commit-Position: refs/heads/master@{#362478}
* Android GN: Define USE_SECCOMP_BPF in //content/renderer.rsesek2015-12-011-0/+5
| | | | | | | | R=sievers@chromium.org Review URL: https://codereview.chromium.org/1484353002 Cr-Commit-Position: refs/heads/master@{#362477}
* Make a content/test API for registering JNI.brettw2015-12-015-27/+31
| | | | | | | | | | | | The components test setup needs to register browserJNI calls but this is not part of the content API. This makes a new content test wrapper API for doing this. This change fixes the components tests "gn check" failures so these targets can now be added to the whitelist. Cleans up the components/test DEPS file. The dependency allowances for this directory are quite wide so whitelisting every header file, as was done before, was needlessly complicated. Review URL: https://codereview.chromium.org/1485893003 Cr-Commit-Position: refs/heads/master@{#362476}
* ModelTypeEntity refactoring to use EntityData and EntityMetadatastanisc2015-12-0115-641/+696
| | | | | | | | | | | | | | | | | | | | | | | | | 1) Changed existing ModelTypeEntity to be based on EntityMetadata, client key, and EntityDataPtr. Changed the class construction functions slighly to better reuse the code and to be able to pass the data without copying. 2) Moved model_type_entity* files next to shared_model_type_processor* 3) Did initial implementation of the data caching, although it might still need some refinement. The code that prepares commit request data structure now uses the cached EntityDataPtr. 4) Made necessary changes in SharedModelTypeProcessor to ensure that all existing tests pass. Had to disable two re-encryption tests because they expect the data received in updates to be cached in ModelTypeEntity which isn't the case anymore. BUG=517657, 553638 Review URL: https://codereview.chromium.org/1471293005 Cr-Commit-Position: refs/heads/master@{#362475}
* [MD] Fix omnibox row highlight colorestade2015-12-011-8/+6
| | | | | | | | BUG=562691 Review URL: https://codereview.chromium.org/1485903002 Cr-Commit-Position: refs/heads/master@{#362474}
* [Chromecast] Add media playback browser test for audio buildshalliwell2015-12-011-1/+10
| | | | | | | | | | | Also rename video playback test to be clear, and filter it out on audio-only builds. BUG= Review URL: https://codereview.chromium.org/1475863004 Cr-Commit-Position: refs/heads/master@{#362473}
* Remove kuint16max.avi2015-12-0119-137/+176
| | | | | | | | | | | BUG=138542 Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46 Cr-Commit-Position: refs/heads/master@{#362431} Review URL: https://codereview.chromium.org/1475803002 Cr-Commit-Position: refs/heads/master@{#362472}
* Add and implement WebCompositorSupport::createLayerFromCcLayer.jbroman2015-12-013-0/+12
| | | | | | | | | BUG=563667 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1487593003 Cr-Commit-Position: refs/heads/master@{#362471}
* Make init*Event() arguments nullable where appropriatephilipj2015-12-014-4/+4
| | | | | | | | | | | | | | | | | | Because these methods have [LegacyInterfaceTypeChecking], this does not change the generated code, but it will limit the impact of dropping [LegacyInterfaceTypeChecking]. Only initKeyboardEvent() appears to have a spec: https://w3c.github.io/uievents/#idl-interface-KeyboardEvent-initializers For the others, the nullability matches that of the *Event member. BUG=561338 R=rbyers@chromium.org Review URL: https://codereview.chromium.org/1488803002 Cr-Commit-Position: refs/heads/master@{#362470}
* Stop requiring NotificationAction action and title to be non-emptyjohnme2015-12-013-82/+1
| | | | | | | | | | | | | | | | | Improve spec compliance. Note that http/tests/notifications/serviceworkerregistration-document-actions-throw.html still tests that they are set (but it's no longer possible to have an equivalent check in NotificationDataTest, since required WebIDL attributes are enforced at the V8 level by [1], and are bypassed when creating IDL objects from C++). [1]: https://chromium.googlesource.com/chromium/src/+/dfd8ec1b3edb7f876235bec1138ecec4f2da748d/third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp#55 BUG=557624 Review URL: https://codereview.chromium.org/1487063002 Cr-Commit-Position: refs/heads/master@{#362469}
* remove WebMediaPlayerImpl::CreateRendererhubbe2015-12-011-3/+0
| | | | | | | | WebMediaPlayerImpl::CreateRenderer is neither defined or called anywhere, remove it's declaration. Review URL: https://codereview.chromium.org/1487653003 Cr-Commit-Position: refs/heads/master@{#362468}
* Roll openmax 6625be0:7a179b9thakis2015-12-011-1/+1
| | | | | | | | | | | | Picks up: 7a179b9 Only pass android_toolchain in android builds. BUG=563844 TBR=rtoy@chromium.org Review URL: https://codereview.chromium.org/1483263004 Cr-Commit-Position: refs/heads/master@{#362467}
* Increase event timer for debug buildssky2015-12-011-4/+17
| | | | | | | | | | | | Without this I readily hit the timeout in a debug build on windows. BUG=none TEST=none R=sadrul@chromium.org Review URL: https://codereview.chromium.org/1490843002 Cr-Commit-Position: refs/heads/master@{#362466}
* Roll src/third_party/skia/ eeebdb538..9323dc6a7 (5 commits).skia-deps-roller2015-12-011-1/+1
| | | | | | | | | | | | | | | | | | https://chromium.googlesource.com/skia.git/+log/eeebdb538d47..9323dc6a72de $ git log eeebdb538..9323dc6a7 --date=short --no-merges --format='%ad %ae %s' 2015-12-01 scroggo Revert of Fix Android framework build (patchset #1 id:1 of https://codereview.chromium.org/1491563003/ ) 2015-12-01 bsalomon Revert of Make NVPR a GL context option instead of a GL context (patchset #2 id:20001 of https://codereview.chromium.org/1448883002/ ) 2015-12-01 scroggo Fix Android framework build 2015-12-01 lsalzman check that SSE2 is available before using __vectorcall 2015-12-01 mtklein Add Sk4f::ToBytes(uint8_t[16], Sk4f, Sk4f, Sk4f, Sk4f) CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=scroggo@google.com Review URL: https://codereview.chromium.org/1488103002 Cr-Commit-Position: refs/heads/master@{#362465}
* Add bisect FYI bots on tryserver.chromium.perf to MB configprasadv2015-12-011-2/+5
| | | | | | | | BUG=560981 Review URL: https://codereview.chromium.org/1488773002 Cr-Commit-Position: refs/heads/master@{#362464}
* GN(android): Use list of libraries rather than native_lib_dir in all placesagrieve2015-12-016-127/+153
| | | | | | | | | | | Addresses a TODO and makes rules more well suited for adding in loadable_modules BUG=559289 Review URL: https://codereview.chromium.org/1483683002 Cr-Commit-Position: refs/heads/master@{#362463}
* ExtensionSyncService: don't self-notify of incoming sync changestreib2015-12-013-10/+123
| | | | | | | | BUG=560955 Review URL: https://codereview.chromium.org/1478493003 Cr-Commit-Position: refs/heads/master@{#362462}
* [Sync] GetClientTag implementation for device info.skym2015-12-014-28/+62
| | | | | | | | BUG=543405 Review URL: https://codereview.chromium.org/1484073003 Cr-Commit-Position: refs/heads/master@{#362461}
* Cleanup: Remove unused boolean parameter from ProfileResetter::Reset.dpapad2015-12-015-8/+1
| | | | | | | | | | | | | The parameter was added at https://codereview.chromium.org/333193002. The code that uses the parameter was later removed at https://codereview.chromium.org/495643002, but the method signature was not cleaned up. BUG=546840 Review URL: https://codereview.chromium.org/1484113003 Cr-Commit-Position: refs/heads/master@{#362460}
* [PartitionAlloc] Take type argument for heap profilingruuda2015-12-0141-245/+267
| | | | | | | | | | | | | | | | | | | | | | | | This adds an extra argument to |PartitionAlloc| and similar allocating functions: the type name. The type name is then passed to the heap profiling hook. A new macro, |WTF_HEAP_PROFILER_TYPE_NAME| is introduced to obtain a type name string. On non-official builds, this macro expands to a null pointer, so the impact on official builds is minimal. On non-official builts, the macro expands to the type name, so developers can get type info in the heap profiler without rebuilding. In the future, some instances of |WTF_HEAP_PROFILER_TYPE_NAME| can be replaced to pass a type name string unconditionally. This will enable type info in the heap profiler even for official builds, without bloating the binary, because only the most common types should be annotated. This is part of the heap profiler in chrome://tracing. BUG=524631 Review URL: https://codereview.chromium.org/1472083008 Cr-Commit-Position: refs/heads/master@{#362459}
* Mark http/tests/webfont/font-display.html as flaky on Win7 and XPyurys2015-12-011-0/+2
| | | | | | | | | | TBR=,ksakamoto@chromium.org BUG=564109 NOTRY=True Review URL: https://codereview.chromium.org/1488163002 Cr-Commit-Position: refs/heads/master@{#362458}
* Mark a few tests for auto-rebaseline on Androidyurys2015-12-011-0/+9
| | | | | | | | | | | | | | They've been having image diff since https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/41855 https://chromium.googlesource.com/chromium/src/+log/bd2336b6a1a62889db5af91b02290ece6d74f244%5E..019a65d7a669b75fb8fefa9a88a9ef0ac7116ebf?pretty=fuller TBR=davve@opera.com BUG=561519 NOTRY=True Review URL: https://codereview.chromium.org/1485213002 Cr-Commit-Position: refs/heads/master@{#362457}
* Make mash build in component tooben2015-12-011-1/+1
| | | | | | | | | R=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/1485813003 Cr-Commit-Position: refs/heads/master@{#362456}
* [Sync] Add Sync.InitialState UMA metric.maxbogue2015-12-013-0/+55
| | | | | | | | | | | | We don't know for sure whether sync will succeed at starting up at initialization time, but we can inspect and report on the state of various flags. BUG=555113 Review URL: https://codereview.chromium.org/1463583008 Cr-Commit-Position: refs/heads/master@{#362455}
* [NaCl SDK] Remove support for bionic toolchainsbc2015-12-0125-847/+28
| | | | | | | | CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Review URL: https://codereview.chromium.org/1269623004 Cr-Commit-Position: refs/heads/master@{#362454}
* [Extensions UI Mac] Fix crash in overflow toolbar actions barrdevlin.cronin2015-12-013-2/+66
| | | | | | | | | | | | | Fix a crash that would happen when a new action was added with the overflow menu open. The overflow container would try to update before adding the new action. Fix, and add a test. BUG=561237 Review URL: https://codereview.chromium.org/1488703002 Cr-Commit-Position: refs/heads/master@{#362453}
* [Media Router] Use Polymer listeners block rather than addEventListener().apacible2015-12-011-1/+1
| | | | | | | | | | This change follows the pattern of using Polymer's listeners block within the element rather than manually adding the event listener separately from the general element setup. We're also already using it for 'tap'. HTML element specific events (e.g. on-click) are left in the template until I find out more about the performance difference between the two setups. It's possible to have id-specific listener objects in the listeners block by declaring 'id.event' rather than just 'event'. Review URL: https://codereview.chromium.org/1486763002 Cr-Commit-Position: refs/heads/master@{#362452}
* Document retail mode policies as removed.tnagel2015-12-011-6/+6
| | | | | | | | BUG=524269 Review URL: https://codereview.chromium.org/1490833002 Cr-Commit-Position: refs/heads/master@{#362451}
* [Sync] Renaming MetadataChanges to MetadataChangeList, slight metadata ↵skym2015-12-0117-36/+196
| | | | | | | | | | ownership tweak, and adding a few stub methods. BUG=543405 Review URL: https://codereview.chromium.org/1478593002 Cr-Commit-Position: refs/heads/master@{#362450}
* Check .exe's within an archive against manual-blacklist-flag. Beforenparker2015-12-012-22/+84
| | | | | | | | | | we were just checking the hash of the main file. BUG=553595 Review URL: https://codereview.chromium.org/1477523003 Cr-Commit-Position: refs/heads/master@{#362449}
* Update V8 to version 4.9.117.v8-autoroll2015-12-011-1/+1
| | | | | | | | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/74f6589d..2472199b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1490823002 Cr-Commit-Position: refs/heads/master@{#362448}
* Remove obsolete provider IOSChromeBrowsingDataRemoverProvider.sdefresne2015-12-015-118/+64
| | | | | | | | | | | | Inline the two methods that no longer have any bad dependency in client IOSChromeBrowsingDataRemover, and move GetSafeBrowsingURLRequestContext method to ChromeBrowserProvider to remove one indirection. BUG=562155,563936,563581 Review URL: https://codereview.chromium.org/1492443002 Cr-Commit-Position: refs/heads/master@{#362447}
* tools/gn: make use of base's StartsWith() functiontfarina2015-12-011-11/+8
| | | | | | | | | | | | | | Since Brett introduced this funtion to base, we can make use of it and remove our copy from gn. We are also making use of it in other five files already. BUG=None TEST=gn gen + gn_unittests R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1481403006 Cr-Commit-Position: refs/heads/master@{#362446}
* Reduce frequency of media element memory usage reports.dalecurtis2015-12-012-7/+30
| | | | | | | | | | | | | | | The code will no longer report memory usage every 500ms when nothing is going on. Instead it will: - Report once we have enough data. - Start reporting every 2 seconds once playback starts. - Stop reporting once playback is paused. BUG=549694 TEST=original crash test still doesn't crash. Review URL: https://codereview.chromium.org/1488833002 Cr-Commit-Position: refs/heads/master@{#362445}
* Revert of Remove kuint16max. (patchset #7 id:120001 of ↵avi2015-12-0117-164/+127
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1475803002/ ) Reason for revert: missed one :( Original issue's description: > Remove kuint16max. > > BUG=138542 > > Committed: https://crrev.com/0d94fda8c494d7a6c27d065d782f42e99d834f46 > Cr-Commit-Position: refs/heads/master@{#362431} TBR=treib@chromium.org,mark@chromium.org,sergeyu@chromium.org,bartfab@chromium.org,rsleevi@chromium.org,sky@chromium.org,cpu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=138542 Review URL: https://codereview.chromium.org/1485853003 Cr-Commit-Position: refs/heads/master@{#362444}
* Try to remove the suppression for issue 273047 to check if the bug has been ↵glider2015-12-011-4/+0
| | | | | | | | | | | fixed. BUG=273047 TBR=benwells@chromium.org Review URL: https://codereview.chromium.org/1489853002 Cr-Commit-Position: refs/heads/master@{#362443}
* Re-enable DownloadFile/DownloadFileTestWithRename.RenameWithErrorRetry testszhaoqin2015-12-011-4/+0
| | | | | | | | | | | | The issue in Dr. Memory is fixed and updated to Chromium. TBR=asanka@chromium.org,oshima@chromium.org NOTRY=true BUG=418748 Review URL: https://codereview.chromium.org/1489053002 Cr-Commit-Position: refs/heads/master@{#362442}
* remove Dr. Memory suppression for issue 554520zhaoqin2015-12-011-8/+0
| | | | | | | | | | TBR=jmadill@chromium.org NOTRY=true BUG=554520 Review URL: https://codereview.chromium.org/1489743003 Cr-Commit-Position: refs/heads/master@{#362441}
* NaCl: Fix a file descriptor leak on Unixmseaborn2015-12-011-0/+15
| | | | | | | | | | | | | | | | | Before this change, the renderer process leaks a file descriptor every time a PNaCl translator process is launched or a (P)NaCl process runs without calling the ppapi_start() API. There was no leak on Windows, because client-side IPC::ChannelHandles fill out the "name" field rather than the "pipe.handle" field. BUG=302078 TEST=Run an invalid pexe repeatedly and manually inspect /proc/PID/fd of the renderer process. Review URL: https://codereview.chromium.org/1473513005 Cr-Commit-Position: refs/heads/master@{#362440}
* Allow multiple OnMoreData() calls in WASAPIAudioOutputStreamTest.ValidPacketSizewdzierzanowski2015-12-011-2/+4
| | | | | | | | | | | | Follow up on https://codereview.chromium.org/1318933003/ and allow OnMoreData() to be called more than once in the test. BUG=524947 TEST=WASAPIAudioOutputStreamTest.ValidPacketSize passes Review URL: https://codereview.chromium.org/1487733003 Cr-Commit-Position: refs/heads/master@{#362439}
* Implement data channel support in WebrtcTransport.sergeyu2015-12-016-37/+436
| | | | | | | | | | | Now WebrtcTransport::GetStreamChannelFactory() returns a valid factory that creates streams using WebRTC data channel. BUG=547158 Review URL: https://codereview.chromium.org/1488723002 Cr-Commit-Position: refs/heads/master@{#362438}
* Move crash keys for command-line switches to components/crash so they can be setjoenotcharles2015-12-0113-131/+284
| | | | | | | | | | from the installer as well as chrome, and set them on installer startup. BUG=558552 Review URL: https://codereview.chromium.org/1481933002 Cr-Commit-Position: refs/heads/master@{#362437}
* bitmap_uploader: Remove DCHECK on LostContextfsamuel2015-12-011-2/+2
| | | | | | | | | | This is not a fatal error and it's causing an unclean shutdown in mustash. BUG=none Review URL: https://codereview.chromium.org/1480363004 Cr-Commit-Position: refs/heads/master@{#362436}
* Roll GYP f4d65e3:e2313c0.sdefresne2015-12-011-1/+1
| | | | | | | | | | | | This rolls GYP to the latest commit in its repo. e2313c0 Fix CalculateGeneratorInputInfo for "xcode-ninja" generator. BUG=562135 Review URL: https://codereview.chromium.org/1485133002 Cr-Commit-Position: refs/heads/master@{#362435}
* Further media mime_util cleanupservolk2015-12-014-110/+55
| | | | | | | | | | | | Removed MimeUtil::media_map_ by using media_format_map_ instead. Removed common_media_types/proprietary_media_types, since they are duplicated in format_codec_mappings. Added a new COMMON/PROPRIETARY flag to each media format mapping instead. BUG=461012 Review URL: https://codereview.chromium.org/1472443003 Cr-Commit-Position: refs/heads/master@{#362434}
* Fixing PhishingDOMFeatureExtractorTest and PhishingClassifierTest VS ↵lukasza2015-12-015-60/+117
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | --isolate-extensions. PhishingClassifierTest assumed that a given RenderFrame pointer stays valid throughout navigations - this is not really true. I fixed the test by creating a new PhishingClassifier (with a fresh RenderFrame pointer) before every navigation - this has been accomplished be splitting one test into five smaller, more granular tests. Note: PhishingClassifierDelegateTest has a similar problem, but in this test navigation seems to be a core part of the test - I am not sure how to easily fix this test. Both PhishingClassifierDelegateTest and PhishingDOMFeatureExtractorTest were storing a render_view_routing_id and assuming that it stays valid throughout navigfations - this is not really true. I changed both tests to always get a fresh RenderFrame pointer via WebContents, so they don't have to rely on a potentially stale routing id. All 3 test suites use --single-process mode. This mode was crashing early when combined with --site-per-process or --isolate-extensions - the crash was in aec_dump_message_filter.cc(28) - check failed: !g_filter. This is fixed by more aggressively requiring reuse of the renderer process when --single-process mode is active - special thanks to nick@ for pointing out the change needed in render_process_host_impl.cc. BUG=532666 Review URL: https://codereview.chromium.org/1469603002 Cr-Commit-Position: refs/heads/master@{#362433}
* GN: Merge apk_deps and deps in test() templateagrieve2015-12-0117-60/+46
| | | | | | | | | | | apk_deps has been causing some unneccesary confusion. BUG=558193 R=tfarina@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/1465923002 Cr-Commit-Position: refs/heads/master@{#362432}
* Remove kuint16max.avi2015-12-0117-127/+164
| | | | | | | | BUG=138542 Review URL: https://codereview.chromium.org/1475803002 Cr-Commit-Position: refs/heads/master@{#362431}
generated by cgit v1.1 at 2025-01-22 01:58:02 +0000