| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=32529
TBR=dank
TEST=TSan UI should become green
Review URL: http://codereview.chromium.org/545110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
but would like to avoid the dependencies that would be added by including the whole win_util.cc file
Review URL: http://codereview.chromium.org/536028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test occasionally crashes on WIN.
BUG=32518
TEST=none
TBR=senorblanco
Review URL: http://codereview.chromium.org/542103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test occasionally crashes on WIN.
BUG=32516
TEST=none
TBR=senorblanco
Review URL: http://codereview.chromium.org/542102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was currently processed as a control message.
This is an actual part of the previous CLD related CL:
http://codereview.chromium.org/548057
It kept failing on the bots for some tests, I am not sure why yet and cannot repro locally. Hopefully splitting it will help pinpoint the issue.
TEST=All unit-tests, ui tests should still work.
Navigate to a page with some specific words in it, then go
to the history tab and search for pages with these specific
words. Make sure the page you navigated is shown in the results.
TBR=brettw
Review URL: http://codereview.chromium.org/553012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UMA data suggests that a 500ms limit on queue duration
(before assuming congestion) provides better user
experience. This change sets 500ms as the default,
and reduces the percentage of users that have other
experimental values.
BUG=3041,15479
r=eroman
Review URL: http://codereview.chromium.org/543083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Make sure the buildtime is interpretted the same in all time zones.
r=dpranke
Review URL: http://codereview.chromium.org/546067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, add a platformspecific BaselinePath() routine that allows the
generic code to query where the baselines are for a particular platform
(rather than assuming a fixed representation scheme in path_utils).
Second, modify the search paths to only look in the "old" directories
under webkit/data/layout_tests/platform/chromium{linux,mac,win}/LayoutTests.
We will not move the subdirs up under platform/chromium* until we upstream
all of the baselines to webkit.
Note that all of this code will get rewritten as part of the webkit upstreaming.
BUG=none
R=victorw@chromium.org, pam@chromium.org, ojan@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/548050
TBR=dpranke@google.com
Review URL: http://codereview.chromium.org/551061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, add a platform-specific BaselinePath() routine that allows the
generic code to query where the baselines are for a particular platform
(rather than assuming a fixed representation scheme in path_utils).
Second, modify the search paths to only look in the "old" directories
under webkit/data/layout_tests/platform/chromium-{linux,mac,win}/LayoutTests.
We will not move the subdirs up under platform/chromium-* until we upstream
all of the baselines to webkit.
Note that all of this code will get rewritten as part of the webkit upstreaming.
BUG=none
R=victorw@chromium.org, pam@chromium.org, ojan@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/548050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager.
* Added factory method to create chromeos specific tab/tabstrip and layoutmanagers.
* Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36452
Review URL: http://codereview.chromium.org/543095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromiumos_text_input contains IME candidate window code which is part
of text input suppport for Chromium OS.
See the design doc for details:
http://www.chromium.org/chromium-os/chromiumos-design-docs/text-input
BUG=none
TEST=confirmed gclient --runhooks work with and without GYP_DEFINES="chromeos=1". Also confirmed that 'candidate_window' target is only valid and built when GYP_DEFINES="chromeos=1" is set.
Review URL: http://codereview.chromium.org/551043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
broker currently launches with --no-sandbox, so the 64-bit version of the sandbox library is there only to allow successful build.
BUG=27218
TEST=none
Review URL: http://codereview.chromium.org/543058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
In the next CL (http://codereview.chromium.org/542030/show) NaCl broker code will need to include sandbox_policy.h from chrome/nacl, and without this move check_deps test fails.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add NOTREACHED() to branch of Sandbox code that we should never hit.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/536060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Options page for an extension.
Thanks to Phistuck for pointing this out.
Also, use IDS_MANAGE_EXTENSIONS for all locales on dev (it will get translated in the next run).
BUG=None
TEST=Use the extension context menu and Manage Extensions and Configure should not open new tabs if that tab already exists.
Review URL: http://codereview.chromium.org/551056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
desktop with latest nvidia drivers which does not complain about precision. But it does not compile on most other drivers.
Review URL: http://codereview.chromium.org/551057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8ae39b4c6290397c03661b59619e125f416a9af8.
TBR=sky@chromium.org
BUG=none
TEST=interactive_ui_tests on windows should pass with revert.
Review URL: http://codereview.chromium.org/542098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes are:
* base::IsValidCodepoint() now returns false on noncharacter code points.
* base::IsStringUTF8() now uses ICU library (removed old Mozilla implementation).
* Removed base::IsStringWideUTF8() (was unused and confusing)
* file_util::ReplaceIllegalCharactersInPath() now treats Unicode replacement character (U+FFFD) as invalid.
* Associated unit tests updated.
BUG=2759
BUG=30662
TEST=base_unittests gtest_filter=StringUtilTest.IsStringUTF8
TEST=base_unittests gtest_filter=UTFStringConversionsTest.*
TEST=base_unittests gtest_filter=FileUtilICUTestReplaceIllegalCharactersInPathTest
Review URL: http://codereview.chromium.org/548017
TBR=jschuh@chromium.org
Review URL: http://codereview.chromium.org/552026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* base::IsValidCodepoint() now returns false on non-character code points.
* base::IsStringUTF8() now uses ICU library (removed old Mozilla implementation).
* Removed base::IsStringWideUTF8() (was unused and confusing)
* file_util::ReplaceIllegalCharactersInPath() now treats Unicode replacement character (U+FFFD) as invalid.
* Associated unit tests updated.
BUG=2759
BUG=30662
TEST=base_unittests --gtest_filter=StringUtilTest.IsStringUTF8
TEST=base_unittests --gtest_filter=UTFStringConversionsTest.*
TEST=base_unittests --gtest_filter=FileUtilICUTestReplaceIllegalCharactersInPathTest
Review URL: http://codereview.chromium.org/548017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Needed for Pepper progress.
Review URL: http://codereview.chromium.org/552024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Revert "Revert part of r35312 now that ChromeOS is fixed.""
This reverts commit 6717ffb85f34b1de756f9a703a68ab7ef8336651.
TBR=evan@chromium.org
BUG=none
TEST=unit_tests should pass except for chromeos build.
Review URL: http://codereview.chromium.org/553007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 78422af7d04c5a0244677f8f80258ee1173ba0d3.
TBR=evan@chromium.org
BUG=none
TEST=Basic in ui_tests should pass
Review URL: http://codereview.chromium.org/548065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* renamed BrowserLayoutManager to more explicit, BrowserViewLayoutManager.
* Added factory method to create chromeos specific tab/tabstrip and layoutmanagers.
* Introduced ChromeosBrowserView and chromeos specific tab/tabstrip and layoutmanager, and moved chromeos specifi code into them.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/543095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4th attempt at landing this.
It caused several tests to fails previously.
Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow).
No code change.
Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unittests.
TBR=brettw
Review URL: http://codereview.chromium.org/548057
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/536085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* TabData.blocked is not initialized.
* logo_icon_ was leaking because it's not added to the view tree.
BUG=none
TEST=valgrind failure for these two should be gone with this patch.
Review URL: http://codereview.chromium.org/553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=zelidrag
BUG=none
TEST=Linux Valgrind
Review URL: http://codereview.chromium.org/543100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use new style protocol in addition to old style protocol when talking to the server in preparation for new data type synchronization.
original patch from issue 487011
TEST=manually tested old client new client new server mixes
BUG=30032
Review URL: http://codereview.chromium.org/549029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Auto-expand the Cookies folder after expanding a domain-level folder
* XIB change: disable multiple selection (and removal) of cookies to prevent a crash
* Auto-select the next cookie after deletion
BUG=31678,32002,32022
TEST=Open cookies manager. Expand a domain and Cookies folder should auto-expand.
TEST=Open cookies manager. Should not be able to perform multiple selection or deletion.
TEST=Open cookies manager. Expand domain with multiple cookies. Delete the first cookie. Second cookie should now be selected.
Review URL: http://codereview.chromium.org/542091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused several tests to fails previously.
Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow).
No code change.
Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unit-tests.
TBR=brettw
Review URL: http://codereview.chromium.org/548057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=all the bookmark mgr test under valgrind...
Review URL: http://codereview.chromium.org/549075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=none
BUG=32444
Review URL: http://codereview.chromium.org/545104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/536084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Determine the size request after showing the dialog for the first time. For one reason or another, the size request before that point doesn't take into account the checkbox label text.
BUG=32394
TEST=see bug
Review URL: http://codereview.chromium.org/549073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32331
TEST=Open bookmark manager, choose "Bookmark Manager" menu command again: it should close. Or open, then activate browser window, then choose command again: it'll come to the front.
Review URL: http://codereview.chromium.org/536072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently loading document to prevent small documents from executing code.
I'm not enabling httpequiv just yet as there are a couple of things I'm working on related to tests that will break once I make the switch.
TEST=There should be no change since the code isn't still active but run all tests just to be safe.
BUG=none
Review URL: http://codereview.chromium.org/545096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(patch by thiago.farina@gmail.com ; original code review is http://codereview.chromium.org/541006 )
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/541059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
equivalent to their counterparts under browser/views/notifications; CL also enables the exposure of notifications in WebKit on linux platform.
BUG=23954
TEST=none
Review URL: http://codereview.chromium.org/525050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"LayoutTests" from paths in test_expectations.txt
R=ojan
BUG=none
TEST=run test output formatter, should find baselines successfully
Review URL: http://codereview.chromium.org/549060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The list views now match the Windows version: left one is a tree that only shows folders, right one is a flat list.
In BookmarkManager.xib: left pane changed to BookmarkTreeController, 'folder' column added to right outline view, toolbar added.
BUG=31969,32080
TEST=new unit tests on BookmarkManagerController, BookmarkItem, BookmarkTreeController.
Review URL: http://codereview.chromium.org/536063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/550055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The test used to rely on menu item #3, while the change made it use the
last item; the last item on Linux is a submenu so the test was failing.
Go back to menu item #3.
Review URL: http://codereview.chromium.org/545098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the SSL 2.0 cipher suites must be available if SSL 2.0 is enabled.
R=mark
BUG=30682
TEST=none
Review URL: http://codereview.chromium.org/552014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- adds a second transport, existing mode is unchanged
- switching logic for transport according to packet size
- new message to render so it can use the syncsocket
- non operational yet, so no tests included yet, however bits
are already tested in media-audio unittests.
TEST=none
BUG=28292
Review URL: http://codereview.chromium.org/515046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
handshake errors. It should never return a certificate error
because we don't have the server's certificate when handshake
fails.
R=agl
BUG=24064
TEST=Visit the test URL in issue 24064 comment 8 on Linux. Chromium
should not crash.
Review URL: http://codereview.chromium.org/550026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webkit/data/layoutests/platform/chromium-{mac,win,linux}/* to
chromium-{mac,win,linux}/LayoutTests/* . Although the LayoutTests subdirectory
is superfluous and doesn't comply with the way WebKit does things, it doesn't
really do any harm, either, so we'll leave it there until we can upstream
all of the baselines into webkit.
BUG=none
R=pam@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/536074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=none
BUG=10300
BUG=10430
Review URL: http://codereview.chromium.org/542094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29948
TEST=none
Review URL: http://codereview.chromium.org/551051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36423 0039d316-1c4b-4281-b951-d872f2087c98
|