| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/242113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TODO=get alignment right for NTP background when alignment != top
TODO=fancy-pants animation (on windows this animation looks rather janky anyway so I'm not eager to work on this)
TODO=tweak in gtk mode (border color=?)
TEST=fiddle a lot, make sure there are no problems with find bar occlusion.
TEST=install a bunch of different themes; everything looks right (up to TODOs)
TEST=switch back and forth between gtk theme and chromium theme
TEST=popup windows still work
TEST=poked around in valgrind
TEST=poked around with fullscreen
BUG=18780
Review URL: http://codereview.chromium.org/243057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Not sure this is the best place for them but
we can move them later.
Review URL: http://codereview.chromium.org/256031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
modifiers supplied for a test. Before this change it would leave
options_string == None, which throws a confusing error in _GetOptionsList.
Review URL: http://codereview.chromium.org/242112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=21201
TEST=no
Review URL: http://codereview.chromium.org/256029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
symbols. Chromebot does not like 200MB zip files and 800MB chrome binaries.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/259008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20339
TEST=none
Review URL: http://codereview.chromium.org/243065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing implementation crashed when I switched syncapi to static
linkage, I think because pthreads had already been unloaded when
CleanupSSL happened.
BUG=19895
TEST=basic two-client sync run-through, start-up, shutdown.
Review URL: http://codereview.chromium.org/246067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Mainly, identify all the LayoutTests/accessibility tests that
actually always FAIL instead of FAIL PASS.
Review URL: http://codereview.chromium.org/249062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
result of my change. test_shell doesn't use font at all. This is
exactly the same change as was earlier landed.
BUG=22791
TEST=see bug
TBR=agl
Review URL: http://codereview.chromium.org/242111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will allow us to have a different set of feature_defines for upstream and downstream webkit builds.
Review URL: http://codereview.chromium.org/242102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split out the fts2 changes a little.
BUG=NONE
TEST=Applied the patches in order to check for mistakes.
Review URL: http://codereview.chromium.org/243068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
complexity and clean up some of the ifdefs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/254008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
There are too many tests that take ~1 second every couple hundred runs.
It's not worth the manual maintenance effort.
Review URL: http://codereview.chromium.org/242106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Rebaselining mouse-drag-from-frame-to-other-frame because the upstream test is failing and they updated the expectations upstream to reflect the failure output.
This breaks us, because we are not failing, so we have to rebaseline.
TEST=none
TBR=jparent
Review URL: http://codereview.chromium.org/251061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changed the heading from Themes: to Appearance: and switch
from 'Set to XXX theme' to 'Use XXX theme'.
BUG=21504
Review URL: http://codereview.chromium.org/243059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Escape.EscapeUrlEncodedData
Review URL: http://codereview.chromium.org/257021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This prevents races from arising where extension renderers may try to navigate to extension urls before the request context knows how to map the urls to extension resources.
BUG=22668
Review URL: http://codereview.chromium.org/255047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27781 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'll re-order the methods in webview_impl.cc in a follow-up CL. I
wanted to keep this one easy to review.
SetBackForwardListSize is no longer necessary given that
BackForwardListChromium.cpp doesn't care about its capacity.
R=dglazkov
BUG=10033
TEST=none
Originally reviewed here: http://codereview.chromium.org/251051
Review URL: http://codereview.chromium.org/255042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=23090
Review URL: http://codereview.chromium.org/246057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification of focus changes after the WebWidgetHost has been
deleted, resulting in a crash.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Pick a color for wrong-expectations that is more different from
the browser's selection color.
2. Make the webkit merge color grey instead of black to avoid confusing
it with passing results.
3. Make single-clicking on test paths select the whole test path for
easier copy-pasting.
One functionality improvement. Walk through the paths in test_expectations
in sorted order, not reverse sorted. We want to hit the more specific expectations
*last*, but we were hitting them first. So the less-specific expectations
(e.g. LayoutTests/foo) were overriding the more-specific (e.g. LayoutTests/foo/bar.html).
Review URL: http://codereview.chromium.org/249060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=run chrome with --enable-byte-range-support --incognito and watch a video in http://tinyvid.tv/, seeking should be fine.
http_cache::PartialData used to read a length of zero when reading has reached
the end. The zero parameter will cause MemEntryImpl to complain about invalid
argument, so early return for the case that we know we have nothing to read.
Review URL: http://codereview.chromium.org/255034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27776 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cpu
Review URL: http://codereview.chromium.org/249061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaking this off of the change to single-click because this is
definitely a keeper, that one might be contencious.
http://crbug.com/22980
TEST=Unit test only.
Review URL: http://codereview.chromium.org/242103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=3805
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/244050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[crbug.com/13488].
This turns out to be because it was never implemented.
Tested manually on Windows; I'll test on Linux before submitting.
BUG=13488
TEST=Tested manually on Windows and added a unit test for the new Clipboard function.
Review URL: http://codereview.chromium.org/210042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cpu
Review URL: http://codereview.chromium.org/257022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27771 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This piggybacks on eseidel's fix last July that made middle-clicks work.
BUG=2566
TEST=Manual testing on Vista with GMail and non-GMail links, with ctrl+click, middle-click, click, and ctrl+shift+click.
Review URL: http://codereview.chromium.org/246040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Dock menu contains an automagic section where you can select
amongst open windows. This is wired up to send to the window as a
target, but if JavaScript closes the window in the meanwhile, it
messages a freed object. This short-circuits the specific selector if
the window is no longer valid.
http://crbug.com/14003
TEST=Bug contains instructions and an example html file to help.
Review URL: http://codereview.chromium.org/259001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
LayoutTests/plugins/npruntime.html.
BUG=10401
TEST=plugins/npruntime.html
Review URL: http://codereview.chromium.org/242097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
was overriding the key variable in the function arguments. :(
Review URL: http://codereview.chromium.org/255045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12354
TEST=plugins/netscape-invoke-browserfuncs.html
Review URL: http://codereview.chromium.org/259002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=erikkay@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
CID=6192
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/257013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Some of these are a bit verbose (many lines for one test), but
I think it's worth it to start getting an handle on the flaky
tests and addressing them.
TBR=senorblanco@chromium.org
Review URL: http://codereview.chromium.org/242100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data. A subsequent change will hook it up to the extension APIs.
See http://dl.getdropbox.com/u/124107/badges.png for a picture
of what this looks like.
BUG=23268
Review URL: http://codereview.chromium.org/259004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=2297
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/249058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WidgetWin.
CID=4190
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/255031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changing the default allocator from TCMalloc to
JEMalloc introduced a page load perf regression.
The change is experimental on the trunk. While in
place, adjust expectations to avoid firing the perf
regression framework.
BUG=23565
TEST=XP perf morejs goes green
Review URL: http://codereview.chromium.org/255043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
found here: https://bugs.webkit.org/show_bug.cgi?id=29655
TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch.
BUG=19972
Review URL: http://codereview.chromium.org/223013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
* Keystrokes are now properly sent to plugins in fullscreen mode
* When a plugin creates a fullscreen window, we hide the menu bar and restore it when the window is closed
BUG=19534,21020
TEST=Open a page with plugins that can go full screen (example: flash video players). Enter full screen mode and verify that esc, arrow keys, spacebar, etc. work as expected. Verify that the menu bar is hidden when the plugin goes fullscreen and is restored when it exits fullscreen mode.
Review URL: http://codereview.chromium.org/257008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
CID=4546
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
force Linux symbol dumping.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/243056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
possible. Currently does nothing.
This also adds a "Purge memory" button to the task manager when run with --purge-memory-button, which can be used to test the functionality.
BUG=23400
TEST=Run with --purge-memory-button, open the task manager and see a new button. Click it to toggle it to "Reset purge", and click again to toggle back.
Review URL: http://codereview.chromium.org/259003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Future patches should not break on trybots due to bad merges.
note - this patch will break on mac and linux trybots due to the patch problems - but future patches in these files should not have that problem.
TBR=slightlyoff
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/255041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
stack traces much more informative.
Two TSAN-specific --show-pc=yes flag was added for the helper to operate.
This patch was prepared by Alexander Potapenko (cc'ed)
Review URL: http://codereview.chromium.org/256025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Enable FLIP over SSL.
- Rework the X-Associated-Content.
The server can send us a list of subresources that it plans
to push. The client will keep track of these in a pending
list. If the client tries to request the resource before the
server pushes it, the client will not issue the request, and
will wait until the push stream arrives. Conversely, if the
pushed stream arrives before the client makes a request for
the resource, the stream is added to the pushed_streams list
and waits for a FlipNetworkTransaction to arrive that wants it
(this part of the logic was already in place).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/249046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/255040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27744 0039d316-1c4b-4281-b951-d872f2087c98
|