summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-278-28/+67
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14665 0039d316-1c4b-4281-b951-d872f2087c98
* This patch adds a new kind of tests: browser tests.jcampan@chromium.org2009-04-2710-19/+785
| | | | | | | | | | | | | | | | | | They are intended to provide an alternative to the UI tests, hopefully helping with flackiness. These tests are in-process browser test. There are 2 projects to build the tests: - the browser_test.dll that contains the tests, the gtest framework and the browser classes. - the browser_test_launcher.exe. The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly. This is Windows only for now. BUG=9764 TEST=Run browser_test.exe Review URL: http://codereview.chromium.org/88066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14664 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling in new version of gyp (.def file support for msvs).bradnelson@google.com2009-04-272-2/+1
| | | | | | | | Taking out msvs_settings based use of .def since it now clashes with the mechanism now built in. Review URL: http://codereview.chromium.org/100058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14663 0039d316-1c4b-4281-b951-d872f2087c98
* Fail the plugin initialization if we are unable to duplicate the event ↵ananta@chromium.org2009-04-273-4/+10
| | | | | | | | | | | | | | handle which is used for deciding whether we need to pump window messages in outgoing sync calls from the plugin. The theory is that the DuplicateHandle call could fail if the renderer process exited. It is unclear as to what a reliable test for this would be. Will think over and possibly add in a future CB. Fixes http://code.google.com/p/chromium/issues/detail?id=10972 Bug=10972 Review URL: http://codereview.chromium.org/99018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14662 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for tkent@google.com.ojan@chromium.org2009-04-273-10/+63
| | | | | | | | | | | | | | | Don't use %, ⊅ and &supl; in serialization. The HTML standards don't define them, and IE and Firefox don't support them. BUG=6035 TEST=Load an HTML document with an attribute includes % and ' save the document as "Web Page, Complete", look at the saved file and confirm that - % is saved as is. - ' is saved as ''' git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14661 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling user install testcase to investigate why it fails on the bot and ↵anantha@chromium.org2009-04-271-1/+1
| | | | | | | | not locally. Review URL: http://codereview.chromium.org/99080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14660 0039d316-1c4b-4281-b951-d872f2087c98
* Update selected line in model before accepting input when the user clicks in ↵shess@chromium.org2009-04-272-5/+6
| | | | | | | | | | the popup. BUG=10932 Review URL: http://codereview.chromium.org/93130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14659 0039d316-1c4b-4281-b951-d872f2087c98
* Add quarantine metadata to downloads on the Mac. Patch by Stuart Morganmark@chromium.org2009-04-277-1/+128
| | | | | | | | | | | <stuart.morgan@gmail.com>. BUG=10853 Code review URL: http://codereview.chromium.org/99005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14657 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get multi-process plug-in scaffolding building on Mac.pinkerton@chromium.org2009-04-273-97/+57
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14656 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at turning on -Werror. I think this will work on gcc 4.2,tc@google.com2009-04-271-2/+1
| | | | | | | | | 4.3, and 4.4. I'll watch the bots closely. Review URL: http://codereview.chromium.org/100066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14655 0039d316-1c4b-4281-b951-d872f2087c98
* Its strange that these tests are failing only on bots, but not on local ↵anantha@chromium.org2009-04-272-4/+16
| | | | | | | | machines. I added few checks to get rid of cascading errors. Enabled only one test to see if it passses this time. Review URL: http://codereview.chromium.org/100003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14654 0039d316-1c4b-4281-b951-d872f2087c98
* Update the build installation script to make it work on ubuntu 9.04tc@google.com2009-04-271-3/+3
| | | | | | | | | | | | | | | I had to include the libcairo2-dev package and change the /etc/issue BUG=None TEST=Build chromium in Ubuntu successfully (fresh install) Original patch by Mohamed Mansour and reviewed by Markus: http://codereview.chromium.org/92155 Review URL: http://codereview.chromium.org/99076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14653 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this. jcampan@chromium.org2009-04-273-41/+71
| | | | | | | | | | | | | | | | | | | The Ole unitialization was failing on one of the Vista build-bot. It is not clear when the Ole initialization is balanced when a CRichEditCtrl is created/destructed. So I now turn it off explicitly. This CL makes sure we unregister our Windows window classes when shut-down. It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/101004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14649 0039d316-1c4b-4281-b951-d872f2087c98
* linux: turn on no-op plugins code.evan@chromium.org2009-04-272-1/+17
| | | | | | | | | | | | | | If you don't have any plugins installed, this currently just shows an empty region on the page rather than the default plugin. If you do have plugins installed (and by "installed" I mean "copied into a 'plugins' subdir where your build output is) we now print a lot of NOTIMPLEMENTEDs and hang. Note that we need to #ifdef out some code related to in_process_plugins because we don't have gfx::NativeViewFromId on Linux. Review URL: http://codereview.chromium.org/102001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14646 0039d316-1c4b-4281-b951-d872f2087c98
* linux: make --single-process mean in-process renderer.evan@chromium.org2009-04-271-0/+8
| | | | | | | | | | | | | | | | | | Since we can't have in-process plugins on Linux, let's make single-process do as much of a single process as possible. The alternative is detecting and erroring out on --single-process, then adding a new flag and changing all of the other code that currently examines --single-process to examine both the new flag and --single-process. That seems like a lot of extra code and source of potential error. Note that we print out a warning indicating this on --single-process in the LINUX case. Review URL: http://codereview.chromium.org/100053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14645 0039d316-1c4b-4281-b951-d872f2087c98
* Repair FileVersionInfo leak. Doh.robertshield@google.com2009-04-271-3/+3
| | | | | | Review URL: http://codereview.chromium.org/99068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14642 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up construction of LocationBarViewMac objects.shess@chromium.org2009-04-277-49/+16
| | | | | | | | | | | This removes the need for SetField() accessors on AutocompleteEditViewMac and AutocompletePopupViewMac, and also removes the Init() wart on LocationBarViewMac. Now everything is wired up in the constructor. Review URL: http://codereview.chromium.org/92136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few crashes when trying to drag a closing tab.jhawkins@chromium.org2009-04-272-4/+32
| | | | | | Review URL: http://codereview.chromium.org/99065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14640 0039d316-1c4b-4281-b951-d872f2087c98
* Rev 12100 changed the way that we spool and render printed output, most notablymaruel@chromium.org2009-04-273-1/+21
| | | | | | | | | | | | | | | | | | | | introducing use of the PrintContext class. The existing PrintContext::spoolPage() method applies a webkit scaling factor before rendering output to the graphics context. ChromePrintContext::spoolPage() (in webframe_impl.cc), which is used by chromium instead of PrintContext::spoolPage(), does not apply this scaling factor, but instead eventually returns the scaling factor via WebFrame::PrintPage(). This is a problem for the Chromium Embedded Framework (CEF) because, unlike chromium, the CEF renders directly to the printer device context. It is therefore important for CEF that we retrieve and apply the webkit scaling factor before calling PrintPage(). In order to support this capability the following adds a WebFrame::GetPrintPageShrink() method. Patch contributed by Marshall Greenblatt <magreenblatt@gmail.com> Review: http://codereview.chromium.org/99058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14639 0039d316-1c4b-4281-b951-d872f2087c98
* Adds --no-audio, which replaces the audio IPC layer with a mock audio device.scherkus@chromium.org2009-04-274-8/+24
| | | | | | | | Useful for testing <audio> and <video> over remote desktop or on machines without sound cards. Should also let mac/linux playback videos without our audio layer being implemented on those platforms. Review URL: http://codereview.chromium.org/93132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14637 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typoamanda@chromium.org2009-04-271-1/+1
| | | | | | | TBR=mark Review URL: http://codereview.chromium.org/99070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14632 0039d316-1c4b-4281-b951-d872f2087c98
* Start building the NPAPI layout test plugin on the Mac (it's been buildableamanda@chromium.org2009-04-271-30/+48
| | | | | | | for a while, but evidently got missed in the grand conversion to gyp) Review URL: http://codereview.chromium.org/100051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14631 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps to pickup r14623:ericroman@google.com2009-04-271-1/+1
| | | | | | | | | | | | | | | | | | | | | ---- Unfork change to VisibleSelection.cpp, and instead apply patch that landed upstream <https://bugs.webkit.org/show_bug.cgi?id=25335>. This will apply cleanly for the next person merging. BUG=10645 Review URL: http://codereview.chromium.org/93137 ---- TBR=dglazkov Review URL: http://codereview.chromium.org/100049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14630 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up the TlsGetValue fix.mbelshe@google.com2009-04-271-1/+1
| | | | | | | BUG=10983 Review URL: http://codereview.chromium.org/93143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14629 0039d316-1c4b-4281-b951-d872f2087c98
* More linux ifdef tweaks. This reverts my earlier change (13503).sky@chromium.org2009-04-2720-79/+30
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/100046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14628 0039d316-1c4b-4281-b951-d872f2087c98
* Add the generatd file pull_in_test_shell.scons to svn:ignore list.maruel@chromium.org2009-04-270-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14627 0039d316-1c4b-4281-b951-d872f2087c98
* Add plugin.scons to the svn:ignore list; it is now generated by scons.maruel@chromium.org2009-04-270-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14626 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we have file dialogs, we might as well hook up "Open File" on the Mac.avi@google.com2009-04-273-7/+11
| | | | | | Review URL: http://codereview.chromium.org/93145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14625 0039d316-1c4b-4281-b951-d872f2087c98
* Add svn:ignore to third_party/codesighs/.maruel@chromium.org2009-04-270-0/+0
| | | | | | | | | | | | | | | | | | codesighs.scons codesighs.sln codesighs.vcproj codesighs.xcodeproj codesighs_main.scons maptsvdifftool.scons maptsvdifftool.vcproj msdump2symdb.vcproj msmap2tsv.vcproj nm2tsv.scons SConstruct git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14624 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some warnings in third party code so I can turn on -Werror.tc@google.com2009-04-272-27/+40
| | | | | | | Review URL: http://codereview.chromium.org/101005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14622 0039d316-1c4b-4281-b951-d872f2087c98
* roll DEPS to get ToT gyp which includes make fixestc@google.com2009-04-271-1/+1
| | | | | | | | | TBR=evan Review URL: http://codereview.chromium.org/100048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14621 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively roll back r14549 and r14508. The chrome browsertc@google.com2009-04-274-42/+14
| | | | | | | | | | | | process is pegged at 100% cpu after ui_tests has exited. Seeing if this is the cause. Will re-roll forward if it's not. TBR=estade Review URL: http://codereview.chromium.org/100047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14620 0039d316-1c4b-4281-b951-d872f2087c98
* Add keyboard accelerators for IDC_FIND_NEXT and IDC_FIND_PREVIOUS.willchan@chromium.org2009-04-271-3/+9
| | | | | | Review URL: http://codereview.chromium.org/101007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14619 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow the browser window to be resized so small that layout starts ↵pkasting@chromium.org2009-04-2713-69/+213
| | | | | | | | | | | breaking horribly. When it _is_ small, draw the frame correctly. This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it. BUG=9885 Review URL: http://codereview.chromium.org/100005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14618 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in TaskManagerphajdan.jr@chromium.org2009-04-271-3/+7
| | | | | | | | http://crbug.com/11068 Review URL: http://codereview.chromium.org/99059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14615 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash with <video>hclam@chromium.org2009-04-271-1/+1
| | | | | | | | | | | | Having typo in the file, causing a different dll loaded for <video>. When initializing ffmpeg since avformat-52.dll is not loaded, it tries to do LoadLibrary within sandbox and kaboom! TBR=scherkus Review URL: http://codereview.chromium.org/99024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14614 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a gcc-4.3 warning in tab_strip_gtk.cc.jhawkins@chromium.org2009-04-272-19/+3
| | | | | | | | | | | | | | | | | | | Also factorizes some code in tab_strip.cc and tab_strip_gtk.cc. One of the inlined call to GenerateStartAndEndWidths with end_tab_count = start_tab_count - 1 caused line 164 to be rewritten as: if (start_tab_count < start_tab_count - 1 && which raised the following warning with gcc-4.3: tab_strip_gtk.cc:164: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false patch by vincent.zanotti@gmail.com <http://codereview.chromium.org/99031> R=me Review URL: http://codereview.chromium.org/100045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14613 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to checksum bookmark data to help determine if themunjal@chromium.org2009-04-273-23/+290
| | | | | | | | | | | | | | bookmarks file was changed by the user between two chrome runs. - BookmarkCodec now serializes a checksum of bookmark data along side bookmark data during encoding. - During decoding BookmarkCodec computes the checksum of deserialized data, and it also reads the checksum in the file. - BookmarkCodec exposes both the checksums via getters. - Add unit tests for BookmarkCodec, right now only checksum related. Review URL: http://codereview.chromium.org/69028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14612 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable and set svn:eol-style to LF.tc@google.com2009-04-274-0/+0
| | | | | | | TBR=dean Review URL: http://codereview.chromium.org/99060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14611 0039d316-1c4b-4281-b951-d872f2087c98
* Update OS error message.kuchhal@chromium.org2009-04-272-2/+2
| | | | | | | | | BUG=6381 Review URL: http://codereview.chromium.org/99009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14610 0039d316-1c4b-4281-b951-d872f2087c98
* Searching by keyword now generates a visit against the site with asky@chromium.org2009-04-2718-32/+256
| | | | | | | | | | | | | | | | transition type of TAB_TO_SEARCH. This visit increments the typed count and ensures if you use TAB_TO_SEARCH you still get autocompleted to the site. I'll add some tests for this, but want to make sure we're ok with it before I do that. BUG=3633 TEST=will be covered by unit tests. Review URL: http://codereview.chromium.org/93087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
* Roll DEPS to pick up ConsoleMessage unforkdglazkov@google.com2009-04-271-1/+1
| | | | | | | | | TBR=dimich BUG=10892 TEST=0 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14608 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in a bunch of missing menu items: Stop, Reload, History, Downloads, ↵pinkerton@chromium.org2009-04-271-8/+229
| | | | | | | | Clear browsing data, etc. Review URL: http://codereview.chromium.org/100043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14606 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Omnibox results improvements:deanm@chromium.org2009-04-272-92/+92
| | | | | | | | | | | | | - Honor the damage rect when painting result lines. - Move some code from GdkRectangle to gfx::Rect. - Drop GC creation and just use one from the widget's style. - Fix a bug in content/description width allocation. - Factor out the icon loading and switch into IconForMatch(). Review URL: http://codereview.chromium.org/99050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14605 0039d316-1c4b-4281-b951-d872f2087c98
* Massively improve the performance of dragging a window over our window.deanm@chromium.org2009-04-271-1/+3
| | | | | | | | | | | | | | | | | Our toolbar background is a 1 pixel wide image, which we tile by drawing a pixbuf over and over. The way the toolbar is laid out, everything shares the same window. The toolbar is painted first, then the buttons on top of it, etc. If the toolbar painting is slow, you can see gray trails when you drag a window over and the exposes are slow to come back to X. Honor the damage rect, so when we get tons of tiny exposes we aren't doing this really inefficient tiling over the entire toolbar. Improving the tiling performance needs to be done separately. Review URL: http://codereview.chromium.org/100036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14604 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore whitespace while mirroring Dom to the client.pfeldman@chromium.org2009-04-273-17/+55
| | | | | | Review URL: http://codereview.chromium.org/92125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14603 0039d316-1c4b-4281-b951-d872f2087c98
* Only check errno when it can be set.phajdan.jr@chromium.org2009-04-271-1/+1
| | | | | | | | This is a follow-up after http://codereview.chromium.org/77022 Review URL: http://codereview.chromium.org/99055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14602 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub test for TabStripController. It doesn't fully work because of issuespinkerton@chromium.org2009-04-273-1/+132
| | | | | | creating WebContents objects. A bug has been filed to come back to it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14601 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED() that's not necessary on Mac.pinkerton@chromium.org2009-04-271-1/+5
| | | | | | Review URL: http://codereview.chromium.org/97004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14600 0039d316-1c4b-4281-b951-d872f2087c98
* Add virtual dtor for TaskManager::ResourceProvider.phajdan.jr@chromium.org2009-04-271-0/+2
| | | | | | | | | It has virtual methods but no virtual dtor. This change may help fix memory leaks which appeared after adding unit tests for TaskManager. Review URL: http://codereview.chromium.org/100041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14599 0039d316-1c4b-4281-b951-d872f2087c98