| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Valgrind on Mac
BUG=51387
TBR=jeremy
Review URL: http://codereview.chromium.org/3005060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove unnecessary forward decls.
- Remove unnecessary inclusions of <set>, <map>, <vector>, <list>.
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3023043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I tripped upon this when I temporarily disabled Negotiate authentication to track down an NTLM bug.
BUG=None
TEST=net_unittests doesn't crash when HttpAuthHandlerNegotiate::Init returns false.
Review URL: http://codereview.chromium.org/3085017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a new suppression for bug 51263 (Numerous memory leaks in
chromeos::CrosLibrary::EnsureLoaded())
BUG=51263,51076
TBR=timurrrr
Review URL: http://codereview.chromium.org/3083019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID= 12238
Review URL: http://codereview.chromium.org/3086019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into devtools front-end.
Added support for enumerating devtools extensions in devtools' DOM UI.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3074025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=PrefValueStoreTest.*
BUG=51176
Review URL: http://codereview.chromium.org/3031047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will allow for having per plugin content settings, i.e. the content settings type would be plugin and the resource identifier would be to concrete plugin that is about to be loaded.
BUG=39252
TEST=unit_tests
Review URL: http://codereview.chromium.org/2878075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51379
TBR=timurrrr
Review URL: http://codereview.chromium.org/3084020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some reason, this is necessary to fold very long language names
into two lines in left-aligned. Example:
Spanish (Latin America and the Caribbean) - español (Latinoamérica y el Caribe)
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3085021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
overlay.
We should've used "set" rather than "vector" to remove duplicates.
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3043058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
~4% regression on Page cycler intl1 across all platforms.
BUG=none
TEST=none
TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/3073032
TBR=sgjesse@google.com
Review URL: http://codereview.chromium.org/3058056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
than create our own
BUG=chromium-os:4706
TEST=open chrome os, go to maps.google.com click my location, check it doesn't crash.
Review URL: http://codereview.chromium.org/3027042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2883063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
knowledge the PrefService has of its two-levels-deep implementation.
Create a TestingPrefService::TestingPrefValueStore to allow tests to set the PrefStores directly, as they used to be able to do.
BUG=50722
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3032058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=51225
TEST=none needed
Review URL: http://codereview.chromium.org/3072022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/3073032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=45230
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/3069033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I pulled out the code to update the socket connectivity stats.
I added defensive code which should preclude the crash that
was reported on the stability bot.
I added a second call to update the stats from
~ClientSocketHandle to ensure that we updated the
related ClientSocket when we are torn down.
As noted in the original checkin:
Enable speculative preconnection by default
Added histogram to track preconnection utilization (vs waste).
BUG=42694
r=mbelshe
Review URL: http://codereview.chromium.org/3050040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Handles the new wrench menu.
2. Uses NotifyAccessibilityEvent to find out when focus changes, rather
than installing focus change listeners that need to be cleaned up.
BUG=none
TEST=Updated AccessibilityEventRouterViewsTest.TestFocusNotification
Review URL: http://codereview.chromium.org/3056045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Build the language list from supported input methods, as well
as kExtraLanguages which don't have associated input methods.
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3072028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=lrn@chromium.org
Review URL: http://codereview.chromium.org/2856093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=confirmed chrome built fine.
Review URL: http://codereview.chromium.org/3081019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3037044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3010052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=unit tests pass
Review URL: http://codereview.chromium.org/3081018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support validation of font hinting code (Adobe Type2 Charstring format.)
BUG=51070
TEST=Verified that Chromium renderer does not crash with the exploit HTML on Windows Vista.
TBR=agl
Review URL: http://codereview.chromium.org/3007039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on first login.
BUG=chromium-os:5332
TEST=On initial login, have the UI set to non-english. Go to the language options menu. Check that both English and the interface language show up.
Review URL: http://codereview.chromium.org/3010053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3074036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This causes two strings (Title, non-title) to hash to the same value and we
only get one translation in the .xtb.
BUG= http://crbug.com/44539
Review URL: http://codereview.chromium.org/3072027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was missed in another review at
http://codereview.chromium.org/3043018/diff/22001/23009#newcode28, noticed by
viettrungluu.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3030035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
{ASSERT,EXPECT}_NS{NE,EQ}. These test ObjC objects using |-isEqual:| and
prints failures using the |-description| selector. This allows for better
debugging output with ObjC++ test cases.
BUG=http://code.google.com/p/googletest/issues/detail?id=303
TEST=Covered by unit tests.
Review URL: http://codereview.chromium.org/3028047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=out/Debug/app_unittests --gtest_filter=TreeNodeModelTest.*
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3017023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use this same accessibility event code to make the Chrome OS login
screen speak, before accessibility extensions are loaded.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3073026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3086017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows and Linux (both Views and GTK+), this makes
Ctrl-R, F5, and regular clicks on the reload button do
regular reloads, while Ctrl-Shift-R, Shift-F5, Control-F5,
and holding Shift or Control while clicking the button all
bypass the cache.
It does the same for the reload button on Mac, but I'm not
modifying any Mac keyboard shortcuts in this change (it
looks like Command-Shift-R already bypasses the cache).
I've updated http://crbug.com/38356 to mention that when
the F5 shortcut is added to Mac, the cache-bypassing
modifiers should also be supported.
BUG=47383
TEST=none
Review URL: http://codereview.chromium.org/2876008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50598
TEST=tools/heapcheck/chrome_tests.sh -t unit --gtest_filter=PhishingDOM*
Review URL: http://codereview.chromium.org/3092010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48857
TEST=none
Review URL: http://codereview.chromium.org/3029061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=manually
BUG=chromium-os:4573
Review URL: http://codereview.chromium.org/3032057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36591
TEST=manually test that network change notifications happen at the right time.
Review URL: http://codereview.chromium.org/2881027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
layout.
BUG=none
TEST=Add the Dutch input method. Set the input method to US Querty. Log out. Log in. Ensure the starting input method is US Querty.
Review URL: http://codereview.chromium.org/3080027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=unit tests
BUG=41300
Review URL: http://codereview.chromium.org/3058043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the part 3 of this series. One more remaining. Splitting this
into small parts, so it is more easy to review and reduce the size of the CL.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/2836088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=pfeldman
Review URL: http://codereview.chromium.org/3031050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49590
TEST=valgrind unit_tests
Review URL: http://codereview.chromium.org/3041052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initializer for the class can sometimes return nil. If so, do not try to
access an ivar directly.
BUG=51307
TEST=none
Review URL: http://codereview.chromium.org/3060047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
only two listed in template_url_prepopulate_data).
Fix invalid search URL in in.gr search engine.
BUG= 51295
TEST= Vietnam and Iran search engine dialogs work fine, searching with in.gr (from Greek default search engine choices) works.
Review URL: http://codereview.chromium.org/3007032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Send the popupmenu events on the MenuScrollViewContainer since it is the View with the ROLE_MENUPOPUP role.
- Return AccessibilityTypes::STATE_FOCUSED for MenuScrollViewContainer since it's not focused by MenuHostWin::ShowMenuHost. NVDA won't process children menu item's focus events unless a parent claims to have focus.
TEST=The wrench menu and it's menu items are read aloud when using NVDA.
BUG=49360
Review URL: http://codereview.chromium.org/3015055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55163 0039d316-1c4b-4281-b951-d872f2087c98
|