| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
several tries.
Do not retry on 415 error, because request will never succeed (as per discussion with Abhijit)
BUG=none
TEST=Verify proxy marks jobs as Error, if we failed to convert on server side.
Review URL: http://codereview.chromium.org/6901159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
while it is open. The [popup close] call here previously prevented the popup's unload handler from firing. This changes the behavior to be consistent with Windows in that clicking a browser action will always open its popup (regardless of what popup is already open).
BUG=31262
TEST=Click a browser action icon repeatedly, and observe unload and load events both firing as expected. (Unfortunately, the unload for the closing popup and the load for the opening popup still fire in an indeterminate order.)
Review URL: http://codereview.chromium.org/6931023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=81706
TBR=sail@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
underlaySurfaceAdded/Removed
This fixes a regression where the window shadow problem was visible on all pages,
not just on gpu-accelerated ones.
BUG=56154
TEST=window shadow should look good on ntp, but broken on youtube.
Review URL: http://codereview.chromium.org/6935010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When file-selection dialogs are forbidden by policy it is better to force the PromptForDownload preference to false and automatically download to the default location, since otherwise the user would just be prompted with a message saying that file-selection dialogs are disallowed.
Also cleaned up ConfigurationPolicyPrefStore* tests.
BUG=73174
TEST=Manually set the policy to false and verify that the PromptForDownload preference is false and cannot be turned on. Added ConfigurationPolicyPrefStorePromptDownloadTest.*.
Review URL: http://codereview.chromium.org/6927008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6932024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6935028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12855,chromium-os:14385,chromium-os:11035,chromium-os:13424,chromium-os:8778,chromium-os:8252,chromium-os:14702
TEST=requires manual testing of all features.
Review URL: http://codereview.chromium.org/6878087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12653
R=dtu@chromium.org
TEST=
Review URL: http://codereview.chromium.org/6929025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove switchToMode().
* Remove setting the iframeToShow argument, since it's unused.
* Rename the syncEverything argument to showSyncEverythingPage.
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6933024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=81685
TEST=find_in_page.FindMatchTests.testSearchInPDF, pdf.PDFTest.testPDFRunner
Review URL: http://codereview.chromium.org/6931035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Expose carrierID (homeProvider).
- Check for deal validity (locale, date).
- Add deal notification text to 3G promo bubble.
- Use top up URL from carrier deal as "View Account" link in network menu/promo.
BUG=chromium-os:14575, chromium-os:14671
TEST=Manual. Used manifest with deal for local provider, checked that UI elements are customized.
Review URL: http://codereview.chromium.org/6929011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=81688
TBR=rsimha@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12829
TEST=Manual
Review URL: http://codereview.chromium.org/6928034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/6929021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac (x86-32 only):
chrome/chrome_dll.gypi
Linux (x86-32 or x86-64, depending on the target arch):
chrome/chrome_installer.gypi
chrome/tools/build/linux/FILES.cfg
Windows (both x86-32 and x86-64 in the same install image)
chrome/installer/mini_installer.gyp
chrome/installer/mini_installer/chrome.release
chrome/tools/build/win/FILES.cfg
I am not sure if I need to add to the lists in
chrome/tools/build/{linux,win}/FILES. Since there are files listed in
FILES.cfg that are not in FILES, I will assume not.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=not sure how to test this, apart from manually testing the
install images that are produced after this is committed
Review URL: http://codereview.chromium.org/6927015
TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/6927050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81679
TEST=PrerenderBrowserTest.PrerenderInfiniteLoop
Review URL: http://codereview.chromium.org/6931032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since r83705, Value::GetAsDouble() can return an integer value as double. We no longer need to call Value::GetAsInteger() explicitly.
BUG=None
TEST=ran try
Review URL: http://codereview.chromium.org/6901084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of some timing changes we made (to give the tests more time to run).
BUG=48544,51012
Review URL: http://codereview.chromium.org/6927030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=PrerenderBrowserTest.PrerenderInfiniteLoop
Review URL: http://codereview.chromium.org/6929039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=66072
TEST=notifications.NotificationsTest.testNotificationOrderAfterClosingOne
Review URL: http://codereview.chromium.org/6927034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
around to reusing it.
BUG=none
TEST=net_unittests --gtest_filter=HttpNetworkTransactionTest.BasicAuthKeepAliveImpatientServer:*.BasicAuthKeepAliveNoBody:*.BasicAuthKeepAliveLargeBody && unit_tests --gtest_filter=*TransportClientSocketTest.IsConnected*
Review URL: http://codereview.chromium.org/6902165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6927038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac (x86-32 only):
chrome/chrome_dll.gypi
Linux (x86-32 or x86-64, depending on the target arch):
chrome/chrome_installer.gypi
chrome/tools/build/linux/FILES.cfg
Windows (both x86-32 and x86-64 in the same install image)
chrome/installer/mini_installer.gyp
chrome/installer/mini_installer/chrome.release
chrome/tools/build/win/FILES.cfg
I am not sure if I need to add to the lists in
chrome/tools/build/{linux,win}/FILES. Since there are files listed in
FILES.cfg that are not in FILES, I will assume not.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=not sure how to test this, apart from manually testing the
install images that are produced after this is committed
Review URL: http://codereview.chromium.org/6927015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
where connects take a long time to fail.
R=eroman@chromium.org,mbelshe@chromium.org
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6905080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the multi-install binaries' ClientState{Medium} key.
BUG=none
TEST=Confirm no substantive change in single-install Chrome. In multi-install, usagestats should be in the ClientState\{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D} and/or ClientStateMedium\{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D} key. Enabling/disabling usage stats for multi-install Chrome (via Under the Hood) should control crash reports and UMA for multi-install Chrome Frame.
Review URL: http://codereview.chromium.org/6936001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=48930
TEST=browser tests
Review URL: http://codereview.chromium.org/6923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Requested by Kurt Seifried.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dereferencing a NULL
ExtensionEventRouter object pointer retrieved from the profile. ChromeFrame net tests run the browser
as a single process executable. Extensions may not exist in these cases.
BUG=none
TEST=chrome frame net tests should run.
TBR=battre
Review URL: http://codereview.chromium.org/6935024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
when using TabContents.
BUG=81229
TEST=PrerenderBrowserTest.PrerenderDelayLoadPlugin, PrerenderIframeDelayLoadPlugin, PrerenderHTML5Audio, PrerenderHTML5Video, PrerenderHTML5VideoJs when PrerenderContents::UseTabContents is true.
Review URL: http://codereview.chromium.org/6928012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58145
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6930035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81658
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6933028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=51716
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6929034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=inferno@chromium.org
TBR=morrita@chromium.org
Review URL: http://codereview.chromium.org/6932040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Change test_suppressions.py and suppressions.py in order to respect the heapchecker suppressions.
Refactor the tests in suppressions.py a bit.
BUG=73154
Review URL: http://codereview.chromium.org/6902031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/6927011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
/b/build/slave/Mac_Clang__dbg_/build/src/chrome/browser/ui/cocoa/first_run_dialog.mm:152:13:error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
model && !model->is_default_search_managed()) {
~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/build/slave/Mac_Clang__dbg_/build/src/chrome/browser/ui/cocoa/first_run_dialog.mm:152:13: note: place parentheses around the '&&' expression to silence this warning
model && !model->is_default_search_managed()) {
^
( )
1 error generated.
TBR: sheriff maf when he wakes up. :-)
Review URL: http://codereview.chromium.org/6935023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81658
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6935022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81657
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6927043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=81578
TEST=no search engine selector in organic builds in Russian locale.
Review URL: http://codereview.chromium.org/6927022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81652
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6935021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81438
TEST=none
TBR=glider@chromium.org
Review URL: http://codereview.chromium.org/6932036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TabContents-based-prerender.
BUG=81427
TEST=browser_tests --gtest_filter=*PrerenderHttpAuthentication*
Review URL: http://codereview.chromium.org/6909030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TBR=inferno@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/net/base/
Contributor: kushi.p@gmail.com
BUG=58409
Review URL: http://codereview.chromium.org/6905059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crypto_helpers only depends on resources in base and is used by sync and
password_manager.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6873156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6933026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1742
TEST=./out/Debug/chrome --nacl-loader-cmd-prefix='strace -c'
Review URL: http://codereview.chromium.org/6883220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6903156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84220 0039d316-1c4b-4281-b951-d872f2087c98
|