| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The use of a protected virtual destructor is to prevent the destruction of a
derived object via a base-class pointer.
That's it, ComboboxModel should only be deleted through derived class.
Example 1:
class FooComboboxModel : public ComboboxModel {
};
ComboboxModel* model = new FooComboboxModel;
delete model; // It should prevent this situation!
Also, a protected virtual destructor makes it clear that someone else owns the
object.
Example 2:
class Foo {
public:
void SetModel(ComboboxModel* model);
};
If you see that the model has a protected destructor, you know Foo doesn't own
|model|.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9817007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing lazy JS object code only allows single objects to be evaluated
lazily, but a common pattern in existing modules is to define multiple objects
and functions in the same closure and attach them as various fields on an
existing object, which that interface doesn't provide for. The approach
implemented in this change leverages the module system by allowing clients to
set 'lazy fields' on already existing objects, which when accessed evaluate to
a given field in a given module.
BUG=104100
TEST=unit tests provided
Review URL: http://codereview.chromium.org/9812025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=binji
BUG=
TEST=
Review URL: http://codereview.chromium.org/9794003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117915
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/9691032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable one-click signin on OS X.
Build Cocoa version of one-click signin dialog.
Refactor one-click signin code to make it easier to unit test.
BUG=116685
TEST=On OSX, with a clean profile, sign into GMail. The one-click infobar should pop up, and clicking "OK, sync" should bring up the one-click dialog.
Review URL: https://chromiumcodereview.appspot.com/9753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Graphics2D, *InputEvent, Instance, ImageData, Module, Rect, URLLoader, URLRequestInfo and URLResponseInfo.
BUG=107398
Review URL: https://chromiumcodereview.appspot.com/9700088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
global error.
Move disabled-extension interface to namespace extensions.
It looks like this:
http://dl.dropbox.com/u/27111995/Mocks/disable-dialog.png
http://dl.dropbox.com/u/27111995/Mocks/disable-menu.png
BUG=108202
TEST=install extension, update to version that requires additional permissions. Accept upgrade. Uninstall manually from chrome://extensions. Don't crash.
Review URL: http://codereview.chromium.org/9718008
TBR=yoz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9802007
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9812033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116987
TEST=Manual
Review URL: http://codereview.chromium.org/9817003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Scrolling with a mousewheel in X has historically generated
matching button press and release events. We were mapping
both presses and releases to ET_MOUSEWHEEL, resulting in two
scrolls for each step of the wheel in Aura. This change
makes us return ET_UNKNOWN for release events, which results
in them getting dropped by aura::RootWindowHostLinux.
BUG=118608
TEST=added a small unit test; also manually checked that the wheel scrolls by 53 pixels in aura instead of 106 and that gtk still works
Review URL: https://chromiumcodereview.appspot.com/9812024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the offersPrivate API
BUG=chromium-os:27854
TEST=navigate to the extension main page, verify chrome.offersPrivate namespace
is visible.
Review URL: http://codereview.chromium.org/9703093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TestUDPSocketPrivateShared->TestUDPSocketPrivate.
-Removed TestTCPSocketPrivateShared. As far as I can tell it performs the exact same tests as TestTCPSocketPrivate.
-Renamed TestUDPSocketPrivateShared to conform to the naming conventions of other files.
-Enabled in-process tests for TCP/UDP as they appear to be working.
BUG=None
TEST=Ran browser_tests
Review URL: http://codereview.chromium.org/9769015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
100: Let FinancialPingTest use RlzValueStore instead of direct registry access.
101: Make rlz_lib_test.cc and financial_ping_test.cc build on mac.
102: Move registry functions from lib_values into rlz_value_store_registry.
103: Add OVERRIDE annotations to rlz_test_helpers.
104: Move rlz_test_helpers from win\test to test.
105: Move rlz_lib_test.cc and financial_ping_test.cc to common directory.
All changes should be no-ops on windows.
BUG=46579
TEST=none
TBR=rogerta
Review URL: http://codereview.chromium.org/9814024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The prefix "ibus_" is no longer relevant because IBus is not used anymore for a keyboard whose ID starts with "xkb:". Another reason to avoid the prefix is that we're likely going to reimplement some of the input methods as Chrome extensions.
BUG=chromium-os:19655
TEST=try
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127471
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127914
Review URL: http://codereview.chromium.org/9721017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements the Chrome To Mobile extension in Chrome.
Consume ChromeToMobileService as done in Views:
See http://codereview.chromium.org/9443007/ and follow-ups.
Add a page action icon when the service reports 1+ devices.
Show a bubble to send the current page URL / MHTML snapshot.
BUG=102709
TEST=Chrome To Mobile GTK UI works as expected :)
Review URL: http://codereview.chromium.org/9689087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jennb
Review URL: https://chromiumcodereview.appspot.com/9814027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ppapi/examples/audio_input
Review URL: http://codereview.chromium.org/9705056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PopArrayFromVariant() appends values to the existing value, rather
than clearing first like I expected, so using this without clear()
first means the property value accumulates all values and never
loses them.
BUG=none
TEST=unit test included
Change-Id: Ie392a89190f4ad8570a905f24b2f446e1f2bed81
R=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9809001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Change the detach threshold to 100 pixeles.
2) Add the animation for the docked panel jumped to the detached position.
3) Fix the gap issue when a detached panel is reattached.
4) Fix the issue with mouse moving slowly on drag.
BUG=118548
TEST=existing tests and manual test by dragging panels around to verify issues fixed
Review URL: https://chromiumcodereview.appspot.com/9767001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
state on 10.8.
On 10.8, parent window key state sharing has changed semantic meaning to also
include when the NSWindowDidResignKeyNotification is sent. This change adds two
event taps, in the same manner as NSPopover does (c.f. bug for details), to
properly dismiss bubble windows.
BUG=116179TEST=On 10.8, open the bookmark bubble, extension bubbles, and the page info bubble. They are all dismissed wh
en you click outside the window or switch applications.
Review URL: http://codereview.chromium.org/9732012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:28162
TEST=manual.
Review URL: https://chromiumcodereview.appspot.com/9815012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
mac-release-10.5/intl2: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl2/report.html?history=100&rev=125325&graph=processes
TBR=nsylvain@chromium.org
BUG=118321
Review URL: https://chromiumcodereview.appspot.com/9811025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128104 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The events are added to GDataFileSystem::Observer.
Along the way, add tests in gdata_file_system_unittest.cc to test
the observer.
BUG=chromium-os:27835
TEST=unit_tests
Review URL: https://chromiumcodereview.appspot.com/9811023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previous ScreenRecorder was calling .get() and .Pass() for the same scoped_ptr
variable in one function call. These calls were executed in undefined order, so
it was crashing when compiled with GCC or VC, but not with clang.
Review URL: https://chromiumcodereview.appspot.com/9815031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
samples.json now contains links to functions and events that are inside of
types.
BUG=105243
TEST=None
Review URL: http://codereview.chromium.org/9730025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since dbus::ObjectProxy is silently cached, with no way to invalidate,
it's possible that individual instances of objects will come and go
using the same underlying object proxy. i.e. dbus::PropertySet
These will need to change the signal callbacks to be bound to their
own instance, so the current behaviour of failing in this case with
a log message is pessimal.
Change dbus::ObjectProxy to overwrite the existing signal callbacks
with the new ones on repeated calls, rather than preserve the first.
BUG=chromium-os:28064
TEST=unit test included, and we receive property notifications on devices after connection now
Change-Id: Ic4ae092163a364c53bdfcf88f4ce8f74b110b5cb
R=satorux@chromium.org
Review URL: http://codereview.chromium.org/9808001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OnPasswordFormsVisible -> OnPasswordFormsRendered
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9796011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128099 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplifies the field trials by removing the unnecessary a/b split. Also:
+ Updates 'ix' param codes and group percentages.
+ Removes UMA restriction, but this is a no-op at the moment, since it's
handled on the server side.
BUG=none
TEST=none (no change in functionality or UI).
Review URL: http://codereview.chromium.org/9797003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128098 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as subresources, even though the extension is not allowed in incognito.
BUG=118721
TEST=see bug for repro; try the proof of concept in incognito mode with adblock installed but not allowed in incognito. adblock should not be detected.
Review URL: http://codereview.chromium.org/9726025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
understand failures on XP bots.
(There is code duplication here, but we should be able to undo it after we understand the failures.)
BUG=108202
TEST=no
Review URL: https://chromiumcodereview.appspot.com/9828002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Provide render_process_id from RenderProcessHostImpl and WorkerProcessHost
to SocketStreamDispatcherHost.
- Provide render_view_id from SocketStreamHost to SocketStreamDispatcherHost.
- Implement SSLErrorHandler::Delegate in SocketStreamDispatcherHost.
- Then use SSLManager in SocketStreamDispatcherHost.
BUG=53836
TEST=none
Review URL: http://codereview.chromium.org/9704045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/9703097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:26646
TEST=none
Review URL: http://codereview.chromium.org/9748009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing CertVerifier implementation has been renamed to
MultiThreadedCertVerifier, consistent with ProxyResolver naming.
This is patch 1 of N for http://crbug.com/114343
BUG=114343
TEST=Compiles and existing unittests pass.
Review URL: https://chromiumcodereview.appspot.com/9476035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9358076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only call OnPassphraseRequired if the cryptographer is not ready, and
we set the reason based on whether there are pending keys.
Also make sure SetDecryptionPassphrase properly handles return value.
BUG=118243
TEST=
Review URL: https://chromiumcodereview.appspot.com/9796001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:28171
TEST=policy.py
Change-Id: Id44c546aa4268318ed4aed4a29b73f204e1b672e
Review URL: https://chromiumcodereview.appspot.com/9829002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually
Review URL: http://codereview.chromium.org/9790001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9826001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
ProtectorSessionStartupTest.testSessionStartupChangeDismissedOnEdit, the new pyauto test failed on all platform.
BUG=119326
Review URL: http://codereview.chromium.org/9821001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/9696057
BUG=110143, 119233
TEST=Test favicon behavior thoroughly. On Ash with the latest GTalk, avatar icons should show in the launcher and status icons should show in the title bar.
Review URL: https://chromiumcodereview.appspot.com/9810023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
hundred LNK4254 and LNK4078 warnings. This CL disables both warnings when compiling using "Express" versions of Visual Studio.
Review URL: http://codereview.chromium.org/9718030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use the Options key instead of the Command key. Oops.
BUG=101578
TEST=Used Options Key when clicking on Mac panel titlebars.
Review URL: https://chromiumcodereview.appspot.com/9810024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes light flicker on boot.
BUG=chromium-os:28161
TEST=No light flickering on boot.
Review URL: http://codereview.chromium.org/9816014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GpuChildThread.
The Android build uses this flag, which assumes that the GPU process host creates the ChildProcess instance. This regressed in r126140.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9815011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
inside a dir writable at Low Integrity for the chrome gpu process
BUG=119131
TEST=ran chrome_tests.bat with and without --keep_logs
Review URL: https://chromiumcodereview.appspot.com/9769005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119298
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9823001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
does it.
Review URL: https://chromiumcodereview.appspot.com/9801005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119233
TEST=chrome_frame_tests.exe RefreshContentsUATest doesn't flake like this anymore
Review URL: http://codereview.chromium.org/9801008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=119218
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9818003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128071 0039d316-1c4b-4281-b951-d872f2087c98
|