| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
or indirectly to pass.
With the recent Singleton refactoring, these tests started exposing some inherent problems with singletons, namely that one test can reference a state set by a different test, which can cause all sorts of flakiness.
Furthermore, some of these tests could reference the registry which may have some user specific settings that could cause the tests to fail
To work around these issues, I'm adding a few utility classes for tests (registry virtualization) and exposing a method to reset singletons before a test is run.
TEST=Fixes flakiness and a few tests that could fail on the waterfall.
BUG=none
Review URL: http://codereview.chromium.org/5564009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Everything builds.
Review URL: http://codereview.chromium.org/5633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will re-enable after a canary goes out with this off.
BUG=65948
TEST=none
Review URL: http://codereview.chromium.org/5592009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65973
TEST=This is hard to test; when CEEE auto-updates while your browser is running, you should see no prompt for elevation like the one in the section "Starting Processes from Protected Mode" in this article: http://msdn.microsoft.com/en-us/library/bb250462(VS.85).aspx
Review URL: http://codereview.chromium.org/5663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created in IE. This happens when the Chrome Frame instances used by the
BHO navigates to "about:blank". By navigating the Chrome Frame to a web page
inside the loaded extension, whether the page exists or not, causes the
existing extension process to be reused for these Chrome Frame instances
instead of a new process being created.
BUG=65966
TEST=create new tabs in IE and make sure that new chrome renderer processes
are not created
Review URL: http://codereview.chromium.org/5526012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=ctguil
Review URL: http://codereview.chromium.org/5532010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65387
TEST=Open task manager, open two new tabs, close first tab
Review URL: http://codereview.chromium.org/5656007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show default stock icons for the bookmark bar context menus, and use gtk-save-as icon instead gtk-save for the 'Save .. As ...' items.
Also, use IDC_ values instead of IDS_ values for the bookmark-bar context menus.
BUG=65441
TEST=manual, see bug.
Review URL: http://codereview.chromium.org/5659003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58323
TEST=current tests
Review URL: http://codereview.chromium.org/5522014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Insted of keeping semi-fixed frame rate, now capturing rate is controlled
by how fast we can send data to the client. Capturing of frame n is
started only after frame n-2 is sent (while n-1 is being encoded). This
guarantees that we don't clog the video channel buffers, and that we start
capturing only if we know that the frame will not need to wait for too long
in the buffer.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/5634002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/5656003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Tighten up test by verifying that the number of descriptors received was what we expected and that we didn't exit the message loop due to channel closing unexpectedly.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/5518007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this can lead to no caching.
BUG=65809
TEST=none
Review URL: http://codereview.chromium.org/5625011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
requires adding support for IAccessible2 interfaces.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4406002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac code to the file thread.
BUG=59265
TEST=none
This patch also splits platform-specific LaunchOnStartup code to platform-specific files, eliminating #if blocks from the primary source file.
Review URL: http://codereview.chromium.org/5368002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
webNavigation APIs on IE CEEE.
(landing for yzshen@chromium.org)
BUG=65952
TEST=none
Review URL: http://codereview.chromium.org/5635010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster.
In a future change, I will remove the "internal.h" files since they're no longer needed.
Review URL: http://codereview.chromium.org/5526008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=built and ran chrome; checked that it was interacting with libcros
BUG=chromium-os:4816
Review URL: http://codereview.chromium.org/5603012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We are moving to using a DEPS file for extra chromium os deps that is checked into the main Chromium tree. As an artifact of the way gclient works, this means that devs will have a r/w version of this file in their source tree and _also_ a read-only version that gclient checks out somewhere else. This README explains this and how to update the DEPS file correctly.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5587011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
occurred because AutocompleteInput strips whitespace, but whitespace
matters for suggest text.
BUG=65701
TEST=see bug
Review URL: http://codereview.chromium.org/5561008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also change the URL as per Support.
BUG=51105
TEST=None
Review URL: http://codereview.chromium.org/5629005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65940
TEST=None
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/5620009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The change deinlines the << operator.
BUG=65151
Review URL: http://codereview.chromium.org/5625013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/5649003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In UrlmonUrlRequestManager::StopAll we meant to clear the map but
used map.empty() instead of map.clear().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5656004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This site has regressed sadly, but it's close enough to the Chrome 8
launch that I'm accepting it.
BUG=65694
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5650002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=64694
TEST=none
Review URL: http://codereview.chromium.org/5610005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
achieve this by leaving the label unselected until the animation starts. The unselected label has a transparent background. Credit for the fix goes to suzhe.
BUG=65817
TEST=manual
Review URL: http://codereview.chromium.org/5518009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65940
TEST=None
TBR=dmaclach@chromium.org
Review URL: http://codereview.chromium.org/5511017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=65932
TEST=None
TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/5629006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
work. When you press tab/right-arrow we tell the search provider to
update the results. The search provider ignores the request if it was
previously told there are no more results coming. When the location
bar updates (AutocompleteEditController::OnChanged) it tells the
search provider there are no more results coming if whatever it is
loading supports instant. The bug was the existing code was using the
state of what is being displayed when it should have been using the
state of what is being loaded, otherwise if they are different it
prematurely finalizes the search provider so that when we go to commit
it does nothing.
I'm also fixing a bug in LocationBarViewGtk::OnCommitSuggestedText. It
wasn't updating instant and it now needs to.
Lastly I changed windows to not fade out the background if animations
are disabled (this doesn't really fit in with these changes, but I'm
trying to minimize merges).
BUG=65706
TEST=see bug, although this is heavily dependant upon your profile.
Review URL: http://codereview.chromium.org/5659004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following css properties where updated.
-webkit-background-size
-webkit-box-sizing
-webkit-border-radius
-webkit-border-top-left-radius
-webkit-border-top-right-radius
-webkit-border-bottom-left-radius
-webkit-border-bottom-right-radius
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/5672001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Simplify debugging some Linux issues on the Mac by allowing Mac users to compile with IPC_USES_READWRITE set to 1 and pass file descriptors in the same manner that Linux does by default.
Previously it was all controlled by #if !defined OS_MACOSX.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/5563005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The third notification was not showing because it did not fit on the screen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5552007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=65899
TEST=None
Review URL: http://codereview.chromium.org/5665003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Remoting unittests
Review URL: http://codereview.chromium.org/5559011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- made details page buttons consistent with list view options
- renamed [Cancel] to [Close] on details page
- aligned all details buttons at the bottom line
- fixed shown messages when cellular is not connected, no plan, etc
BUG=chromium-os:9823, chromium-os:9708, chromium-os:9870
TEST=see bugs above for repro details
Review URL: http://codereview.chromium.org/5634007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/5587006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
declarations and friend classes. Fix cpplint.py nits.
Cancel() should do nothing if it has been called before.
Remove all (rather than just the first) expired elements
from the cache.
R=agl
BUG=none
TEST=no compilation errors.
Review URL: http://codereview.chromium.org/5611006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5560011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hides some of the internals of the posix channels from users, and gets rid
of several #ifdef POSIX blocks. Generally simplifies usage of channels xplatform.
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/5598010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=They work locally
Review URL: http://codereview.chromium.org/5639007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ellyjones@chromium.org:
chromeos: Connect to networks in unknown activation state.
This allows us to connect to GSM networks through the UI, which do not report an
activation state.
BUG=chromium-os:10077
TEST=Tried it
TBR=ellyjones
Review URL: http://codereview.chromium.org/5519017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=joth
BUG=none
TEST=no compilation errors.
Review URL: http://codereview.chromium.org/5511015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68615 0039d316-1c4b-4281-b951-d872f2087c98
|