summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Renames IViewManagerClient::OnConnectionEstablishedsky@chromium.org2014-05-246-22/+23
| | | | | | | | | | | | InterfaceImpl has a function of the same name. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/291193012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272646 0039d316-1c4b-4281-b951-d872f2087c98
* Fix WeakPtrFactory member order in net/url_request/n.bansal@samsung.com2014-05-247-13/+15
| | | | | | | | BUG=303818 Review URL: https://codereview.chromium.org/252003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272645 0039d316-1c4b-4281-b951-d872f2087c98
* Add new test data for ChunkDemuxer tests. BUG=371633dalecurtis@google.com2014-05-231-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272640 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: Remove clang plugins from ppapi/tests/clangdmichael@chromium.org2014-05-234-448/+0
| | | | | | | | | | | | | We don't use these anymore, and they have bitrotted and probably don't even build with recent Clang. If we want them back, we can get them back out of SVN/git. R=teravest@chromium.org BUG= Review URL: https://codereview.chromium.org/297963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272639 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 272565 "Re-land: cc: Fail more visibly when sync queries ..."kbr@chromium.org2014-05-231-18/+0
| | | | | | | | | | | | | | | | | | | | | | | Caused two native crashes in contentshell_instrumentation_tests on Android Tests (dbg) bot on Blink waterfall. BUG=377053,371530,373360 > Re-land: cc: Fail more visibly when sync queries are not working correctly. > > Instead of creating an infinite number of sync queries, which will > eventually cause performance issues, log an error message and block > until oldest query has passed when reaching 16 pending queries. > > BUG=371530,373360 > > Review URL: https://codereview.chromium.org/280543003 TBR=reveman@chromium.org Review URL: https://codereview.chromium.org/299923005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272638 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose --disable-gpu-compositing, only set internally.piman@chromium.org2014-05-233-3/+1
| | | | | | | | | | | | The flag isn't meant to be set externally, it doesn't work on most configs. It's only meant internally to make sure the renderer doesn't try to use GPU when the browser is in software. BUG=None Review URL: https://codereview.chromium.org/300523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272636 0039d316-1c4b-4281-b951-d872f2087c98
* cc: Examine layers to determine if we're ready to activate.reveman@chromium.org2014-05-2313-149/+269
| | | | | | | | | | | | | | | | | | | | | | | | This introduces a new mechanism for determining when we're ready to activate the pending tree. The tile priority is still used to determine when it's worth waking up the compositor thread and evaluating if we can activate. However, the actual check that determines if we're ready to activate doesn't rely on the state of scheduled raster tasks but is a synchronous call on each layer. The result is a pending tree activation mechanism that is much easier to debug and validate for correctness, while still providing the performance benefits of the old mechanism by taking the "required to activate" field of the tile priority into account when scheduling tasks. BUG=375206 TEST=cc_unittests --gtest_filter=PictureLayerImplTest.AllTilesRequiredForActivationAreReadyToDraw Review URL: https://codereview.chromium.org/287643004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272635 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some webview plugin attach-ment code.lazyboy@chromium.org2014-05-232-10/+8
| | | | | | | | | | | | | We would show error message on attach failure now, we used to always return true from attachWindowAndSetUpEvents(). attachWindowAndSetUpEvents() now return the value of -internal-attach call. -internal-attach did not used to return value, now it returns the status of the attachment call from BrowserPluginBindings. Removed 3 unused variables referring to browserPluginNode. BUG=None Review URL: https://codereview.chromium.org/284183013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272634 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HashedExtensionMetrics into ExtensionsMetricsProvider.blundell@chromium.org2014-05-238-60/+101
| | | | | | | | | | | | | | | Transforms HashedExtensionMetrics into a metrics::MetricsProvider, eliminating direct knowledge of this class from MetricsLog. Renames the class to ExtensionsMetricsProvider. Notably, changes the class to take in the MetricsStateManager and later obtain the client ID from the manager rather than directly taking in the ID; this change is necessary because the provider instance is now constructed before the ID is determined. BUG=374225 Review URL: https://codereview.chromium.org/297483008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272633 0039d316-1c4b-4281-b951-d872f2087c98
* Add two new histogram to tracking QUIC packet reordering:rch@chromium.org2014-05-232-0/+33
| | | | | | | | | | * Net.QuicSession.MaxReordering * Net.QuicSession.MaxReorderingTime * Net.QuicSession.MaxReorderingTimeLongRtt Review URL: https://codereview.chromium.org/298893010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272631 0039d316-1c4b-4281-b951-d872f2087c98
* [webcryto] Validate key usages during key creation.eroman@chromium.org2014-05-2312-113/+609
| | | | | | | | | | | | | (1) Key creation (whether by importKey(), unwrapKey(), generateKey() now fails if the requested key usages are not applicable (for instance asking for 'sign' on an AES-CBC key). (2) When generating a key pair, the public/private key get the intersection of supported usages and requested ones. (3) The exceptions thrown during the import phase of unwrapKey() are now surfaced to the caller (bug 372944) BUG=372040,372944,245025 R=rsleevi@chromium.org Review URL: https://codereview.chromium.org/282133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272630 0039d316-1c4b-4281-b951-d872f2087c98
* WebViewPlugin: Apply Prefs to WebSettings before creating WebLocalFramedanakj@chromium.org2014-05-232-8/+9
| | | | | | | | | | | | | | | | | | | | | | | If we create a WebLocalFrame and then set blink's settings, the frame gets an inconsistent view of the settings when they change out from underneath it. Concretely, this leads to us doing WebViewImpl::setRootGraphicsLayer(A) with pinch virtual viewport disabled (the default in WebSettings), when we attach the document to the tree, then we apply the prefs to enable pinch virtual viewport, and later setRootGraphicsLayer(NULL) to detach the document. This causes a crash because the viewport code expects a matching attach before the detach. With this CL, https://codereview.chromium.org/261143003 is able to pass on the print preview and prerender browser tests. R=bauerb@chromium.org BUG=376531,361729 Review URL: https://codereview.chromium.org/296983017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272628 0039d316-1c4b-4281-b951-d872f2087c98
* remove transaction details from didRequestAutocompleteestade@chromium.org2014-05-232-1/+7
| | | | | | | | | | see https://codereview.chromium.org/293853002/ BUG=354897 Review URL: https://codereview.chromium.org/299553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272627 0039d316-1c4b-4281-b951-d872f2087c98
* Remove by-reference implementations of blink::WebMediaPlayer::buffered()sandersd@chromium.org2014-05-238-37/+0
| | | | | | | | | | This cleans up after r270870 following the blink-side changes. BUG=360254 Review URL: https://codereview.chromium.org/282373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272626 0039d316-1c4b-4281-b951-d872f2087c98
* [Hotword] Add error message display back in. Add error messages for NaCl. ↵rlp@chromium.org2014-05-2311-69/+146
| | | | | | | | | | Add metrics for errors. BUG=345804,360246 Review URL: https://codereview.chromium.org/289063012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272625 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, mostly replacing uses of SplitStringUsingSubstr() with SplitString(),pkasting@chromium.org2014-05-237-86/+57
| | | | | | | | | | | also some other misc. changes to shorten code, remove a using directive, etc. BUG=none TEST=none Review URL: https://codereview.chromium.org/291653007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272624 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 272587 "Remove kEnablePrintPreview now that the pdf plugi..."fgorski@chromium.org2014-05-2310-11/+104
| | | | | | | | | | | | | | | | | Reverting bacuse of failure of ClosingWindowWhilePrintingShouldNotCrash after it was enabled by this change on Linux Tests. > Remove kEnablePrintPreview now that the pdf plugin is part of Chromium. > > R=thestig@chromium.org > > Review URL: https://codereview.chromium.org/296453015 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/299273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272622 0039d316-1c4b-4281-b951-d872f2087c98
* ServiceWorker: * is only wildcard at end of scope URLsjsbell@chromium.org2014-05-232-10/+35
| | | | | | | | BUG=372829 Review URL: https://codereview.chromium.org/288693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272621 0039d316-1c4b-4281-b951-d872f2087c98
* Add page.CanRunOnBrowser. Add WebGL check for tough_webgl_cases pagesnednguyen@google.com2014-05-235-0/+101
| | | | | | | | BUG=373812 Review URL: https://codereview.chromium.org/288313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272620 0039d316-1c4b-4281-b951-d872f2087c98
* Made desktop capture screen tab-constrained in ASH.zelidrag@chromium.org2014-05-236-11/+39
| | | | | | | | | | | This should prevent their misterious disapparence when parent window ends up minimized. BUG=375576 TEST=manual Review URL: https://codereview.chromium.org/281383008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272619 0039d316-1c4b-4281-b951-d872f2087c98
* Split out MetricsServiceAccessor out of ChromeMetricsServiceAccessor.motek@chromium.org2014-05-236-23/+59
| | | | | | | | BUG=374199 Review URL: https://codereview.chromium.org/291293005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272618 0039d316-1c4b-4281-b951-d872f2087c98
* Views Examples: Notify Combobox after updating the modelckocagil@chromium.org2014-05-231-0/+1
| | | | | | | | | BUG= R=sky@chromium.org Review URL: https://codereview.chromium.org/299203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272617 0039d316-1c4b-4281-b951-d872f2087c98
* ui/surface: Remove media/base from DEPSspang@chromium.org2014-05-231-1/+0
| | | | | | | | This is not used anymore since r247312. Probably OK to remove. Review URL: https://codereview.chromium.org/296173007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272616 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Add a workaround for setting empty IME compositions.aurimas@chromium.org2014-05-231-0/+30
| | | | | | | | | | | This is a tempory workaround where Blink does not cancel the composition when we send a commit with the empty text. BUG=373934 Review URL: https://codereview.chromium.org/289863013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272615 0039d316-1c4b-4281-b951-d872f2087c98
* Fetch a new GAIA picture every time chrome://settings/manageProfile comes up.noms@chromium.org2014-05-237-9/+29
| | | | | | | | | | | | | | | | | | (currently we do it once, when a profile is signed in, and henceforth every 24h) This assumes the --google-profile-info flag is in use (which comes for free as part of --new-profile-management), and is similar to CrOS, which also forces an update every time chrome://settings/changePicture is loaded. I've also deleted the code that forced the "is using the gaia photo" flag to true on every completed download, as it meant that we'd overwrite any custom avatars the user may have chosen. BUG=311013 Review URL: https://codereview.chromium.org/267253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272614 0039d316-1c4b-4281-b951-d872f2087c98
* Extension API enterprise.platformKeys.pneubeck@chromium.org2014-05-2342-33/+2325
| | | | | | | | | | | | | | | | | | | First version that implements all proposed functions backed by the TPM; enabled on dev-channel only. This is still missing several features: - Reusing algorithm normalization of WebCrypto. - Allow calling Sign() at most once per key. - Storing which extension imported a certificate. - Device-wide token. - Passing publicExponent to generateKey. - Throwing DOMExceptions instead of Errors. - ... BUG=364435 Review URL: https://codereview.chromium.org/214863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272613 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for distilling current WebContentsnyquist@chromium.org2014-05-2324-21/+810
| | | | | | | | | | | This CL adds the utilities needed for using the current WebContents when distilling web pages. BUG=361939 Review URL: https://codereview.chromium.org/266073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272611 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 272478 "Always define _HAS_EXCEPTIONS=0 on Windows"kbr@chromium.org2014-05-231-1/+5
| | | | | | | | | | | | | | | | | | | | | | Caused assertion failures in multiple test suites. BUG=82385,377008 > Always define _HAS_EXCEPTIONS=0 on Windows > > Previously we would not define it in component builds because it didn't work with old versions of MSVC. These days it should work. > > The macro is extra important for Clang, which doesn't currently support exceptions on Windows. > > BUG=82385 > > Review URL: https://codereview.chromium.org/287193012 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/289343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272610 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications: Retain button hover state during content updates.dewittj@chromium.org2014-05-235-19/+152
| | | | | | | | | | | Rapidly updating notifications (like progressbar indicators) can be hard to interact with if the state resets with each update. BUG=368025 Review URL: https://codereview.chromium.org/273173003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272609 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unnecessary semicolons in url_pattern_set.h.lauren.yeun.kim@gmail.com2014-05-232-2/+3
| | | | | | Review URL: https://codereview.chromium.org/292623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272605 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 272540 "Revert 272504 "Destroy all rtc peer connection ha..."fgorski@chromium.org2014-05-233-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original change was not a root cause of the problem. sheriffs are looking into other possible causes. Meanwhile I am getting the change back in. > Revert 272504 "Destroy all rtc peer connection handlers before s..." > > On Win7 Tests (dbg)(2) these tests > > FocusElementCallsFocusedNodeChanged > GetCompositionCharacterBoundsTest > MessageOrderInDidChangeSelection > OnExtendSelectionAndDelete > OnImeTypeChanged > OnSetTextDirection > SendCandidateWindowEvents > SetEditableSelectionAndComposition > > fail with timeout. > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%282%29/builds/21101/steps/content_browsertests/logs/stdio > > > Destroy all rtc peer connection handlers before shutting down blink > > > > The connection handlers will otherwise continue to call into blink which > > is bound to crash after it was shut down. > > > > BUG=337572 > > R=perkj@chromium.org,adamk@chromium.org > > > > Review URL: https://codereview.chromium.org/292163002 > > TBR=jochen@chromium.org > > Review URL: https://codereview.chromium.org/296213007 TBR=vasilii@chromium.org,jochen@chromium.org Review URL: https://codereview.chromium.org/293253003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272604 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.bluetoothLowEnergy: Implement writeDescriptorValue.armansito@chromium.org2014-05-238-4/+206
| | | | | | | | | | | | This CL implements the writeDescriptorValue function of the bluetoothLowEnergy API. BUG=265663 TEST=browser_tests --gtest_filter=BluetoothLowEnergyApiTest.* Review URL: https://codereview.chromium.org/293153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272600 0039d316-1c4b-4281-b951-d872f2087c98
* Update .DEPS.gitchrome-admin@google.com2014-05-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272597 0039d316-1c4b-4281-b951-d872f2087c98
* Blink roll 174659:174692eseidel@chromium.org2014-05-231-1/+1
| | | | | | | | | | http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174659:174692&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/292383006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272596 0039d316-1c4b-4281-b951-d872f2087c98
* Change refs from ChromeSigninClient to base SigninClient class.mlerman@chromium.org2014-05-2312-23/+61
| | | | | | | | | | Refactor. BUG=357693 Review URL: https://codereview.chromium.org/296703011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272595 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: FileDownloader cleanup.teravest@chromium.org2014-05-232-264/+22
| | | | | | | | | | | | | | | Now that StreamAsFile() has moved out of the trusted plugin, we can remove the support in FileDownloader for downloading to a file and providing file information as output. This makes FileDownloader quite a bit smaller and easier to read. BUG=239656 R=bbudge@chromium.org Review URL: https://codereview.chromium.org/292323007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272593 0039d316-1c4b-4281-b951-d872f2087c98
* Make Textfield scroll continuously when dragging beyond edges.msw@chromium.org2014-05-233-36/+66
| | | | | | | | | | | | | | | | Add a timer, point, and function drag selection helpers. Respect ScopedAnimationDurationScaleMode for TextfieldTest.DragToSelect. Comment and function order cleanup; fix timer.h indentation. TODO(followup): Make the scrolling "animation" smoother. BUG=373886 TEST=Dragging to select beyond the left or right ends of the omnibox, find bar textfield, etc. continuously scrolls and modifies the selection. R=pkasting@chromium.org,thakis@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/290733007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272591 0039d316-1c4b-4281-b951-d872f2087c98
* [Metrics] Move Windows-specific CountBrowserCrashDumpAttempts() out of ↵isherman@chromium.org2014-05-234-65/+73
| | | | | | | | | | | | MetricsService BUG=374216 TEST=none R=asvitkine@chromium.org Review URL: https://codereview.chromium.org/296013005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272590 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 272472 "Mojo: nuke EnvironmentData"kbr@chromium.org2014-05-2322-19/+207
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Caused layout tests (when run with check-sys-deps) to hang on Windows with a stuck content_shell process. See Issue 376929. BUG=376929 > Mojo: nuke EnvironmentData > > With this change, Mojo applications that link against mojo_environment_chromium > do not need to instantiate mojo::Environment. We rely on AtExitManager for all > finalization of singleton objects. This frees us up to use the familiar > base::Singleton and base::LazyInstance for any such state. Tests can use > ShadowingAtExitManager to clean the environment between test runs. > > It becomes a link error to use mojo::Environment if you are not linking against > mojo_environment_standalone. I plan to follow this up with a change that buries > mojo::Environment for the case where you are linking against > mojo_environment_standalone. Ideally, this means no one will ever need to think > about mojo::Environment again. > > Review URL: https://codereview.chromium.org/281353005 TBR=darin@chromium.org Review URL: https://codereview.chromium.org/299263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272589 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Fix and re-enable some browser focus interactive ui tests.msw@chromium.org2014-05-231-443/+163
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original r272259 was reverted for test failures on Windows XP. http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31296 FocusTraversal[OnInterstitial] times out on Windows XP with no output: [ RUN ] BrowserFocusTest.FocusTraversal [3796:3464:0522/144031:ERROR:gpu_info_collector_win.cc(103)] Can't retrieve a valid WinSAT assessment. [3796:380:0522/144031:WARNING:embedded_test_server.cc(230)] Request not handled. Returning 404: /favicon.ico [397/398] BrowserFocusTest.FocusTraversal (TIMED OUT) As InterstitialFocus passes, TestFocusTraversal is probably at fault. I disabled that helper on XP with a comment for Issue 376635. The original description is otherwise accurate as follows: ======================================== Fix FocusTraversal[OnInterstitial] except *OnInterstitial on Mac :( Fix InterstitialFocus and FindFocusTest. Add a TestFocusTraversal helper function consolidated from tests. Simplify TestInterstitialPage and add a WaitForInterstitial helper. Move test server init to a common SetUpOnMainThread. Remove unnecessary helpers and includes. TODO(followup): Fix more tests! TODO(followup): s/DisableFindBarAnimationsDuringTesting/ScopedAnimationDurationScaleMode/? BUG=60973, 62544, 67301, 81451, 109770, 163931, 376635 TEST=Automated tests work and stay enabled... TBR=sky@chromium.org Review URL: https://codereview.chromium.org/292363006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272588 0039d316-1c4b-4281-b951-d872f2087c98
* Remove kEnablePrintPreview now that the pdf plugin is part of Chromium.jam@chromium.org2014-05-2310-104/+11
| | | | | | | | R=thestig@chromium.org Review URL: https://codereview.chromium.org/296453015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272587 0039d316-1c4b-4281-b951-d872f2087c98
* Always call WCO::RenderFrameCreated and WCO::RenderFrameDeleted.nick@chromium.org2014-05-234-29/+89
| | | | | | | | | | | | | | | Call WebContentsObserver::RenderFrameCreated for frames created via RenderFrameHostManager::CreateRenderFrame. During WebContentsImpl destruction, make sure that RenderFrameDeleted is always called, by destroying the frame tree and all proxies before clearing the observer list. BUG=364974,374491 Review URL: https://codereview.chromium.org/292363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272586 0039d316-1c4b-4281-b951-d872f2087c98
* Add AttachmentDownloader interface, change signature of AttachmentStore::Readpavely@chromium.org2014-05-239-20/+104
| | | | | | | | | | | | | | | - AttachmentDownloader interface is similar to AttachmentUploader interface. No implementation yet. - AttachmentStore::Read guarantee should be stronger. It should attempt to read all attachments and return list of attachment ids that can't be loaded locally. Those need to be downloaded from server. R=maniscalco@chromium.org BUG=376073 Review URL: https://codereview.chromium.org/293143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272585 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in GpuChannelpiman@chromium.org2014-05-234-60/+30
| | | | | | | | | | | | | | | | | There may be remaining messages in the deferred queue on unclean teardown. Delete those. Also, a little bit of cleanup in the area: - GpuChannel doesn't need to be refcounted - It's ok to copy WeakPtr across threads, as long as they're only dereferenced on the thread that the factory is destroyed. So no need for the extra indirection. BUG=374843 Review URL: https://codereview.chromium.org/299003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272584 0039d316-1c4b-4281-b951-d872f2087c98
* PPAPI: Refactor MessageChannel to prep for sync postMessagedmichael@chromium.org2014-05-2317-272/+278
| | | | | | | | | | | | | | | 1) Remove unused CopyPPVar function from MessageChannel 2) Remove mostly-duplicate NPVariantToPPVar from MessageChannel. 3) Separate V8VarConverter::FromV8Value implementation from calling the callback (so I can have a sync path later, and this is shorter anyway). 4) Simplify NaCl in-process to out-of-process transition. Now, we just queue stuff for in-process (nobody but NaCl uses Messaging in-process), and if/when we switch to out-of-process (handing off to a NaCl app) we drain the queues then. 5) Some other renames/tweaks to how MessageChannel queues pending conversions. BUG=367896 R=raymes@chromium.org Review URL: https://codereview.chromium.org/290553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272583 0039d316-1c4b-4281-b951-d872f2087c98
* Pepper: Simplify Pnacl manifest id logic.teravest@chromium.org2014-05-236-17/+6
| | | | | | | | | | | | | | This removes some unnecessary manifest_id storage and passing to make manifest behavior clearer in the trusted plugin. Helper NaCl Modules (llc and ld) always use the "Pnacl Manifest" for resolving keys, as there is no relevant json-formatted NMF available. BUG=239656 R=dmichael@chromium.org Review URL: https://codereview.chromium.org/292743011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272582 0039d316-1c4b-4281-b951-d872f2087c98
* gn: Remove another obsolete comment about gyp command from command_check.cc.tfarina@chromium.org2014-05-231-1/+0
| | | | | | | | | | | | Forgot to do this in r271968 - https://codereview.chromium.org/296153002 BUG=None TEST=None TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/299203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272581 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of cc: Stop blocking the main thread in ↵danakj@chromium.org2014-05-233-72/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CreateAndInitializeOutputSurface. (https://codereview.chromium.org/287193003/) Reason for revert: This may be causing mac browser test flakiness: https://code.google.com/p/chromium/issues/detail?id=376649 Original issue's description: > cc: Stop blocking the main thread in CreateAndInitializeOutputSurface. > > The ThreadProxy does not need to block the main thread anymore, instead > have it post back DidInitializeOutputSurface() with the result of the > process. > > We would delete all contents textures on the compositor thread during > OutputSurface creation, which doesn't really make sense, cuz the > ResourceProvider won't be the same one anymore, and this required > blocking the thread. > > We also notified the main thread that the OutputSurface was lost when > creating the new output surface. > > Instead, post a DidLoseOutputSurface() to the main thread to inform > the LayerTreeHost right away, and have that block and clean up > the contents textures immediately (to be removed when we always do > impl-side painting). > > R=enne > BUG=374287 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272276 TBR=enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=374287 Review URL: https://codereview.chromium.org/299233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272580 0039d316-1c4b-4281-b951-d872f2087c98
* <webview>: Make HandleContextMenu easier to refactorfsamuel@chromium.org2014-05-232-12/+12
| | | | | | | | | | In the future, BrowserPluginGuest will no longer be a WebContentsDelegate, and so special handling for guests that relies on the internal implementation details of BrowserPlugin should be moved to chrome. BUG=364141, 330264 Review URL: https://codereview.chromium.org/296703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272579 0039d316-1c4b-4281-b951-d872f2087c98
* [webcrypto] Remove RSA-ES support (2 of 3)eroman@chromium.org2014-05-2311-1001/+119
| | | | | | | | | BUG=372920,245025 R=rsleevi@chromium.org Review URL: https://codereview.chromium.org/282903002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272577 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 02:20:51 +0000