| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original review: https://codereview.chromium.org/23856002/
window.resolveLocalFileSystemURL is originally defined only for FileSystem API,
but it'd be nice if it works on SyncFileSystem in a similar way. For that this
change adds new IPC messages and interfaces.
Blink side change depends on this:
https://codereview.chromium.org/23537011/
BUG=177137,294502
TEST=manual (Get FileSystemURL for a file on SyncFS, and then resolve it)
TEST=unit_tests
TEST=run_webkit_tests.sh http/tests/filesystem/\*
TEST=run_webkit_tests.sh http/tests/inspector/filesystem/\*
TBR=tsepez@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/23526076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=295476
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/24088011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On CrOs, this causes a crash in device ID initialization.
R=mad@chromium.org
TBR=mnissler
BUG=266569, 288210
TEST=NONE
Review URL: https://codereview.chromium.org/23990009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a restriction imposed by Chrome Web Store.
R=garykac@chromium.org
Review URL: https://codereview.chromium.org/23708059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through UDP sockets. Rate control is done through a global object, which will be given to each p2p udp socket.
Socket before sending packet to the network will check with throttler for current send date. If current rate is exceeding the allowed limit, packet will be dropped.
R=sergeyu@chromium.org, juberti@chromium.org
TBR=brettw@chromium.org
BUG=276800
Review URL: https://codereview.chromium.org/23441012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=246208
R=asargent
TBR=asargent
Review URL: https://codereview.chromium.org/23536067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Likely cause of http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/10105/steps/unit_tests/logs/stdio
> Fixed problems with pin/unpin preferences changing for not running applications & icon order changes upon sync operations
>
> There are multiple problems fixed with this patch:
> 1. When a running and pinned app (Windowed V1, V2) gets unpinned via sync operation (or multi user switching), the icon will disappear and the sytem gets into an unstable state (-> Crash later on).
> 2. When a running app (Windowed V1, V2) gets pinned via a sync operation (or multi user switching), the icon will be shown, but get into an unsecure state which can lead to crashes.
> 3. There are several cases, where the chrome browser icon does change locations due to sync / multi user switching operations. In this case the icon can shift by one spot to the right.
> 4. There were some problems with the alternate shelf layout.
>
> That all said: With M32 we should possibly come up with a new way of storing running V1/V2 applications since the running applications are not stored by the preferences and can therefore flip around when switching between users AND windowed V1 apps currently have the same "weight" as an application launcher - which means that they will "float around" in the shelf between sync / switch operations.
>
> My visual test to see that everything was working was as follows:
>
> In Multi session mode, have one user with the following applications pinned:
> Chrome Shop, VNC, Angry Birds, gmail, calendar, chrome
> and another user with two other applications and chrome.
>
> Switch between the two and everything should be fine.
> Run VNC (V2 app). Switch to user 2 and see that it is unpinned at the end of the list. Switch back and see it sliding back to where it belongs.
> Then do the same for a windowed V1 app (gmail). Note that the gmail item will not float to the end of the list in user 2 - which is because of the already mentioned weights.
> BUG=294435, 294231, 294227
> TEST=unit tests and visual (see above)
> R=oshima@chromium.org
>
> Review URL: https://codereview.chromium.org/23580008
TBR=skuhne@google.com
Review URL: https://codereview.chromium.org/24227010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=274705
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/24210004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromedriver:520
Review URL: https://chromiumcodereview.appspot.com/23856015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing with notry, the failure on win_rel cannot be related to this patch as this patch only affects Android.
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/23931007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: https://codereview.chromium.org/24333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no need to deactivate and reactivate the window. The Focus()
in particular is wrong in so far as we don't want focus to go to the
rootwindow.
BUG=284411
TEST=see bug
R=ananta@chromium.org
TBR=jschuh@chromium.org
Review URL: https://codereview.chromium.org/23851042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=295476
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/24246015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise the script output dirties up the java tests step.
BUG=None
TEST=None
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/24227009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Desktop Media Picker shows itself available for selection. That
doesn't make sense. Fixed DesktopMediaPickerModel to hide the dialog window
from the list of sources.
BUG=289757
R=sky@chromium.org
Review URL: https://codereview.chromium.org/23629049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=272346
TEST=run example, trybots
R=noelallen@chromium.org
Review URL: https://codereview.chromium.org/23600057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=binji@chromium.org
Review URL: https://codereview.chromium.org/23483061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change affects ChromeOS when the multiple profiles flag is set.
If multiple user accounts have been logged in on a device, the avatar menu
will include a link to add a user to the session. Once some number of users
is added, the avatar menu will display all logged in users and allow the user
to switch to, or open, a browser window for a given profile.
AvatarMenuModel moved to AvatarMenu, model and "controller" functions separated
out into interfaces ProfileList and AvatarMenuActions. AvatarMenu instantiates
components based on multi-profile flag and platform. ChromeOS version of
ProfileList uses the UserManager to identify logged-in users and translate them
into their corresponding profiles.
Original review: https://codereview.chromium.org/23876020/
BUG=288365
TEST=manual, added /chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc
TBR=ben,erg,dpolukhin,xiyuan,michaelpg
Review URL: https://codereview.chromium.org/24190003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
applications & icon order changes upon sync operations
There are multiple problems fixed with this patch:
1. When a running and pinned app (Windowed V1, V2) gets unpinned via sync operation (or multi user switching), the icon will disappear and the sytem gets into an unstable state (-> Crash later on).
2. When a running app (Windowed V1, V2) gets pinned via a sync operation (or multi user switching), the icon will be shown, but get into an unsecure state which can lead to crashes.
3. There are several cases, where the chrome browser icon does change locations due to sync / multi user switching operations. In this case the icon can shift by one spot to the right.
4. There were some problems with the alternate shelf layout.
That all said: With M32 we should possibly come up with a new way of storing running V1/V2 applications since the running applications are not stored by the preferences and can therefore flip around when switching between users AND windowed V1 apps currently have the same "weight" as an application launcher - which means that they will "float around" in the shelf between sync / switch operations.
My visual test to see that everything was working was as follows:
In Multi session mode, have one user with the following applications pinned:
Chrome Shop, VNC, Angry Birds, gmail, calendar, chrome
and another user with two other applications and chrome.
Switch between the two and everything should be fine.
Run VNC (V2 app). Switch to user 2 and see that it is unpinned at the end of the list. Switch back and see it sliding back to where it belongs.
Then do the same for a windowed V1 app (gmail). Note that the gmail item will not float to the end of the list in user 2 - which is because of the already mentioned weights.
BUG=294435, 294231, 294227
TEST=unit tests and visual (see above)
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/23580008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If StopCaching is called, it is possible for mode_ to be NONE while entry_ is
non-NULL and points to an entry in write mode. Don't incorrectly close it as a
read entry (thus crashing) in DoneReading. Add a test which stresses this case.
BUG=295638
TEST=HttpCache.StopCachingThenDoneReadingDeletesEntry,
downloading a large-ish download with gzip compression doesn't crash
Review URL: https://chromiumcodereview.appspot.com/24286004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Previous change https://src.chromium.org/viewvc/chrome?revision=219648&view=revision added support for non resiazable windows to become fullscreen. That change no longer reports the current window's frame dimensions for it's GetRestoredBounds(), but instead returns a cached state which is updated with UpdateRestoredBounds(). This update method needs to be called when the window is moved or resized as well.
BUG=294938
Review URL: https://chromiumcodereview.appspot.com/24237008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Note that it needs a separate CL downstream to actually call this
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/22849016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/24216004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Upgrade the DEPTH_COMPONENT16 render buffer storage format to
DEPTH_COMPONENT24 if the GLES implementation supports the OES_depth24
extension. This is done to improve content portability between desktop
and mobile, since we already do a similar mapping from DEPTH_COMPONENT16
to the unsized DEPTH_COMPONENT on desktop GL. This means that for
example WebGL content can end up relying on a higher precision depth
buffer even though it only requested DEPTH_COMPONENT16.
BUG=285400
TEST=http://www.khronos.org/registry/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html on Nexus 4
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224117
Review URL: https://chromiumcodereview.appspot.com/24079010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-commit of Revision 223663, which was reverted due to a code size
regression from a static initializer.
This CL introduces a heuristic that seems to avoid distorted HD on some
common consumer webcams. The heuristic uses QTKit's default resolution
and reported pixel aspect ratio (if available) to determine whether
HD video is likely to be distorted on this capture device.
With this change, video capture begins immediately during Allocate(), but
OnFrameInfo doesn't fire until the resolution has been checked, and possibly
altered. The camera is first opened at its default resolution. If this is
less than HD, then HD capture is disabled. Otherwise, if a returned HD stream
has nonsquare PAR, then HD capture is also disabled. OnFrameInfo is only
fired once the camera has reached its final resolution.
BUG=234803
Review URL: https://chromiumcodereview.appspot.com/23929007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Storage.
- I uploaded the files already. They are in the bucket chrome-telemetry.
- Removed the logic that uploads page set archive info files. Those are staying in the source tree.
- Updated all references to use the new buckets. Moved the media files from chromium-wpr to chromium-telemetry.
BUG=223667
TEST=./run_benchmark netsim -v; ./run_benchmark media -v; # You should see at least two "Downloading" lines at the beginning of each run.
R=nduca@chromium.org, tonyg@chromium.org
Review URL: https://codereview.chromium.org/24294003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use MMAP buffers and copy out to shared memory from them instead of passing shared memory as USERPTR to MFC. This works around corruption in output stream and the additional memcpy is in range of around a few to a few tens of kilobytes for 720p streams. This doesn't even apply to keyframes, because we were already doing a memmove of the data in their case to put the "header" in front of the dequeued stream.
The corruption happens, because the kernel keeps the USERPTR buffers it set up even after giving them back to us and tears that setup down only if we queue a different buffer than previously under given index. But the old buffer might already be in use somewhere else and the tear down may corrupt the contents in a way that we have not fully grasped yet. Contributing to this was an implicit cache sync on tearing down, but this appears not to be the only issue, as removing it didn't fix the corruption.
This should also actually improve performance. The process of queuing a USERPTR buffer includes copying vma struct for the area, pinning all pages that belong to the area (which involves laboriously walking through the page tables, pulling each page into memory from backing store if needed and incrementing refcounts on each of them), then allocating SG table for all the pages, mapping all pages in device's IOMMU, syncing the cache on noncoherent architectures and verifying contiguity of the memory. Adding to this the fact that our output buffers are 2MB in size, and that we effectively have to, in addition to do doing all the above operations, repeat them in reverse order to clean up in current implementation on each frame, a memcpy of a hundred kilobytes or so seems quite preferable. In MMAP case we only have to sync the cache (once).
As measured by hshi@:
Under Google Cast extension's High (720p) quality setting. Test page URL: Spinning WebGL Box
(www.khronos.org/registry/webgl/sdk/demos/webkit/SpiritBox.html)
Without this CL, about 18.5fps
With this CL, about 23.3fps
BUG=289775,284783
TEST=apprtc
Review URL: https://chromiumcodereview.appspot.com/23653039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke Linux ChromiumOS Tests : http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/33127
> Manually landing already reviewed https://codereview.chromium.org/23876020/ on behalf of michaelpg@:
>
> Multiprofile avatar menu for ChromeOS users.
>
> This change affects ChromeOS when the multiple profiles flag is set.
> If multiple user accounts have been logged in on a device, the avatar menu
> will include a link to add a user to the session. Once some number of users
> is added, the avatar menu will display all logged in users and allow the user
> to switch to, or open, a browser window for a given profile.
>
> AvatarMenuModel moved to AvatarMenu, model and controller functions separated out into interfaces ProfileList and AvatarMenuActions. AvatarMenu instantiates components based on multi-profile flag and platform. ChromeOS version of ProfileList uses the UserManager to identify logged-in users and translate them into their corresponding profiles.
>
> BUG=288365
> TEST=manual, added /chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc
> TBR=ben,erg,dpolukhin,xiyuan,michaelpg
>
> Review URL: https://codereview.chromium.org/24330003
TBR=zelidrag@chromium.org
Review URL: https://codereview.chromium.org/23497007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move ui/base/latency_info* to ui/events
>
> Latest in a sequence of changes to extract ui/gfx as its own component and sever ties on ui/base from various should-be-lower-level components.
>
> TBR=jamesr@chromium.org, sky@chromium.org
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/23464099
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/24141009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove dependency on ui::ScaleFactor from ui/gfx
>
> As part of the work to removed dependencies on ui/base from ui/gfx I have
> changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
> to take float scale values instead of ui::ScaleFactor.
>
> The notion of supported scale factors has been broken into 2 parts.
> ui::SetSupportedScaleFactors remains and calls the
> new ImageSkia::SetSupportedScales().
>
> The initialization of the supported scale factors has been moved from layout.h
> into ResourceBundle, and is done explicitly in tests that don't use
> ResourceBundle.
>
> BUG=103304
> R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/24175004
TBR=davemoore@chromium.org
Review URL: https://codereview.chromium.org/24262008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual, unittest
R=jered@chromium.org
Review URL: https://codereview.chromium.org/24269014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Latest in a sequence of changes to extract ui/gfx as its own component and sever ties on ui/base from various should-be-lower-level components.
TBR=jamesr@chromium.org, sky@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/23464099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
on behalf of michaelpg@:
Multiprofile avatar menu for ChromeOS users.
This change affects ChromeOS when the multiple profiles flag is set.
If multiple user accounts have been logged in on a device, the avatar menu
will include a link to add a user to the session. Once some number of users
is added, the avatar menu will display all logged in users and allow the user
to switch to, or open, a browser window for a given profile.
AvatarMenuModel moved to AvatarMenu, model and controller functions separated out into interfaces ProfileList and AvatarMenuActions. AvatarMenu instantiates components based on multi-profile flag and platform. ChromeOS version of ProfileList uses the UserManager to identify logged-in users and translate them into their corresponding profiles.
BUG=288365
TEST=manual, added /chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc
TBR=ben,erg,dpolukhin,xiyuan,michaelpg
Review URL: https://codereview.chromium.org/24330003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a helper class to facilitate device credential reset.
The callback will be asyncrhonous due to network transactions.
BUG=292699
Review URL: https://chromiumcodereview.appspot.com/23531071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When AwContents is created, the ContainerView may have already changed
its visibility from the default false, so update visibility in the
constructor.
Internal b/10852450
NOTRY=true
BUG=
Review URL: https://chromiumcodereview.appspot.com/24070005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
has no event log.
BUG=https://code.google.com/p/webrtc/issues/detail?id=2351
Review URL: https://chromiumcodereview.appspot.com/23698012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=binji@chromium.org, dschuff@chromium.org
Review URL: https://codereview.chromium.org/24287003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some AppContainer methods moved to another DLL and the address
space for 64-bit apps is larger than before.
BUG=none
TEST=current sbox_unittests, sbox_integration_tests, sbox_validation_tests
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/24296002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a flag that binds with --multi-profiles switch;
- Only allow multiple profiles when the field trial
ChromeOSUseMultiProfile in Enabled group as a temp
solution before the underlying support is ready;
BUG=288765,293641
R=asvitkine@chromium.org, davemoore@chromium.org, dpolukhin@chromium.org, zelidrag@chromium.org
Review URL: https://codereview.chromium.org/24078015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSTextView should have been NSTextField.
BUG=none
TEST=no more DCHECK of death
R=groby@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24237011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/24220004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=navabi@chromium.org
BUG=None
TEST=None
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/24198012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=280550
TEST=MP3StreamParserTest.*
R=scherkus@chromium.org
Review URL: https://codereview.chromium.org/24287002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Manually landing already reviewed https://codereview.chromium.org/23876020/ on behalf of michaelpg@:
>
> Multiprofile avatar menu for ChromeOS users.
>
> This change affects ChromeOS when the multiple profiles flag is set.
> If multiple user accounts have been logged in on a device, the avatar menu
> will include a link to add a user to the session. Once some number of users
> is added, the avatar menu will display all logged in users and allow the user
> to switch to, or open, a browser window for a given profile.
>
> AvatarMenuModel moved to AvatarMenu, model and controller functions separated out into interfaces ProfileList and AvatarMenuActions. AvatarMenu instantiates components based on multi-profile flag and platform. ChromeOS version of ProfileList uses the UserManager to identify logged-in users and translate them into their corresponding profiles.
>
> BUG=288365
> TEST=manual, added /chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc
> TBR=ben,erg,dpolukhin,xiyuan,michaelpg
>
> Review URL: https://codereview.chromium.org/23503085
TBR=zelidrag@chromium.org
Review URL: https://codereview.chromium.org/23593011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CL 22986010 added a policy to disable fullscreen. This CL extends the
enforcement of this policy to ppapi plugins as well.
BUG=275405
TEST=Manual
Review URL: https://chromiumcodereview.appspot.com/23591062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=scherkus@chromium.org
TBR=scherkus
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224431
Review URL: https://codereview.chromium.org/24227004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
results rather than using a redirect into the extension.
BUG=291207
Review URL: https://chromiumcodereview.appspot.com/23891005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to display the cacheable NTP for incognito profiles. Use
the same function we're using to decide when not to show the current
Instant NTP, which also looks at the suggest pref.
TEST=unittest
BUG=
R=samarth@chromium.org
Review URL: https://codereview.chromium.org/24267009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224472 0039d316-1c4b-4281-b951-d872f2087c98
|