| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the saved window size is used as the "minimum" size of window on HTMLDialog (cf. http://crbug.com/115403). This CL make the saved size as default size and adds the GetMinimumDialogSize() method in HTMLDialogUI to set minimum size of window separately.
This CL also enables the viwes::Widget::SaveWindowPlacement() on TaskManagerDialog by adding HtmlDialogView::GetWindowName() and HtmlDialogUIDelegate::GetDialogName() virtual functions. And this CL disables to save the window placement on TaskManagerDialog on views, since views::Widget has same feature which is enabled by this CL.
BUG=115403
TEST=manual on Windows, Linux with gtk and Linux with chromiumos=1
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127660
Review URL: http://codereview.chromium.org/9569001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These will be translated as part of the same bundle as the rest of the
Chrome strings. I will automatically add a prefix to the description
before uploading to the translation console to make it more obvious.
BUG=None
Review URL: http://codereview.chromium.org/9808036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=116995
TEST=pointer settings dialog ok/cancel buttons work
NOTRY=true
Review URL: http://codereview.chromium.org/9839031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Report exec time, kernal time, and user cpu time
when we have a crash. Also report non-crashing
durations for comparison.
r=rvargas
Review URL: https://chromiumcodereview.appspot.com/9769011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also suppress the window caption header edge when maximized.
"It's cleaner"
BUG=119551
TEST=visual
R=sky@chromium.org
Review URL: http://codereview.chromium.org/9839026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9838027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9732020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=116586
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9667020
TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/9808048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No real code change.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9812031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's possible that the partial swap rect passed to PostSubBuffer is
empty. Rather than checking that it is the size of the buffer (which
will never be empty), early out. If there is no damage, then the buffers
are already in the correct state.
BUG=119465
TEST=open aura with an extension, observe no crash
Review URL: https://chromiumcodereview.appspot.com/9808040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Browser tests are supposedly faster than ui tests.
BUG=118499
TEST=
Review URL: http://codereview.chromium.org/9693065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed a bug.
BUG=none
TEST=PanelResizeBrowserTest
Review URL: http://codereview.chromium.org/9824002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9834024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. cache files are now stored in subdirectories to indicate their state - persistent, tmp, pinned, and outgoing (as opposed to using RWX mode of files previously)
2. to reduce file operations to lookup location of cache file, change all IO tasks to run as private methods of GDataFileSystem instance using base::Unretained, so that they can access data members of GDataFileSystem, specifically lock and root's cache map (previously, was using static anonymous space functions)
3. because of item 2, lots of intermediate callbacks and empty IO tasks posted just to force synchronization of IO tasks were eliminated
4. because of item 2, expand use of waitable event to indicate start and completion of all IO tasks, so that GDataFileSystem doesn''t destruct while a IO task is in progress,
5. because of item 4, add one more boolean in_shutdown_ to indicate when GDataFileSystem is being destructed, so that IO tasks will simply exit
6. change unittest to handle new cache file mgmt, and add more tests
BUG=chromium-os:27970
TEST=GDataFileSystemTest uniitest runs, opening file manager in ui show files in gdata dir
Review URL: https://chromiumcodereview.appspot.com/9753012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9808025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=added
Review URL: http://codereview.chromium.org/9834022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=111587
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128039
Review URL: http://codereview.chromium.org/9722032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=build success
Review URL: http://codereview.chromium.org/9826026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix issue that the transaction can not be started if the nesting_transaction rollback.
BUG=
TEST=Add a new test to cover this case. Also pass the existing tests.
Review URL: http://codereview.chromium.org/9839021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111733
TEST=none
Review URL: http://codereview.chromium.org/9834001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The original implementation neglected to define the necessary
CallbackParamTraits and CallbackForward implementations for ScopedVector.
Fix scoped_ptr_malloc and scoped_array while I'm at it. Awesome.
BUG=NONE
TEST=scoped_vector_unittest.cc
Review URL: http://codereview.chromium.org/9827003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a check in the window.print call to make window.print fail if called from a blocked popup.
Creates a new notification sent by BlockedContentTabHelper to let other parts of the code know about the state of blocked content.
Based off of https://chromiumcodereview.appspot.com/9762004.
Also adds handling to print_preview_tab_controller.cc to mark preview as done if the creation of the print preview ui fails.
BUG=117955
TEST=Open test page attached to bug 117955. Allow the blocked popup. Ctrl-P should work normally.
R=thestig@chromium.org
Review URL: http://codereview.chromium.org/9815014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119580
TEST=tests/perf_expectations_unittest.py
Review URL: http://codereview.chromium.org/9838024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Pickle::WriteLong() to WriteLongUsingDangerousNonPortableLessPersistableForm()
and add a strongly-worded comment against its use; it is used only for IPC
which is safe. (These methods write variable amounts of data to pickles,
depending on architecture, and aren't safe if pickles are persisted.)
Review URL: http://codereview.chromium.org/9641005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
update monitor configurations."
TBR=ben@chromium.org
BUG=115510
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9839032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9838023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suppress clang's "comparison of unsigned expression < 0 is always false" error
BUG=None
TEST=build browser_tests with GYP_DEFINES="chromeos=1 clang=1 clang_use_chrome_plugins=1"
Review URL: http://codereview.chromium.org/9837017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=77103
Review URL: http://codereview.chromium.org/9812029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=119543
Review URL: https://chromiumcodereview.appspot.com/9838019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
A remote thread is used to call DumpProcessWithoutCrash(), this should
give us a snapshot without disturbing the hung state.
BUG=119390
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/9812041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disables failing test under Linux/TSAN bot.
BUG=115540, 119615, 118365
TEST=TSAN bots go green
TBR=xhwang@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9834033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GDataUploader, GDataDownloadObserver, and GDataSyncClient, were owned by
GDataFileSystem, just because there was no better owner.
Introduce GDataSystemService, a profile-keyed service, to be the new owner
of these objects. GDataFileSystem is also owned by the new owner, and
becomes a nomral object than a profile-keyed-service.
The motivation of this change is to make GDataFileSystem, which is already
overly complex, a little bit simpler, and make it easier to write tests.
BUG=chromium-os:28238
TEST=run tests, the file manager works as before
Review URL: https://chromiumcodereview.appspot.com/9808033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The tests ProfileSyncServiceSessionTest.WriteFilledSessionToNode and
ProfileSyncServiceSessionTest.ValidTabs disabled under Valgrind on
Linux.
BUG=116097, 119610
TEST=Valgrind on Linux goes green
TBR=zea@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configurations.
* Message on secondary monitor view
* Accelerator to create/delete/cycle monitors to test multi monitor on linux desktop
* unittest for MultiMonitorManager/MonitorController
BUG=115510
TEST=multi_monitor_manager_unittests
Review URL: https://chromiumcodereview.appspot.com/9754001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
NOTRY=true
Review URL: http://codereview.chromium.org/9812023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes it to be implemented by the Aura client, via a new interface EventClient.
The client can determine whether or not a given window and its subtree can receive events.
I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell.
http://crbug.com/119347
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This check is already done elsewhere so we don't need to show the same message twice.
BUG=none
TEST=no "line longer than 80 chars" message in JS checks.
NOTRY=true
Review URL: http://codereview.chromium.org/9838026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114288
TEST=ProtectedPrefsWatcherTest.*
Review URL: http://codereview.chromium.org/9808018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=115784
TEST=none
Review URL: http://codereview.chromium.org/9838021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=115784
TEST=none
Review URL: http://codereview.chromium.org/9826013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115348
TEST=try bots
Review URL: https://chromiumcodereview.appspot.com/9814028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/9722008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Since toolkit_views=1 is equivalent to (OS_WIN==1 || USE_AURA==1) it is safe to
remove that code.
R=saintlou@chromium.org,erg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9808032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=118862
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9826002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=118830
TEST=see bug
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9826022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resized to a smaller size.
BUG=110130
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9834026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add download to cache after download completes in GDataUploader.
Handle the case when the file being streamed is an exact multiple of 512k bytes.
BUG=NONE
TEST=File download works as before.
Review URL: https://chromiumcodereview.appspot.com/9836021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This started failing somewhere around r128174, but no smoking gun.
Disabling test.
BUG=118883
TEST=Valgrind on ChromeOS
TBR=rch@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9835029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL seems to break HistoryExtensionApiTest.TimedSearch on Vista & Win7.
Added optional callbacks to addUrl and deleteUrl, and fixed
up some of the api tests to use them.
BUG=76170
TEST=*HistoryExtensionApiTest*
Review URL: http://codereview.chromium.org/9811017
TBR=cduvall@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9837024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128315 0039d316-1c4b-4281-b951-d872f2087c98
|