| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Update dependency to NSS >= 3.14.3 and NSPR >= 4.9.2
>
> Technically NSS 3.14.3 depends on NSPR 4.9.5, but Debian stable still
> ships 4.9.2 on stable, so this is the lower bound.
>
> 3.14.3 contains a number of important security fixes, and support for
> older systems is no longer desirable.
>
> BUG=245370
> R=thestig@chromium.org, wtc@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/18063013
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/18181019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This patch attempts to generalise the linux libc urandom override, so that it works for non-glibc linux platforms too.
BUG=255215
Review URL: https://chromiumcodereview.appspot.com/18093002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These improvement come from un-followed-up suggestions from
https://codereview.chromium.org/10913262/
(The suggestions were offered after the code was submitted.)
BUG=
NOTRY=1
Review URL: https://chromiumcodereview.appspot.com/18083017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=none
TEST=empty CC ## is red on submit
Review URL: https://chromiumcodereview.appspot.com/18080017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically NSS 3.14.3 depends on NSPR 4.9.5, but Debian stable still
ships 4.9.2 on stable, so this is the lower bound.
3.14.3 contains a number of important security fixes, and support for
older systems is no longer desirable.
BUG=245370
R=thestig@chromium.org, wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18063013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Closing this overlay on enter doesn't make sense, so removed
the default-button class on the 'Done' button.
BUG=254322
Review URL: https://chromiumcodereview.appspot.com/18117011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254734
TEST=none
R=estade@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17986002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and abandoned initial setup
A new "Sync nothing" option was recently added to the advanced sync
settings dialog. It allowed the user to stop syncing, but stay signed
in. In addition, sign in and sync were separated, with the result that
on a dashboard clear, the user would remain signed in, but would no
longer have sync enabled.
For M29, we've decided to hide this UI and revert to old sign-in/out
behavior because there are other services that depend on the sync
engine being up and running.
This patch undoes a small number of these changes as listed below:
1) Hides the "Sync nothing" item in the advanced sync settings drop-down
2) Signs out the user if the user clicks "Choose what to sync" during
initial setup, and then clicks cancel on the advanced dialog
3) Signs out the user when a dashboard clear is done
4) Signs out the user if the user clicks cancel while re-setting up sync
after the dashboard clear
5) Reverts the status string shown when sync is cleared via the dashboard
BUG=235633, 252049, 248877
TEST=No "Sync nothing" UI in advanced settings; user is signed out when sync is disabled on Desktop; Chrome OS strings back to M28
Review URL: https://chromiumcodereview.appspot.com/17392009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Found while trying to debug what's going wrong with Android layout
tests on my N4.
BUG=none
TEST=content_shell_apk
Review URL: https://chromiumcodereview.appspot.com/18112002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL replaces the PowerIdleAction pref with a PowerAcIdleAction pref
and a PowerBatteryIdleAction pref, allowing different idle actions to be
specified when running on AC and battery power. This is a prerequisite
for allowing Chrome to control power management on the login screen where
different actions are needed.
Enterprise user policies are update accordingly, replacing IdleAction with
IdleActionAC and IdleActionBattery.
BUG=254404
TEST=Updated browser and unit tests
Review URL: https://chromiumcodereview.appspot.com/18051012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The InvalidationService was introduced r199520. That commit added the
InvalidationService interface and several implementations of it, but
made no use of the new code. This commit builds on that work.
Up until now, TICL invalidations were handled on the sync thread. The
related objects were instantiated and owned by the SyncBackendHost and
SyncManager. All requests to update the set of object registrations had
to be passed to the sync thread. Components that wanted to receive
invalidations but were not part of sync had to route their communication
with the invalidations server through ProfileSyncService to get to the
sync thread. Things were a bit different on Android, but the system
still tried to pretend that invalidations were owned by the sync thread.
The new InvalidationService implementation is a ProfileKeyedService that
is mostly independent from sync. It still relies on sync to manage sign
in and fetch the appropriate auth tokens. However, it's now much easier
for components outside of sync to communication with the invalidations
server.
The new system allows us to remove a lot of invalidations-related code
from the ProfileSyncService, SyncBackendHost and SyncManager. Sync is
now just one of many clients of the InvalidationService. The
SyncBackendHost is responsible for forwarding messages back and forth
between the InvalidationService and the sync thread.
TBR=dcheng,satorux1,battre,rsimha,bauerb,sky,erg
BUG=124137
Review URL: https://chromiumcodereview.appspot.com/17699005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new buckets to the Ash.GestureTarget histogram which
will be useful in measuring the effectiveness of views
fuzzing when it is implemented. The idea is to count taps
made on the different element types located on/near the
tab strip. A description of the new types added to
GestureActionType in touch_uma.cc:
GESTURE_TABSWITCH_TAP: A tap on a currently unselected
tab (i.e., the tap was responsible for selecting the tab).
GESTURE_TABNOSWITCH_TAP: A tap on a currently selected
tab (i.e, the tap had no visible effect).
GESTURE_TABCLOSE_TAP: A tap on a tab's close button.
GESTURE_NEWTAB_TAP: A tap on the new tab button.
GESTURE_FRAMEMAXIMIZE_TAP: A tap on the frame maximize
button.
GESTURE_FRAMEVIEW_TAP: A tap on the space to the right of
the tabstrip, left of the tabstrip, or in between tabs.
Such a tap has no visible effect.
GESTURE_ROOTVIEWTOP_TAP: A tap on the top edge of a browser
window. Such a tap has no visible effect.
GESTURE_MAXIMIZE_DOUBLETAP: A double-tap on the browser
window resulting in a maximize or restore action.
BUG=248230
Review URL: https://chromiumcodereview.appspot.com/16832003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depending on the data source (wallet, autofill), the
AutofillDialogController wants to show different section. Show/hide
accordingly and accomodate in layout computations.
R=rsesek@chromium.org
BUG=157274
Review URL: https://chromiumcodereview.appspot.com/18122003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after libwebp-0.3.1 it's correctly detected as BSD-like.
R=thestig@chromium.org
BUG=98448
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12771026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fileapi::FileSystemQuotaClient::DeleteOriginData().
BUG=255718
TBR=groby@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18251002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
this account.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17583017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=248917
Review URL: https://chromiumcodereview.appspot.com/17738002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=163552
Review URL: https://chromiumcodereview.appspot.com/18122002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Most of this change is adding token cache information, but there are some other changes meant to improve clarity.
BUG=181641
Review URL: https://chromiumcodereview.appspot.com/18029009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds following UMA stats for touch event latency
1. Event.Latency.Browser.TouchUI:
touch event received by Chrome -> touch event sent to renderer
2. Event.Latency.Browser.TouchAcked
touch event sent to renderer -> touch event acked from renderer
Corresponding telemetry stats are also added.
BUG=chromium:246034
TEST=1. Check UMA stats exist in chrome://histograms/Event.Latency.Browser
2. Check the relevant stats are in telemetry smoothness test.
Review URL: https://chromiumcodereview.appspot.com/17757002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The compositor_unittests has some tests that expect a real
framebuffer. ozone does not yet have a real framebuffer
implementation that can run in the test infrastructure.
This CL adds a simulated framebuffer sufficient to build and
run the compositor_unittests.
BUG=25242
Review URL: https://chromiumcodereview.appspot.com/17932004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The enter keyevent was double-handled in the 'Manage other users'
options dialog, making the dialog close when a user was added. This
CL fixes the problem by changing the event handled from keypress to
keydown so it matches the other event, then calling stopPropagation
on it when it is handled.
BUG=254163
Review URL: https://chromiumcodereview.appspot.com/17733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
scrolling areas
This change adds new debug rect types to show regions with touch or
wheel event handlers as well as areas that scroll slowly. Each rect type
also displays a label in the top left corner to make them easier to
identify.
BUG=253552
Review URL: https://chromiumcodereview.appspot.com/17599002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
depends on: https://codereview.chromium.org/13245007/
and: https://codereview.chromium.org/13132005/
BUG=181319
Review URL: https://chromiumcodereview.appspot.com/13258003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Checking Android sync settings appears to be cheap but masks potential
slow calls and jank on the ui-thread due to many parties querying sync
state. One example for slowness is due to this issuing IPCs to a
separate service which may need to be re-started and load state from
disk.
Testing on a Galaxy Nexus shows ~50-70ms aggregrate time spent querying
Android sync state reducing to <5ms for loading an initial page. There
are additional checks throughout the lifetime of the app that now become
in-memory lookups.
Regarding the implementation:
- Master Sync Automatically is account agnostic and can be cached once
at startup, and only updated when a notification is received that
settings have changed.
- The remaining settings are per-account. On access of any of these
settings, we grab the latest values for the requested account, and
also update when a notification is received. Updates are infrequent
and only when the signed in account changes.
BUG=238506
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/16092014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=jkummerow@chromium.org
Review URL: https://chromiumcodereview.appspot.com/18175006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using different blending equations we can perform
the pre-multiplication in the shader itself.
I am working on improving the performance of compositing canvas
elements with opaque background. This requires blending the
canvas texture with the background color in the shader. The
implementation of this blending equation becomes much easier if
we can assume that textures are always premultiplied.
BUG=236982
TEST=compositing/webgl/webgl-nonpremultiplied-blend.html
Review URL: https://chromiumcodereview.appspot.com/16943021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=251577
R=satorux@chromium.org
Review URL: https://codereview.chromium.org/17741009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=binji
BUG=
Review URL: https://codereview.chromium.org/18153014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's possible that if there has never been an activation (implying no root
layer on the active tree), then the trees will not be cleared during
LayerTreeHostImpl's destructor. Given the comment in the destructor about
animation, this seems to be problematic enough.
Issue 251722 is about a case where the tile manager tries to activate the tree
during its destruction but because the trees haven't been cleared yet, it
thinks this is a supported operation. This is fixed by always destroying the
trees in the destructor.
Related cleanup is to remove the CleanupRenderSurfaces() call which isn't
needed there. When you destroy a tree, you destroy its render surfaces. And,
it looked like none of the other CleanupRenderSurfaces() calls were really
needed either except for losing the output surface, so one call got moved there
and all the rest of the functions got removed.
R=danakj@chromium.org
BUG=251722
Review URL: https://chromiumcodereview.appspot.com/16831016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dpranke@chromium.org
Review URL: https://codereview.chromium.org/18184014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to be most expensive frames first.
BUG=none
TEST=experimental, manual
R=bradnelson@google.com
Review URL: https://codereview.chromium.org/18231003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That parts that will live in utility (the actual importers) work on
ImporterURLRow instead of history::URLRow, and once it's in-process in
in_process_importer_bridge, they're converted to history::URLRow to
be passed on to the profile code.
In preference to https://codereview.chromium.org/17956003/.
R=sky@chromium.org
BUG=254672
Review URL: https://codereview.chromium.org/18080009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The coordinate (0, 0) always refers to the primary screen, rather than the
screen containing the browser window for the popup.
BUG=246468
TEST=Autofill popup should be correctly positioned on multiple monitors, except
possibly when a retina display is involved.
R=shess@chromium.org
Review URL: https://chromiumcodereview.appspot.com/17733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
... but it was referencing it in index.html.
BUG=none
TBR=noelallen@chromium.org
Review URL: https://codereview.chromium.org/18182011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Legacy from migration from the Blink backend. This pushes the callback
wrapper creation into the dispatcher; those will eventually be eliminated
too. Gets rid of some FilePath->UTF16->FilePath conversions, too.
BUG=234278
R=jam@chromium.org
Review URL: https://codereview.chromium.org/18147004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The alpha value from the video's alpha plane should be
pre-multiplied in the YUVA Fragment Shader. This fixes videos not
rendering properly when the alpha plane is completely transparent
(i.e.) alpha value is zero. Also, adding a pixel test to test the
correct behavior.
BUG=147355
Review URL: https://chromiumcodereview.appspot.com/18122007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add missing support for name mangling of versions structures, enums,and typedefs.
NOTRY=true
BUG=157017
R=sehr@chromium.org
sehr for generator change.
yzshen please test with your CL to verify fix.
Review URL: https://chromiumcodereview.appspot.com/17924002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> ProcessSingleton now uses base::win::MessageWindow to create a message-only window.
>
> Collateral changes:
> - base::win::MessageWindow registes a single window class used by all message-only windows it creates. The class is registered via base::LazyInstance.
> - Added base::win::MessageWindow::FindWindow() wrapper used to find other message-only windows, including the other created by a different process.
> - Removed chrome::kMessageWindowClass constant.
>
> Review URL: https://chromiumcodereview.appspot.com/17615003
TBR=alexeypa@chromium.org
Review URL: https://codereview.chromium.org/18040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This improves the stub behavior for services and profile entries.
BUG=251922
R=gspencer@chromium.org
Review URL: https://codereview.chromium.org/18165003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without this the new NPObject ownership management implementation breaks
Android tests.
TBR=dfalcantara@chromium.org
Review URL: https://codereview.chromium.org/18233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change adds a script that will post-procress
gcc-generated .d files such that they do not have
file-not-found issue when headers are removed or
renamed.
Also, fix an issue in common.mk where it was checking
for IGNORE_DEPS incorrectly. This was causing dependencies
to always be built which was leading to duplicate builds
of the same project causing race conditions in the build
system.
R=binji@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/17769006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Reduce indenting levels
* Align args per style guide
* Improve (or remove) comments
* Pass around TemplateURL*s where convenient and safe instead of converting
to/from keywords. This generally simplifies things slightly and will be
useful for subsequent changes that need the TemplateURL*s in more places.
* Don't handle DCHECK failure
* Nuke long-outdated disabled KeywordProvider unittest
* Attempt (and probably fail) to put SearchProvider::CreateSearchSuggestion()
args in some sort of order
* Remove using directives where they don't save lines
* Follow style guide class declaration order
* Use OVERRIDE
* Make function declaration and definition order match
* Shorten/simplify code
* Put all three IsGoogleXXX() functions that take URLs in one group
* Eliminate unnecessary #includes
* Add GetDefaultSearchURLForSearchTerms() function to c/b/search_engines/util.h
since many disparate callers want to do that (and in a subsequent change I'll
want to slightly modify how that works)
* Fix presubmit warning about mismatched braces
* Remove unnecessary ResetDefaultTemplateURL() calls from ToolbarModel tests
BUG=249197
TEST=none
R=cpu@chromium.org, jered@chromium.org
Review URL: https://codereview.chromium.org/18119005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/18050013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=237267
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/18172004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates several histograms in the form
Platform.SwapJank.<event>.<measure>.<swap group>.<time interval>
where
<event> is TabSwitch or Scroll
<measure> is Cpu or Faults
<swap group> is Swap0, ... Swap3
<time interval> is Time1, ... Time4
When an event occurs (tab switch or scroll), we post tasks to the blocking
pool to read some measures at a few time intervals following the event
(100, 300, 1000 and 3000 milliseconds). Each measure is an average
for the interval. Measures are CPU utilization (%) and number of page
faults per second. We further classify the event by the current
utilization of the swap device: up to 10%, 10-30%, 30-60%, >60%.
The purpose of these histograms is to characterize the impact of
memory pressure (and consequently paging) on common events. We chose
tab switches and scroll events because they seem to be the ones
that are most affected by paging. Ideally we would like to measure
the time from the input event to the completion of the request,
but this is hard to do, so instead we attempt to extrapolate the impact
of paging from these indirect measures.
This has been tested both on Linux and Chrome OS, and the histograms
appear reasonable.
BUG=252772
TEST=manual, run with --v=0 --vmodule=swap_metrics=1 and switch tabs
R=semenzato@chromium.org, stevenjb@chromium.org
Review URL: https://codereview.chromium.org/17577003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=255228
TBR=shess@chromium.org
Review URL: https://codereview.chromium.org/18052023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=none
Review URL: https://chromiumcodereview.appspot.com/17585005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209223 0039d316-1c4b-4281-b951-d872f2087c98
|