| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
The UMA_HISTOGRAM_ENUMERATION macro declares a static object, so we need to explode the macro.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7184003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change eliminates parts of html test suite not related to <form> elements in an attempt to speed up the tests.
Before:
real 0m58.920s
user 1m4.858s
sys 0m15.006s
After:
real 0m46.897s
user 0m50.286s
sys 0m12.361s
A subsequent patch will attempt to re-enable these tests on Windows in the hopes that we're under the wire now with respect to timeouts.
BUG=85276
TEST=FormStructureBrowserTest.*
Review URL: http://codereview.chromium.org/7190012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and renderer process) in the same share group.
This is work towards allowing offscreen canvas contexts to be allocated before compositor view contexts are created. This is a problem because a canvas might be created before the window it will be displayed in exists.
This does not fix the bug on its own.
BUG=80703
Review URL: http://codereview.chromium.org/7104148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Delegate a few implemented BrowserWindow methods via NativePanel.
In preparation to removing BrowserWindow inheritance on a native Panel implementation.
Review URL: http://codereview.chromium.org/7192013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
r=kcc
bug=86143
Review URL: http://codereview.chromium.org/7187001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resources
BUG=chromium-os:85082
TEST=see bug
Review URL: http://codereview.chromium.org/7182003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tree_node_model_unittest.cc
First reason is because doesn't make sense to continue when the assertions in
question fails. Second reason is because we are already using more ASSERT_* checks
than EXPECT_*. So this change makes everything using ASSERT_* rather than EXPECT_*.
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.*
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7187016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Give the new directory media-flavored OWNERS (in addition to the auto-inherited
OWNERS).
This should hopefully significantly cut down on OWNERS rubberstamps.
BUG=none
TEST=trybots & OVDATest passes on ARM.
Review URL: http://codereview.chromium.org/7192003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85463
TEST=Crash server stops seeing crashes (see bug).
Review URL: http://codereview.chromium.org/7145006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=yutak
Review URL: http://codereview.chromium.org/7187020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7187009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocking updates for individual products are conflicting with the effective update policy for the multi-install binaries.
In so doing, I moved the GP update policy checking code that was in browser into installer_util.
BUG=none
TEST=Install multi-install Chrome version N-1, disable updates for Chrome, then try to update to version N. With luck, you'll find that the update failed on account of inconsistent GP settings.
R=robertshield@chromium.org,pastarmovj@chromium.org,gwilson@chromium.org
Review URL: http://codereview.chromium.org/7111012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16001
TEST=None
Review URL: http://codereview.chromium.org/7191020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=78860
TEST=n/a
Review URL: http://codereview.chromium.org/7187010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60149
TEST=net_unittests
Review URL: http://codereview.chromium.org/7187012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16138
TEST=ctrl-j to launch downloads tab. Right click should no longer do anything.
Review URL: http://codereview.chromium.org/7046116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
moved this to pp::SelectionDev.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/7185007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/7097004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85258
TEST=manual testing done by developer
Review URL: http://codereview.chromium.org/7027040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a client.
BUG=85110
TEST=
Review URL: http://codereview.chromium.org/7134023
TBR=wez@chromium.org
Review URL: http://codereview.chromium.org/7189017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
avoids crash where migrator pulls a null snapshot post-shutdown.
also make sure migrator examines the correct set of types to migrate when calling Configure.
BUG=85181
TEST=MigrationErrorsTest (sync_integration_tests)
Review URL: http://codereview.chromium.org/7170034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
just need to disable the popup blocker to work properly.
Review URL: http://codereview.chromium.org/7187013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85408
TEST=
Review URL: http://codereview.chromium.org/7191012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7185013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=85110
TEST=
Review URL: http://codereview.chromium.org/7134023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sdch, skia, and testing.
BUG=28727
Review URL: http://codereview.chromium.org/7165009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81624,chromium-os:15176
TEST=pyauto notification will pass
Review URL: http://codereview.chromium.org/7146027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1846
TEST= nacl_integration
Review URL: http://codereview.chromium.org/7184021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
possible in target.
BUG=none
TEST=manual on linux
Review URL: http://codereview.chromium.org/7171008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=browser_test:WindowOpenPanel
Review URL: http://codereview.chromium.org/7192001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The z-ordering of child views is currently maintained (implicitly?) by the order
they are added to the parent view. It may often be necessary to change the
z-order of views, and View::ReorderChildView can be used to do that.
I changed views_desktop to have the two pure-views windows to have overlapping
regions, and View::ReorderChildView is used to change the z-ordering of the two
windows. So it is possible to click a window to activate it and bring it on top
of the other. It could have been done without adding Widget::MoveToTop, but
given Widget::MoveAbove and MoveAboveWidget, it sounded like a good idea to have
Widget::MoveToTop (MoveToFront?). I do now know what the implementation for
windows should be, though. So left it as NOTIMPLEMENTED.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7185005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduced in 7080030
BUG=86136
TEST=unit_tests BaseTabStripTest*CreateTabForDragging
Review URL: http://codereview.chromium.org/7170028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently ui_unittests runs the unittests for base/, gfx/ and views/ through ui/gfx/run_all_unittests.cc
(which is the only run_all_unittests compiled in the ui_unittests target) and thus can
have only one main() function to run those tests.
BUG=None
TEST=ui_unittests
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/7184014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Run DisconnectWindow::Show/Hide on correct thread.
This is to ensure that the DisconnectWindow UI actions are carried out on the
proper thread for making platform-native GUI API calls (for example, GTK on
Linux).
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7180001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Updated TypedURLModelAssociator to delete any old-style sync nodes so they don't clutter up the sync DB (makes it hard to debug/test).
Also updated typed URL sync code to sync up the full transition data (not just the transition type). This is important as that extra data is used by the history view to determine if a URL should be displayed -- removing the extra bits would ultimately cause items to disappear from History.
BUG=84258
TEST=Run typed url sync with old obsolete nodes, see that those nodes are deleted on startup. Also, type in URL in client A, sync URL to client B, see URL in History view on both clients.
Review URL: http://codereview.chromium.org/7188001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move private NativeWidget methods to new internal interface
NativeWidgetPrivate.
This should make it harder to abuse accidentally.
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/7170019
Review URL: http://codereview.chromium.org/7189012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provide common URLs as users start typing "about://" or "chrome://".
Highlight matching input (including "chrome://" for "about:" input).
Support settings sub-pages/paths, e.g. "chrome://settings/foo".
Add BuiltinProviderTest unit test.
Additional hosts will be added when I fix crbug.com/73926.
BUG=55771
TEST=Get chrome:// AutocompleteProvider URLs in the omnibox dropdown.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89073
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89298
Review URL: http://codereview.chromium.org/6995096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allocating |root| on the stack and passing to |model|, also on the stack,
does _not_ work, because TreeNodeModel owns the root.
So when the dtor of TreeNodeModel is called, it attempts to free an invalid
pointer, which was already deleted.
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7171001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- replacing occurences of sys.platform == 'linux2' with
sys.platform.startswith('linux')
- congregating occurences of sys.platform in ('linux[X]', 'linuxY', ...)
to sys.platform.startswith('linux')
- adding the key 'linux3' to all relevant lookup dicts
BUG=85845
TEST=Try building chromium on Linux >=3.0-r1
Review URL: http://codereview.chromium.org/7172016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG= http://code.google.com/p/nativeclient/issues/detail?id=1846
TEST= chrome_browser_tests
Review URL: http://codereview.chromium.org/7182002
TBR=dspringer@chromium.org
Review URL: http://codereview.chromium.org/7184018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89352 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7046034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7097014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=8592
Review URL: http://codereview.chromium.org/6995133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
template
BUG=86313
TEST=manually
Review URL: http://codereview.chromium.org/7184012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ui_unittests --gtest_filter=TreeNodeModelTest.AddNode
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7166001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=80694
TEST=None
Review URL: http://codereview.chromium.org/7192009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89344 0039d316-1c4b-4281-b951-d872f2087c98
|