| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1128753005
Cr-Commit-Position: refs/heads/master@{#328905}
|
|
|
|
|
|
|
|
|
|
|
| |
Mike (mtklein) built this simplified version when doing https://codereview.chromium.org/1114283003/.
TEST=trybots seems happy
R=danakj@chromium.org
Review URL: https://codereview.chromium.org/1115993004
Cr-Commit-Position: refs/heads/master@{#328904}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When Chrome is linked against an OSX 10.9+ SDK, -[NSAttributedString
copy] returns a retained self, rather than a copy.
-[NSMutableAttributedString copy] returns a new object. The test
TextInputClientMacTest.GetSubstring was checking that a new object was
made, but it was passing as an input an NSAttributedString. I changed
the test to use a NSMutableAttributedString as input instead.
BUG=484203
Review URL: https://codereview.chromium.org/1131773002
Cr-Commit-Position: refs/heads/master@{#328903}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #3 id:40001 of https://codereview.chromium.org/1126393002/)
Reason for revert:
Broke Linux GN Clobber build.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/49/steps/compile/logs/stdio
Original issue's description:
> [Chromoting] Add GN build support for ar_sample_app target.
>
> This adds GN build rules for the AppRemoting sample app.
> Some DesktopRemoting build rules were prettified as part of this
> process (to make the App- and Desktop- remoting build rules more
> similar).
>
> BUG=471916
>
> Committed: https://crrev.com/13a3ca1f8053b1b2d195b8f5f52b90e184287ea8
> Cr-Commit-Position: refs/heads/master@{#328871}
TBR=jamiewalch@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471916
Review URL: https://codereview.chromium.org/1135603003
Cr-Commit-Position: refs/heads/master@{#328902}
|
|
|
|
|
|
|
|
|
|
| |
Replace fileManagerPrivate.installWebstoreItem with the new method.
BUG=477106
Review URL: https://codereview.chromium.org/1125093003
Cr-Commit-Position: refs/heads/master@{#328901}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test reproduces the condition which was triggering an infinite loop
inside GinJavaBridgeDispatcherHost::RenderFrameDeleted.
Verified that the test indeed hangs up and timeouts if the fix is removed.
BUG=484927
Review URL: https://codereview.chromium.org/1134543002
Cr-Commit-Position: refs/heads/master@{#328900}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These applications became deps of core_services with:
https://codereview.chromium.org/1131703002/
BUG=477435
TEST=Building core_services builds dependent targets.
R=erg@chromium.org,sky@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/1134613002
Cr-Commit-Position: refs/heads/master@{#328899}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supplies this file (patchset #5 id:80001 of https://codereview.chromium.org/1131153002/)
Reason for revert:
Broke Win8 GN build.
http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/7036/steps/compile/logs/stdio
Original issue's description:
> Include inttypes.h unconditionally in format_macros.h - VS2103 now supplies this file
>
> BUG=
>
> Committed: https://crrev.com/ffb6b7c8e0599f6fb3b25bbd5bc49b5fba818ffd
> Cr-Commit-Position: refs/heads/master@{#328894}
TBR=scottmg@chromium.org,thakis@chromium.org,chcunningham@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1123983003
Cr-Commit-Position: refs/heads/master@{#328898}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The entry in the WebFrame->RenderFrameProxy map is removed in the
RenderFrameProxy destructor, but the destructor runs after the frame
has been destroyed. Remove the entry at the time of WebFrame::close().
BUG=357747
Review URL: https://codereview.chromium.org/1136593003
Cr-Commit-Position: refs/heads/master@{#328897}
|
|
|
|
|
|
|
|
|
|
|
| |
Add an isolate for the audio_unittests target.
BUG=416594
TEST=isolate.py run
Review URL: https://codereview.chromium.org/1129853006
Cr-Commit-Position: refs/heads/master@{#328896}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Creates a new "NewVideoRendererTrial" field trial which will be
rolled out at to a small percentage (group_name == "Disabled") of
users for tracking improvements to YT watch time.
BUG=485699
TEST=Verified new path with --force-fieldtrials and without.
Review URL: https://codereview.chromium.org/1132003002
Cr-Commit-Position: refs/heads/master@{#328895}
|
|
|
|
|
|
|
|
|
|
| |
this file
BUG=
Review URL: https://codereview.chromium.org/1131153002
Cr-Commit-Position: refs/heads/master@{#328894}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This buildtools roll rolls GN from 327383:328853, primarily
to pick up the fix the to 'gn refs' command in #328846.
This buildtools roll also drops the linux32 binary of GN.
TBR=brettw@chromium.org
BUG=485386
CQ_EXTRA_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_rel,win_chromium_gn_x64_rel;tryserver.chromium.mac:mac_chromium_gn_rel
Review URL: https://codereview.chromium.org/1131923003
Cr-Commit-Position: refs/heads/master@{#328893}
|
|
|
|
|
|
|
|
|
|
| |
Much much simpler.
BUG=none
Review URL: https://codereview.chromium.org/1130303002
Cr-Commit-Position: refs/heads/master@{#328892}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added GCD device ID to host config.
- Disabled email verification for GCD devices.
Disabling email verification is necessary because it is apparently not possible to retrieve an email address for a device registered through GCD.
BUG=471928
Review URL: https://codereview.chromium.org/1108203003
Cr-Commit-Position: refs/heads/master@{#328891}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add unit/browser tests for MediaRouterDialogController.
Tests creating the dialog, navigation, and WebContents closing.
Also refactor out common logic between PrintPreviewTest and
MediaRouterTest into a test class.
Please note that MediaRouterTest will be reused in another unit test
that will be upstreamed in a future patch.
BUG=464216
Review URL: https://codereview.chromium.org/1128363002
Cr-Commit-Position: refs/heads/master@{#328890}
|
|
|
|
|
|
|
|
| |
These changes are based on other CLs. A sink ID is passed into the create route call rather than the entire sink (per imcheng@'s CL). The "selectedCastModeValue" replaces the more vague "castMode" naming.
Review URL: https://codereview.chromium.org/1130123004
Cr-Commit-Position: refs/heads/master@{#328889}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
transitions.
This test was requested in https://codereview.chromium.org/1099703004/
BUG=346230
R=sunnyps,enne
Review URL: https://codereview.chromium.org/1115213007
Cr-Commit-Position: refs/heads/master@{#328888}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids having to copy them when inserting them into a recording
during paint.
This patch changes the time to do UpdateLayers for a single tab
loading spinner from 0.206279ms to 0.163527 on a linux z620, giving
a 21% reduction in frame record time. I used a mean of 2000 samples
(throwing out the first 100) in each run to reduce noise.
R=sky
BUG=466426
Review URL: https://codereview.chromium.org/1128403003
Cr-Commit-Position: refs/heads/master@{#328887}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(2nd try)
When the message center opens, NotificationUIManager::CancelById method doesn't close the notification. We need to call MessageCenter::RemoveNotification in addition.
The use-after-free on the previous patch has been fixed in this patch.
BUG=481078
TEST=manually tested, added test succees
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng
Review URL: https://codereview.chromium.org/1135503002
Cr-Commit-Position: refs/heads/master@{#328886}
|
|
|
|
|
|
|
|
|
|
|
| |
They convert internal Media Router objects to their Mojo struct counterparts and vice versa.
Depends on Issue which is under review in CL 1103273013.
BUG=464205
Review URL: https://codereview.chromium.org/1110853003
Cr-Commit-Position: refs/heads/master@{#328885}
|
|
|
|
|
|
|
|
|
| |
BUG=451917
TEST=manually
Review URL: https://codereview.chromium.org/1113333002
Cr-Commit-Position: refs/heads/master@{#328884}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the responsibility of clearing state inside the LTHI after an
impl frame is finished from the thread proxies to the LTHI class. This makes
WillBeginImplFrame and DidFinishImplFrame a logical pair.
This CL also;
* Adds a test that checks the number of WillBeginImplFrame
calls matches the DidFinishImplFrame calls.
* Cleans up classes in cc/test/layer_tree_test.h around WillBeginImplFrame.
* Removes the UpdateCurrentBeginFrameArgs / ResetCurrentBeginFrameArgs methods.
* Fixes a bug where STP was calling ResetCurrentBeginFrameArgs twice every frame.
BUG=346230,481810
R=brianderson,enne
Committed: https://crrev.com/2caee4f89de17858822c11379da9c6cd80f90708
Cr-Commit-Position: refs/heads/master@{#328689}
Review URL: https://codereview.chromium.org/1111743002
Cr-Commit-Position: refs/heads/master@{#328883}
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org, bbudge@chromium.org
BUG=482415
Review URL: https://codereview.chromium.org/1119613002
Cr-Commit-Position: refs/heads/master@{#328882}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a plugin cannot be found, and NPAPI plugins are disabled - try and determine if it's probably an NPAPI plugin and if so display an infobar about NPAPI deprecation to the user. This aims to catch the case of plugins suddenly not working after M42.
This is the second part of two CLs to better inform users about the NPAPI deprecation.
See mocks - https://docs.google.com/document/d/1hwSFxMKL1Q2FVNAqmy1GxiZZb0Df8PO_oCkXnUk2QpQ/edit
BUG=380227
Review URL: https://codereview.chromium.org/1122683002
Cr-Commit-Position: refs/heads/master@{#328881}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whitelist two non-system macros.
Even though CR_BEGIN_MSG_MAP_EX and BEGIN_SAFE_MSG_MAP_EX are from chromium
code, they are interface-compatible with the system macro BEGIN_MSG_MAP_EX
and so we can't fix the style plugin warnings about them. So whitelist these
two macros.
BUG=484721
Review URL: https://codereview.chromium.org/1126413004
Cr-Commit-Position: refs/heads/master@{#328880}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds two new optional filter parameters to studies, "country"
and "exclude_country", that allow studies to be enabled or disabled in
specific countries.
The country code is supplied by the variations server as part of the
variations seed response. Chrome uses the latest country code received
for filtering session-consistency studies. For permanent-consistency
field trials, Chrome uses the first country code received for the
current Chrome version.
BUG=477039
Review URL: https://codereview.chromium.org/1122083004
Cr-Commit-Position: refs/heads/master@{#328879}
|
|
|
|
|
|
|
|
|
|
|
| |
CredentialManagerClientTest allocates a client and a credential in test
setup, but doesn't free the client in the teardown.
BUG=
Review URL: https://codereview.chromium.org/1124393003
Cr-Commit-Position: refs/heads/master@{#328878}
|
|
|
|
|
|
|
|
|
|
| |
BUG=477084
TEST=new tests
TBR=kalman@chromium.org
Review URL: https://codereview.chromium.org/1128123003
Cr-Commit-Position: refs/heads/master@{#328877}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds all of the remaining test binaries to the
Linux GN release waterfall bot and tryserver except
for browser_tests:
- content_browsertests
- interactive_ui_tests
- media_unittests
- net_unittests
- sync_integration_tests
- unit_tests
R=brettw@chromium.org
BUG=432959
Review URL: https://codereview.chromium.org/1125173003
Cr-Commit-Position: refs/heads/master@{#328876}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
What was done:
* Status pages have new desing now (<notification-card> element).
* Close button have a correct color depending of background color.
* Introduced new step 'attribute-promtp-error' which is <notification-card> too.
BUG=471934
TEST=manually,enrollment works
Review URL: https://codereview.chromium.org/1119933003
Cr-Commit-Position: refs/heads/master@{#328875}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add new UMA histograms for APIPermission::ID (which will eventually replace PermissionMessage::ID)
TBRing a mechanical change in app_launcher_handler.cc
TBR=estade
BUG=398257
Review URL: https://codereview.chromium.org/1094873002
Cr-Commit-Position: refs/heads/master@{#328874}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1084793003/)
Reason for revert:
BUG=480789
Original issue's description:
> Re-size frame only for printing selection
>
> Re-size was added to fix issue 1566. There is a test in #7.
> With current state of blink resize is not needed and actually has
> issues afters https://codereview.chromium.org/1008513003.
>
> Printing selection still needs resizing, because selectionAsMarkup() returns
> fixed snapshot of frame. Re-layout or re-sizing of the snapshot after
> that is not possible.
>
> BUG=474173
>
> Committed: https://crrev.com/51cda916c51147311cf3d13d4305bc6647b22479
> Cr-Commit-Position: refs/heads/master@{#325106}
TBR=alekseys@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=474173
Review URL: https://codereview.chromium.org/1131193002
Cr-Commit-Position: refs/heads/master@{#328873}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Fix order of HKDF arguments: the salt was being passed as the label
and the label as the salt.
2. Pass sizeof(label) to the StringPiece constructor to match server.
This CL also adds a "known gold" test with a corresponding server-side
test. Hopefully if the client-side cert report encryption/decryption
code changes in such a way that the server would no longer be able to
decrypt reports, this test will catch it.
BUG=
Review URL: https://codereview.chromium.org/1131763005
Cr-Commit-Position: refs/heads/master@{#328872}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds GN build rules for the AppRemoting sample app.
Some DesktopRemoting build rules were prettified as part of this
process (to make the App- and Desktop- remoting build rules more
similar).
BUG=471916
Review URL: https://codereview.chromium.org/1126393002
Cr-Commit-Position: refs/heads/master@{#328871}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1126873002
Cr-Commit-Position: refs/heads/master@{#328870}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change switches the Google pins to accept the GlobalSign root
rather than requiring GIAG2 specifically. This is in preparation for the
renewal of GIAG2.
BUG=485701
TEST=Google sites still load in official builds.
Review URL: https://codereview.chromium.org/1131993002
Cr-Commit-Position: refs/heads/master@{#328869}
|
|
|
|
|
|
|
|
| |
BUG=471928
Review URL: https://codereview.chromium.org/1124313002
Cr-Commit-Position: refs/heads/master@{#328868}
|
|
|
|
|
|
|
|
| |
BUG=471928
Review URL: https://codereview.chromium.org/1128753002
Cr-Commit-Position: refs/heads/master@{#328867}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves clipboard, window_manager and view_manager into the same
core_services.mojo physical library, letting us share the core mojo and
base code in said library. We make core_services a packaging detail of
mandoline, and only set up the aliases in the mandoline binary.
This is the first pass at starting each of these applications on their
own thread.
BUG=477435
Review URL: https://codereview.chromium.org/1131703002
Cr-Commit-Position: refs/heads/master@{#328866}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/e40d397..e64eb57
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/1125383004
Cr-Commit-Position: refs/heads/master@{#328865}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
operator overloads. (patchset #1 id:1 of https://codereview.chromium.org/1128273004/)
Reason for revert:
Still breaks iOS bots. Tracking at crbug.com/485435.
Original issue's description:
> Revert of Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #1 id:1 of https://codereview.chromium.org/1130953002/)
>
> Reason for revert:
> iOS_Device builder was not rebuilding certain modules dependent on changes in base::Time. http://crbug.com/485435
>
> Original issue's description:
> > Revert of Fixit: Factor out common base::Time* math operator overloads. (patchset #2 id:40001 of https://codereview.chromium.org/1122443004/)
> >
> > Reason for revert:
> > Broke iOS build.
> >
> > http://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/5621/steps/compile/logs/stdio
> >
> > Original issue's description:
> > > Fixit: Factor out common base::Time* math operator overloads.
> > >
> > > This is part 1 of a 2-part change to fork base::TimeTicks into three
> > > type-checked time classes (TimeTicks + ThreadTicks + TraceTicks). The
> > > forking of TimeTicks will ensure values from different clocks are not
> > > erroneously being mixed together when doing time math.
> > >
> > > In this change, the identical comparison and math operator overloads
> > > found in base::Time and base::TimeTicks are being factored-out into a
> > > templated base class. In a following change, this base class will also
> > > be used to de-dupe this common functionality in the two new time
> > > classes.
> > >
> > > BUG=467417
> > >
> > > Committed: https://crrev.com/7ca717095b4758cb76e53e904b775852e46d646d
> > > Cr-Commit-Position: refs/heads/master@{#328696}
> >
> > TBR=thestig@chromium.org,miu@chromium.org
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=467417
> >
> > Committed: https://crrev.com/a365825583412c355a449274bec70e41e992ffd7
> > Cr-Commit-Position: refs/heads/master@{#328706}
>
> TBR=thestig@chromium.org,ksakamoto@chromium.org
> NOPRESUBMIT=true
> BUG=467417,485435
>
> Committed: https://crrev.com/59fca1cd30487a013b942acf9d660dfcc639e25a
> Cr-Commit-Position: refs/heads/master@{#328843}
TBR=thestig@chromium.org,ksakamoto@chromium.org,smut@chromium.org,miu@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467417,485435
Review URL: https://codereview.chromium.org/1125283003
Cr-Commit-Position: refs/heads/master@{#328864}
|
|
|
|
|
|
|
|
|
|
| |
To give legacy content 2px extra leeway.
BUG=481258
Review URL: https://codereview.chromium.org/1132453002
Cr-Commit-Position: refs/heads/master@{#328863}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:80001 of https://codereview.chromium.org/1106153002/)
Reason for revert:
The smart bubble isn't gonna happen in M44. There is no reason to make these unnecessary requests.
Original issue's description:
> PaswordFormManager should fetch the site stats.
>
> ManagePasswordsUIController will be extended in the future to write the stats.
>
> BUG=431739
>
> Committed: https://crrev.com/0ff4c141dab88f9cca01a21b790b2a767b462ff2
> Cr-Commit-Position: refs/heads/master@{#327973}
TBR=vabr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=431739
Review URL: https://codereview.chromium.org/1135643003
Cr-Commit-Position: refs/heads/master@{#328862}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Roll 66dc43ded4472d20dda860acbf22a06e625ea86a:1e318b3f0ad952d22477151eec98d37fa08e5bc7
BUG=485632,485634,485641,485642,483282
TEST=gpu_bots
R=kbr@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/1128343003
Cr-Commit-Position: refs/heads/master@{#328861}
|
|
|
|
|
|
|
|
| |
BUG=165989
Review URL: https://codereview.chromium.org/1102873002
Cr-Commit-Position: refs/heads/master@{#328860}
|
|
|
|
|
|
|
|
|
| |
R=boliu@chromium.org,qinmin@chromium.org,tedchoc@chromium.org,danakj@chromium.org,caitkp@chromium.org
BUG=484911
Review URL: https://codereview.chromium.org/1123993002
Cr-Commit-Position: refs/heads/master@{#328859}
|
|
|
|
|
|
|
|
|
|
|
| |
Landing https://codereview.chromium.org/1114543002/
BUG=469992
TBR=isherman@chromium.org
Review URL: https://codereview.chromium.org/1132523002
Cr-Commit-Position: refs/heads/master@{#328858}
|
|
|
|
|
|
|
|
|
| |
BUG=362214
TBR=michaeln
Review URL: https://codereview.chromium.org/1131073002
Cr-Commit-Position: refs/heads/master@{#328857}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new StoragePartition::Flush method to flush all unwritten data
for the StoragePartition. At present this only flushes the
DOMStorageContextImpl - not sure if other storage systems require flushing.
Also, included a few headers (as suggested by git cl lint), and fixed a few
typos.
BUG=479767
Review URL: https://codereview.chromium.org/1126733002
Cr-Commit-Position: refs/heads/master@{#328856}
|