| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Eliminate NativeWidgetGtk specifics, remove extra files.
This supersedes http://codereview.chromium.org/8811001/
This supersedes http://codereview.chromium.org/8774022/
See Issue 106230 for a list of some BubbleWindow users.
The save and open SelectFileExtensionDialog instances look good.
Bookmark All Tabs dialog looks good on non-aura, blocked on aura by crbug.com/106474.
BUG=106230
TEST=BubbleWindows look the same on CrOS, and now similar on Aura. Ensure no regressions of crosbug.com/9065, crosbug.com/8538.
Review URL: http://codereview.chromium.org/8800032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow the user of the utility process to specify whether the zygote
should be used on Linux. This allows to sandbox all the uses
of the utility process that don't do FS access, which right now are all
except extension unpacking and NPAPI plugin listing.
This is the first step to get the utility process sandboxed
on Linux. Since most of the uses of the utility process
don't do file access, launching all of those from the zygote
will simplify sandboxing the one that does: extension
unpacking.
BUG=93109
TEST=Try installing an extension from the web store.
Review URL: http://codereview.chromium.org/8770025
TBR=jorgelo@chromium.org
Review URL: http://codereview.chromium.org/8817013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly revoked permission and hence the OAuth2
access token generation may fail. In that case, prompt the user.
add unit tests and modify existing tests.
TBR=asargent
Review URL: http://codereview.chromium.org/8822006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The unit test was causing a DCHECK to fail. IsDefaultProfileImageURL() doesn't expect an invalid URL so I remvoed the invalid URL.
TBR=ivankr@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8821007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105028
TEST=none
Review URL: http://codereview.chromium.org/8800010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=93950
TEST=none
Review URL: http://codereview.chromium.org/8818002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=88782
TEST=changed certificate_types struct in local copy of nss selfserv,
reloaded, checked "echo .dump | sqlite3 'Origin Bound Certs'" to see if
new cert was generated.
Review URL: http://codereview.chromium.org/8821002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ordinal IME shows candidate window under the cursor, but Mozc should show
"suggest window"(same view but different location) and it's location is sent
by mozc-engine.
BUG=chromium-os:21356
TEST=manually confirmed it works fine and no conflict with other CJK engine.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112452
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112965
Review URL: http://codereview.chromium.org/8505051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes NOTIMPLEMENTED()s for platform_util's
ShowItemInFolder(), OpenItem(), and OpenExternal(). We now
use the native Chrome OS, Windows, or Linux versions of
these functions.
BUG=99712
TEST=manual: checked that we use the file manager extension to open downloaded files on Chrome OS and that we use XDG on linux
Review URL: http://codereview.chromium.org/8808003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove search box until we have decided how to approach it;
- Show apps pagination dots;
- Dismiss app list UI on escape or click on non-app and non nav dots;
- Defer widget showing further until apps are loaded by webui;
- Add a container div to limit apps page height so that the gap between apps icons and nav dots are not too big;
- Passing bounds when requesting app list widget to avoid resizing;
BUG=98308,105794,106451
TEST=Verify search box is gone, nav gots show up on bottom and could switch pages by clicking on it;
Review URL: http://codereview.chromium.org/8747021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
were attempting shutdown before destroying the compositor.
BUG=104360
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8800030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, each Expose event (caused e.g. when you move the host window) would
trigger an immediate redraw, which can take a long time (vsyng, GPU load, ...).
Instead, schedule a redraw so that multiple expose can get gathered into a
single redraw.
BUG=None
TEST=launch chrome/aura, move the window around for a few seconds, check that things are interactive again right away.
Review URL: http://codereview.chromium.org/8815004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8804027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not the final UI yet.
Additional improvements:
- file name is selected in save-as dialog at start;
- new folder moved to context menu, button deleted.
BUG=chromium-os:20168,chromium-os:22106,chromium-os:22105,chromium-os:22032,chromium-os:20547,chromium-os:20549
TEST=Manual
Review URL: http://codereview.chromium.org/8554003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91241
TEST=
Review URL: http://codereview.chromium.org/8772055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:23388
TEST=Go to chrome://settings/system. Play with touchpad settings. top -u chronos should not show any defunct tpcontrol processes.
Review URL: http://codereview.chromium.org/8813001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prevent a crash in the first run search engine selector.
It is possible to try and close the window now before the TemplateURLService is loaded. In this case we will not have a fallback search engine to select by default. So we will just reject attempts to close the window in this circumstance until it is loaded and a fallback choice has been set. It should be an edge case.
http://crbug.com/106078
TEST=unit test
Review URL: http://codereview.chromium.org/8771018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=hans
Review URL: http://codereview.chromium.org/8817002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will eventually replace ModelType{Bit,}Set.
BUG=79970
TEST=
Review URL: http://codereview.chromium.org/8772073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed AUTHENTICATED state from ConnectionToHost - We no longer need it there.
BUG=105214
Review URL: http://codereview.chromium.org/8774017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These two functions are normal functions these days and can't be NULL.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8802029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=106188
TEST=added
Review URL: http://codereview.chromium.org/8800016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8800031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105657
TEST=manual
Review URL: http://codereview.chromium.org/8806025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the break, it fails if the app happens to come before the extension in items.
BUG=104091
TEST=none
TBR=asargent@chromium.org
Review URL: http://codereview.chromium.org/8801037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=92421
TEST=none
Review URL: http://codereview.chromium.org/8817010
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/8817011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/8818003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92421
TEST=none
Review URL: http://codereview.chromium.org/8817010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20Clang%20%28ChromeOS%20dbg%29/builds/4017/steps/compile/logs/stdio
Add ONC VPN support for OpenVPN and L2TP/IPsec VPNs
Also simplifies some of the parsing code, adds type validation, brings
the WiFi security parsing up to spec, and improves the unit tests for
wifi so that they all verify the property_map_ fields (the only ones
actually used to configure the network). Also fixed a general parser
problem where certificates wouldn't be parsed if network configs were.
BUG=chromium-os:23476 chromium-os:23477
TEST=manual import of ONC file with openvpn network, unit_tests
Review URL: http://codereview.chromium.org/8759014
TBR=kmixter@chromium.org
Review URL: http://codereview.chromium.org/8819011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
over SSL.
Review URL: http://codereview.chromium.org/8805020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These sources have been moved over to the native_client repository.
Remove them from chromium/src altogether and just make the gyp files
refer to the native_client stuff.
BUG= none
TEST= linux still builds
R=sehr@google.com
Review URL: http://codereview.chromium.org/8800034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Add unit tests.
Review URL: http://codereview.chromium.org/8803029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
views::InputMethodBridge
InputMethodBridge:
- Implements ui::TextInputClient interface, and receives IME results (e.g. composition text) from ui::InputMethod and forwards them to UI (e.g. a text field).
- Also receives a request like 'CancelComposition' from the UI and forwards it to ui::InputMethod.
Original review: http://codereview.chromium.org/8576005/ (PatchSet #1-8, Comment #1-24)
BUG=97261
TEST=see part 3 of 3.
Review URL: http://codereview.chromium.org/8687027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102576
TEST=None
Review URL: http://codereview.chromium.org/8741022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=No visible change.
Review URL: http://codereview.chromium.org/8790006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
log when the user changes their photo. Currently it logs any time name OR avatar are updated. Now it should only do it for actual avatar changes.
BUG=93825,106134
TEST=none
Review URL: http://codereview.chromium.org/8790010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8800026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=On linux you should see a dangerous file type warning when downloading an exe.
Review URL: http://codereview.chromium.org/8806021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NSS implicitly before calling the NSS function
SSL_ClearSessionCache.
Remove the stale comment that
SSLClientSocketNSS::ClearSessionCache is only for tests.
R=mattm@chromium.org
BUG=105431
TEST=net_unittests --gtest_filter=SSLClientSocketNSSTest.ClearSessionCache
Review URL: http://codereview.chromium.org/8816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is another stupid mistake of mine while moving spellchecker-related context-menu to the SpellingMenuObserver class. (As written in r111881 <http://crrev.com/111881>, the original code shows this separator only when |misspelled_word| is not empty.) This change shows this separator only when this |misspelled_word| is not empty.
BUG=105926
TEST=manual
Review URL: http://codereview.chromium.org/8806006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=sail@chromium.org,estade@chromium.org
BUG=98928
TEST=Focus starts on user name. When you press shift tab you land on "Learn
more" link. When you press enter on that link and press tab again, you're still
on the same link (that now reads "Hide").
Review URL: http://codereview.chromium.org/8502042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8742001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98110
Review URL: http://codereview.chromium.org/8539045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also simplifies some of the parsing code, adds type validation, brings
the WiFi security parsing up to spec, and improves the unit tests for
wifi so that they all verify the property_map_ fields (the only ones
actually used to configure the network). Also fixed a general parser
problem where certificates wouldn't be parsed if network configs were.
BUG=chromium-os:23476 chromium-os:23477
TEST=manual import of ONC file with openvpn network, unit_tests
Review URL: http://codereview.chromium.org/8759014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=106060
TEST=none
Review URL: http://codereview.chromium.org/8779001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Restoring the CL
Revert 113015 - speculative revert to see if this fixes the interactive test breakage
Remove OnMessageReceived that was using internal content IPCs in a chrome test. Dispatch the IPC in RenderViewHost instead of TabContents to solve this (it's only used by tests anyways). Remove test_utils methods that weren't being used.
BUG=98716
Review URL: http://codereview.chromium.org/8801002
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8817007
TBR=sail@chromium.org
Review URL: http://codereview.chromium.org/8821005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
based on whether there is a node on the sync side.
BUG=102714
TEST=none
Review URL: http://codereview.chromium.org/8786006
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8819008
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/8818004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recent large increases were webkit roll (crbug.com/106167) and sfntly
roll (crbug.com/106515)
BUG=106515,106167
TEST=none
TBR=cmp@chromium.org
Review URL: http://codereview.chromium.org/8817008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
green tree. TBRing since this is a revert.
R=sail@chromium.org, jwd@chromium.org
BUG=87658
TEST=none
Review URL: http://codereview.chromium.org/8815005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113115 0039d316-1c4b-4281-b951-d872f2087c98
|