summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Move some JNI headers from chrome_apk target to browser library target"Kibeom Kim2015-05-2815-76/+51
| | | | | | | | | | | This reverts commit 2466c430c4341f2ecfafd8b4e846c46147ae54a7. NOTRY=true BUG=484934 Review URL: https://codereview.chromium.org/1149893011 Cr-Commit-Position: refs/heads/master@{#331850}
* [Sync] Add test for SyncController.start() and .stop()maxbogue2015-05-281-0/+14
| | | | | | | | BUG=480604 Review URL: https://codereview.chromium.org/1160813002 Cr-Commit-Position: refs/heads/master@{#331849}
* Roll src/third_party/WebKit b4d2fd5:8517652 (svn 196073:196078)blink-deps-roller2015-05-281-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b4d2fd5..8517652 TBR=dmurph@chromium.org,mnaganov@chromium.org Review URL: https://codereview.chromium.org/1157143003 Cr-Commit-Position: refs/heads/master@{#331848}
* Fix downloading in update_reference_builds.pysimonhatch2015-05-282-29/+29
| | | | | | | | BUG=492641 Review URL: https://codereview.chromium.org/1157383003 Cr-Commit-Position: refs/heads/master@{#331847}
* disable PPAPINaClPNaClTest.PostMessage as it is flaking on Mac ASAN buildscaitkp2015-05-281-1/+7
| | | | | | | | | BUG= 437411, 437408 TBR=dmichael@chromium.org Review URL: https://codereview.chromium.org/1157433007 Cr-Commit-Position: refs/heads/master@{#331846}
* Deleting all cloudMessaging and pushMessaging docs, and putting in proper ↵mkearney2015-05-2819-1126/+15
| | | | | | | | cross-reference support. Review URL: https://codereview.chromium.org/1165453002 Cr-Commit-Position: refs/heads/master@{#331845}
* Re-add telemetry_perf_unittests to Android trybotszhenw2015-05-281-0/+8
| | | | | | | | | | | Cycle time of linux_android_rel_ng is now reduced to 2m40s due to the following fix: https://codereview.chromium.org/1153103007 BUG=379378 Review URL: https://codereview.chromium.org/1154383003 Cr-Commit-Position: refs/heads/master@{#331844}
* cc: Move ListContainer to cc/base/.jbroman2015-05-2810-1000/+947
| | | | | | | | | | | | | | | | | | | | | This means that list_container.cc can no longer refer to quad types etc., so instead the bulk of the logic is moved to the non-template class ListContainerBase, which can be defined without any knowledge outside cc/base/. Due to linking issues, the instantiations are no longer explicit. However, the actual template to be instantiated is now much smaller, with most of the actual code being in ListContainerBase (which defined in list_container.cc). Effort has been made to make minimal changes aside from code movement. In particular, other refactorings (including of the unit test) are intentionally not in this CL. BUG=492952 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1161883003 Cr-Commit-Position: refs/heads/master@{#331843}
* Adding myself to authors filetanay.c2015-05-281-0/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/1162503004 Cr-Commit-Position: refs/heads/master@{#331842}
* Reduce rate of, and de-dupe, timer-poll based captures.miu2015-05-286-44/+174
| | | | | | | | | | | | | | | | | | | | | In tab capture (all platforms) and desktop/window capture (CrOS), a timer fires when compositor updates stop occurring. This is to ensure the video encoder receives multiple copies of the same content, to incrementally apply quality-improving "deltas" that reduce the lossy errors in complex content. However, the existing mechanism goes overboard in two ways that this change resolves: 1) The rate of capture is "full speed," whereas our research suggests a frugal 8 FPS provides the same, rapid quality improvements. 2) It's possible for the timer to initiate more than one capture at the same time, which is not necessary since there is logically no reason to capture static content "smoothly." BUG=156767,492839 Review URL: https://codereview.chromium.org/1145383006 Cr-Commit-Position: refs/heads/master@{#331841}
* Fix indent issue introduced by r331729.miu2015-05-281-6/+6
| | | | | | | | | | No semantic change. Just fixing an indent problem. TBR=raymes@chromium.org Review URL: https://codereview.chromium.org/1152213008 Cr-Commit-Position: refs/heads/master@{#331840}
* Unify texImage2D and texImage3D handling.zmo2015-05-286-65/+107
| | | | | | | | | | BUG=429053 TEST=gpu_unittests R=sievers@chromium.org Review URL: https://codereview.chromium.org/1159543002 Cr-Commit-Position: refs/heads/master@{#331839}
* Disable NoPromptForFailedLoginFromSubFrameWithMultiFramesInPage on Macsamuong2015-05-281-1/+9
| | | | | | | | | BUG=493263 TBR=vabr@chromium.org Review URL: https://codereview.chromium.org/1160953003 Cr-Commit-Position: refs/heads/master@{#331838}
* Refactor SharedMemory::Create and fix a rare file leak.erikchen2015-05-281-41/+72
| | | | | | | | | | | | | | | | I moved some of the logic in SharedMemory::Create() into a new method CreateAnonymousSharedMemory(). I also fixed a bug in the logic that would cause temporary files to be leaked if a readonly_fd could not be obtained for the file. The refactor is in preparation for an A/B test that batch-opens files for SharedMemory. BUG=492803 Review URL: https://codereview.chromium.org/1156103012 Cr-Commit-Position: refs/heads/master@{#331837}
* Revert of [BackgroundSync] Launch the browser on Android when next online ↵spang2015-05-2819-584/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #17 id:340001 of https://codereview.chromium.org/1140813006/) Reason for revert: Unused variable breaks CrOS build: http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20daisy%20Compile/builds/83/steps/compile/logs/stdio ../../content/browser/background_sync/background_sync_manager.cc: In member function 'void content::BackgroundSyncManager::SchedulePendingRegistrations()': ../../content/browser/background_sync/background_sync_manager.cc:650:8: error: variable 'keep_browser_alive_for_one_shot' set but not used [-Werror=unused-but-set-variable] bool keep_browser_alive_for_one_shot = false; ^ cc1plus.elf: all warnings being treated as errors Original issue's description: > [BackgroundSync] Launch the browser on Android when next online > > On Android devices BackgroundSync needs to launch the browser the next time the device goes online if a one-shot sync is registered. This CL adds an Android Receiver and Service (BackgroundSyncLauncherService) to listen to connectvity events and launch the browser. It also provides a BackgroundSyncLauncher JNI class that C++ can interact with to register interest in launching in the background. > > This feature is experimental and behind a flag. > > Note that the components_tests.gyp change (to add content_java) is because content::StoragePartition creates a BackgroundSyncManager which immediately talks to java therefore the content java classes are needed for testing. > > BUG=479665 > > Committed: https://crrev.com/6970b0ad59723ced9cc473f5474e8c3c0bf5d7bc > Cr-Commit-Position: refs/heads/master@{#331826} TBR=jochen@chromium.org,jdduke@chromium.org,mvanouwerkerk@chromium.org,nyquist@chromium.org,peter@chromium.org,tedchoc@chromium.org,jkarlin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479665 Review URL: https://codereview.chromium.org/1149373007 Cr-Commit-Position: refs/heads/master@{#331836}
* Convert cr_expand_button to Polymer v0_8stevenjb2015-05-284-4/+66
| | | | | | | | BUG=485381 Review URL: https://codereview.chromium.org/1131903006 Cr-Commit-Position: refs/heads/master@{#331835}
* Remove subtarget configuration flags.pcc2015-05-281-21/+0
| | | | | | | | | | | | Our version of Clang now supports subtarget-specific code generation during LTO, so remove these flags, as they are no longer needed. BUG=453195 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1148153004 Cr-Commit-Position: refs/heads/master@{#331834}
* Roll src/third_party/WebKit b150dde:b4d2fd5 (svn 196008:196073)blink-deps-roller2015-05-281-1/+1
| | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/b150dde..b4d2fd5 TBR=dmurph@chromium.org,mnaganov@chromium.org Review URL: https://codereview.chromium.org/1149423005 Cr-Commit-Position: refs/heads/master@{#331833}
* Stop deleting the tab model metadata file immediately after loading.dfalcantara2015-05-281-2/+0
| | | | | | | | | | | | | Instead of immediately deleting the file on startup, hold onto it and simply overwrite it when necessary. This prevents cases where Chrome hasn't managed to read in all of the TabState files before a crash, which results in total annihilation of the tabs on the next load. BUG=485217 Review URL: https://codereview.chromium.org/1156343002 Cr-Commit-Position: refs/heads/master@{#331832}
* Fix a bug where the desired size was passed to ↵beaudoin2015-05-281-1/+1
| | | | | | | | | | | | GetLargestRawFaviconForPageURL rather than the expected minimum size. This caused smaller icons to be returned rather than large icons when the minimum size was 0, as used on Android. BUG=482815 Review URL: https://codereview.chromium.org/1145313008 Cr-Commit-Position: refs/heads/master@{#331831}
* [Sync] Add support for associating while downloading within the same priorityzea2015-05-288-222/+447
| | | | | | | | | | | | | | | | | | | | Datatypes that are ready will immediately begin associating, regardless of whether a sync cycle has to be performed for other datatypes in the group. As part of this, the DOWNLOAD_PENDING state has been removed, as association can now happen while downloading, and the triggering of unrecoverable errors when a download fails has also been removed to make the DataTypeManager more resilient. The association queue is populated at the time download is triggered, and association will now happen anytime progress is made, there's still work to do, and model association manager isn't busy. BUG=477063 Review URL: https://codereview.chromium.org/1161723002 Cr-Commit-Position: refs/heads/master@{#331830}
* Remove tonyg@ from chrome/renderer/OWNERS.tonyg2015-05-281-1/+0
| | | | | | | | | | | I'm not working on this code actively enough any more to provide meaningful reviews. BUG= Review URL: https://codereview.chromium.org/1165443002 Cr-Commit-Position: refs/heads/master@{#331829}
* Browser tests for the new way of handling device ID in Chrome OS.dzhioev2015-05-284-2/+354
| | | | | | | | | BUG=486044,486136 TEST=browser_tests --gtest_filter=DeviceIDTest.* Review URL: https://codereview.chromium.org/1141163002 Cr-Commit-Position: refs/heads/master@{#331828}
* Revert of Refresh android relocation packer from AOSP bionic. (patchset #1 ↵caitkp2015-05-2816-163/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1164453002/) Reason for revert: This CL is causing check_perms failures on the linux builds: http://build.chromium.org/p/chromium/builders/Linux/builds/62718/steps/check_perms/logs/stdio Logs: /b/build/slave/Linux/build/src/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32.so: Has ELF header but not executable bit /b/build/slave/Linux/build/src/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_ia32_packed.so: Has ELF header but not executable bit /b/build/slave/Linux/build/src/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32.so: Has ELF header but not executable bit /b/build/slave/Linux/build/src/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_mips32_packed.so: Has ELF header but not executable bit /b/build/slave/Linux/build/src/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64.so: Has ELF header but not executable bit /b/build/slave/Linux/build/src/third_party/android_platform/bionic/tools/relocation_packer/test_data/elf_file_unittest_relocs_x64_packed.so: Has ELF header but not executable bit Original issue's description: > Refresh android relocation packer from AOSP bionic. > > Imports: > Fix unit tests, and extend for other architectures > https://android-review.googlesource.com/#/c/151901/ > > Do not adjust PT_GNU_STACK segment > https://android-review.googlesource.com/#/c/149300/ > > Adjust DT_MIPS_RLD_MAP2 value > https://android-review.googlesource.com/#/c/148822/ > > Reduce p_align for program header to page size. > https://android-review.googlesource.com/#/c/148492/ > > Exit normally when relocations are already packed. > https://android-review.googlesource.com/#/c/148175/ > > NOPRESUBMIT=true > BUG=385553 > > Committed: https://crrev.com/9cb10e88d01e71c5786a463f7c39409e7a41ddcd > Cr-Commit-Position: refs/heads/master@{#331808} TBR=rmcilroy@chromium.org,simonb@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=385553 Review URL: https://codereview.chromium.org/1143303007 Cr-Commit-Position: refs/heads/master@{#331827}
* [BackgroundSync] Launch the browser on Android when next onlinejkarlin2015-05-2819-0/+584
| | | | | | | | | | | | | | On Android devices BackgroundSync needs to launch the browser the next time the device goes online if a one-shot sync is registered. This CL adds an Android Receiver and Service (BackgroundSyncLauncherService) to listen to connectvity events and launch the browser. It also provides a BackgroundSyncLauncher JNI class that C++ can interact with to register interest in launching in the background. This feature is experimental and behind a flag. Note that the components_tests.gyp change (to add content_java) is because content::StoragePartition creates a BackgroundSyncManager which immediately talks to java therefore the content java classes are needed for testing. BUG=479665 Review URL: https://codereview.chromium.org/1140813006 Cr-Commit-Position: refs/heads/master@{#331826}
* Sync: reduce Android test flakiness caused by page loadpvalenzuela2015-05-281-1/+8
| | | | | | | | | | | | | | | This CL prevents unnecessary loading of google.com before Sync tests. This is wasteful (using both time and networking), but also pollutes local client data. Instead, about:blank is loaded. This CL also adds an assert around the clearAppData() call to ensure that this step succeeds. BUG=481192 Review URL: https://codereview.chromium.org/1152683002 Cr-Commit-Position: refs/heads/master@{#331825}
* Use resolved URLs with NetworkFetcher in ApplicationManager.msw2015-05-281-1/+10
| | | | | | | | | | | | | | | | Revert the resolved/requested URL behavior change from here: https://codereview.chromium.org/1121783003/diff/320001/mojo/shell/application_manager.cc android_mojo_shell.py hosts apps on a locally-served build dir. This restores the ability to load those origin-mapped app URLs. BUG=486220 TEST="mojo/tools/android_mojo_shell.py mojo:clipboard_apptests" works. R=jam@chromium.org Review URL: https://codereview.chromium.org/1156923003 Cr-Commit-Position: refs/heads/master@{#331824}
* cc: Move RoundUp and RoundDown out of util.h into math_util.hvmpstr2015-05-2819-141/+114
| | | | | | | | | | | | This patch merges util.h into math_util.h since the only two functions in there are math functions. R=danakj CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1161553012 Cr-Commit-Position: refs/heads/master@{#331823}
* Handle gamepad length being incorrectly set to 0 even when gamepad is presentarajp2015-05-281-3/+4
| | | | | | | | | | | | When Windows sends device changed event multiple times even when a single gamepad is connected, EnumerateDevices incorrectly sets gamepad length to zero. BUG=485507 R=scottmg, raymes Review URL: https://codereview.chromium.org/1145063004 Cr-Commit-Position: refs/heads/master@{#331822}
* metrics: add wake-reason-specific dark resume wake duration histogramssamueltan2015-05-281-0/+38
| | | | | | | | | | | | For each type of dark resume wake trigger, add a histograms tracking the time spent in dark resumes caused by that trigger. BUG=chromium:485315 TEST=None. Review URL: https://codereview.chromium.org/1142343006 Cr-Commit-Position: refs/heads/master@{#331821}
* Merge android_strings.grd and android_chrome_strings.grd part 1pkotwicz2015-05-283-10/+14
| | | | | | | | | | | | | | | This CL makes android_strings.grd and android_chrome_strings.grd dependencies of the same target: chrome_java for gyp and chrome_java_resources for GN respectively. BUG=484934 TEST=None R=newt TBR=sky for chrome/chrome.gyp Review URL: https://codereview.chromium.org/1157083004 Cr-Commit-Position: refs/heads/master@{#331820}
* Hook up findEligibleUnlockDevices CryptAuth API to chrome://proximity-auth.tengs2015-05-2822-119/+426
| | | | | | | | | | | | Clicking the "Eligible Devices" tab will perform the API call and display the devices returned by CryptAuth on the page. This change also introduces a delegate interface for the WebUI to fetch objects with dependencies on chrome. BUG=409158 Review URL: https://codereview.chromium.org/1145113004 Cr-Commit-Position: refs/heads/master@{#331819}
* Doing a history navigation while interstitial is showing doesn't navigate.nasko2015-05-281-4/+3
| | | | | | | | | | | The unit test incorrectly sends a navigation after the interstitial page is dismissed by invoking GoBack. This CL fixes the test to behave properly. BUG= Review URL: https://codereview.chromium.org/1158303002 Cr-Commit-Position: refs/heads/master@{#331818}
* [mojo] Use mojo::StrongBinding instead of mojo::InterfaceImpl in ↵timvolodine2015-05-283-20/+24
| | | | | | | | | | VibrationManagerImpl. BUG=489758 Review URL: https://codereview.chromium.org/1160933002 Cr-Commit-Position: refs/heads/master@{#331817}
* Do an origin check if the renderer claims a renderer-initiated navigation ↵avi2015-05-281-2/+4
| | | | | | | | | | | was in-page. BUG=369661 TEST=none Review URL: https://codereview.chromium.org/1156113009 Cr-Commit-Position: refs/heads/master@{#331816}
* Update V8 to version 4.5.21.v8-autoroll2015-05-281-1/+1
| | | | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8d896cb3..2aef3c8a Please follow these instructions for assigning/CC'ing issues: https://code.google.com/p/v8-wiki/wiki/TriagingIssues TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1159733005 Cr-Commit-Position: refs/heads/master@{#331815}
* Start a renderer-initiated navigation before commit in ↵nasko2015-05-281-0/+2
| | | | | | | | | | | | | | | RendererInitiatedPendingEntries The RendererInitiatedPendingEntries test does a direct call to Navigator::DidStartProvisionalLoad without setting up any state on the RenderFrameHost object. This CL adds some initial steps to prepare the necessary state for successful navigation. BUG= Review URL: https://codereview.chromium.org/1159043002 Cr-Commit-Position: refs/heads/master@{#331814}
* Chromite roll 46c52fb..1b2cf4bspang2015-05-281-1/+1
| | | | | | | | | | | | | https://chromium.googlesource.com/chromiumos/chromite/+log/46c52fb8bcc08f7b4c6f7326517398fd800b6999..1b2cf4bb771222945141048090f607ae2b216d6d Pulls in fix for cros chrome-sdk --use-external-config BUG=489795 TEST=gclient sync Review URL: https://codereview.chromium.org/1152213004 Cr-Commit-Position: refs/heads/master@{#331813}
* Revert of Refactor get_salient_image_url.js to use DocumentImageExtractor ↵samuong2015-05-2815-296/+102
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #20 id:330001 of https://codereview.chromium.org/1036113002/) Reason for revert: This is causing a compile failure on the Android GN dbg bot: https://build.chromium.org/p/chromium.linux/builders/Android%20GN%20%28dbg%29/builds/2048 Original issue's description: > Refactor get_salient_image_url.js to use DocumentImageExtractor > > Refactor get_salient_image_url.js to use the DocumentImageExtractor. > Move get_salient_image_url.js into components so it accessible for > iOS as well. > > BUG=454623 > > Committed: https://crrev.com/9bacad65abe3631048c1e5d0467e1cea414e5700 > Cr-Commit-Position: refs/heads/master@{#331807} TBR=jochen@chromium.org,danduong@chromium.org,ianwen@chromium.org,jhawkins@chromium.org,kkimlabs@chromium.org,mcolbert@chromium.org,noyau@chromium.org,tedchoc@chromium.org,twellington@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454623 Review URL: https://codereview.chromium.org/1157093005 Cr-Commit-Position: refs/heads/master@{#331812}
* clang: Rewrite package.sh in python.Nico Weber2015-05-283-204/+233
| | | | | | | | | | | | | | | | The motivation is to be able to use this on Windows, but for now this is a pure rewrite of the existing package.sh script with no Windows-specific code yet. (In particular, this calls update.py with --bootstrap, which isn't implemented on Windows yet, and the plugin bundling code isn't quite right either since the plugins are compiled into the clang binary on Windows. Also, Windows doesn't do symlinks.) BUG=483065 R=hans@chromium.org Review URL: https://codereview.chromium.org/1149153004 Cr-Commit-Position: refs/heads/master@{#331811}
* Fix issue when rotating leaked PopupTouchHandleDrawable instancesjdduke2015-05-281-17/+21
| | | | | | | | | | | | | | | | | | Java PopupTouchHandleDrawable objects are owned by native code. However, WebView makes no guarantees about the shutdown sequence for native code, so it's possible that discarded WebView instances might still be associated with a PopupTouchHandleDrawable. Resolve this by aggressively disconnecting the PopupTouchHandleDrawable from the associated WebView when appropriate. This fixes a crash that occurs on Nexus 9 devices when a selection is active and the tablet is rotated from landscape to portrait. BUG=493180 Review URL: https://codereview.chromium.org/1161983003 Cr-Commit-Position: refs/heads/master@{#331810}
* Roll src/third_party/skia 9c240a1:084d1b6skia-deps-roller2015-05-281-1/+1
| | | | | | | | | | | | Summary of changes available at: https://chromium.googlesource.com/skia/+log/9c240a1..084d1b6 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1152343003 Cr-Commit-Position: refs/heads/master@{#331809}
* Refresh android relocation packer from AOSP bionic.simonb2015-05-2816-20/+163
| | | | | | | | | | | | | | | | | | | | | | | | | Imports: Fix unit tests, and extend for other architectures https://android-review.googlesource.com/#/c/151901/ Do not adjust PT_GNU_STACK segment https://android-review.googlesource.com/#/c/149300/ Adjust DT_MIPS_RLD_MAP2 value https://android-review.googlesource.com/#/c/148822/ Reduce p_align for program header to page size. https://android-review.googlesource.com/#/c/148492/ Exit normally when relocations are already packed. https://android-review.googlesource.com/#/c/148175/ NOPRESUBMIT=true BUG=385553 Review URL: https://codereview.chromium.org/1164453002 Cr-Commit-Position: refs/heads/master@{#331808}
* Refactor get_salient_image_url.js to use DocumentImageExtractortwellington2015-05-2815-102/+296
| | | | | | | | | | | | Refactor get_salient_image_url.js to use the DocumentImageExtractor. Move get_salient_image_url.js into components so it accessible for iOS as well. BUG=454623 Review URL: https://codereview.chromium.org/1036113002 Cr-Commit-Position: refs/heads/master@{#331807}
* Chromecast: adds ChromecastInitData parsing code.gunsch2015-05-285-45/+286
| | | | | | | | | | | R=derekjchow@chromium.org,halliwell@chromium.org CC=lcwu@chromium.org,vadimgo@chromium.org,alokp@chromium.org BUG=492810 BUG=internal b/18580106 Review URL: https://codereview.chromium.org/1157333002 Cr-Commit-Position: refs/heads/master@{#331806}
* Don't set window.opener for blocked popups.alexmos2015-05-289-14/+23
| | | | | | | | | | | | | | | | | | | | | | | | The current behavior is to set window.opener for blocked popups that were opened, but that window.opener ends up in an incorrect, locked-down state (can't be navigated, can't be targeted by postMessage, etc. - see https://crbug.com/485376), even for same-site popups. This CL reverses that behavior to not set the opener for blocked popups. There doesn't appear to be a good reason to have it set, and this will simplify refactoring of opener logic for OOPIF (https://crbug.com/225940). The only dependency on previous behavior was to propagate the openedByDOM bit, which determines whether the popup can do window.close(). To still support this, the CL keeps the should_set_opener bit, but renames it into "created_with_opener". BUG=485376, 225940 Review URL: https://codereview.chromium.org/1140443003 Cr-Commit-Position: refs/heads/master@{#331805}
* Adding Chrome Custom Tabs to top navigation.mkearney2015-05-281-0/+4
| | | | | | | | Src file lives in GitHub repo: https://github.com/GoogleChrome/multi-device/blob/master/android/customtabs.html Review URL: https://codereview.chromium.org/1155423009 Cr-Commit-Position: refs/heads/master@{#331804}
* <webview>: Remove Undocumented Resize DOM eventfsamuel2015-05-288-43/+14
| | | | | | | | | | | | <webview> had an undocumented resize event that we added as an experiment but it seems to be causing more harm than good, so let's just remove it. BUG=492648 TBR=nasko@chromium.org for trivial browser_plugin_delegate.h change. Review URL: https://codereview.chromium.org/1155163009 Cr-Commit-Position: refs/heads/master@{#331803}
* Fix duplicate symbol in ARM build of nacl_helper_nonsfi_unittestsSam Clegg2015-05-281-11/+14
| | | | | | | | | | | | | The arm linux is currently broken due to duplicate definition of BPF_TEST_C_socketpair. BUG=492731 R=hidehiko@chromium.org, mseaborn@chromium.org, hidehiko CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile Review URL: https://codereview.chromium.org/1158133003 Cr-Commit-Position: refs/heads/master@{#331802}
* Stop crashes during shutdown due to refcounted API delegate outliving its ↵dewittj2015-05-281-1/+27
| | | | | | | | | | | | | profile pointer. Each notification API object now will listen for profile destruction events on its profile and null out the pointer when this happens. BUG=485601 Review URL: https://codereview.chromium.org/1147403002 Cr-Commit-Position: refs/heads/master@{#331801}
generated by cgit v1.1 at 2025-02-09 22:24:28 +0000